151225 2015-11-12 14:30:14 -0800 Web Inspector: Reduce list of saved console messages 2015-11-12 15:27:16 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue ggaren graouts joepeck keith_miller mark.lam mattbaker msaboff nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1141639 0 joepeck 2015-11-12 14:30:14 -0800 * SUMMARY Reduce list of saved console messages. Most sites do not produce a very large number of console messages. But for pages that live for a long time and generate many errors over time, saving the last 1000 messages in case an inspector frontend opens can result in a lot of wasted memory. Likewise when an inspector first open sending all 1000 messages to the frontend results in a poor experience. Lets reduce this to 100. When just growing the web and not developing a page, most warnings/errors accumulated are engine generated warnings/errors that themselves can be investigated to reduce noise and further lower the actual number of ConsoleMessages. 1141640 1 webkit-bug-importer 2015-11-12 14:31:17 -0800 <rdar://problem/23524129> 1141642 2 265435 joepeck 2015-11-12 14:36:52 -0800 Created attachment 265435 [PATCH] Proposed Fix 1141643 3 265435 ggaren 2015-11-12 14:38:07 -0800 Comment on attachment 265435 [PATCH] Proposed Fix r=me 1141655 4 265435 commit-queue 2015-11-12 15:27:13 -0800 Comment on attachment 265435 [PATCH] Proposed Fix Clearing flags on attachment: 265435 Committed r192391: <http://trac.webkit.org/changeset/192391> 1141656 5 commit-queue 2015-11-12 15:27:16 -0800 All reviewed patches have been landed. Closing bug. 265435 2015-11-12 14:36:52 -0800 2015-11-12 15:27:13 -0800 [PATCH] Proposed Fix reduce.patch text/plain 2257 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGI3NTZkODcuLjE3MjZjYzggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE1LTExLTEyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVkdWNl IGxpc3Qgb2Ygc2F2ZWQgY29uc29sZSBtZXNzYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMjI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zcGVjdG9yIHNhdmVzIG1lc3NhZ2VzIHNvIHRoYXQg d2hlbiBhbiBpbnNwZWN0b3IgZnJvbnRlbmQgb3BlbnMgaXQgY2FuIHJlcG9ydAorICAgICAgICB0 aGVzZSBtZXNzYWdlcyB0byB0aGUgZnJvbnRlbmQuIEhvd2V2ZXIgd2Ugd2VyZSBzYXZpbmcgYSBy YXRoZXIgbGFyZ2UgbGlzdCBvZgorICAgICAgICAxMDAwIG1lc3NhZ2VzLiBNb3N0IHBhZ2VzIGRv IG5vdCBwcm9kdWNlIGEgbGFyZ2UgbnVtYmVyIG9mIGNvbnNvbGUgbWVzc2FnZXMuCisgICAgICAg IEhvd2V2ZXIgcGFnZXMgdGhhdCBsaXZlIGZvciBhIGxvbmcgdGltZSBjYW4gZ2VuZXJhdGUgbWFu eSBlcnJvcnMgb3ZlciB0aW1lLAorICAgICAgICBlc3BlY2lhbGx5IHBlcmlvZGljIGVuZ2luZSBp c3N1ZXMgc3VjaCBhcyBjcm9zcy1vcmlnaW4gYWNjZXNzIGVycm9ycy4gVGhpcyBjb3VsZAorICAg ICAgICByZXN1bHQgaW4gYSBsb3Qgb2Ygd2FzdGVkIG1lbW9yeSBmb3IgY29uc29sZSBtZXNzYWdl cyB0aGF0IG1heSBuZXZlciBiZSB1c2VkLgorCisgICAgICAgIExpa2V3aXNlIHdoZW4gYW4gaW5z cGVjdG9yIGZpcnN0IG9wZW4gc2VuZGluZyBhbGwgMTAwMCBtZXNzYWdlcyB0byB0aGUgZnJvbnRl bmQKKyAgICAgICAgcmVzdWx0cyBpbiBhIHBvb3IgZXhwZXJpZW5jZS4KKworICAgICAgICBMZXRz IHJlZHVjZSB0aGUgbGlzdCBvZiBzYXZlZCBtZXNzYWdlcy4gRGV2ZWxvcGVyIHdpbGwgc3RpbGwg YmUgYWJsZSB0byBzZWUKKyAgICAgICAgYWxsIG1lc3NhZ2VzIGFzIGxvbmcgYXMgdGhleSBoYXZl IFdlYiBJbnNwZWN0b3Igb3BlbiBhdCB0aGUgdGltZSB0aGUgbWVzc2FnZXMKKyAgICAgICAgYXJl IGdlbmVyYXRlZC4KKworICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ29uc29s ZUFnZW50LmNwcDoKKyAgICAgICAgUmVkdWNlIHRoZSBsaXN0IGZyb20gMTAwMCB0byAxMDAuIEFs c28sIHdoZW4gZXhwaXJpbmcKKyAgICAgICAgbWVzc2FnZXMgZnJvbSB0aGlzIGxpc3QsIGNodW5r IGluIDEwcyBpbnN0ZWFkIG9mIDEwMHMuCisKIDIwMTUtMTEtMTEgIE1hcmsgTGFtICA8bWFyay5s YW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhYmlsaXR5IHRvIGluc2VydCBwcm9iZXMgaW4g TExWTSBJUiB0aGF0IHdlIGdlbmVyYXRlLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ29uc29sZUFnZW50LmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckNvbnNvbGVBZ2VudC5jcHAK aW5kZXggYTExZDlmMS4uYWY0MWMyNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ29uc29sZUFnZW50LmNwcAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JDb25zb2xlQWdlbnQuY3Bw CkBAIC00MCw4ICs0MCw4IEBACiAKIG5hbWVzcGFjZSBJbnNwZWN0b3IgewogCi1zdGF0aWMgY29u c3QgdW5zaWduZWQgbWF4aW11bUNvbnNvbGVNZXNzYWdlcyA9IDEwMDA7Ci1zdGF0aWMgY29uc3Qg aW50IGV4cGlyZUNvbnNvbGVNZXNzYWdlc1N0ZXAgPSAxMDA7CitzdGF0aWMgY29uc3QgdW5zaWdu ZWQgbWF4aW11bUNvbnNvbGVNZXNzYWdlcyA9IDEwMDsKK3N0YXRpYyBjb25zdCBpbnQgZXhwaXJl Q29uc29sZU1lc3NhZ2VzU3RlcCA9IDEwOwogCiBJbnNwZWN0b3JDb25zb2xlQWdlbnQ6Okluc3Bl Y3RvckNvbnNvbGVBZ2VudChBZ2VudENvbnRleHQmIGNvbnRleHQpCiAgICAgOiBJbnNwZWN0b3JB Z2VudEJhc2UoQVNDSUlMaXRlcmFsKCJDb25zb2xlIikpCg==