15122 2007-08-31 02:05:48 -0700 REGRESSION: Assertion failure in avoidIntersectionWithNode (!node || node->parentNode()) running editing/deleting/5408255.html 2007-08-31 09:20:07 -0700 1 1 1 Unclassified WebKit HTML Editing 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://build.webkit.org/results/post-commit-leaks-intel-mac-os-x/1074/results.html InRadar, LayoutTestFailure, Regression P2 Normal --- 1 mitz darin alice.barraclough darin oldest_to_newest 1112 0 mitz 2007-08-31 02:05:48 -0700 editing/deleting/5408255.html fails in debug builds with ASSERTION FAILED: !node || node->parentNode() (/WebKit/WebCore/editing/htmlediting.cpp:915 WebCore::Selection WebCore::avoidIntersectionWithNode(const WebCore::Selection&, WebCore::Node*)) <http://build.webkit.org/post-commit-leaks-intel-mac-os-x/builds/1074> is the first build to show the failure. The assertion itself was changed in <http://trac.webkit.org/projects/webkit/changeset/25311>. 1111 1 mrowe 2007-08-31 02:07:35 -0700 <rdar://problem/5452970> 1097 2 darin 2007-08-31 09:12:12 -0700 This is happening because the delete button controller no longer destroys its container element when not in use. So it can be hanging around with no parent. We're OK as long as we don't actually try to work with the container element, so I just moved the assertion. 1098 3 16169 darin 2007-08-31 09:17:24 -0700 Created attachment 16169 patch that fixes assertion 1099 4 16169 andersca 2007-08-31 09:18:28 -0700 Comment on attachment 16169 patch that fixes assertion r=me 1100 5 darin 2007-08-31 09:20:07 -0700 Committed revision 25330. 16169 2007-08-31 09:17:24 -0700 2007-08-31 09:18:28 -0700 patch that fixes assertion AssertionPatch.txt text/plain 2236 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTMyOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDctMDgtMzEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gaHR0 cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMjIKKworICAgICAgICAqIGVk aXRpbmcvaHRtbGVkaXRpbmcuY3BwOiAoV2ViQ29yZTo6YXZvaWRJbnRlcnNlY3Rpb25XaXRoTm9k ZSk6CisgICAgICAgIENoYW5nZSBhc3NlcnRpb24gc28gdGhhdCBpdCBvbmx5IGZpcmVzIHdoZW4g YWN0dWFsbHkgbW9kaWZ5aW5nIHRoZSBzZWxlY3Rpb24uCisgICAgICAgIFRoaXMgaXNuJ3QgbmVh cmx5IGFzIGhlbHBmdWwsIGJlY2F1c2UgdGhlIG9sZCBhc3NlcnRpb24gY291bGQgY2F0Y2ggcG90 ZW50aWFsCisgICAgICAgIHByb2JsZW1zIGluIG1vcmUgY2FzZXMsIGJ1dCBpdCdzIG5vdCBvYnZp b3VzIGhvdyB0byBkbyBiZXR0ZXIuCisKIDIwMDctMDgtMzAgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtLgpJbmRleDogV2ViQ29yZS9l ZGl0aW5nL2h0bWxlZGl0aW5nLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2VkaXRpbmcvaHRt bGVkaXRpbmcuY3BwCShyZXZpc2lvbiAyNTMyOSkKKysrIFdlYkNvcmUvZWRpdGluZy9odG1sZWRp dGluZy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg4OCwxMyArODg4LDE0IEBAIFBhc3NSZWZQdHI8 UmFuZ2U+IGF2b2lkSW50ZXJzZWN0aW9uV2l0aE4KIAogICAgIEFTU0VSVChzdGFydENvbnRhaW5l cik7CiAgICAgQVNTRVJUKGVuZENvbnRhaW5lcik7Ci0gICAgQVNTRVJUKCFub2RlIHx8IG5vZGUt PnBhcmVudE5vZGUoKSk7CiAKICAgICBpZiAoc3RhcnRDb250YWluZXIgPT0gbm9kZSB8fCBzdGFy dENvbnRhaW5lci0+aXNEZXNjZW5kYW50T2Yobm9kZSkpIHsKKyAgICAgICAgQVNTRVJUKG5vZGUt PnBhcmVudE5vZGUoKSk7CiAgICAgICAgIHN0YXJ0Q29udGFpbmVyID0gbm9kZS0+cGFyZW50Tm9k ZSgpOwogICAgICAgICBzdGFydE9mZnNldCA9IG5vZGUtPm5vZGVJbmRleCgpOwogICAgIH0KICAg ICBpZiAoZW5kQ29udGFpbmVyID09IG5vZGUgfHwgZW5kQ29udGFpbmVyLT5pc0Rlc2NlbmRhbnRP Zihub2RlKSkgeworICAgICAgICBBU1NFUlQobm9kZS0+cGFyZW50Tm9kZSgpKTsKICAgICAgICAg ZW5kQ29udGFpbmVyID0gbm9kZS0+cGFyZW50Tm9kZSgpOwogICAgICAgICBlbmRPZmZzZXQgPSBu b2RlLT5ub2RlSW5kZXgoKTsKICAgICB9CkBAIC05MTIsMTMgKzkxMywxNiBAQCBTZWxlY3Rpb24g YXZvaWRJbnRlcnNlY3Rpb25XaXRoTm9kZShjb25zCiAgICAgTm9kZSogZXh0ZW50ID0gc2VsZWN0 aW9uLmV4dGVudCgpLm5vZGUoKTsKICAgICBBU1NFUlQoYmFzZSk7CiAgICAgQVNTRVJUKGV4dGVu dCk7Ci0gICAgQVNTRVJUKCFub2RlIHx8IG5vZGUtPnBhcmVudE5vZGUoKSk7CiAgICAgCi0gICAg aWYgKGJhc2UgPT0gbm9kZSB8fCBiYXNlLT5pc0Rlc2NlbmRhbnRPZihub2RlKSkKKyAgICBpZiAo YmFzZSA9PSBub2RlIHx8IGJhc2UtPmlzRGVzY2VuZGFudE9mKG5vZGUpKSB7CisgICAgICAgIEFT U0VSVChub2RlLT5wYXJlbnROb2RlKCkpOwogICAgICAgICB1cGRhdGVkU2VsZWN0aW9uLnNldEJh c2UoUG9zaXRpb24obm9kZS0+cGFyZW50Tm9kZSgpLCBub2RlLT5ub2RlSW5kZXgoKSkpOworICAg IH0KICAgICAKLSAgICBpZiAoZXh0ZW50ID09IG5vZGUgfHwgZXh0ZW50LT5pc0Rlc2NlbmRhbnRP Zihub2RlKSkKKyAgICBpZiAoZXh0ZW50ID09IG5vZGUgfHwgZXh0ZW50LT5pc0Rlc2NlbmRhbnRP Zihub2RlKSkgeworICAgICAgICBBU1NFUlQobm9kZS0+cGFyZW50Tm9kZSgpKTsKICAgICAgICAg dXBkYXRlZFNlbGVjdGlvbi5zZXRFeHRlbnQoUG9zaXRpb24obm9kZS0+cGFyZW50Tm9kZSgpLCBu b2RlLT5ub2RlSW5kZXgoKSkpOworICAgIH0KICAgICAgICAgCiAgICAgcmV0dXJuIHVwZGF0ZWRT ZWxlY3Rpb247CiB9Cg==