151188 2015-11-12 05:16:33 -0800 [EFL] Fix EFL 1.16 with enabled NEON support 2016-01-15 06:21:30 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 150228 1 ossy ossy gyuyoung.kim hs85.jeong jh718.park ossy oldest_to_newest 1141456 0 ossy 2015-11-12 05:16:33 -0800 http://trac.webkit.org/changeset/192358 bumped the EFL version from 1.15 to 1.16, but unfortunately 1.16 build is broken on ARM with enabled NEON support. :( lib/ector/software/ector_drawhelper_neon.c: In function 'comp_func_solid_source_over_neon': lib/ector/software/ector_drawhelper_neon.c:46:4: error: unknown type name 'DATA32' DATA32 *start = dest; ^ lib/ector/software/ector_drawhelper_neon.c:46:20: warning: pointer targets in initialization differ in signedness [-Wpointer-sign] DATA32 *start = dest; ^ lib/ector/software/ector_drawhelper_neon.c:48:4: error: unknown type name 'DATA32' DATA32 *end = start + (size & ~7); ^ lib/ector/software/ector_drawhelper_neon.c:58:9: warning: pointer targets in passing argument 1 of 'vld1q_u32' differ in signedness [-Wpointer-sign] d0_32x4 = vld1q_u32(start); ^ In file included from lib/ector/software/ector_drawhelper_neon.c:9:0: /usr/lib/gcc/aarch64-linux-gnu/4.8/include/arm_neon.h:19989:1: note: expected 'const uint32_t *' but argument is of type 'int *' vld1q_u32 (const uint32_t *a) ^ lib/ector/software/ector_drawhelper_neon.c:59:9: warning: pointer targets in passing argument 1 of 'vld1q_u32' differ in signedness [-Wpointer-sign] d1_32x4 = vld1q_u32(start+4); ^ In file included from lib/ector/software/ector_drawhelper_neon.c:9:0: /usr/lib/gcc/aarch64-linux-gnu/4.8/include/arm_neon.h:19989:1: note: expected 'const uint32_t *' but argument is of type 'int *' vld1q_u32 (const uint32_t *a) ^ lib/ector/software/ector_drawhelper_neon.c:87:9: warning: pointer targets in passing argument 1 of 'vst1q_u32' differ in signedness [-Wpointer-sign] vst1q_u32(start, d0_32x4); ^ CC lib/ecore/lib_ecore_libecore_la-ecore.lo In file included from lib/ector/software/ector_drawhelper_neon.c:9:0: /usr/lib/gcc/aarch64-linux-gnu/4.8/include/arm_neon.h:24488:1: note: expected 'uint32_t *' but argument is of type 'int *' vst1q_u32 (uint32_t *a, uint32x4_t b) ^ lib/ector/software/ector_drawhelper_neon.c:88:9: warning: pointer targets in passing argument 1 of 'vst1q_u32' differ in signedness [-Wpointer-sign] vst1q_u32(start+4, d1_32x4); ^ In file included from lib/ector/software/ector_drawhelper_neon.c:9:0: /usr/lib/gcc/aarch64-linux-gnu/4.8/include/arm_neon.h:24488:1: note: expected 'uint32_t *' but argument is of type 'int *' vst1q_u32 (uint32_t *a, uint32x4_t b) ^ lib/ector/software/ector_drawhelper_neon.c:95:9: warning: implicit declaration of function 'MUL_256' [-Wimplicit-function-declaration] *start = color + MUL_256(alpha, *start); ^ lib/ector/software/ector_drawhelper_neon.c: In function 'comp_func_source_over_sse2': lib/ector/software/ector_drawhelper_neon.c:138:4: error: unknown type name 'DATA32' DATA32 *start; ^ lib/ector/software/ector_drawhelper_neon.c:139:4: error: unknown type name 'DATA32' DATA32 *end; ^ lib/ector/software/ector_drawhelper_neon.c:151:10: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] start = dest; ^ lib/ector/software/ector_drawhelper_neon.c:152:11: error: 'l' undeclared (first use in this function) size = l; ^ lib/ector/software/ector_drawhelper_neon.c:152:11: note: each undeclared identifier is reported only once for each function it appears in lib/ector/software/ector_drawhelper_neon.c:160:9: warning: pointer targets in passing argument 1 of 'vld1q_u32' differ in signedness [-Wpointer-sign] d_32x4 = vld1q_u32(start); ^ In file included from lib/ector/software/ector_drawhelper_neon.c:9:0: /usr/lib/gcc/aarch64-linux-gnu/4.8/include/arm_neon.h:19989:1: note: expected 'const uint32_t *' but argument is of type 'int *' vld1q_u32 (const uint32_t *a) ^ lib/ector/software/ector_drawhelper_neon.c:198:9: warning: pointer targets in passing argument 1 of 'vst1q_u32' differ in signedness [-Wpointer-sign] vst1q_u32(start, d_32x4); ^ In file included from lib/ector/software/ector_drawhelper_neon.c:9:0: /usr/lib/gcc/aarch64-linux-gnu/4.8/include/arm_neon.h:24488:1: note: expected 'uint32_t *' but argument is of type 'int *' vst1q_u32 (uint32_t *a, uint32x4_t b) ^ lib/ector/software/ector_drawhelper_neon.c:207:9: error: unknown type name 'DATA32' DATA32 sc = MUL4_SYM(color, *s); ^ lib/ector/software/ector_drawhelper_neon.c:207:9: warning: implicit declaration of function 'MUL4_SYM' [-Wimplicit-function-declaration] lib/ector/software/ector_drawhelper_neon.c:207:38: error: 's' undeclared (first use in this function) DATA32 sc = MUL4_SYM(color, *s); ^ lib/ector/software/ector_drawhelper_neon.c:208:9: error: unknown type name 'DATA32' DATA32 alpha = 256 - (sc >> 24); ^ lib/ector/software/ector_drawhelper_neon.c:103:85: warning: unused parameter 'length' [-Wunused-parameter] comp_func_source_over_sse2(uint * __restrict dest, const uint * __restrict src, int length, uint color, uint const_alpha) ^ lib/ector/software/ector_drawhelper_neon.c: In function 'init_draw_helper_neon': lib/ector/software/ector_drawhelper_neon.c:228:42: error: 'comp_func_source_over_neon' undeclared (first use in this function) func_for_mode[ECTOR_ROP_BLEND] = comp_func_source_over_neon; ^ lib/ector/software/ector_drawhelper_neon.c: At top level: lib/ector/software/ector_drawhelper_neon.c:103:1: warning: 'comp_func_source_over_sse2' defined but not used [-Wunused-function] comp_func_source_over_sse2(uint * __restrict dest, const uint * __restrict src, int length, uint color, uint const_alpha) ^ make[4]: *** [lib/ector/software/lib_ector_libector_la-ector_drawhelper_neon.lo] Error 1 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [all-recursive] Error 1 make[2]: *** [all] Error 2 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 1141460 1 ossy 2015-11-12 05:22:30 -0800 I disabled NEON to fix the build - http://trac.webkit.org/changeset/192360. But it would be great to fix this build issue in upstream EFL. 1141466 2 ossy 2015-11-12 05:42:10 -0800 Maybe the following patch fixes this issue: diff --git a/src/lib/ector/software/ector_drawhelper_private.h b/src/lib/ector/software/ector_drawhelper_private.h index d15a8f6..d62830a 100644 --- a/src/lib/ector/software/ector_drawhelper_private.h +++ b/src/lib/ector/software/ector_drawhelper_private.h @@ -11,6 +11,10 @@ #define MAX( a, b ) ( (a) > (b) ? (a) : (b) ) #endif +#ifndef DATA32 +typedef unsigned int DATA32; +#endif + #ifndef uint typedef unsigned int uint; #endif I'll try it later and will submit if it is enough. 1142227 3 265585 ossy 2015-11-16 05:44:00 -0800 Created attachment 265585 Patch This patch fixes the EFL NEON build for me, but I'm not sure if it is functionally right or not. I let EFL maintainers to fix this bug themself - https://phab.enlightenment.org/T2851 . 1142529 4 ossy 2015-11-17 05:12:01 -0800 (In reply to comment #3) > Created attachment 265585 [details] > Patch > > This patch fixes the EFL NEON build for me, but I'm not sure if it is > functionally right or not. I let EFL maintainers to fix this bug themself - > https://phab.enlightenment.org/T2851 . NEON build was disabled in ector, so we can enable NEON again once 1.16.1 is released or we can add the patch to jhbuild. 1155748 5 ossy 2016-01-15 06:21:30 -0800 We already use 1.16.1 since https://trac.webkit.org/changeset/194571 (bug152688) (and 1.17 is coming soon) 265585 2015-11-16 05:44:00 -0800 2015-11-16 05:44:00 -0800 Patch bug-151188-20151116054351.patch text/plain 4935 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNDY4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmE0ZTk2NmZlMzE0ODhkMDhlZjA2NGFjODAyNTBmZWMy MmFjMWI5MS4uOGIwMTI0YWJkY2JiZTc3YTBhZTBmMTI1YWZkMjdkMjljZTVlZmRiZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTExLTE2ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW0VGTF0gRml4IEVGTCAxLjE2IHdpdGggZW5hYmxlZCBORU9OIHN1cHBvcnQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTE4OAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZWZsL2poYnVp bGQubW9kdWxlczoKKyAgICAgICAgKiBlZmwvcGF0Y2hlcy9lY3Rvcl9ORU9OX2J1aWxkZml4LnBh dGNoOiBBZGRlZC4KKwogMjAxNS0xMS0xNSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdl YmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE5MjQ2Mi4KZGlm ZiAtLWdpdCBhL1Rvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMgYi9Ub29scy9lZmwvamhidWlsZC5t b2R1bGVzCmluZGV4IGYwMTI3ZDM4N2U1MmZmN2U1MTYyYjRmOTM4ZTUyYWQ1M2VkYmI1ZjMuLmQw ZmIxNTBiMTAxYmJjM2Y5NTBlODBmMDUyNzc0Y2EyNWZjOGRhOGIgMTAwNjQ0Ci0tLSBhL1Rvb2xz L2VmbC9qaGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9vbHMvZWZsL2poYnVpbGQubW9kdWxlcwpAQCAt MTk5LDcgKzE5OSw3IEBACiAgPC9hdXRvdG9vbHM+CiAKICAgPGF1dG90b29scyBpZD0iZWZsIiBh dXRvZ2VuLXNoPSJjb25maWd1cmUiCi0gICAgICAgICAgICAgYXV0b2dlbmFyZ3M9Ii0tZGlzYWJs ZS1mcmliaWRpIC0tZGlzYWJsZS1hdWRpbyAtLWRpc2FibGUtbGlibW91bnQgLS1kaXNhYmxlLXBo eXNpY3MgLS1lbmFibGUtbHVhLW9sZCAtLWVuYWJsZS1pLXJlYWxseS1rbm93LXdoYXQtaS1hbS1k b2luZy1hbmQtdGhhdC10aGlzLXdpbGwtcHJvYmFibHktYnJlYWstdGhpbmdzLWFuZC1pLXdpbGwt Zml4LXRoZW0tbXlzZWxmLWFuZC1zZW5kLXBhdGNoZXMtYWJhIC0tZGlzYWJsZS1uZW9uIj4KKyAg ICAgICAgICAgICBhdXRvZ2VuYXJncz0iLS1kaXNhYmxlLWZyaWJpZGkgLS1kaXNhYmxlLWF1ZGlv IC0tZGlzYWJsZS1saWJtb3VudCAtLWRpc2FibGUtcGh5c2ljcyAtLWVuYWJsZS1sdWEtb2xkIC0t ZW5hYmxlLWktcmVhbGx5LWtub3ctd2hhdC1pLWFtLWRvaW5nLWFuZC10aGF0LXRoaXMtd2lsbC1w cm9iYWJseS1icmVhay10aGluZ3MtYW5kLWktd2lsbC1maXgtdGhlbS1teXNlbGYtYW5kLXNlbmQt cGF0Y2hlcy1hYmEiPgogICAgIDxkZXBlbmRlbmNpZXM+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImZv bnRjb25maWciLz4KICAgICAgIDxkZXAgcGFja2FnZT0iZ3N0cmVhbWVyIi8+CkBAIC0yMDksNiAr MjA5LDcgQEAKICAgICAgICAgICAgIHJlcG89ImRvd25sb2FkLmVubGlnaHRlbm1lbnQub3JnIgog ICAgICAgICAgICAgaGFzaD0ic2hhMjU2OjM1YWYwNzgzZDZkZDg3ZWJiNDM1YzQ2ZmQ2NjJlZjVh NjQ4NTEwZDc0ZmI2ZGM2NTQwYTMxNjVjOWIyMjFlNTAiPgogICAgICAgPHBhdGNoIGZpbGU9ImVj b3JlX3JlbW92ZV93YXJuaW5ncy5wYXRjaCIgc3RyaXA9IjEiLz4KKyAgICAgIDxwYXRjaCBmaWxl PSJlY3Rvcl9ORU9OX2J1aWxkZml4LnBhdGNoIiBzdHJpcD0iMSIvPgogICAgIDwvYnJhbmNoPgog ICA8L2F1dG90b29scz4KIApkaWZmIC0tZ2l0IGEvVG9vbHMvZWZsL3BhdGNoZXMvZWN0b3JfTkVP Tl9idWlsZGZpeC5wYXRjaCBiL1Rvb2xzL2VmbC9wYXRjaGVzL2VjdG9yX05FT05fYnVpbGRmaXgu cGF0Y2gKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uOTNhYTEwNTQyODRkMWZjN2YxZWEwNDZlM2Q4OWEzMTA2NDM0ODky YwotLS0gL2Rldi9udWxsCisrKyBiL1Rvb2xzL2VmbC9wYXRjaGVzL2VjdG9yX05FT05fYnVpbGRm aXgucGF0Y2gKQEAgLTAsMCArMSw2OSBAQAorZGlmZiAtLWdpdCBhL3NyYy9saWIvZWN0b3Ivc29m dHdhcmUvZWN0b3JfZHJhd2hlbHBlcl9uZW9uLmMgYi9zcmMvbGliL2VjdG9yL3NvZnR3YXJlL2Vj dG9yX2RyYXdoZWxwZXJfbmVvbi5jCitpbmRleCBhNTIzMTE5Li4yMmZlYTZjIDEwMDY0NAorLS0t IGEvc3JjL2xpYi9lY3Rvci9zb2Z0d2FyZS9lY3Rvcl9kcmF3aGVscGVyX25lb24uYworKysrIGIv c3JjL2xpYi9lY3Rvci9zb2Z0d2FyZS9lY3Rvcl9kcmF3aGVscGVyX25lb24uYworQEAgLTkyLDcg KzkyLDcgQEAgY29tcF9mdW5jX3NvbGlkX3NvdXJjZV9vdmVyX25lb24odWludCAqIF9fcmVzdHJp Y3QgZGVzdCwgaW50IGxlbmd0aCwgdWludCBjb2xvciwKKyAgICBlbmQgKz0gKHNpemUgJiA3KTsK KyAgICB3aGlsZSAoc3RhcnQgPCAgZW5kKQorICAgICAgeworLSAgICAgICAgKnN0YXJ0ID0gY29s b3IgKyBNVUxfMjU2KGFscGhhLCAqc3RhcnQpOworKyAgICAgICAgKnN0YXJ0ID0gY29sb3IgKyBF Q1RPUl9NVUxfMjU2KGFscGhhLCAqc3RhcnQpOworICAgICAgICAgc3RhcnQrKzsKKyAgICAgIH0K KyB9CitAQCAtMTAwLDcgKzEwMCw3IEBAIGNvbXBfZnVuY19zb2xpZF9zb3VyY2Vfb3Zlcl9uZW9u KHVpbnQgKiBfX3Jlc3RyaWN0IGRlc3QsIGludCBsZW5ndGgsIHVpbnQgY29sb3IsCisgLyogTm90 ZTogT3B0aW1pc2F0aW9uIGlzIGJhc2VkIG9uIGtlZXBpbmcgX2Rlc3RfIGFsaWduZWQ6IGVsc2Ug aXQncyBhIHBhaXIgb2YKKyAgKiByZWFkcywgdGhlbiB0d28gd3JpdGVzLCBhIG1pc3Mgb24gcmVh ZCBpcyAnanVzdCcgdHdvIHJlYWRzICovCisgc3RhdGljIHZvaWQKKy1jb21wX2Z1bmNfc291cmNl X292ZXJfc3NlMih1aW50ICogX19yZXN0cmljdCBkZXN0LCBjb25zdCB1aW50ICogX19yZXN0cmlj dCBzcmMsIGludCBsZW5ndGgsIHVpbnQgY29sb3IsIHVpbnQgY29uc3RfYWxwaGEpCisrY29tcF9m dW5jX3NvdXJjZV9vdmVyX25lb24odWludCAqIF9fcmVzdHJpY3QgZGVzdCwgY29uc3QgdWludCAq IF9fcmVzdHJpY3Qgc3JjLCBpbnQgbGVuZ3RoLCB1aW50IGNvbG9yLCB1aW50IGNvbnN0X2FscGhh KQorIHsKKyAgICB1aW50MTZ4OF90IGFkMF8xNng4OworICAgIHVpbnQxNng4X3QgYWQxXzE2eDg7 CitAQCAtMTQ5LDcgKzE0OSw3IEBAIGNvbXBfZnVuY19zb3VyY2Vfb3Zlcl9zc2UyKHVpbnQgKiBf X3Jlc3RyaWN0IGRlc3QsIGNvbnN0IHVpbnQgKiBfX3Jlc3RyaWN0IHNyYywKKyAgICB4MV84eDE2 ID0gdmR1cHFfbl91OCgweDEpOworICAgIHgxXzMyeDQgPSB2cmVpbnRlcnByZXRxX3UzMl91OCh4 MV84eDE2KTsKKyAgICBzdGFydCA9IGRlc3Q7CistICAgc2l6ZSA9IGw7CisrICAgc2l6ZSA9IGxl bmd0aDsKKyAgICBlbmQgPSBzdGFydCArIChzaXplICYgfjMpOworIAorICAgIHdoaWxlIChzdGFy dCA8IGVuZCkKK0BAIC0yMDQsOSArMjA0LDkgQEAgY29tcF9mdW5jX3NvdXJjZV9vdmVyX3NzZTIo dWludCAqIF9fcmVzdHJpY3QgZGVzdCwgY29uc3QgdWludCAqIF9fcmVzdHJpY3Qgc3JjLAorICAg IGVuZCArPSAoc2l6ZSAmIDMpOworICAgIHdoaWxlIChzdGFydCA8ICBlbmQpCisgICAgICB7Cist ICAgICAgICBEQVRBMzIgc2MgPSBNVUw0X1NZTShjb2xvciwgKnMpOworKyAgICAgICAgREFUQTMy IHNjID0gRUNUT1JfTVVMNF9TWU0oY29sb3IsICpzcmMpOworICAgICAgICAgREFUQTMyIGFscGhh ID0gMjU2IC0gKHNjID4+IDI0KTsKKy0gICAgICAgICpzdGFydCA9IHNjICsgTVVMXzI1NihhbHBo YSwgKnN0YXJ0KTsKKysgICAgICAgICpzdGFydCA9IHNjICsgRUNUT1JfTVVMXzI1NihhbHBoYSwg KnN0YXJ0KTsKKyAgICAgICAgIHN0YXJ0Kys7CisgICAgICAgICBzcmMrKzsKKyAgICAgIH0KK2Rp ZmYgLS1naXQgYS9zcmMvbGliL2VjdG9yL3NvZnR3YXJlL2VjdG9yX2RyYXdoZWxwZXJfcHJpdmF0 ZS5oIGIvc3JjL2xpYi9lY3Rvci9zb2Z0d2FyZS9lY3Rvcl9kcmF3aGVscGVyX3ByaXZhdGUuaAor aW5kZXggZDE1YThmNi4uM2U0MWFlMiAxMDA2NDQKKy0tLSBhL3NyYy9saWIvZWN0b3Ivc29mdHdh cmUvZWN0b3JfZHJhd2hlbHBlcl9wcml2YXRlLmgKKysrKyBiL3NyYy9saWIvZWN0b3Ivc29mdHdh cmUvZWN0b3JfZHJhd2hlbHBlcl9wcml2YXRlLmgKK0BAIC0xMSw2ICsxMSwxMCBAQAorICNkZWZp bmUgTUFYKCBhLCBiICkgICggKGEpID4gKGIpID8gKGEpIDogKGIpICkKKyAjZW5kaWYKKyAKKysj aWZuZGVmIERBVEEzMgorK3R5cGVkZWYgdW5zaWduZWQgaW50IERBVEEzMjsKKysjZW5kaWYKKysK KyAjaWZuZGVmIHVpbnQKKyB0eXBlZGVmIHVuc2lnbmVkIGludCB1aW50OworICNlbmRpZgorQEAg LTE4LDYgKzIyLDEwIEBAIHR5cGVkZWYgdW5zaWduZWQgaW50IHVpbnQ7CisgI2RlZmluZSBFQ1RP Ul9BUkdCX0pPSU4oYSxyLGcsYikgXAorICAgICAgICAgKCgoYSkgPDwgMjQpICsgKChyKSA8PCAx NikgKyAoKGcpIDw8IDgpICsgKGIpKQorIAorKyNkZWZpbmUgRUNUT1JfTVVMXzI1NihhLCBjKSBc CisrICggKCgoKChjKSA+PiA4KSAmIDB4MDBmZjAwZmYpICogKGEpKSAmIDB4ZmYwMGZmMDApICsg XAorKyAgICgoKCgoYykgJiAweDAwZmYwMGZmKSAqIChhKSkgPj4gOCkgJiAweDAwZmYwMGZmKSAp CisrCisgI2RlZmluZSBFQ1RPUl9NVUw0X1NZTSh4LCB5KSBcCisgICggKCgoKCgoeCkgPj4gMTYp ICYgMHhmZjAwKSAqICgoKHkpID4+IDE2KSAmIDB4ZmYwMCkpICsgMHhmZjAwMDApICYgMHhmZjAw MDAwMCkgKyBcCisgICAgKCgoKCgoeCkgPj4gOCkgJiAweGZmMDApICogKCgoeSkgPj4gMTYpICYg MHhmZikpICsgMHhmZjAwKSAmIDB4ZmYwMDAwKSArIFwK