151187 2015-11-12 04:21:20 -0800 Null dereference loading Blink layout test editing/execCommand/indent-button-crash.html 2015-11-17 23:52:58 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned clopez darin oldest_to_newest 1141451 0 cgarcia 2015-11-12 04:21:20 -0800 Program received signal SIGSEGV, Segmentation fault. 0x00007f432d4e5310 in WebCore::CompositeEditCommand::insertNodeAt(WTF::PassRefPtr<WebCore::Node>, WebCore::Position const&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 (gdb) bt #0 0x00007f432d4e5310 in WebCore::CompositeEditCommand::insertNodeAt(WTF::PassRefPtr<WebCore::Node>, WebCore::Position const&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #1 0x00007f432d4d20eb in WebCore::ApplyBlockElementCommand::formatSelection(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #2 0x00007f432d4ce715 in WebCore::ApplyBlockElementCommand::doApply() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #3 0x00007f432d4e2ec3 in WebCore::CompositeEditCommand::apply() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #4 0x00007f432d519455 in WebCore::executeIndent(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #5 0x00007f432d429822 in WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #6 0x00007f432e077a42 in WebCore::jsDocumentPrototypeFunctionExecCommand(JSC::ExecState*) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #7 0x00007f42c7fff0c8 in ?? () #8 0x00007ffe9911cec0 in ?? () #9 0x00007f432b6b872f in llint_entry () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 Backtrace stopped: frame did not save the PC The test seems to be passing in mac bots, though. 1141452 1 265382 cgarcia 2015-11-12 04:27:23 -0800 Created attachment 265382 Patch Merge blink patch. 1141829 2 cgarcia 2015-11-13 05:56:08 -0800 *** Bug 151260 has been marked as a duplicate of this bug. *** 1141918 3 clopez 2015-11-13 13:05:55 -0800 I marked this test as crashing on the GTK TestExpectations on https://trac.webkit.org/r192435 Please remove it from the expectations when landing this patch. Thanks. 1142777 4 cgarcia 2015-11-17 23:52:58 -0800 Committed r192567: <http://trac.webkit.org/changeset/192567> 265382 2015-11-12 04:27:23 -0800 2015-11-17 09:06:58 -0800 Patch wcore-indent-button-crash.diff text/plain 3561 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzNmRkYWI4Li40Mzg0MTVkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTUtMTEt MTIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAg IE51bGwgZGVyZWZlcmVuY2UgbG9hZGluZyBCbGluayBsYXlvdXQgdGVzdCBlZGl0aW5nL2V4ZWND b21tYW5kL2luZGVudC1idXR0b24tY3Jhc2guaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMTg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vVGVzdEV4cGVjdGF0aW9uczog VW5za2lwIHRoZSB0ZXN0LgorCiAyMDE1LTExLTEwICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxs ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlZ3Jlc3Npb24ocjE5MTgxNSk6IDUuMyUgcmVncmVz c2lvbiBvbiBEcm9tYWVvIEpTIExpYnJhcnkgQmVuY2htYXJrCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS93aW4vVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L3dpbi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDVhMzE4N2UuLjZhNjBmZmQgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRl c3RzL3BsYXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRpb25zCkBAIC0zMjMxLDcgKzMyMzEsNiBAQCB3 ZWJraXQub3JnL2IvMTQ4ODg4IGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9zbG93bWV0YXJlZGlyZWN0 LWJhc2ljLmh0bWwgWyBQYXNzIEZhaQogIyBJbXBvcnRlZCBCbGluayB0ZXN0cy4KIGltcG9ydGVk L2JsaW5rL2NvbXBvc2l0aW5nL2lmcmFtZXMvYW5jZXN0b3ItY2xpcHBpbmctbGF5ZXIuaHRtbCBb IFNraXAgXQogaW1wb3J0ZWQvYmxpbmsvY29tcG9zaXRpbmcvcGVyc3BlY3RpdmUtb3JpZ2luLW92 ZXJmbG93LWhpZGRlbi5odG1sIFsgU2tpcCBdCi1pbXBvcnRlZC9ibGluay9lZGl0aW5nL2V4ZWND b21tYW5kL2luZGVudC1idXR0b24tY3Jhc2guaHRtbCBbIFNraXAgXQogaW1wb3J0ZWQvYmxpbmsv aHR0cC90ZXN0cy9wbHVnaW5zL2dldC11cmwtbm90aWZ5LW9uLXJlbW92YWwuaHRtbCBbIFNraXAg XQogaW1wb3J0ZWQvYmxpbmsvcGx1Z2lucy9lbXB0eS1wZXItY29udGV4dC1kYXRhLmh0bWwgWyBT a2lwIF0KIGltcG9ydGVkL2JsaW5rL2FuaW1hdGlvbnMvYW5pbWF0aW9uLWl0ZXJhdGlvbi1ldmVu dC1zaG9ydC1pdGVyYXRpb25zLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDNm OTIyYmEuLmRkOTQ2OGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxNS0xMS0xMiAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKKyAgICAgICAgTnVs bCBkZXJlZmVyZW5jZSBsb2FkaW5nIEJsaW5rIGxheW91dCB0ZXN0IGVkaXRpbmcvZXhlY0NvbW1h bmQvaW5kZW50LWJ1dHRvbi1jcmFzaC5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTExODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGEgbWVyZ2Ugb2YgQmxpbmsgcjE3NDY3MToKKyAg ICAgICAgaHR0cHM6Ly9jb2RlcmV2aWV3LmNocm9taXVtLm9yZy8yOTExNDMwMDIKKworICAgICAg ICBGaXhlcyBpbXBvcnRlZC9ibGluay9lZGl0aW5nL2V4ZWNDb21tYW5kL2luZGVudC1idXR0b24t Y3Jhc2guaHRtbC4KKworICAgICAgICAqIGVkaXRpbmcvQXBwbHlCbG9ja0VsZW1lbnRDb21tYW5k LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFwcGx5QmxvY2tFbGVtZW50Q29tbWFuZDo6ZG9BcHBs eSk6CisKKzIwMTUtMTEtMTIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEu Y29tPgorCiAgICAgICAgIFtHU3RyZWFtZXJdIFVzZSBSdW5Mb29wOjp0aW1lciBpbiBNZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXJCYXNlIGZvciBHTCBkcmF3aW5nCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTEwOTkKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9BcHBseUJsb2NrRWxlbWVudENvbW1hbmQuY3BwIGIvU291cmNl L1dlYkNvcmUvZWRpdGluZy9BcHBseUJsb2NrRWxlbWVudENvbW1hbmQuY3BwCmluZGV4IGQyOTAw YjEuLmNlYWRiMmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvQXBwbHlCbG9j a0VsZW1lbnRDb21tYW5kLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0FwcGx5Qmxv Y2tFbGVtZW50Q29tbWFuZC5jcHAKQEAgLTcwLDggKzcwLDEyIEBAIHZvaWQgQXBwbHlCbG9ja0Vs ZW1lbnRDb21tYW5kOjpkb0FwcGx5KCkKICAgICAvLyBGSVhNRTogV2UgcGFpbnQgdGhlIGdhcCBi ZWZvcmUgc29tZSBwYXJhZ3JhcGhzIHRoYXQgYXJlIGluZGVudGVkIHdpdGggbGVmdCAKICAgICAv LyBtYXJnaW4vcGFkZGluZywgYnV0IG5vdCBvdGhlcnMuICBXZSBzaG91bGQgbWFrZSB0aGUgZ2Fw IHBhaW50aW5nIG1vcmUgY29uc2lzdGVudCBhbmQgCiAgICAgLy8gdGhlbiB1c2UgYSBsZWZ0IG1h cmdpbi9wYWRkaW5nIHJ1bGUgaGVyZS4KLSAgICBpZiAodmlzaWJsZUVuZCAhPSB2aXNpYmxlU3Rh cnQgJiYgaXNTdGFydE9mUGFyYWdyYXBoKHZpc2libGVFbmQpKQotICAgICAgICBzZXRFbmRpbmdT ZWxlY3Rpb24oVmlzaWJsZVNlbGVjdGlvbih2aXNpYmxlU3RhcnQsIHZpc2libGVFbmQucHJldmlv dXMoQ2Fubm90Q3Jvc3NFZGl0aW5nQm91bmRhcnkpLCBlbmRpbmdTZWxlY3Rpb24oKS5pc0RpcmVj dGlvbmFsKCkpKTsKKyAgICBpZiAodmlzaWJsZUVuZCAhPSB2aXNpYmxlU3RhcnQgJiYgaXNTdGFy dE9mUGFyYWdyYXBoKHZpc2libGVFbmQpKSB7CisgICAgICAgIFZpc2libGVTZWxlY3Rpb24gbmV3 U2VsZWN0aW9uKHZpc2libGVTdGFydCwgdmlzaWJsZUVuZC5wcmV2aW91cyhDYW5ub3RDcm9zc0Vk aXRpbmdCb3VuZGFyeSksIGVuZGluZ1NlbGVjdGlvbigpLmlzRGlyZWN0aW9uYWwoKSk7CisgICAg ICAgIGlmIChuZXdTZWxlY3Rpb24uaXNOb25lKCkpCisgICAgICAgICAgICByZXR1cm47CisgICAg ICAgIHNldEVuZGluZ1NlbGVjdGlvbihuZXdTZWxlY3Rpb24pOworICAgIH0KIAogICAgIFZpc2li bGVTZWxlY3Rpb24gc2VsZWN0aW9uID0gc2VsZWN0aW9uRm9yUGFyYWdyYXBoSXRlcmF0aW9uKGVu ZGluZ1NlbGVjdGlvbigpKTsKICAgICBWaXNpYmxlUG9zaXRpb24gc3RhcnRPZlNlbGVjdGlvbiA9 IHNlbGVjdGlvbi52aXNpYmxlU3RhcnQoKTsK