151186 2015-11-12 03:47:09 -0800 Fix build failure due to missing NeverDestroyed.h include after r192169 2015-11-12 10:21:39 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 150986 1 ossy ossy commit-queue darin esprehn+autocc glenn kondapallykalyan mmaxfield oldest_to_newest 1141446 0 ossy 2015-11-12 03:47:09 -0800 http://trac.webkit.org/changeset/192169 broke the --minimal build: ../../Source/WebCore/rendering/RenderCombineText.cpp: In member function ‘void WebCore::RenderCombineText::combineText()’: ../../Source/WebCore/rendering/RenderCombineText.cpp:185:71: error: variable ‘WTF::NeverDestroyed<WTF::String> objectReplacementCharacterString’ has initializer but incomplete type static NeverDestroyed<String> objectReplacementCharacterString(&objectReplacementCharacter, 1); ^ ninja: build stopped: subcommand failed. The normal build works fine, because some #if guarded header includes NeverDestroyed.h, but RenderCombineText.cpp shouldn't rely on this transitive dependency. 1141447 1 265381 ossy 2015-11-12 03:53:23 -0800 Created attachment 265381 Patch 1141501 2 265381 darin 2015-11-12 09:33:40 -0800 Comment on attachment 265381 Patch In general we *do* rely on transitive dependencies all the time, but if it’s platform specific, then a fix like this is fine. 1141527 3 265381 commit-queue 2015-11-12 10:21:34 -0800 Comment on attachment 265381 Patch Clearing flags on attachment: 265381 Committed r192368: <http://trac.webkit.org/changeset/192368> 1141528 4 commit-queue 2015-11-12 10:21:39 -0800 All reviewed patches have been landed. Closing bug. 265381 2015-11-12 03:53:23 -0800 2015-11-12 10:21:34 -0800 Patch bug-151186-20151112125317.patch text/plain 1141 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMzU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Y5MjJiYTkyN2NkYzYx OTU0ZTdkMDYyZTc5YmM3NTMzZTkzNTZkZS4uMmIzOGRlMTUzYmQzYmNjYjVlOTE0YWZhNGQxZGQ1 NWQ0MTVkMDkxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTExLTEyICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGJ1aWxkIGZh aWx1cmUgZHVlIHRvIG1pc3NpbmcgTmV2ZXJEZXN0cm95ZWQuaCBpbmNsdWRlIGFmdGVyIHIxOTIx NjkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTE4 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckNvbWJpbmVUZXh0LmNwcDoKKwogMjAxNS0xMS0xMiAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gVXNl IFJ1bkxvb3A6OnRpbWVyIGluIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UgZm9yIEdM IGRyYXdpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJDb21i aW5lVGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQ29tYmluZVRleHQu Y3BwCmluZGV4IDc0ZTgxZTVkNGI0NDkwOWQxZjE0NjlmZGVlYzYyY2IxNWJmNTRmYTkuLmUwODZl MmUxNGQ1OGIwN2MxM2JjNmJkZWU4YjI3YmU4ZjA4ZDViNGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJDb21iaW5lVGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckNvbWJpbmVUZXh0LmNwcApAQCAtMjMsNiArMjMsNyBAQAogCiAj aW5jbHVkZSAiUmVuZGVyQmxvY2suaCIKICNpbmNsdWRlICJTdHlsZUluaGVyaXRlZERhdGEuaCIK KyNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewog Cg==