151185 2015-11-12 03:35:48 -0800 Fix build failure due to missing forward declaration of FontVariantSettings after r191968 2015-11-12 10:17:22 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149771 1 ossy ossy commit-queue mmaxfield simon.fraser oldest_to_newest 1141442 0 ossy 2015-11-12 03:35:48 -0800 http://trac.webkit.org/changeset/191968 broke the --minimal build. http://trac.webkit.org/changeset/191968/trunk/Source/WebCore/css/CSSFontFaceSource.h started using FontVariantSettings type without forward declaration. The full build works fine, because one of included header declares it (or includes its header), but CSSFontFaceSource.h shouldn't contain this transitive dependency. build log: ----------- In file included from ../../Source/WebCore/css/CSSFontFaceSource.cpp:27:0: ../../Source/WebCore/css/CSSFontFaceSource.h:64:141: error: 'FontVariantSettings' does not name a type ../../Source/WebCore/css/CSSFontFaceSource.cpp:104:14: error: prototype for 'WTF::RefPtr<WebCore::Font> WebCore::CSSFontFaceSource::font(const WebCore::FontDescription&, bool, bool, WebCore::CSSFontSelector*, const WebCore::FontFeatureSettings&, const WebCore::FontVariantSettings&)' does not match any in class 'WebCore::CSSFontFaceSource' In file included from ../../Source/WebCore/css/CSSFontFaceSource.cpp:27:0: ../../Source/WebCore/css/CSSFontFaceSource.h:64:18: error: candidate is: WTF::RefPtr<WebCore::Font> WebCore::CSSFontFaceSource::font(const WebCore::FontDescription&, bool, bool, WebCore::CSSFontSelector*, const WebCore::FontFeatureSettings&, const int&) 1141443 1 265379 ossy 2015-11-12 03:37:28 -0800 Created attachment 265379 Patch 1141444 2 265380 ossy 2015-11-12 03:42:07 -0800 Created attachment 265380 Patch 1141524 3 265380 commit-queue 2015-11-12 10:17:17 -0800 Comment on attachment 265380 Patch Clearing flags on attachment: 265380 Committed r192367: <http://trac.webkit.org/changeset/192367> 1141525 4 commit-queue 2015-11-12 10:17:22 -0800 All reviewed patches have been landed. Closing bug. 265379 2015-11-12 03:37:28 -0800 2015-11-12 03:42:01 -0800 Patch bug-151185-20151112123721.patch text/plain 1207 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMzU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Y5MjJiYTkyN2NkYzYx OTU0ZTdkMDYyZTc5YmM3NTMzZTkzNTZkZS4uZjExNGViM2Y0NTcwNTQwZjkxZWJhNDdhMGJkMGRm NDgxMjc3NTBhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTExLTEyICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGJ1aWxkIGZh aWx1cmUgZHVlIHRvIG1pc3NpbmcgZm9yd2FyZCBkZWNsYXJhdGlvbiBvZiBGb250VmFyaWFudFNl dHRpbmdzIGFmdGVyIHIxOTE5NjgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1MTE4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogY3NzL0NTU0ZvbnRGYWNlU291cmNlLmg6CisKIDIwMTUtMTEtMTIgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3Ry ZWFtZXJdIFVzZSBSdW5Mb29wOjp0aW1lciBpbiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJC YXNlIGZvciBHTCBkcmF3aW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRm9u dEZhY2VTb3VyY2UuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250RmFjZVNvdXJjZS5oCmlu ZGV4IDJlNzZmOTU1ZTg2ZGYxNzUwOWQ1ZGMyOTJlYmZmNWY1Y2FhMDkyNjkuLmVhNTQ5NTUyYWYy Yzk3YTdmZTRiZGQ0ZDNlODBhMGQ0YjZjNmZmMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NGb250RmFjZVNvdXJjZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250 RmFjZVNvdXJjZS5oCkBAIC00NSw2ICs0NSw3IEBAIGNsYXNzIENTU0ZvbnRTZWxlY3RvcjsKIGNs YXNzIEZvbnQ7CiBjbGFzcyBGb250RGVzY3JpcHRpb247CiBjbGFzcyBGb250RmVhdHVyZVNldHRp bmdzOworY2xhc3MgRm9udFZhcmlhbnRTZXR0aW5nczsKIAogY2xhc3MgQ1NTRm9udEZhY2VTb3Vy Y2UgZmluYWwgOiBwdWJsaWMgQ2FjaGVkRm9udENsaWVudCB7CiAgICAgV1RGX01BS0VfRkFTVF9B TExPQ0FURUQ7Cg== 265380 2015-11-12 03:42:07 -0800 2015-11-12 10:17:17 -0800 Patch bug-151185-20151112124201.patch text/plain 1208 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMzU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Y5MjJiYTkyN2NkYzYx OTU0ZTdkMDYyZTc5YmM3NTMzZTkzNTZkZS4uZjExNGViM2Y0NTcwNTQwZjkxZWJhNDdhMGJkMGRm NDgxMjc3NTBhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTExLTEyICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGJ1aWxkIGZh aWx1cmUgZHVlIHRvIG1pc3NpbmcgZm9yd2FyZCBkZWNsYXJhdGlvbiBvZiBGb250VmFyaWFudFNl dHRpbmdzIGFmdGVyIHIxOTE5NjgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1MTE4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogY3NzL0NTU0ZvbnRGYWNlU291cmNlLmg6CisKIDIwMTUtMTEtMTIgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3Ry ZWFtZXJdIFVzZSBSdW5Mb29wOjp0aW1lciBpbiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJC YXNlIGZvciBHTCBkcmF3aW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRm9u dEZhY2VTb3VyY2UuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250RmFjZVNvdXJjZS5oCmlu ZGV4IDJlNzZmOTU1ZTg2ZGYxNzUwOWQ1ZGMyOTJlYmZmNWY1Y2FhMDkyNjkuLjJkYjYxZWU4YWU1 NzY3YmM3OTYzYTU2OGUxMTllZWYwYTJkZWYzYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NGb250RmFjZVNvdXJjZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250 RmFjZVNvdXJjZS5oCkBAIC00NSw2ICs0NSw3IEBAIGNsYXNzIENTU0ZvbnRTZWxlY3RvcjsKIGNs YXNzIEZvbnQ7CiBjbGFzcyBGb250RGVzY3JpcHRpb247CiBjbGFzcyBGb250RmVhdHVyZVNldHRp bmdzOworc3RydWN0IEZvbnRWYXJpYW50U2V0dGluZ3M7CiAKIGNsYXNzIENTU0ZvbnRGYWNlU291 cmNlIGZpbmFsIDogcHVibGljIENhY2hlZEZvbnRDbGllbnQgewogICAgIFdURl9NQUtFX0ZBU1Rf QUxMT0NBVEVEOwo=