15118 2007-08-30 13:13:33 -0700 WebKit Gdk fails to build due to icu, under some conditions 2007-09-17 05:21:55 -0700 1 1 1 Unclassified WebKit WebKit Misc. 523.x (Safari 3) All Linux RESOLVED WORKSFORME P2 Normal --- 0 mh+webkit webkit-unassigned oldest_to_newest 1171 0 mh+webkit 2007-08-30 13:13:33 -0700 (it would be a good thing to have a WebKit Gdk component) Latest icu release (3.8) now includes a --enable-weak-threads flag to configure, which makes icu not link against the pthread library. Let's not discuss why it's good or bad. What is important is that it means icu-config doesn't report -lpthread in the ldflags, which it shouldn't have been in the first place, since you don't need to link against the pthread library to *use* icu. Anyways, the WebKit Gdk build shouldn't rely on icu-config providing the -lpthread necessary to it, it should define it itself. A trivial fix is to add -lpthread to LIBS for gdk-port in JavaScriptCore/kjs/testkjs.pro and WebKit.pri. But I don't know if that would be okay for something else than Linux... 555 1 16275 mh+webkit 2007-09-12 23:28:54 -0700 Created attachment 16275 Proposed patch 556 2 16275 aroben 2007-09-12 23:31:21 -0700 Comment on attachment 16275 Proposed patch The changes and ChangeLogs look sane to me, but I'll leave it to some of the Qt/Gtk guys to review this. 438 3 zecke 2007-09-16 14:19:25 -0700 AFAIK FreeBSD has at least two different threading implementations. Hardcoding -lpthread is something we should not do. So if ICU is not using POSIX thread symbols, who is using them? The one who has the dependency on pthread should introduce that with --ldflags. So an actual link error would be nice to see what we are talking about. 431 4 mh+webkit 2007-09-16 14:57:10 -0700 (In reply to comment #3) > AFAIK FreeBSD has at least two different threading implementations. Hardcoding > -lpthread is something we should not do. > > So if ICU is not using POSIX thread symbols, who is using them? The one who has > the dependency on pthread should introduce that with --ldflags. So an actual > link error would be nice to see what we are talking about. Erm, WebKit does require it in several places, just grep pthread in the code. 430 5 mh+webkit 2007-09-16 15:30:44 -0700 Mmmmmm there might have been something else than the missing -lpthread... The original error message was as below, but it actually doesn't occur anymore here. I suspect a combination of missing -lpthread from icu and some glibc fuckage. Let's mark this bug worksforme... I'll reopen if I can reproduce again. > g++ -Wl,--as-needed -o ../testkjs testkjs.o pcre_get.o pcre_refcount.o pcre_ucp_findchar.o pcre_compile.o pcre_globals.o pcre_config.o pcre_version.o pcre_info.o pcre_study.o pcre_exec.o pcre_xclass.o pcre_tables.o pcre_maketables.o pcre_try_flipped.o pcre_ord2utf8.o pcre_fullinfo.o TCSystemAlloc.o Assertions.o HashTable.o FastMalloc.o NP_jsobject.o npruntime.o runtime_array.o runtime.o runtime_method.o runtime_object.o runtime_root.o c_class.o c_instance.o c_runtime.o c_utility.o DateMath.o JSWrapperObject.o PropertyNameArray.o array_object.o bool_object.o collector.o CommonIdentifiers.o Context.o date_object.o debugger.o dtoa.o error_object.o ExecState.o fpconst.o function.o function_object.o identifier.o internal.o interpreter.o JSImmediate.o JSLock.o lexer.o list.o lookup.o math_object.o nodes.o nodes2string.o number_object.o object.o object_object.o operations.o Parser.o property_map.o property_slot.o regexp.o regexp_object.o scope_chain.o string_object.o ustring.o value.o grammar.o -lm -L/usr/lib -licui18n -licuuc -licudata -lm > collector.o: In function `currentThreadStackBase': > /tmp/webkit-0~svn25144/build-gdk/JavaScriptCore/kjs/../../../JavaScriptCore/kjs/collector.cpp:290: undefined reference to `pthread_getattr_np' > /tmp/webkit-0~svn25144/build-gdk/JavaScriptCore/kjs/../../../JavaScriptCore/kjs/collector.cpp:292: undefined reference to `pthread_attr_getstack' > /tmp/webkit-0~svn25144/build-gdk/JavaScriptCore/kjs/../../../JavaScriptCore/kjs/collector.cpp:290: undefined reference to `pthread_getattr_np' > /tmp/webkit-0~svn25144/build-gdk/JavaScriptCore/kjs/../../../JavaScriptCore/kjs/collector.cpp:292: undefined reference to `pthread_attr_getstack' > collect2: ld returned 1 exit status > make[2]: *** [../testkjs] Error 1 > make[2]: Leaving directory `/tmp/webkit-0~svn25144/build-gdk/JavaScriptCore/kjs' > make[1]: *** [sub-JavaScriptCore-kjs-testkjs-pro-make_default-ordered] Error 2 > make[1]: Leaving directory `/tmp/webkit-0~svn25144/build-gdk' > make: *** [build-gdk-stamp] Error 2 422 6 zecke 2007-09-17 05:21:55 -0700 Okay, if it reoccurs I would probably propose to add gthread-2.0 to the PKG_CONFIG list. 16275 2007-09-12 23:28:54 -0700 2007-09-16 15:31:02 -0700 Proposed patch diff text/plain 2034 mh+webkit ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzZWRiODc5Li45NGUyMDhk IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAK KzIwMDctMDktMTIgIE1pa2UgSG9tbWV5IDxnbGFuZGl1bUBkZWJpYW4ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0LnByaToKKyAg ICAgICAgRG9uJ3QgYXNzdW1lIGljdS1jb25maWcgLS1sZGZsYWdzIGluY2x1ZGVzIC1scHRocmVh ZC4KKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMTgK KwogMjAwNy0wNy0yOSAgQnJpYW4gTWFzdGVuYnJvb2sgIDxicmlhbkBtYXN0ZW5icm9vay5uZXQ+ CiAKICAgICAgICAgQnVpbGQgZml4IGZvciBXZWJLaXQvR3RrIHRvIGNvbXBpbGUgb24gRmVkb3Jh IDcgYXMgZGVzY3JpYmVkIGluCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cg Yi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggOGE3NzkzYS4uZTY4MmU4MyAxMDA2NDQK LS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDExIEBACisyMDA3LTA5LTEyICBNaWtlIEhvbW1leSA8Z2xhbmRpdW1A ZGViaWFuLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGtqcy90ZXN0a2pzLnBybzoKKyAgICAgICAgRG9uJ3QgYXNzdW1lIGljdS1jb25maWcg LS1sZGZsYWdzIGluY2x1ZGVzIC1scHRocmVhZC4KKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMTgKKwogMjAwNy0wOS0xMiAgU2FtIFdlaW5pZyAgPHNh bUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmcmV5IEdhcmVuLgpkaWZm IC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUva2pzL3Rlc3RranMucHJvIGIvSmF2YVNjcmlwdENvcmUv a2pzL3Rlc3RranMucHJvCmluZGV4IGRjM2ZkNGUuLjkyOGM3MDcgMTAwNjQ0Ci0tLSBhL0phdmFT Y3JpcHRDb3JlL2tqcy90ZXN0a2pzLnBybworKysgYi9KYXZhU2NyaXB0Q29yZS9ranMvdGVzdGtq cy5wcm8KQEAgLTksNyArOSw3IEBAIHF0LXBvcnQ6REVGSU5FUyArPSBCVUlMRElOR19RVF9fCiAj cXQtcG9ydDpMSUJTICs9IC1MJCRPVVRQVVRfRElSL2xpYiAtbFF0V2ViS2l0CiBnZGstcG9ydCB7 CiAgICAgUU1BS0VfQ1hYRkxBR1MgKz0gJCRzeXN0ZW0oaWN1LWNvbmZpZyAtLWNwcGZsYWdzKQot ICAgIExJQlMgKz0gJCRzeXN0ZW0oaWN1LWNvbmZpZyAtLWxkZmxhZ3MpCisgICAgTElCUyArPSAk JHN5c3RlbShpY3UtY29uZmlnIC0tbGRmbGFncykgLWxwdGhyZWFkCiB9CiBRTUFLRV9SUEFUSERJ UiArPSAkJE9VVFBVVF9ESVIvbGliCiAKZGlmZiAtLWdpdCBhL1dlYktpdC5wcmkgYi9XZWJLaXQu cHJpCmluZGV4IDY3MTllN2MuLmJlNzYzNjMgMTAwNjQ0Ci0tLSBhL1dlYktpdC5wcmkKKysrIGIv V2ViS2l0LnByaQpAQCAtMTUsNyArMTUsNyBAQCBxdC1wb3J0OiFidWlsZGluZy1saWJzIHsKIGdk ay1wb3J0OkNPTkZJRyArPSBsaW5rX3BrZ2NvbmZpZwogZ2RrLXBvcnQ6UEtHQ09ORklHICs9IGNh aXJvIGNhaXJvLWZ0IGdkay0yLjAgZ3RrKy0yLjAgbGliY3VybAogZ2RrLXBvcnQ6REVGSU5FUyAr PSBCVUlMRElOR19HREtfXz0xIEJVSUxESU5HX0NBSVJPX18KLWdkay1wb3J0OkxJQlMgKz0gLUwk JE9VVFBVVF9ESVIvbGliIC1sV2ViS2l0R2RrICQkc3lzdGVtKGljdS1jb25maWcgLS1sZGZsYWdz KSAtbGpwZWcgLWxwbmcKK2dkay1wb3J0OkxJQlMgKz0gLUwkJE9VVFBVVF9ESVIvbGliIC1sV2Vi S2l0R2RrICQkc3lzdGVtKGljdS1jb25maWcgLS1sZGZsYWdzKSAtbHB0aHJlYWQgLWxqcGVnIC1s cG5nCiBnZGstcG9ydDpRTUFLRV9DWFhGTEFHUyArPSAkJHN5c3RlbShpY3UtY29uZmlnIC0tY3Bw ZmxhZ3MpCiAKIERFRklORVMgKz0gVVNFX1NZU1RFTV9NQUxMT0MK