151177 2015-11-11 19:29:26 -0800 Patchpoints with stackArgument constraints should work 2015-11-11 19:39:19 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 150279 1 fpizlo fpizlo barraclough benjamin commit-queue ggaren mark.lam mhahnenb msaboff nrotem oliver saam sam oldest_to_newest 1141349 0 fpizlo 2015-11-11 19:29:26 -0800 Patch forthcoming. 1141350 1 265353 fpizlo 2015-11-11 19:32:08 -0800 Created attachment 265353 the patch 1141351 2 commit-queue 2015-11-11 19:34:19 -0800 Attachment 265353 did not pass style-queue: ERROR: Source/JavaScriptCore/b3/testb3.cpp:2590: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/b3/testb3.cpp:2591: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:2604: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 1141352 3 265353 saam 2015-11-11 19:35:16 -0800 Comment on attachment 265353 the patch r=me 1141353 4 fpizlo 2015-11-11 19:39:19 -0800 Landed in http://trac.webkit.org/changeset/192345 265353 2015-11-11 19:32:08 -0800 2015-11-11 19:35:16 -0800 the patch blah.patch text/plain 6137 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkyMzQ0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMzIEBA CisyMDE1LTExLTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UGF0Y2hwb2ludHMgd2l0aCBzdGFja0FyZ3VtZW50IGNvbnN0cmFpbnRzIHNob3VsZCB3b3JrCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTExNzcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgb25seSB0 aGluZyBicm9rZW4gd2FzIHRoYXQgU3RhY2ttYXBTcGVjaWFsJ3MgaXNWYWxpZEZvcm0gd291bGQg cmVqZWN0IEFyZzo6YWRkciwgc28KKyAgICAgICAgdmFsaWRhdGlvbiB3b3VsZCBmYWlsIGFmdGVy IGFsbG9jYXRlU3RhY2suCisKKyAgICAgICAgSW4gb3JkZXIgZm9yIFN0YWNrbWFwU3BlY2lhbCB0 byB2YWxpZGF0ZSBBcmc6OmFkZHIsIGl0IG5lZWRzIHRvIGtub3cgdGhlIGZyYW1lIHNpemUuIFRv IGtub3cKKyAgICAgICAgdGhlIGZyYW1lIHNpemUsIGl0IG5lZWRzIGFjY2VzcyB0byBDb2RlJi4g U28sIHRoaXMgY2hhbmdlcyBBaXI6OlNwZWNpYWwgdG8gYWx3YXlzIGhhdmUgYQorICAgICAgICBw b2ludGVyIGJhY2sgdG8gQ29kZS4KKworICAgICAgICBPdGhlciB0aGFuIHRoaXMgYWxyZWFkeSB3 b3JrZWQuCisKKyAgICAgICAgKiBiMy9CM1N0YWNrbWFwU3BlY2lhbC5jcHA6CisgICAgICAgIChK U0M6OkIzOjpTdGFja21hcFNwZWNpYWw6OmlzVmFsaWRJbXBsKToKKyAgICAgICAgKiBiMy9haXIv QWlyQ29kZS5jcHA6CisgICAgICAgIChKU0M6OkIzOjpBaXI6OkNvZGU6OmFkZFNwZWNpYWwpOgor ICAgICAgICAqIGIzL2Fpci9BaXJTcGVjaWFsLmNwcDoKKyAgICAgICAgKEpTQzo6QjM6OkFpcjo6 U3BlY2lhbDo6U3BlY2lhbCk6CisgICAgICAgICogYjMvYWlyL0FpclNwZWNpYWwuaDoKKyAgICAg ICAgKEpTQzo6QjM6OkFpcjo6U3BlY2lhbDo6Y29kZSk6CisgICAgICAgICogYjMvdGVzdGIzLmNw cDoKKyAgICAgICAgKEpTQzo6QjM6OnRlc3RTaW1wbGVQYXRjaHBvaW50KToKKyAgICAgICAgKEpT Qzo6QjM6OnRlc3RQYXRjaHBvaW50Q2FsbEFyZyk6CisgICAgICAgIChKU0M6OkIzOjp0ZXN0U2lt cGxlQ2hlY2spOgorICAgICAgICAoSlNDOjpCMzo6cnVuKToKKwogMjAxNS0xMS0xMSAgTWFyayBM YW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGFiaWxpdHkgdG8gaW5zZXJ0 IHByb2JlcyBpbiBMTFZNIElSIHRoYXQgd2UgZ2VuZXJhdGUuCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYjMvQjNTdGFja21hcFNwZWNpYWwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9iMy9CM1N0YWNrbWFwU3BlY2lhbC5jcHAJKHJldmlzaW9uIDE5MjM0MykK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1N0YWNrbWFwU3BlY2lhbC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE1MSw5ICsxNTEsMTcgQEAgYm9vbCBTdGFja21hcFNwZWNpYWw6OmlzVmFs aWRJbXBsKAogICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgICAgICAgICBi cmVhazsKICAgICAgICAgY2FzZSBWYWx1ZVJlcDo6U3RhY2tBcmd1bWVudDoKLSAgICAgICAgICAg IGlmIChhcmcgIT0gQXJnOjpjYWxsQXJnKHJlcC5vZmZzZXRGcm9tU1AoKSkpCi0gICAgICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOwotICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICBpZiAo YXJnID09IEFyZzo6Y2FsbEFyZyhyZXAub2Zmc2V0RnJvbVNQKCkpKQorICAgICAgICAgICAgICAg IGJyZWFrOworICAgICAgICAgICAgaWYgKGFyZy5pc0FkZHIoKSAmJiBjb2RlKCkuZnJhbWVTaXpl KCkpIHsKKyAgICAgICAgICAgICAgICBpZiAoYXJnLmJhc2UoKSA9PSBUbXAoR1BSSW5mbzo6Y2Fs bEZyYW1lUmVnaXN0ZXIpCisgICAgICAgICAgICAgICAgICAgICYmIGFyZy5vZmZzZXQoKSA9PSBy ZXAub2Zmc2V0RnJvbVNQKCkgLSBjb2RlKCkuZnJhbWVTaXplKCkpCisgICAgICAgICAgICAgICAg ICAgIGJyZWFrOworICAgICAgICAgICAgICAgIGlmIChhcmcuYmFzZSgpID09IFRtcChNYWNyb0Fz c2VtYmxlcjo6c3RhY2tQb2ludGVyUmVnaXN0ZXIpCisgICAgICAgICAgICAgICAgICAgICYmIGFy Zy5vZmZzZXQoKSA9PSByZXAub2Zmc2V0RnJvbVNQKCkpCisgICAgICAgICAgICAgICAgICAgIGJy ZWFrOworICAgICAgICAgICAgfQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICBj YXNlIFZhbHVlUmVwOjpDb25zdGFudDoKICAgICAgICAgICAgIC8vIFRoaXMgaXMgbm90IGEgdmFs aWQgaW5wdXQgcmVwcmVzZW50YXRpb24uCiAgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQo KTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy90ZXN0YjMuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy90ZXN0YjMuY3BwCShyZXZpc2lvbiAxOTIzNDMp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvdGVzdGIzLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMjU3Nyw2ICsyNTc3LDMzIEBAIHZvaWQgdGVzdFNpbXBsZVBhdGNocG9pbnQoKQogICAgIENI RUNLKGNvbXBpbGVBbmRSdW48aW50Pihwcm9jLCAxLCAyKSA9PSAzKTsKIH0KIAordm9pZCB0ZXN0 UGF0Y2hwb2ludENhbGxBcmcoKQoreworICAgIFByb2NlZHVyZSBwcm9jOworICAgIEJhc2ljQmxv Y2sqIHJvb3QgPSBwcm9jLmFkZEJsb2NrKCk7CisgICAgVmFsdWUqIGFyZzEgPSByb290LT5hcHBl bmROZXc8QXJndW1lbnRSZWdWYWx1ZT4ocHJvYywgT3JpZ2luKCksIEdQUkluZm86OmFyZ3VtZW50 R1BSMCk7CisgICAgVmFsdWUqIGFyZzIgPSByb290LT5hcHBlbmROZXc8QXJndW1lbnRSZWdWYWx1 ZT4ocHJvYywgT3JpZ2luKCksIEdQUkluZm86OmFyZ3VtZW50R1BSMSk7CisgICAgUGF0Y2hwb2lu dFZhbHVlKiBwYXRjaHBvaW50ID0gcm9vdC0+YXBwZW5kTmV3PFBhdGNocG9pbnRWYWx1ZT4ocHJv YywgSW50MzIsIE9yaWdpbigpKTsKKyAgICBwYXRjaHBvaW50LT5hcHBlbmQoQ29uc3RyYWluZWRW YWx1ZShhcmcxLCBWYWx1ZVJlcDo6c3RhY2tBcmd1bWVudCgwKSkpOworICAgIHBhdGNocG9pbnQt PmFwcGVuZChDb25zdHJhaW5lZFZhbHVlKGFyZzIsIFZhbHVlUmVwOjpzdGFja0FyZ3VtZW50KDgp KSk7CisgICAgcGF0Y2hwb2ludC0+c2V0R2VuZXJhdG9yKAorICAgICAgICBbJl0gKENDYWxsSGVs cGVycyYgaml0LCBjb25zdCBTdGFja21hcEdlbmVyYXRpb25QYXJhbXMmIHBhcmFtcykgeworICAg ICAgICAgICAgQ0hFQ0socGFyYW1zLnJlcHMuc2l6ZSgpID09IDMpOworICAgICAgICAgICAgQ0hF Q0socGFyYW1zLnJlcHNbMF0uaXNHUFIoKSk7CisgICAgICAgICAgICBDSEVDSyhwYXJhbXMucmVw c1sxXS5pc1N0YWNrKCkpOworICAgICAgICAgICAgQ0hFQ0socGFyYW1zLnJlcHNbMl0uaXNTdGFj aygpKTsKKyAgICAgICAgICAgIGppdC5sb2FkMzIoCisgICAgICAgICAgICAgICAgQ0NhbGxIZWxw ZXJzOjpBZGRyZXNzKEdQUkluZm86OmNhbGxGcmFtZVJlZ2lzdGVyLCBwYXJhbXMucmVwc1sxXS5v ZmZzZXRGcm9tRlAoKSksCisgICAgICAgICAgICAgICAgcGFyYW1zLnJlcHNbMF0uZ3ByKCkpOwor ICAgICAgICAgICAgaml0LmFkZDMyKAorICAgICAgICAgICAgICAgIENDYWxsSGVscGVyczo6QWRk cmVzcyhHUFJJbmZvOjpjYWxsRnJhbWVSZWdpc3RlciwgcGFyYW1zLnJlcHNbMl0ub2Zmc2V0RnJv bUZQKCkpLAorICAgICAgICAgICAgICAgIHBhcmFtcy5yZXBzWzBdLmdwcigpKTsKKyAgICAgICAg fSk7CisgICAgcm9vdC0+YXBwZW5kTmV3PENvbnRyb2xWYWx1ZT4ocHJvYywgUmV0dXJuLCBPcmln aW4oKSwgcGF0Y2hwb2ludCk7CisKKyAgICBDSEVDSyhjb21waWxlQW5kUnVuPGludD4ocHJvYywg MSwgMikgPT0gMyk7Cit9CisKIHZvaWQgdGVzdFNpbXBsZUNoZWNrKCkKIHsKICAgICBQcm9jZWR1 cmUgcHJvYzsKQEAgLTM2MDYsNiArMzYzMyw3IEBAIHZvaWQgcnVuKGNvbnN0IGNoYXIqIGZpbHRl cikKICAgICBSVU4odGVzdENvbXBsZXgoNCwgMzg0KSk7CiAKICAgICBSVU4odGVzdFNpbXBsZVBh dGNocG9pbnQoKSk7CisgICAgUlVOKHRlc3RQYXRjaHBvaW50Q2FsbEFyZygpKTsKICAgICBSVU4o dGVzdFNpbXBsZUNoZWNrKCkpOwogICAgIFJVTih0ZXN0Q2hlY2tMZXNzVGhhbigpKTsKICAgICBS VU4odGVzdENoZWNrTWVnYUNvbWJvKCkpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Iz L2Fpci9BaXJDb2RlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMv YWlyL0FpckNvZGUuY3BwCShyZXZpc2lvbiAxOTIzNDMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYjMvYWlyL0FpckNvZGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02OCw2ICs2OCw3IEBAIFN0 YWNrU2xvdCogQ29kZTo6YWRkU3RhY2tTbG90KFN0YWNrU2xvdFYKIFNwZWNpYWwqIENvZGU6OmFk ZFNwZWNpYWwoc3RkOjp1bmlxdWVfcHRyPFNwZWNpYWw+IHNwZWNpYWwpCiB7CiAgICAgU3BlY2lh bCogcmVzdWx0ID0gc3BlY2lhbC5nZXQoKTsKKyAgICByZXN1bHQtPm1fY29kZSA9IHRoaXM7CiAg ICAgbV9zcGVjaWFscy5hcHBlbmQoV1RGOjptb3ZlKHNwZWNpYWwpKTsKICAgICByZXR1cm4gcmVz dWx0OwogfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJTcGVjaWFsLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0FpclNwZWNpYWwu Y3BwCShyZXZpc2lvbiAxOTIzNDMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fp clNwZWNpYWwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNyw2ICszNyw3IEBAIGNvbnN0IGNoYXIq IGNvbnN0IFNwZWNpYWw6OmR1bXBQcmVmaXggPSAKIAogU3BlY2lhbDo6U3BlY2lhbCgpCiAgICAg OiBtX2luZGV4KFVJTlRfTUFYKQorICAgICwgbV9jb2RlKG51bGxwdHIpCiB7CiB9CiAKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlyU3BlY2lhbC5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlyU3BlY2lhbC5oCShyZXZpc2lvbiAxOTIz NDMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0FpclNwZWNpYWwuaAkod29ya2lu ZyBjb3B5KQpAQCAtMzYsNiArMzYsNyBAQAogCiBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIEIz IHsgbmFtZXNwYWNlIEFpciB7CiAKK2NsYXNzIENvZGU7CiBzdHJ1Y3QgR2VuZXJhdGlvbkNvbnRl eHQ7CiAKIGNsYXNzIFNwZWNpYWwgewpAQCAtNDcsNiArNDgsOCBAQCBwdWJsaWM6CiAgICAgU3Bl Y2lhbCgpOwogICAgIHZpcnR1YWwgflNwZWNpYWwoKTsKIAorICAgIENvZGUmIGNvZGUoKSBjb25z dCB7IHJldHVybiAqbV9jb2RlOyB9CisKICAgICBDU3RyaW5nIG5hbWUoKSBjb25zdDsKIAogICAg IHZpcnR1YWwgdm9pZCBmb3JFYWNoQXJnKEluc3QmLCBjb25zdCBTY29wZWRMYW1iZGE8SW5zdDo6 RWFjaEFyZ0NhbGxiYWNrPiYpID0gMDsKQEAgLTk3LDYgKzEwMCw3IEBAIHByaXZhdGU6CiAKICAg ICBjb25zdCBjaGFyKiBtX25hbWU7CiAgICAgdW5zaWduZWQgbV9pbmRleDsKKyAgICBDb2RlKiBt X2NvZGU7CiB9OwogCiBjbGFzcyBEZWVwU3BlY2lhbER1bXAgewo=