151176 2015-11-11 19:22:04 -0800 [JSC] Add a comment explaining the opcode suffixes on x86 2015-11-11 21:19:37 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 1141346 0 benjamin 2015-11-11 19:22:04 -0800 [JSC] Add a comment explaining the opcode suffixes on x86 1141347 1 265352 benjamin 2015-11-11 19:24:08 -0800 Created attachment 265352 Patch 1141359 2 265352 achristensen 2015-11-11 20:40:28 -0800 Comment on attachment 265352 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265352&action=review I've wondered about the EvGv suffixes, too. > Source/JavaScriptCore/assembler/X86Assembler.h:181 > + // The most commons argument types are: common > Source/JavaScriptCore/assembler/X86Assembler.h:185 > + // The most commons sizes are: common > Source/JavaScriptCore/assembler/X86Assembler.h:187 > + // -z: 32bits in both 32bits and 64bits mode. Common for immediate values. 32bit and 64bit mode 1141369 3 benjamin 2015-11-11 21:19:37 -0800 Committed r192348: <http://trac.webkit.org/changeset/192348> 265352 2015-11-11 19:24:08 -0800 2015-11-11 20:40:28 -0800 Patch bug-151176-20151111192403.patch text/plain 2283 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi NzU2ZDg3NjMwMWYxNzQ2YmVmMmExOTY3NDlmZGMzMzVmMzc4YTk1Li4xMzE3ZmE4YWEyY2Y1OTQw MjRjNWEwN2VhNzNhMGYzNjAxNTY4Zjg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNS0xMS0xMSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbSlNDXSBBZGQgYSBjb21tZW50IGV4cGxhaW5pbmcgdGhlIG9wY29k ZSBzdWZmaXhlcyBvbiB4ODYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE1MTE3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogYXNzZW1ibGVyL1g4NkFzc2VtYmxlci5oOgorICAgICAgICBJIHdhcyBhbHdh eXMgY29uZnVzZWQgd2l0aCB0aGUgcHJlZml4ZXMuIEdhdmluIHBvaW50ZWQgb3V0IHRoZSBJbnRl bCBkb2N1bWVudGF0aW9uCisgICAgICAgIGV4cGxhaW5zIGV2ZXJ5dGhpbmcuCisgICAgICAgIEkg YWRkZWQgYSBjb21tZW50IHRvIGhlbHAgdGhlIG5leHQgcGVyc29uIGNvbmZ1c2VkIGFib3V0IHRo b3NlIHN1ZmZpeGVzLgorCiAyMDE1LTExLTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KIAogICAgICAgICBBZGQgYWJpbGl0eSB0byBpbnNlcnQgcHJvYmVzIGluIExMVk0gSVIgdGhh dCB3ZSBnZW5lcmF0ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvWDg2QXNzZW1ibGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1g4NkFz c2VtYmxlci5oCmluZGV4IDM3NGNmYWE3YTE0ZTk1MmFhN2QwN2FkYmNmNGZmY2M5M2Y3YmEwZmYu LjY5NmZlYzljZjk4MDFjMWVlZWFmZTJmODk3YWNkZWJkOTY1OWNiZGMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9YODZBc3NlbWJsZXIuaApAQCAtMTY5LDYgKzE2OSwy MiBAQCBwdWJsaWM6CiAgICAgfSBDb25kaXRpb247CiAKIHByaXZhdGU6CisgICAgLy8gT25lQnl0 ZU9wY29kZUlEIGRlZmluZXMgdGhlIGJ5dGVjb2RlIGZvciAxIGJ5dGUgaW5zdHJ1Y3Rpb24uIEl0 IGFsc28gY29udGFpbnMgdGhlIHByZWZpeGVzCisgICAgLy8gZm9yIHR3byBieXRlcyBpbnN0cnVj dGlvbnMuCisgICAgLy8gVHdvQnl0ZU9wY29kZUlELCBUaHJlZUJ5dGVPcGNvZGVJRCBkZWZpbmUg dGhlIG9wY29kZXMgZm9yIHRoZSBtdWx0aWJ5dGVzIGluc3RydWN0aW9ucy4KKyAgICAvLworICAg IC8vIFRoZSBlbmNvZGluZyBmb3IgZWFjaCBpbnN0cnVjdGlvbiBjYW4gYmUgZm91bmQgaW4gdGhl IEludGVsIEFyY2hpdGVjdHVyZSBNYW51YWwgaW4gdGhlIGFwcGVuZGl4CisgICAgLy8gIk9wY29k ZSBNYXAuIgorICAgIC8vCisgICAgLy8gRWFjaCBvcGNvZGUgY2FuIGhhdmUgYSBzdWZmaXggZGVz Y3JpYmluZyB0aGUgdHlwZSBvZiBhcmd1bWVudC4gVGhlIGZ1bGwgbGlzdCBvZiBzdWZmaXhlcyBp cworICAgIC8vIGluIHRoZSAiS2V5IHRvIEFiYnJldmlhdGlvbnMiIHNlY3Rpb24gb2YgdGhlICJP cGNvZGUgTWFwIi4KKyAgICAvLyBUaGUgbW9zdCBjb21tb25zIGFyZ3VtZW50IHR5cGVzIGFyZToK KyAgICAvLyAgICAgLUU6IFRoZSBhcmd1bWVudCBpcyBlaXRoZXIgYSBHUFIgb3IgYSBtZW1vcnkg YWRkcmVzcy4KKyAgICAvLyAgICAgLUc6IFRoZSBhcmd1bWVudCBpcyBhIEdQUi4KKyAgICAvLyAg ICAgLUk6IFRoZSBhcmd1bWVudCBpcyBhbiBpbW1lZGlhdGUuCisgICAgLy8gVGhlIG1vc3QgY29t bW9ucyBzaXplcyBhcmU6CisgICAgLy8gICAgIC12OiAzMiBvciA2NGJpdHMgZGVwZW5kaW5nIG9u IHRoZSBvcGVyYW5kLXNpemUgYXR0cmlidXRlLgorICAgIC8vICAgICAtejogMzJiaXRzIGluIGJv dGggMzJiaXRzIGFuZCA2NGJpdHMgbW9kZS4gQ29tbW9uIGZvciBpbW1lZGlhdGUgdmFsdWVzLgog ICAgIHR5cGVkZWYgZW51bSB7CiAgICAgICAgIE9QX0FERF9Fdkd2ICAgICAgICAgICAgICAgICAg ICAgPSAweDAxLAogICAgICAgICBPUF9BRERfR3ZFdiAgICAgICAgICAgICAgICAgICAgID0gMHgw MywK