151159 2015-11-11 15:17:09 -0800 Add ability to insert probes in LLVM IR that we generate. 2015-11-11 16:41:14 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue oldest_to_newest 1141245 0 mark.lam 2015-11-11 15:17:09 -0800 This is done by inserting a stackmap intrinsic and emitting the probe there. 1141248 1 265322 mark.lam 2015-11-11 15:22:05 -0800 Created attachment 265322 the patch. 1141251 2 commit-queue 2015-11-11 15:24:33 -0800 Attachment 265322 did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:9401: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/ftl/FTLInlineCacheDescriptor.h:181: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/ftl/FTLInlineCacheDescriptor.h:190: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 1141255 3 265322 ggaren 2015-11-11 15:53:15 -0800 Comment on attachment 265322 the patch. r=me 1141279 4 265322 commit-queue 2015-11-11 16:41:12 -0800 Comment on attachment 265322 the patch. Clearing flags on attachment: 265322 Committed r192334: <http://trac.webkit.org/changeset/192334> 1141280 5 commit-queue 2015-11-11 16:41:14 -0800 All reviewed patches have been landed. Closing bug. 265322 2015-11-11 15:22:05 -0800 2015-11-11 16:41:12 -0800 the patch. bug-151159.patch text/plain 6663 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkyMzI5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBA CisyMDE1LTExLTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgYWJpbGl0eSB0byBpbnNlcnQgcHJvYmVzIGluIExMVk0gSVIgdGhhdCB3ZSBnZW5lcmF0ZS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTE1OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMg ZG9uZSBieSBpbnNlcnRpbmcgYSBzdGFja21hcCBpbnRyaW5zaWMgYW5kIGVtaXR0aW5nIHRoZSBw cm9iZSB0aGVyZS4KKworICAgICAgICBXZSBjYW4gbm93IGluc2VydCBwcm9iZXMgdGhhdCB0YWtl IGEgbGFtYmRhIGxpa2Ugc286CisKKyAgICAgICAgICAgIHByb2JlKFtdIChDQ2FsbEhlbHBlcnM6 OlByb2JlQ29udGV4dCopIHsKKyAgICAgICAgICAgICAgICBkYXRhTG9nKCJIZWxsbyBGVExcbiIp OworICAgICAgICAgICAgfSk7CisKKyAgICAgICAgKiBmdGwvRlRMQ29tcGlsZS5jcHA6CisgICAg ICAgICogZnRsL0ZUTElubGluZUNhY2hlRGVzY3JpcHRvci5oOgorICAgICAgICAoSlNDOjpGVEw6 OlByb2JlRGVzY3JpcHRvcjo6UHJvYmVEZXNjcmlwdG9yKToKKyAgICAgICAgKEpTQzo6RlRMOjpQ cm9iZURlc2NyaXB0b3I6OnByb2JlRnVuY3Rpb24pOgorICAgICAgICAqIGZ0bC9GVExJbmxpbmVD YWNoZVNpemUuY3BwOgorICAgICAgICAoSlNDOjpGVEw6OnNpemVPZlByb2JlKToKKyAgICAgICAg KiBmdGwvRlRMSW5saW5lQ2FjaGVTaXplLmg6CisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9M TFZNLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2VyREZHVG9MTFZNOjpwcm9iZSk6 CisgICAgICAgICogZnRsL0ZUTFN0YXRlLmg6CisKIDIwMTUtMTEtMTEgIE1hcmsgTGFtICA8bWFy ay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIENoYW5nZSBwcm9iZSBDUFVTdGF0ZSBncHIoKSBh bmQgZnByKCkgdG8gcmV0dXJuIHJlZmVyZW5jZXMuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZnRsL0ZUTENvbXBpbGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9mdGwvRlRMQ29tcGlsZS5jcHAJKHJldmlzaW9uIDE5MjMyMikKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9mdGwvRlRMQ29tcGlsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1OSw2ICs0NTks MzYgQEAgc3RhdGljIHZvaWQgZ2VuZXJhdGVBcml0aFN1YklDRmFzdFBhdGgoCiAgICAgfQogfQog CisjaWYgRU5BQkxFKE1BU01fUFJPQkUpCisKK3N0YXRpYyB2b2lkIGdlbmVyYXRlUHJvYmUoCisg ICAgU3RhdGUmIHN0YXRlLCBDb2RlQmxvY2sqIGNvZGVCbG9jaywgR2VuZXJhdGVkRnVuY3Rpb24g Z2VuZXJhdGVkRnVuY3Rpb24sCisgICAgU3RhY2tNYXBzOjpSZWNvcmRNYXAmIHJlY29yZE1hcCwg UHJvYmVEZXNjcmlwdG9yJiBpYykKK3sKKyAgICBWTSYgdm0gPSBzdGF0ZS5ncmFwaC5tX3ZtOwor ICAgIHNpemVfdCBzaXplT2ZJQyA9IHNpemVPZlByb2JlKCk7CisKKyAgICBTdGFja01hcHM6OlJl Y29yZE1hcDo6aXRlcmF0b3IgaXRlciA9IHJlY29yZE1hcC5maW5kKGljLnN0YWNrbWFwSUQoKSk7 CisgICAgaWYgKGl0ZXIgPT0gcmVjb3JkTWFwLmVuZCgpKQorICAgICAgICByZXR1cm47IC8vIEl0 IHdhcyBvcHRpbWl6ZWQgb3V0LgorCisgICAgQ0NhbGxIZWxwZXJzIGZhc3RQYXRoSklUKCZ2bSwg Y29kZUJsb2NrKTsKKyAgICBWZWN0b3I8U3RhY2tNYXBzOjpSZWNvcmRBbmRJbmRleD4mIHJlY29y ZHMgPSBpdGVyLT52YWx1ZTsKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSByZWNvcmRzLnNpemUoKTsg aS0tOykgeworICAgICAgICBTdGFja01hcHM6OlJlY29yZCYgcmVjb3JkID0gcmVjb3Jkc1tpXS5y ZWNvcmQ7CisKKyAgICAgICAgZmFzdFBhdGhKSVQucHJvYmUoaWMucHJvYmVGdW5jdGlvbigpKTsK KyAgICAgICAgQ0NhbGxIZWxwZXJzOjpKdW1wIGRvbmUgPSBmYXN0UGF0aEpJVC5qdW1wKCk7CisK KyAgICAgICAgY2hhciogc3RhcnRPZklDID0gYml0d2lzZV9jYXN0PGNoYXIqPihnZW5lcmF0ZWRG dW5jdGlvbikgKyByZWNvcmQuaW5zdHJ1Y3Rpb25PZmZzZXQ7CisgICAgICAgIGdlbmVyYXRlSW5s aW5lSWZQb3NzaWJsZU91dE9mTGluZUlmTm90KHN0YXRlLCB2bSwgY29kZUJsb2NrLCBmYXN0UGF0 aEpJVCwgc3RhcnRPZklDLCBzaXplT2ZJQywgIlByb2JlIiwgWyZdIChMaW5rQnVmZmVyJiBsaW5r QnVmZmVyLCBDQ2FsbEhlbHBlcnMmLCBib29sKSB7CisgICAgICAgICAgICBsaW5rQnVmZmVyLmxp bmsoZG9uZSwgQ29kZUxvY2F0aW9uTGFiZWwoc3RhcnRPZklDICsgc2l6ZU9mSUMpKTsKKyAgICAg ICAgfSk7CisgICAgfQorfQorCisjZW5kaWYgLy8gRU5BQkxFKE1BU01fUFJPQkUpCisKIHN0YXRp YyBSZWdpc3RlclNldCB1c2VkUmVnaXN0ZXJzRm9yKGNvbnN0IFN0YWNrTWFwczo6UmVjb3JkJiBy ZWNvcmQpCiB7CiAgICAgaWYgKE9wdGlvbnM6OmFzc3VtZUFsbFJlZ3NJbkZUTElDQXJlTGl2ZSgp KQpAQCAtOTExLDYgKzk0MSwxMiBAQCBzdGF0aWMgdm9pZCBmaXhGdW5jdGlvbkJhc2VkT25TdGFj a01hcHMoCiAgICAgICAgICAgICAgICAgICAgIHN0YXRlLmZpbmFsaXplci0+c2lkZUNvZGVMaW5r QnVmZmVyLT5sb2NhdGlvbk9mKHN0ZDo6Z2V0PDE+KHR1cGxlKSkpOwogICAgICAgICAgICAgfQog ICAgICAgICB9CisjaWYgRU5BQkxFKE1BU01fUFJPQkUpCisgICAgICAgIGZvciAodW5zaWduZWQg aSA9IHN0YXRlLnByb2Jlcy5zaXplKCk7IGktLTspIHsKKyAgICAgICAgICAgIFByb2JlRGVzY3Jp cHRvciYgcHJvYmUgPSBzdGF0ZS5wcm9iZXNbaV07CisgICAgICAgICAgICBnZW5lcmF0ZVByb2Jl KHN0YXRlLCBjb2RlQmxvY2ssIGdlbmVyYXRlZEZ1bmN0aW9uLCByZWNvcmRNYXAsIHByb2JlKTsK KyAgICAgICAgfQorI2VuZGlmCiAgICAgICAgIGZvciAoYXV0byYgcGFpciA6IGV4Y2VwdGlvbkp1 bXBzVG9MaW5rKQogICAgICAgICAgICAgc3RhdGUuZmluYWxpemVyLT5zaWRlQ29kZUxpbmtCdWZm ZXItPmxpbmsocGFpci5maXJzdCwgcGFpci5zZWNvbmQpOwogICAgIH0KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9mdGwvRlRMSW5saW5lQ2FjaGVEZXNjcmlwdG9yLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExJbmxpbmVDYWNoZURlc2NyaXB0b3IuaAko cmV2aXNpb24gMTkyMzIyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExJbmxpbmVD YWNoZURlc2NyaXB0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtMTc1LDYgKzE3NSwyMiBAQCBwdWJs aWM6CiAgICAgUmVmUHRyPExhenlTbG93UGF0aExpbmtlclRhc2s+IG1fbGlua2VyOwogfTsKIAor I2lmIEVOQUJMRShNQVNNX1BST0JFKQorY2xhc3MgUHJvYmVEZXNjcmlwdG9yIDogcHVibGljIElu bGluZUNhY2hlRGVzY3JpcHRvciB7CitwdWJsaWM6CisgICAgUHJvYmVEZXNjcmlwdG9yKHVuc2ln bmVkIHN0YWNrbWFwSUQsIHN0ZDo6ZnVuY3Rpb248dm9pZCAoQ0NhbGxIZWxwZXJzOjpQcm9iZUNv bnRleHQqKT4gcHJvYmVGdW5jdGlvbikKKyAgICAgICAgOiBJbmxpbmVDYWNoZURlc2NyaXB0b3Io c3RhY2ttYXBJRCwgY29kZU9yaWdpbigpLCBudWxscHRyKQorICAgICAgICAsIG1fcHJvYmVGdW5j dGlvbihwcm9iZUZ1bmN0aW9uKQorICAgIHsKKyAgICB9CisKKyAgICBzdGQ6OmZ1bmN0aW9uPHZv aWQgKENDYWxsSGVscGVyczo6UHJvYmVDb250ZXh0Kik+JiBwcm9iZUZ1bmN0aW9uKCkgeyByZXR1 cm4gbV9wcm9iZUZ1bmN0aW9uOyB9CisKK3ByaXZhdGU6CisgICAgc3RkOjpmdW5jdGlvbjx2b2lk IChDQ2FsbEhlbHBlcnM6OlByb2JlQ29udGV4dCopPiBtX3Byb2JlRnVuY3Rpb247Cit9OworI2Vu ZGlmIC8vIEVOQUJMRShNQVNNX1BST0JFKQorCiB9IH0gLy8gbmFtZXNwYWNlIEpTQzo6RlRMCiAK ICNlbmRpZiAvLyBFTkFCTEUoRlRMX0pJVCkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9m dGwvRlRMSW5saW5lQ2FjaGVTaXplLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZnRsL0ZUTElubGluZUNhY2hlU2l6ZS5jcHAJKHJldmlzaW9uIDE5MjMyMikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMSW5saW5lQ2FjaGVTaXplLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTQ1LDYgKzE0NSwxMyBAQCBzaXplX3Qgc2l6ZU9mQXJpdGhTdWIoKQogI2VuZGlm CiB9CiAKKyNpZiBFTkFCTEUoTUFTTV9QUk9CRSkKK3NpemVfdCBzaXplT2ZQcm9iZSgpCit7Cisg ICAgcmV0dXJuIDEzMjsgLy8gQmFzZWQgb24gQVJNNjQuCit9CisjZW5kaWYKKwogc2l6ZV90IHNp emVPZklDRm9yKE5vZGUqIG5vZGUpCiB7CiAgICAgc3dpdGNoIChub2RlLT5vcCgpKSB7CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTElubGluZUNhY2hlU2l6ZS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMSW5saW5lQ2FjaGVTaXplLmgJKHJl dmlzaW9uIDE5MjMyMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMSW5saW5lQ2Fj aGVTaXplLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ3LDYgKzQ3LDkgQEAgc2l6ZV90IHNpemVPZkNv bnN0cnVjdFZhcmFyZ3MoKTsKIHNpemVfdCBzaXplT2ZDb25zdHJ1Y3RGb3J3YXJkVmFyYXJncygp Owogc2l6ZV90IHNpemVPZkluKCk7CiBzaXplX3Qgc2l6ZU9mQXJpdGhTdWIoKTsKKyNpZiBFTkFC TEUoTUFTTV9QUk9CRSkKK3NpemVfdCBzaXplT2ZQcm9iZSgpOworI2VuZGlmCiAKIHNpemVfdCBz aXplT2ZJQ0ZvcihERkc6Ok5vZGUqKTsKIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0 bC9GVExMb3dlckRGR1RvTExWTS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHJldmlzaW9uIDE5MjMyMikKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCSh3b3JraW5nIGNvcHkp CkBAIC05Mzk3LDYgKzkzOTcsMTUgQEAgcHJpdmF0ZToKICAgICAgICAgcmV0dXJuIGFic3RyYWN0 U3RydWN0dXJlKGVkZ2Uubm9kZSgpKTsKICAgICB9CiAgICAgCisjaWYgRU5BQkxFKE1BU01fUFJP QkUpCisgICAgdm9pZCBwcm9iZShzdGQ6OmZ1bmN0aW9uPHZvaWQgKENDYWxsSGVscGVyczo6UHJv YmVDb250ZXh0Kik+IHByb2JlRnVuYykKKyAgICB7CisgICAgICAgIHVpbnQzMl90IHN0YWNrbWFw SUQgPSBtX3N0YWNrbWFwSURzKys7CisgICAgICAgIG1fZnRsU3RhdGUucHJvYmVzLmFwcGVuZChQ cm9iZURlc2NyaXB0b3Ioc3RhY2ttYXBJRCwgcHJvYmVGdW5jKSk7CisgICAgICAgIG1fb3V0LmNh bGwobV9vdXQuc3RhY2ttYXBJbnRyaW5zaWMoKSwgbV9vdXQuY29uc3RJbnQ2NChzdGFja21hcElE KSwgbV9vdXQuY29uc3RJbnQzMihzaXplT2ZQcm9iZSgpKSk7CisgICAgfQorI2VuZGlmCisKICAg ICB2b2lkIGNyYXNoKCkKICAgICB7CiAgICAgICAgIGNyYXNoKG1faGlnaEJsb2NrLT5pbmRleCwg bV9ub2RlLT5pbmRleCgpKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMU3Rh dGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTFN0YXRlLmgJ KHJldmlzaW9uIDE5MjMyMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMU3RhdGUu aAkod29ya2luZyBjb3B5KQpAQCAtODEsNiArODEsOSBAQCBwdWJsaWM6CiAgICAgU2VnbWVudGVk VmVjdG9yPENoZWNrSW5EZXNjcmlwdG9yPiBjaGVja0luczsKICAgICBTZWdtZW50ZWRWZWN0b3I8 QXJpdGhTdWJEZXNjcmlwdG9yPiBhcml0aFN1YnM7CiAgICAgU2VnbWVudGVkVmVjdG9yPExhenlT bG93UGF0aERlc2NyaXB0b3I+IGxhenlTbG93UGF0aHM7CisjaWYgRU5BQkxFKE1BU01fUFJPQkUp CisgICAgU2VnbWVudGVkVmVjdG9yPFByb2JlRGVzY3JpcHRvcj4gcHJvYmVzOworI2VuZGlmCiAg ICAgVmVjdG9yPEpTQ2FsbD4ganNDYWxsczsKICAgICBWZWN0b3I8SlNDYWxsVmFyYXJncz4ganND YWxsVmFyYXJnc2VzOwogICAgIFZlY3RvcjxKU1RhaWxDYWxsPiBqc1RhaWxDYWxsczsK