151149 2015-11-11 12:52:19 -0800 Web Inspector: blank debugger tab when opening inspector on unvisited website 2015-11-11 19:13:44 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1141194 0 bburg 2015-11-11 12:52:19 -0800 . 1141195 1 webkit-bug-importer 2015-11-11 12:52:31 -0800 <rdar://problem/23504427> 1141205 2 bburg 2015-11-11 13:26:35 -0800 SUMMARY: * Sometimes we don't show anything in the main content view of Debugger tab, even when there are resources in the sidebar that could be shown. STEPS TO REPRODUCE: * Open the inspector on any page, select the Debugger Tab. * Close the inspector * Navigate to a page for which the inspector has never been opened * Open the inspector EXPECTED: * Content view should show the first eligible resource in the debugger sidebar. ACTUAL: * Nothing in the sidebar is selected, the main content view is empty. 1141241 3 bburg 2015-11-11 15:03:28 -0800 Notes: * It seems that at the time when we try to show default content (WebInspector.contentLoaded calls shown() on the active tab), there are no eligible resources added to the tree. So, showDefaultContentView finds no tree elements it can show. There are two options I see: 1. inside finalAttemptToRestoreViewStateFromCookie, call showDefaultContentView again if the cookie is empty. This would show some view after the final attempt timeout, which is 300ms or so. 2. when we add tree elements to the DebuggerSidebarPanel, if there's nothing being shown and there's no cookie pending for restore, show it as the default content. 1141269 4 265334 bburg 2015-11-11 16:27:20 -0800 Created attachment 265334 Patch 1141305 5 265334 joepeck 2015-11-11 17:17:13 -0800 Comment on attachment 265334 Patch This sounds good to me. It seems a bit arbitrary, but better than a blank view! 1141343 6 265334 commit-queue 2015-11-11 19:13:39 -0800 Comment on attachment 265334 Patch Clearing flags on attachment: 265334 Committed r192344: <http://trac.webkit.org/changeset/192344> 1141344 7 commit-queue 2015-11-11 19:13:44 -0800 All reviewed patches have been landed. Closing bug. 265334 2015-11-11 16:27:20 -0800 2015-11-11 19:13:39 -0800 Patch bug-151149-20151111162715.patch text/plain 3144 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm NjM1NjQyZGU1Y2NlOTcyNGI0MWFlNGE0MmRhMTMyNDdlYTI0OTViLi4zYTRkZDdhMzE0YzU0ZGNh NDUyZjU3ZTdmNzY1YmYwYjY1MjkxNmZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxNS0xMS0xMSAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBibGFuayBkZWJ1Z2dlciB0YWIgd2hlbiBvcGVuaW5nIGlu c3BlY3RvciBvbiB1bnZpc2l0ZWQgd2Vic2l0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2hlbiBJbnNwZWN0b3IgdHJpZXMgdG8gc2hvdyBkZWZhdWx0 IGNvbnRlbnQgd2hlbiBpbml0aWFsbHkgc2hvd2luZyBhIHRhYiB1cG9uIG9wZW5pbmcsCisgICAg ICAgIHRoZXJlIG1heSBub3QgYmUgYW55IHRyZWUgZWxlbWVudHMgYWRkZWQgdG8gdGhlIG5hdmln YXRpb24gYmFyIHlldC4gSW4gdGhlIGNhc2Ugb2YgYW4KKyAgICAgICAgdW52aXNpdGVkIHdlYnNp dGUsIHRoZXJlIHdpbGwgYmUgbm8gc3RhdGUgcmVzdG9yYXRpb24gY29va2llIHRvIHRyaWdnZXIg ZGVmZXJyZWQgc2VsZWN0aW9uLgorICAgICAgICBTbywgc2hvd0RlZmF1bHRDb250ZW50VmlldyBm aW5kcyBubyB0cmVlIGVsZW1lbnRzIGl0IGNhbiBzaG93LCBhbmQgdGhlIG1haW4gdmlldyBpcyBi bGFuay4KKworICAgICAgICBXZSBjYW4gZml4IHRoaXMgYnkgc3BlY3VsYXRpdmVseSBzaG93aW5n IHRoZSBmaXJzdCBzY3JpcHQvcmVzb3VyY2UgdGhhdCdzIGFkZGVkIHRvIHRoZSB0cmVlCisgICAg ICAgIGlmIG5vIGNvbnRlbnQgdmlldyBpcyBiZWluZyBzaG93bi4gSWYgYSBzdGF0ZSByZXN0b3Jh dGlvbiBjb29raWUgZXhpc3RzLCBpdCB3aWxsIHRha2UgcHJpb3JpdHkKKyAgICAgICAgb3ZlciB0 aGUgZGVmYXVsdC1kaXNwbGF5ZWQgY29udGVudCB2aWV3LgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5EZWJ1Z2dlclNpZGViYXJQYW5lbC5wcm90b3R5cGUuX2FkZFJlc291cmNlKToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5EZWJ1Z2dlclNpZGViYXJQYW5lbC5wcm90b3R5cGUuX2FkZFNjcmlwdCk6 CisKIDIwMTUtMTEtMDkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBTdXBwb3J0IEdlc3R1cmUgRXZlbnRzIHRvIHpvb20gaW4g LyBvdXQgb2YgdGhlIFRpbWVsaW5lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzCmlu ZGV4IDRjZjBkZGI5ZjY4MTJjNTkwMDhhMDJlZjY5ZWMxYWZmYzVjZDlmNWUuLmY5YTRiMmY0OTll MWY5NWMzZjk1Nzk1NWM1NzYyZTY0YjgzYWUyNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJh clBhbmVsLmpzCkBAIC0zNzcsOSArMzc3LDEyIEBAIFdlYkluc3BlY3Rvci5EZWJ1Z2dlclNpZGVi YXJQYW5lbCA9IGNsYXNzIERlYnVnZ2VyU2lkZWJhclBhbmVsIGV4dGVuZHMgV2ViSW5zcGVjCiAg ICAgICAgIGlmICghW1dlYkluc3BlY3Rvci5SZXNvdXJjZS5UeXBlLkRvY3VtZW50LCBXZWJJbnNw ZWN0b3IuUmVzb3VyY2UuVHlwZS5TY3JpcHRdLmluY2x1ZGVzKHJlc291cmNlLnR5cGUpKQogICAg ICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIHRoaXMuX2FkZFRyZWVFbGVtZW50Rm9yU291cmNl Q29kZVRvQ29udGVudFRyZWVPdXRsaW5lKHJlc291cmNlKTsKKyAgICAgICAgbGV0IHRyZWVFbGVt ZW50ID0gdGhpcy5fYWRkVHJlZUVsZW1lbnRGb3JTb3VyY2VDb2RlVG9Db250ZW50VHJlZU91dGxp bmUocmVzb3VyY2UpOwogICAgICAgICB0aGlzLl9hZGRCcmVha3BvaW50c0ZvclNvdXJjZUNvZGUo cmVzb3VyY2UpOwogICAgICAgICB0aGlzLl9hZGRJc3N1ZXNGb3JTb3VyY2VDb2RlKHJlc291cmNl KTsKKworICAgICAgICBpZiAoIXRoaXMuY29udGVudEJyb3dzZXIuY3VycmVudENvbnRlbnRWaWV3 KQorICAgICAgICAgICAgdGhpcy5zaG93RGVmYXVsdENvbnRlbnRWaWV3Rm9yVHJlZUVsZW1lbnQo dHJlZUVsZW1lbnQpOwogICAgIH0KIAogICAgIF9tYWluUmVzb3VyY2VEaWRDaGFuZ2UoZXZlbnQp CkBAIC00MTksOSArNDIyLDEyIEBAIFdlYkluc3BlY3Rvci5EZWJ1Z2dlclNpZGViYXJQYW5lbCA9 IGNsYXNzIERlYnVnZ2VyU2lkZWJhclBhbmVsIGV4dGVuZHMgV2ViSW5zcGVjCiAgICAgICAgIGlm IChzY3JpcHQucmVzb3VyY2UpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgdGhpcy5f YWRkVHJlZUVsZW1lbnRGb3JTb3VyY2VDb2RlVG9Db250ZW50VHJlZU91dGxpbmUoc2NyaXB0KTsK KyAgICAgICAgbGV0IHRyZWVFbGVtZW50ID0gdGhpcy5fYWRkVHJlZUVsZW1lbnRGb3JTb3VyY2VD b2RlVG9Db250ZW50VHJlZU91dGxpbmUoc2NyaXB0KTsKICAgICAgICAgdGhpcy5fYWRkQnJlYWtw b2ludHNGb3JTb3VyY2VDb2RlKHNjcmlwdCk7CiAgICAgICAgIHRoaXMuX2FkZElzc3Vlc0ZvclNv dXJjZUNvZGUoc2NyaXB0KTsKKworICAgICAgICBpZiAoIXRoaXMuY29udGVudEJyb3dzZXIuY3Vy cmVudENvbnRlbnRWaWV3KQorICAgICAgICAgICAgdGhpcy5zaG93RGVmYXVsdENvbnRlbnRWaWV3 Rm9yVHJlZUVsZW1lbnQodHJlZUVsZW1lbnQpOwogICAgIH0KIAogICAgIF9zY3JpcHRzQ2xlYXJl ZChldmVudCkK