151147 2015-11-11 12:00:45 -0800 Handle custom menu items in WebKit instead of WebCore on Windows 2015-11-11 13:48:03 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1141186 0 andersca 2015-11-11 12:00:45 -0800 Handle custom menu items in WebKit instead of WebCore on Windows 1141187 1 265312 andersca 2015-11-11 12:02:02 -0800 Created attachment 265312 Patch 1141193 2 265313 andersca 2015-11-11 12:35:59 -0800 Created attachment 265313 Patch 1141214 3 andersca 2015-11-11 13:48:03 -0800 Committed r192322: <http://trac.webkit.org/changeset/192322> 265312 2015-11-11 12:02:02 -0800 2015-11-11 12:35:56 -0800 Patch bug-151147-20151111120157.patch text/plain 3653 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3dp bi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKaW5kZXggMDRlNGQxZWZm ZDgwNmNjNTNhY2YxMmRhMTBmYWZkYjljZDVkNzYwNi4uYWZkMDExZjA4MDBmODA0ZjcyYzk2MzM1 OWQ1MTBmOTI3M2JmOWRmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC93aW4vQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1 LTExLTExICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAg SGFuZGxlIGN1c3RvbSBtZW51IGl0ZW1zIGluIFdlYktpdCBpbnN0ZWFkIG9mIFdlYkNvcmUgb24g V2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTUxMTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBXZWJDb3JlU3VwcG9ydC9XZWJDb250ZXh0TWVudUNsaWVudC5jcHA6CisgICAgICAgIChXZWJD b250ZXh0TWVudUNsaWVudDo6Y29udGV4dE1lbnVJdGVtU2VsZWN0ZWQpOgorICAgICAgICAqIFdl YlZpZXcuY3BwOgorICAgICAgICAoV2ViVmlldzo6b25NZW51Q29tbWFuZCk6CisKKzIwMTUtMTEt MTEgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBVc2Ug V2luMzIgZnVuY3Rpb25zIHRvIGdldCBjb250ZXh0IG1lbnUgaXRlbSBpbmZvCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTExMjMKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViQ29udGV4dE1lbnVDbGllbnQu Y3BwIGIvU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViQ29udGV4dE1lbnVDbGll bnQuY3BwCmluZGV4IGI2ZTcxYjVjOTZjYTlhYWIxZjQzZmRjOWM4NmM3MmEyOGM2MTMyMjkuLjMw Y2U0MmMyM2M3OWYyODcwZTI4YjhkNzNhMDM4MTMwZDZmMmY3YjYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkNvbnRleHRNZW51Q2xpZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJDb250ZXh0TWVudUNsaWVudC5j cHAKQEAgLTUyLDI5ICs1Miw4IEBAIHZvaWQgV2ViQ29udGV4dE1lbnVDbGllbnQ6OmNvbnRleHRN ZW51RGVzdHJveWVkKCkKICAgICBkZWxldGUgdGhpczsKIH0KIAotdm9pZCBXZWJDb250ZXh0TWVu dUNsaWVudDo6Y29udGV4dE1lbnVJdGVtU2VsZWN0ZWQoQ29udGV4dE1lbnVJdGVtKiBpdGVtLCBj b25zdCBDb250ZXh0TWVudSogcGFyZW50TWVudSkKK3ZvaWQgV2ViQ29udGV4dE1lbnVDbGllbnQ6 OmNvbnRleHRNZW51SXRlbVNlbGVjdGVkKENvbnRleHRNZW51SXRlbSosIGNvbnN0IENvbnRleHRN ZW51KikKIHsKLSAgICBBU1NFUlQoaXRlbS0+dHlwZSgpID09IEFjdGlvblR5cGUgfHwgaXRlbS0+ dHlwZSgpID09IENoZWNrYWJsZUFjdGlvblR5cGUpOwotCi0gICAgQ09NUHRyPElXZWJVSURlbGVn YXRlPiB1aURlbGVnYXRlOwotICAgIGlmIChGQUlMRUQobV93ZWJWaWV3LT51aURlbGVnYXRlKCZ1 aURlbGVnYXRlKSkpCi0gICAgICAgIHJldHVybjsKLQotICAgIEFTU0VSVCh1aURlbGVnYXRlKTsK LQotICAgIENPTVB0cjxXZWJFbGVtZW50UHJvcGVydHlCYWc+IHByb3BlcnR5QmFnOwotICAgIHBy b3BlcnR5QmFnLmFkb3B0UmVmKFdlYkVsZW1lbnRQcm9wZXJ0eUJhZzo6Y3JlYXRlSW5zdGFuY2Uo bV93ZWJWaWV3LT5wYWdlKCktPmNvbnRleHRNZW51Q29udHJvbGxlcigpLmhpdFRlc3RSZXN1bHQo KSkpOwotCi0gICAgLy8gVGhpcyBjYWxsIHdvdWxkIGxlYWsgdGhlIE1FTlVJVEVNSU5GTydzIHN1 Yk1lbnUgaWYgaXQgaGFkIG9uZSwgYnV0IG9uIFdpbmRvd3MsIHN1Yk1lbnVzIGNhbid0IGJlIHNl bGVjdGVkLCBzbyB0aGVyZSBpcwotICAgIC8vIG5vIHdheSB3ZSB3b3VsZCBnZXQgdG8gdGhpcyBw b2ludC4gQWxzbywgaXQgY2FuJ3QgYmUgYSBzZXBhcmF0b3IsIGJlY2F1c2Ugc2VwYXJhdG9ycyBj YW5ub3QgYmUgc2VsZWN0ZWQuCi0gICAgQVNTRVJUKGl0ZW0tPnR5cGUoKSAhPSBTdWJtZW51VHlw ZSk7Ci0gICAgQVNTRVJUKGl0ZW0tPnR5cGUoKSAhPSBTZXBhcmF0b3JUeXBlKTsKLQotICAgIC8v IENvbnRleHRNZW51SXRlbTo6cGxhdGZvcm1Db250ZXh0TWVudUl0ZW0gZG9lc24ndCBzZXQgdGhl IGR3VHlwZURhdGEgb2YgdGhlIE1FTlVJVEVNSU5GTywgYnV0IG5vIFdlYktpdCBjbGllbnRzCi0g ICAgLy8gdXNlIHRoZSB0aXRsZSBpbiBJV2ViVUlEZWxlZ2F0ZTo6Y29udGV4dE1lbnVJdGVtU2Vs ZWN0ZWQsIHNvIHdlIGRvbid0IG5lZWQgdG8gcG9wdWxhdGUgaXQgaGVyZS4KLSAgICBNRU5VSVRF TUlORk8gc2VsZWN0ZWRJdGVtID0gaXRlbS0+cGxhdGZvcm1Db250ZXh0TWVudUl0ZW0oKTsKLQot ICAgIHVpRGVsZWdhdGUtPmNvbnRleHRNZW51SXRlbVNlbGVjdGVkKG1fd2ViVmlldywgJnNlbGVj dGVkSXRlbSwgcHJvcGVydHlCYWcuZ2V0KCkpOwogfQogCiB2b2lkIFdlYkNvbnRleHRNZW51Q2xp ZW50Ojpkb3dubG9hZFVSTChjb25zdCBVUkwmIHVybCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvd2luL1dlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdC93aW4vV2ViVmlldy5jcHAKaW5kZXgg NDM4YTc5YzYwNmQ0ZmViMGYxODkxNGQ2NDY1Y2U4YTA0MGQ1YmI1Yi4uNmFmZTEyNDdlNTYzOTY2 YzQ3OTEzNWRmNTliNzcyZTYzMWJhODlmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC93aW4v V2ViVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC93aW4vV2ViVmlldy5jcHAKQEAgLTE2MjUs NiArMTYyNSwxNiBAQCB2b2lkIFdlYlZpZXc6Om9uTWVudUNvbW1hbmQoV1BBUkFNIHdQYXJhbSwg TFBBUkFNIGxQYXJhbSkKICAgICBTdHJpbmcgdGl0bGUoYnVmZmVyLmdldCgpLCBtZW51SXRlbUlu Zm8uY2NoKTsKICAgICBDb250ZXh0TWVudUFjdGlvbiBhY3Rpb24gPSBzdGF0aWNfY2FzdDxDb250 ZXh0TWVudUFjdGlvbj4obWVudUl0ZW1JbmZvLndJRCk7CiAKKyAgICBpZiAoYWN0aW9uID49IENv bnRleHRNZW51SXRlbUJhc2VBcHBsaWNhdGlvblRhZykgeworICAgICAgICBpZiAobV91aURlbGVn YXRlKSB7CisgICAgICAgICAgICBDT01QdHI8V2ViRWxlbWVudFByb3BlcnR5QmFnPiBwcm9wZXJ0 eUJhZzsKKyAgICAgICAgICAgIHByb3BlcnR5QmFnLmFkb3B0UmVmKFdlYkVsZW1lbnRQcm9wZXJ0 eUJhZzo6Y3JlYXRlSW5zdGFuY2UobV9wYWdlLT5jb250ZXh0TWVudUNvbnRyb2xsZXIoKS5oaXRU ZXN0UmVzdWx0KCkpKTsKKworICAgICAgICAgICAgbV91aURlbGVnYXRlLT5jb250ZXh0TWVudUl0 ZW1TZWxlY3RlZChtX3dlYlZpZXcsICZtZW51SXRlbUluZm8sIHByb3BlcnR5QmFnLmdldCgpKTsK KyAgICAgICAgfQorICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgQ29udGV4dE1lbnVJdGVt IGl0ZW0oQWN0aW9uVHlwZSwgYWN0aW9uLCB0aXRsZSwgdHJ1ZSwgZmFsc2UpOwogICAgIG1fcGFn ZS0+Y29udGV4dE1lbnVDb250cm9sbGVyKCkuY29udGV4dE1lbnVJdGVtU2VsZWN0ZWQoJml0ZW0p OwogfQo= 265313 2015-11-11 12:35:59 -0800 2015-11-11 13:34:48 -0800 Patch bug-151147-20151111123553.patch text/plain 3648 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3dp bi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKaW5kZXggMDRlNGQxZWZm ZDgwNmNjNTNhY2YxMmRhMTBmYWZkYjljZDVkNzYwNi4uYWZkMDExZjA4MDBmODA0ZjcyYzk2MzM1 OWQ1MTBmOTI3M2JmOWRmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC93aW4vQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1 LTExLTExICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAg SGFuZGxlIGN1c3RvbSBtZW51IGl0ZW1zIGluIFdlYktpdCBpbnN0ZWFkIG9mIFdlYkNvcmUgb24g V2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTUxMTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBXZWJDb3JlU3VwcG9ydC9XZWJDb250ZXh0TWVudUNsaWVudC5jcHA6CisgICAgICAgIChXZWJD b250ZXh0TWVudUNsaWVudDo6Y29udGV4dE1lbnVJdGVtU2VsZWN0ZWQpOgorICAgICAgICAqIFdl YlZpZXcuY3BwOgorICAgICAgICAoV2ViVmlldzo6b25NZW51Q29tbWFuZCk6CisKKzIwMTUtMTEt MTEgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBVc2Ug V2luMzIgZnVuY3Rpb25zIHRvIGdldCBjb250ZXh0IG1lbnUgaXRlbSBpbmZvCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTExMjMKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViQ29udGV4dE1lbnVDbGllbnQu Y3BwIGIvU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViQ29udGV4dE1lbnVDbGll bnQuY3BwCmluZGV4IGI2ZTcxYjVjOTZjYTlhYWIxZjQzZmRjOWM4NmM3MmEyOGM2MTMyMjkuLjMw Y2U0MmMyM2M3OWYyODcwZTI4YjhkNzNhMDM4MTMwZDZmMmY3YjYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkNvbnRleHRNZW51Q2xpZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJDb250ZXh0TWVudUNsaWVudC5j cHAKQEAgLTUyLDI5ICs1Miw4IEBAIHZvaWQgV2ViQ29udGV4dE1lbnVDbGllbnQ6OmNvbnRleHRN ZW51RGVzdHJveWVkKCkKICAgICBkZWxldGUgdGhpczsKIH0KIAotdm9pZCBXZWJDb250ZXh0TWVu dUNsaWVudDo6Y29udGV4dE1lbnVJdGVtU2VsZWN0ZWQoQ29udGV4dE1lbnVJdGVtKiBpdGVtLCBj b25zdCBDb250ZXh0TWVudSogcGFyZW50TWVudSkKK3ZvaWQgV2ViQ29udGV4dE1lbnVDbGllbnQ6 OmNvbnRleHRNZW51SXRlbVNlbGVjdGVkKENvbnRleHRNZW51SXRlbSosIGNvbnN0IENvbnRleHRN ZW51KikKIHsKLSAgICBBU1NFUlQoaXRlbS0+dHlwZSgpID09IEFjdGlvblR5cGUgfHwgaXRlbS0+ dHlwZSgpID09IENoZWNrYWJsZUFjdGlvblR5cGUpOwotCi0gICAgQ09NUHRyPElXZWJVSURlbGVn YXRlPiB1aURlbGVnYXRlOwotICAgIGlmIChGQUlMRUQobV93ZWJWaWV3LT51aURlbGVnYXRlKCZ1 aURlbGVnYXRlKSkpCi0gICAgICAgIHJldHVybjsKLQotICAgIEFTU0VSVCh1aURlbGVnYXRlKTsK LQotICAgIENPTVB0cjxXZWJFbGVtZW50UHJvcGVydHlCYWc+IHByb3BlcnR5QmFnOwotICAgIHBy b3BlcnR5QmFnLmFkb3B0UmVmKFdlYkVsZW1lbnRQcm9wZXJ0eUJhZzo6Y3JlYXRlSW5zdGFuY2Uo bV93ZWJWaWV3LT5wYWdlKCktPmNvbnRleHRNZW51Q29udHJvbGxlcigpLmhpdFRlc3RSZXN1bHQo KSkpOwotCi0gICAgLy8gVGhpcyBjYWxsIHdvdWxkIGxlYWsgdGhlIE1FTlVJVEVNSU5GTydzIHN1 Yk1lbnUgaWYgaXQgaGFkIG9uZSwgYnV0IG9uIFdpbmRvd3MsIHN1Yk1lbnVzIGNhbid0IGJlIHNl bGVjdGVkLCBzbyB0aGVyZSBpcwotICAgIC8vIG5vIHdheSB3ZSB3b3VsZCBnZXQgdG8gdGhpcyBw b2ludC4gQWxzbywgaXQgY2FuJ3QgYmUgYSBzZXBhcmF0b3IsIGJlY2F1c2Ugc2VwYXJhdG9ycyBj YW5ub3QgYmUgc2VsZWN0ZWQuCi0gICAgQVNTRVJUKGl0ZW0tPnR5cGUoKSAhPSBTdWJtZW51VHlw ZSk7Ci0gICAgQVNTRVJUKGl0ZW0tPnR5cGUoKSAhPSBTZXBhcmF0b3JUeXBlKTsKLQotICAgIC8v IENvbnRleHRNZW51SXRlbTo6cGxhdGZvcm1Db250ZXh0TWVudUl0ZW0gZG9lc24ndCBzZXQgdGhl IGR3VHlwZURhdGEgb2YgdGhlIE1FTlVJVEVNSU5GTywgYnV0IG5vIFdlYktpdCBjbGllbnRzCi0g ICAgLy8gdXNlIHRoZSB0aXRsZSBpbiBJV2ViVUlEZWxlZ2F0ZTo6Y29udGV4dE1lbnVJdGVtU2Vs ZWN0ZWQsIHNvIHdlIGRvbid0IG5lZWQgdG8gcG9wdWxhdGUgaXQgaGVyZS4KLSAgICBNRU5VSVRF TUlORk8gc2VsZWN0ZWRJdGVtID0gaXRlbS0+cGxhdGZvcm1Db250ZXh0TWVudUl0ZW0oKTsKLQot ICAgIHVpRGVsZWdhdGUtPmNvbnRleHRNZW51SXRlbVNlbGVjdGVkKG1fd2ViVmlldywgJnNlbGVj dGVkSXRlbSwgcHJvcGVydHlCYWcuZ2V0KCkpOwogfQogCiB2b2lkIFdlYkNvbnRleHRNZW51Q2xp ZW50Ojpkb3dubG9hZFVSTChjb25zdCBVUkwmIHVybCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvd2luL1dlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdC93aW4vV2ViVmlldy5jcHAKaW5kZXgg NDM4YTc5YzYwNmQ0ZmViMGYxODkxNGQ2NDY1Y2U4YTA0MGQ1YmI1Yi4uNDQyZThmOTRiOWJjY2Rl YTE2ZTUyYjViYzgzN2IwYmMwZTE1YjAwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC93aW4v V2ViVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC93aW4vV2ViVmlldy5jcHAKQEAgLTE2MjUs NiArMTYyNSwxNiBAQCB2b2lkIFdlYlZpZXc6Om9uTWVudUNvbW1hbmQoV1BBUkFNIHdQYXJhbSwg TFBBUkFNIGxQYXJhbSkKICAgICBTdHJpbmcgdGl0bGUoYnVmZmVyLmdldCgpLCBtZW51SXRlbUlu Zm8uY2NoKTsKICAgICBDb250ZXh0TWVudUFjdGlvbiBhY3Rpb24gPSBzdGF0aWNfY2FzdDxDb250 ZXh0TWVudUFjdGlvbj4obWVudUl0ZW1JbmZvLndJRCk7CiAKKyAgICBpZiAoYWN0aW9uID49IENv bnRleHRNZW51SXRlbUJhc2VBcHBsaWNhdGlvblRhZykgeworICAgICAgICBpZiAobV91aURlbGVn YXRlKSB7CisgICAgICAgICAgICBDT01QdHI8V2ViRWxlbWVudFByb3BlcnR5QmFnPiBwcm9wZXJ0 eUJhZzsKKyAgICAgICAgICAgIHByb3BlcnR5QmFnLmFkb3B0UmVmKFdlYkVsZW1lbnRQcm9wZXJ0 eUJhZzo6Y3JlYXRlSW5zdGFuY2UobV9wYWdlLT5jb250ZXh0TWVudUNvbnRyb2xsZXIoKS5oaXRU ZXN0UmVzdWx0KCkpKTsKKworICAgICAgICAgICAgbV91aURlbGVnYXRlLT5jb250ZXh0TWVudUl0 ZW1TZWxlY3RlZCh0aGlzLCAmbWVudUl0ZW1JbmZvLCBwcm9wZXJ0eUJhZy5nZXQoKSk7CisgICAg ICAgIH0KKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIENvbnRleHRNZW51SXRlbSBpdGVt KEFjdGlvblR5cGUsIGFjdGlvbiwgdGl0bGUsIHRydWUsIGZhbHNlKTsKICAgICBtX3BhZ2UtPmNv bnRleHRNZW51Q29udHJvbGxlcigpLmNvbnRleHRNZW51SXRlbVNlbGVjdGVkKCZpdGVtKTsKIH0K