151140 2015-11-11 10:27:41 -0800 bmalloc: Add libdl dependency 2015-11-11 17:02:26 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Other Linux RESOLVED FIXED P2 Normal --- 1 akiss webkit-unassigned commit-queue ossy oldest_to_newest 1141149 0 akiss 2015-11-11 10:27:41 -0800 When building webkit (or simply javascriptcore) on my aarch64 linux setup (with Tools/Scripts/build-{webkit,jsc} --gtk), I get undefined reference errors: [820/823] Linking CXX shared library lib/libjavascriptcoregtk-4.0.so.18.3.0 FAILED: : && /usr/bin/c++ -fPIC -std=c++11 -mfix-cortex-a53-835769 -std=c++11 -mfix-cortex-a53-835769 -O3 -DNDEBUG -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-strict-aliasing -fno-rtti -Wl,--no-undefined -Wl,--no-undefined -L/home/akiss/devel/WebKit/WebKitBuild/DependenciesGTK/Root/lib -shared -Wl,-soname,libjavascriptcoregtk-4.0.so.18 -o lib/libjavascriptcoregtk-4.0.so.18.3.0 @CMakeFiles/JavaScriptCore.rsp && : lib/../Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/Environment.cpp.o: In function `bmalloc::Environment::computeIsBmallocEnabled()': Environment.cpp:(.text+0xa8): undefined reference to `dlopen' Environment.cpp:(.text+0xbc): undefined reference to `dlsym' Environment.cpp:(.text+0xc8): undefined reference to `dlclose' collect2: error: ld returned 1 exit status It turns out that the symbols are referenced from the isASanEnabled() function and -ldl is indeed missing from the linker's command line. 1141153 1 265304 akiss 2015-11-11 10:32:16 -0800 Created attachment 265304 Proposed patch 1141154 2 265304 ossy 2015-11-11 10:37:51 -0800 Comment on attachment 265304 Proposed patch LGTM, r=me 1141188 3 265304 commit-queue 2015-11-11 12:02:54 -0800 Comment on attachment 265304 Proposed patch Rejecting attachment 265304 from commit-queue. akiss@inf.u-szeged.hu does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1141190 4 265304 commit-queue 2015-11-11 12:05:48 -0800 Comment on attachment 265304 Proposed patch Rejecting attachment 265304 from commit-queue. akiss@inf.u-szeged.hu does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1141297 5 265304 commit-queue 2015-11-11 17:02:24 -0800 Comment on attachment 265304 Proposed patch Clearing flags on attachment: 265304 Committed r192336: <http://trac.webkit.org/changeset/192336> 1141298 6 commit-queue 2015-11-11 17:02:26 -0800 All reviewed patches have been landed. Closing bug. 265304 2015-11-11 10:32:16 -0800 2015-11-11 17:02:24 -0800 Proposed patch fix-bmalloc-libdl.patch text/plain 1012 akiss ZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL2JtYWxs b2MvQ01ha2VMaXN0cy50eHQKaW5kZXggYjcxMmFlYi4uNTYwNzM3ZSAxMDA2NDQKLS0tIGEvU291 cmNlL2JtYWxsb2MvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL2JtYWxsb2MvQ01ha2VMaXN0 cy50eHQKQEAgLTE2LDYgKzE2LDEwIEBAIHNldChibWFsbG9jX1NPVVJDRVMKICAgICBibWFsbG9j L21ibWFsbG9jLmNwcAogKQogCitzZXQoYm1hbGxvY19MSUJSQVJJRVMKKyAgICAke0NNQUtFX0RM X0xJQlN9CispCisKIFdFQktJVF9JTkNMVURFX0NPTkZJR19GSUxFU19JRl9FWElTVFMoKQogCiBX RUJLSVRfV1JBUF9TT1VSQ0VMSVNUKCR7Ym1hbGxvY19TT1VSQ0VTfSkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZyBiL1NvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwppbmRleCA0 NDUyMDBhLi4wZWRmNjZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKKysr IGIvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMTEtMTEg IEFrb3MgS2lzcyAgPGFraXNzQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBibWFsbG9jOiBB ZGQgbGliZGwgZGVwZW5kZW5jeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUxMTQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTWFrZSBzdXJlIHRoYXQgdGhlIGxpbmtlciBsaW5rcyBsaWJkbCBhbmQgZmlu ZHMgdGhlIHJlZmVyZW5jZXMgdG8KKyAgICAgICAgZGxvcGVuLCBkbHN5bSBhbmQgZGxjbG9zZSBp biBFbnZpcm9ubWVudC5jcHAuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxNS0x MS0wMiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBB ZGQgdHZPUyBhbmQgd2F0Y2hPUyB0byBTVVBQT1JURURfUExBVEZPUk1TCg==