15114 2007-08-29 14:41:07 -0700 Provide compile-time assertions for sizeof(UChar), sizeof(DeprecatedChar), etc. 2009-01-04 10:13:17 -0800 1 1 1 Unclassified WebKit Web Template Framework 523.x (Safari 3) All All RESOLVED FIXED P2 Normal --- 1 ddkilzer darin ggaren oldest_to_newest 1221 0 ddkilzer 2007-08-29 14:41:07 -0700 * SUMMARY The UChar and DeprecatedChar structs have implicit assumptions that they are two bytes on all platforms. It would be nice if there were compile-time assertions that prevented the project from compiling if these assumptions are ever violated. * NOTES A Google search yielded some solutions: Compile Time Assertions in C (CVu 11.3) http://www.jaggersoft.com/pubs/CVu11_3.html Compile-Time Assertions & Debugging http://www.ddj.com/development-tools/184402051 Compile-Time Assertions http://www.ddj.com/architect/184401873 1220 1 ggaren 2007-08-29 15:56:01 -0700 If this is possible, it would be really helpful to check sizeof all JSObject subclasses at compile time. The collector assumes a maximum size, but it's not checked at compile time. 71845 2 darin 2008-02-24 23:03:30 -0800 wtf/Assertions.h has COMPILE_ASSERT, so we just need to use it. 104346 3 26413 darin 2009-01-04 09:47:20 -0800 Created attachment 26413 patch 104348 4 26413 ddkilzer 2009-01-04 09:55:28 -0800 Comment on attachment 26413 patch r=me 104351 5 darin 2009-01-04 10:13:17 -0800 http://trac.webkit.org/changeset/39585 26413 2009-01-04 09:47:20 -0800 2009-01-04 09:55:28 -0800 patch UCharSizePatch.txt text/plain 1173 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM5NTg0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDEtMDQgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEJ1ZyAxNTExNDogUHJvdmlkZSBjb21waWxlLXRpbWUgYXNzZXJ0aW9u cyBmb3Igc2l6ZW9mKFVDaGFyKSwgc2l6ZW9mKERlcHJlY2F0ZWRDaGFyKSwgZXRjLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMTQKKworICAgICAg ICAqIHd0Zi91bmljb2RlL1VuaWNvZGUuaDogQXNzZXJ0IHNpemUgb2YgVUNoYXIuIFRoZXJlIGlz IG5vIERlcHJlY2F0ZWRDaGFyIGFueSBtb3JlLgorCiAyMDA5LTAxLTAzICBTYW0gV2VpbmlnICA8 c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4 OiBKYXZhU2NyaXB0Q29yZS93dGYvdW5pY29kZS9Vbmljb2RlLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2 YVNjcmlwdENvcmUvd3RmL3VuaWNvZGUvVW5pY29kZS5oCShyZXZpc2lvbiAzOTU3NykKKysrIEph dmFTY3JpcHRDb3JlL3d0Zi91bmljb2RlL1VuaWNvZGUuaAkod29ya2luZyBjb3B5KQpAQCAtMjIs NyArMjIsNyBAQAogI2lmbmRlZiBXVEZfVU5JQ09ERV9ICiAjZGVmaW5lIFdURl9VTklDT0RFX0gK IAotI2luY2x1ZGUgPHd0Zi9QbGF0Zm9ybS5oPgorI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+ CiAKICNpZiBVU0UoUVQ0X1VOSUNPREUpCiAjaW5jbHVkZSAicXQ0L1VuaWNvZGVRdDQuaCIKQEAg LTMyLDQgKzMyLDYgQEAKICNlcnJvciAiVW5rbm93biBVbmljb2RlIGltcGxlbWVudGF0aW9uIgog I2VuZGlmCiAKK0NPTVBJTEVfQVNTRVJUKHNpemVvZihVQ2hhcikgPT0gMiwgVUNoYXJJc1R3b0J5 dGVzKTsKKwogI2VuZGlmIC8vIFdURl9VTklDT0RFX0gK