151132 2015-11-11 03:12:38 -0800 [GTK] Runtime critical warnings when closing a page containing windowed plugins 2015-11-11 08:36:34 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply gustavo pnormand zan oldest_to_newest 1141086 0 cgarcia 2015-11-11 03:12:38 -0800 (WebKitPluginProcess:31915): Gtk-CRITICAL **: gtk_widget_destroy: assertion 'GTK_IS_WIDGET (widget)' failed This is because our plugin widget that is a GtkPlug (derived from GtkWindow) can receive the delete-event signal before NetscapePlugin::platformDestroy is called. The delete-event signal, by default, destroys the window when the signal is not handled. So after the delete-event the GtkPlug is destroyed, but our pointer hasn't been reset. We can handle the delete-event using gtk_widget_hide_on_delete as callback, so that the plugin widget is hidden instead of destroyed. 1141087 1 265280 cgarcia 2015-11-11 03:16:20 -0800 Created attachment 265280 Patch 1141114 2 cgarcia 2015-11-11 08:36:34 -0800 Committed r192311: <http://trac.webkit.org/changeset/192311> 265280 2015-11-11 03:16:20 -0800 2015-11-11 05:15:38 -0800 Patch wk2-windowed-plugins-warning.diff text/plain 2405 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxMjZjNDc0Li45NzgyMTRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTUtMTEtMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFJ1bnRpbWUgY3JpdGljYWwgd2FybmluZ3Mgd2hlbiBjbG9zaW5n IGEgcGFnZSBjb250YWluaW5nIHdpbmRvd2VkIHBsdWdpbnMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTEzMgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgYmVjYXVzZSBvdXIgcGx1Z2luIHdp ZGdldCwgdGhhdCBpcyBhIEd0a1BsdWcgKGRlcml2ZWQgZnJvbQorICAgICAgICBHdGtXaW5kb3cp LCBjYW4gcmVjZWl2ZSB0aGUgZGVsZXRlLWV2ZW50IHNpZ25hbCBiZWZvcmUKKyAgICAgICAgTmV0 c2NhcGVQbHVnaW46OnBsYXRmb3JtRGVzdHJveSBpcyBjYWxsZWQuIFRoZSBkZWxldGUtZXZlbnQK KyAgICAgICAgc2lnbmFsLCBieSBkZWZhdWx0LCBkZXN0cm95cyB0aGUgd2luZG93IHdoZW4gdGhl IHNpZ25hbCBpcyBub3QKKyAgICAgICAgaGFuZGxlZC4gU28sIGFmdGVyIHRoZSBkZWxldGUtZXZl bnQgdGhlIEd0a1BsdWcgaXMgZGVzdHJveWVkLCBidXQKKyAgICAgICAgb3VyIHBvaW50ZXIgaGFz bid0IGJlZW4gcmVzZXQuIFdlIGNhbiBoYW5kbGUgdGhlIGRlbGV0ZS1ldmVudAorICAgICAgICB1 c2luZyBndGtfd2lkZ2V0X2hpZGVfb25fZGVsZXRlIGFzIGNhbGxiYWNrLCBzbyB0aGF0IHRoZSBw bHVnaW4KKyAgICAgICAgd2lkZ2V0IGlzIGhpZGRlbiBpbnN0ZWFkIG9mIGRlc3Ryb3llZC4KKwor ICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS94MTEvTmV0c2NhcGVQbHVnaW5Y MTEuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1Qb3N0SW5p dGlhbGl6ZVdpbmRvd2VkKToKKwogMjAxNS0xMS0xMCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJp c3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEltcGxlbWVudCBhdXRoZW50aWNhdGlvbiBj aGFsbGVuZ2UgaGFuZGxpbmcgd2hlbiB1c2luZyBORVRXT1JLX1NFU1NJT04KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS94MTEvTmV0c2NhcGVQ bHVnaW5YMTEuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBl L3gxMS9OZXRzY2FwZVBsdWdpblgxMS5jcHAKaW5kZXggZTg1OGIzZi4uMzgwMjg5NyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL3gxMS9OZXRz Y2FwZVBsdWdpblgxMS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5z L05ldHNjYXBlL3gxMS9OZXRzY2FwZVBsdWdpblgxMS5jcHAKQEAgLTEzNCw2ICsxMzQsMTEgQEAg Ym9vbCBOZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1Qb3N0SW5pdGlhbGl6ZVdpbmRvd2VkKGJvb2wg bmVlZHNYRW1iZWQsIHVpbnQ2NF90IHcKICAgICAvLyBJIGd1ZXNzIGl0IHVzZXMgZ2RrX3dpbmRv d19sb29rdXAoKSwgc28gd2UgY3JlYXRlIGEgbmV3IHNvY2tldCBoZXJlCiAgICAgLy8gY29udGFp bmluZyBhIHBsdWcgd2l0aCB0aGUgVUkgcHJvY2VzcyBzb2NrZXQgZW1iZWRkZWQuCiAgICAgbV9w bGF0Zm9ybVBsdWdpbldpZGdldCA9IGd0a19wbHVnX25ldyhzdGF0aWNfY2FzdDxXaW5kb3c+KHdp bmRvd0lEKSk7CisKKyAgICAvLyBIaWRlIHRoZSBHdGtQbHVnIG9uIGRlbGV0ZS1ldmVudCBzaW5j ZSB3ZSBhc3N1bWUgdGhlIHdpZGdldCBpcyB2YWxpZCB3aGlsZSB0aGUgcGx1Z2luIGlzIGFjdGl2 ZS4KKyAgICAvLyBwbGF0Zm9ybURlc3Ryb3koKSB3aWxsIGJlIGNhbGxlZCBhbnl3YXkgcmlnaHQg YWZ0ZXIgdGhlIGRlbGV0ZS1ldmVudC4KKyAgICBnX3NpZ25hbF9jb25uZWN0KG1fcGxhdGZvcm1Q bHVnaW5XaWRnZXQsICJkZWxldGUtZXZlbnQiLCBHX0NBTExCQUNLKGd0a193aWRnZXRfaGlkZV9v bl9kZWxldGUpLCBudWxscHRyKTsKKwogICAgIEd0a1dpZGdldCogc29ja2V0ID0gZ3RrX3NvY2tl dF9uZXcoKTsKICAgICAvLyBEbyBub3Qgc2hvdyB0aGUgcGx1ZyB3aWRnZXQgdW50aWwgdGhlIHNv Y2tldCBpcyBjb25uZWN0ZWQuCiAgICAgZ19zaWduYWxfY29ubmVjdF9zd2FwcGVkKHNvY2tldCwg InBsdWctYWRkZWQiLCBHX0NBTExCQUNLKGd0a193aWRnZXRfc2hvdyksIG1fcGxhdGZvcm1QbHVn aW5XaWRnZXQpOwo=