151116 2015-11-10 12:21:18 -0800 Web Inspector: Code coverage profiler: incorrect "in-viewport" detection algorithm 2015-11-10 13:40:01 -0800 1 1 1 Unclassified WebKit Web Inspector Safari 9 All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1140897 0 nvasilyev 2015-11-10 12:21:18 -0800 The following "is block in the viewport" code is incorrect: basicBlocks = basicBlocks.filter(function(block) { return (block.startOffset >= startOffset && block.startOffset <= endOffset) || (block.startOffset <= startOffset && block.endOffset >= endOffset); }); https://github.com/WebKit/webkit/blob/f70c51a855acc626ec921f7400a69ede4bffac96/Source/WebInspectorUI/UserInterface/Controllers/BasicBlockAnnotator.js#L68-L71 Let's break it down into smaller pieces: block.startOffset >= startOffset && block.startOffset <= endOffset returns true for the following cases (tilt your head 90 degrees): Viewport: [---] Block: [---] block.startOffset <= startOffset && block.endOffset >= endOffset returns true for the following case: Viewport: [---] Block: [------] The following case isn't covered, e.g. the filter function wrongly returns false: Viewport: [---] Block: [---] 1140898 1 webkit-bug-importer 2015-11-10 12:21:50 -0800 <rdar://problem/23485933> 1140901 2 nvasilyev 2015-11-10 12:31:21 -0800 Let's outline all the possible scenarios. Intersect: A: [---] B: [---] A: [-----] B: [-] A: [-] B: [-----] A: [---] B: [---] Don't intersect: A: [---] B: [---] A: [---] B: [---] The easiest way to check if two ranges intersect is to check if they don't intersect. It is also the fastest way. 1140904 3 265220 nvasilyev 2015-11-10 12:39:26 -0800 Created attachment 265220 Patch 1140909 4 265220 bburg 2015-11-10 12:51:06 -0800 Comment on attachment 265220 Patch r=me 1140924 5 265220 commit-queue 2015-11-10 13:39:58 -0800 Comment on attachment 265220 Patch Clearing flags on attachment: 265220 Committed r192264: <http://trac.webkit.org/changeset/192264> 1140925 6 commit-queue 2015-11-10 13:40:01 -0800 All reviewed patches have been landed. Closing bug. 265220 2015-11-10 12:39:26 -0800 2015-11-10 13:39:58 -0800 Patch patch.txt text/plain 1918 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY2MzU2NDIuLmQ4ODRjOWQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTExLTEwICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvZGUg Y292ZXJhZ2UgcHJvZmlsZXI6IGluY29ycmVjdCAiaW4tdmlld3BvcnQiIGRldGVjdGlvbiBhbGdv cml0aG0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 MTExNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9Db250cm9sbGVycy9CYXNpY0Jsb2NrQW5ub3RhdG9yLmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLkJhc2ljQmxvY2tBbm5vdGF0b3IucHJvdG90eXBlLl9hbm5vdGF0ZUJh c2ljQmxvY2tFeGVjdXRpb25SYW5nZXMpOgorCiAyMDE1LTExLTA5ICBKb3NlcGggUGVjb3Jhcm8g IDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU3VwcG9ydCBH ZXN0dXJlIEV2ZW50cyB0byB6b29tIGluIC8gb3V0IG9mIHRoZSBUaW1lbGluZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQmFzaWNC bG9ja0Fubm90YXRvci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Nv bnRyb2xsZXJzL0Jhc2ljQmxvY2tBbm5vdGF0b3IuanMKaW5kZXggZTM1MzQ1Mi4uMzU5ZGVlMCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxl cnMvQmFzaWNCbG9ja0Fubm90YXRvci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Db250cm9sbGVycy9CYXNpY0Jsb2NrQW5ub3RhdG9yLmpzCkBAIC02Nyw3ICs2 NywxNyBAQCBXZWJJbnNwZWN0b3IuQmFzaWNCbG9ja0Fubm90YXRvciA9IGNsYXNzIEJhc2ljQmxv Y2tBbm5vdGF0b3IgZXh0ZW5kcyBXZWJJbnNwZWN0bwogCiAgICAgICAgICAgICB2YXIge3N0YXJ0 T2Zmc2V0LCBlbmRPZmZzZXR9ID0gdGhpcy5zb3VyY2VDb2RlVGV4dEVkaXRvci52aXNpYmxlUmFu Z2VPZmZzZXRzKCk7CiAgICAgICAgICAgICBiYXNpY0Jsb2NrcyA9IGJhc2ljQmxvY2tzLmZpbHRl cihmdW5jdGlvbihibG9jaykgewotICAgICAgICAgICAgICAgIHJldHVybiAoYmxvY2suc3RhcnRP ZmZzZXQgPj0gc3RhcnRPZmZzZXQgJiYgYmxvY2suc3RhcnRPZmZzZXQgPD0gZW5kT2Zmc2V0KSB8 fCAoYmxvY2suc3RhcnRPZmZzZXQgPD0gc3RhcnRPZmZzZXQgJiYgYmxvY2suZW5kT2Zmc2V0ID49 IGVuZE9mZnNldCk7CisgICAgICAgICAgICAgICAgLy8gVmlld3BvcnQ6IFstLV0KKyAgICAgICAg ICAgICAgICAvLyBCbG9jazogICAgICAgICBbLS1dCisgICAgICAgICAgICAgICAgaWYgKGJsb2Nr LnN0YXJ0T2Zmc2V0ID4gZW5kT2Zmc2V0KQorICAgICAgICAgICAgICAgICAgICByZXR1cm4gZmFs c2U7CisKKyAgICAgICAgICAgICAgICAvLyBWaWV3cG9ydDogICAgICBbLS1dCisgICAgICAgICAg ICAgICAgLy8gQmxvY2s6ICAgIFstLV0KKyAgICAgICAgICAgICAgICBpZiAoYmxvY2suZW5kT2Zm c2V0IDwgc3RhcnRPZmZzZXQpCisgICAgICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKwor ICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICAgICAgfSk7CiAKICAgICAgICAg ICAgIGZvciAodmFyIGJsb2NrIG9mIGJhc2ljQmxvY2tzKSB7Cg==