15108 2007-08-29 05:29:10 -0700 Wheel scrolling scrolls by too far in the GTK port 2007-10-20 16:05:18 -0700 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) PC Linux RESOLVED FIXED P2 Normal --- 0 gwright webkit-unassigned slomo xan.lopez oldest_to_newest 1262 0 gwright 2007-08-29 05:29:10 -0700 When scrolling with a mouse wheel the page scrolls by 4800 pixels which scrolls to either the very top of the page or the very bottom in most cases. This step needs to be smaller. 1263 1 gwright 2007-08-29 05:32:59 -0700 A look at WheelEventGdk.cpp and comparing it with WheelEventQt.cpp shows that deltaX and deltaY for the PlatformWheelEvent are being hard coded to 120 in the GTK port and are being set to some multiple or fraction of 15 degrees in the Qt port (Qt reports the wheel scroll event as the number of degrees the mouse wheel has rotated through, in eighths of a degree, and WheelEventQt.cpp divides this value by 120 - http://doc.trolltech.com/4.3/qwheelevent.html#delta). When calling scrollBy(), this delta is multiplied by LINE_STEP which is hardcoded at 40 to give 4800 in the case of GTK. Therefore I propose we hardcode deltaX/deltaY to something more sane in GTK like 0.25 instead of 120. 58931 2 16746 m 2007-10-20 14:44:34 -0700 Created attachment 16746 Change scroll delta from 120 to 0.25 I've also moved the delta into a static const float at the start of the function. 58940 3 16746 mjs 2007-10-20 15:59:58 -0700 Comment on attachment 16746 Change scroll delta from 120 to 0.25 r=me 58943 4 mrowe 2007-10-20 16:05:18 -0700 Landed in r26835. 16746 2007-10-20 14:44:34 -0700 2007-10-20 15:59:58 -0700 Change scroll delta from 120 to 0.25 gtk-scroll-delta.patch text/plain 1702 m SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNjgzMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDctMTAtMjAgIEphc3BlciBCcnlhbnQtR3JlZW5lICA8bUBuaS5h Yy5uej4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD aGFuZ2VkIHRoZSBoYXJkLWNvZGVkIHNjcm9sbCBkZWx0YSBpbiBXaGVlbEV2ZW50R3RrIGZyb20g MTIwIHRvIDAuMjUsCisgICAgICAgIGFzIHN1Z2dlc3RlZCBieSBHZW9yZ2UgV3JpZ2h0IGluICMx NTEwOCAod2hpY2ggdGhpcyBwYXRjaCB3aWxsCisgICAgICAgIHJlc29sdmUpLgorCisgICAgICAg IFRoaXMgZ2l2ZXMgYSBtb3JlIHNhbmUgc2Nyb2xsaW5nIGJlaGF2aW91ciwgcmF0aGVyIHRoYW4g dGhlCisgICAgICAgIGp1bXBpbmcgdG8gdGhlIGVuZCBvciBzdGFydCBvZiB0aGUgZG9jdW1lbnQg YXMgb2NjdXJyZWQgcHJldmlvdXNseS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9XaGVlbEV2 ZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtV2hlZWxFdmVudDo6UGxhdGZv cm1XaGVlbEV2ZW50KToKKwogMjAwNy0xMC0yMCAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRpbSBIYXRjaGVyLgpJbmRleDogV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvV2hlZWxFdmVudEd0ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9y bS9ndGsvV2hlZWxFdmVudEd0ay5jcHAJKHJldmlzaW9uIDI2ODI5KQorKysgV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvV2hlZWxFdmVudEd0ay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM0LDE3ICszNCwx OSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFBsYXRmb3JtV2hlZWxFdmVudDo6UGxhdGZvcm1X aGVlbEV2ZW50KEdka0V2ZW50U2Nyb2xsKiBldmVudCkKIHsKKyAgICBzdGF0aWMgY29uc3QgZmxv YXQgZGVsdGEgPSAwLjI1OworCiAgICAgbV9kZWx0YVggPSAwOwogICAgIG1fZGVsdGFZID0gMDsK IAogICAgIGlmIChldmVudC0+ZGlyZWN0aW9uID09IEdES19TQ1JPTExfVVApCi0gICAgICAgIG1f ZGVsdGFZID0gLTEyMDsKKyAgICAgICAgbV9kZWx0YVkgPSAtZGVsdGE7CiAgICAgZWxzZSBpZiAo ZXZlbnQtPmRpcmVjdGlvbiA9PSBHREtfU0NST0xMX0xFRlQpCi0gICAgICAgIG1fZGVsdGFYID0g LTEyMDsKKyAgICAgICAgbV9kZWx0YVggPSAtZGVsdGE7CiAgICAgZWxzZSBpZiAoZXZlbnQtPmRp cmVjdGlvbiA9PSBHREtfU0NST0xMX1JJR0hUKQotICAgICAgICBtX2RlbHRhWCA9IDEyMDsKKyAg ICAgICAgbV9kZWx0YVggPSBkZWx0YTsKICAgICBlbHNlCi0gICAgICAgIG1fZGVsdGFZID0gMTIw OworICAgICAgICBtX2RlbHRhWSA9IGRlbHRhOwogCiAgICAgbV9wb3NpdGlvbiA9IEludFBvaW50 KChpbnQpZXZlbnQtPngsIChpbnQpZXZlbnQtPnkpOwogICAgIG1fZ2xvYmFsUG9zaXRpb24gPSBJ bnRQb2ludCgoaW50KWV2ZW50LT54X3Jvb3QsIChpbnQpZXZlbnQtPnlfcm9vdCk7Cg==