151060 2015-11-09 16:33:45 -0800 [EFL] Support an applicationVersion argument to UserAgentEfl::standardUserAgent() 2015-11-10 19:41:16 -0800 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue lucas.de.marchi oldest_to_newest 1140591 0 gyuyoung.kim 2015-11-09 16:33:45 -0800 *applicationVersion* was missed to support by r192148. This patch adds it as well as missed Darin comments are fixed. 1140594 1 265116 gyuyoung.kim 2015-11-09 16:37:20 -0800 Created attachment 265116 Patch 1140837 2 265116 darin 2015-11-10 10:44:15 -0800 Comment on attachment 265116 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265116&action=review > Source/WebCore/platform/efl/UserAgentEfl.cpp:70 > + String finalApplicationVersion = applicationVersion; Should do early return if the application name is empty rather than computing an unused string. Probably easier to read than the ?: ternary. 1141015 3 265116 gyuyoung.kim 2015-11-10 17:40:11 -0800 Comment on attachment 265116 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265116&action=review >> Source/WebCore/platform/efl/UserAgentEfl.cpp:70 >> + String finalApplicationVersion = applicationVersion; > > Should do early return if the application name is empty rather than computing an unused string. Probably easier to read than the ?: ternary. Yes, right. It is more readable ! 1141025 4 265258 gyuyoung.kim 2015-11-10 18:34:02 -0800 Created attachment 265258 Patch 1141034 5 265258 commit-queue 2015-11-10 19:41:13 -0800 Comment on attachment 265258 Patch Clearing flags on attachment: 265258 Committed r192288: <http://trac.webkit.org/changeset/192288> 1141035 6 commit-queue 2015-11-10 19:41:16 -0800 All reviewed patches have been landed. Closing bug. 265116 2015-11-09 16:37:20 -0800 2015-11-10 18:33:55 -0800 Patch patch.txt text/plain 2557 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMjYyZGQxLi5mY2U5NjBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTUtMTEtMDkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUB3ZWJraXQub3JnPgor CisgICAgICAgIFtFRkxdIFN1cHBvcnQgYW4gYXBwbGljYXRpb25WZXJzaW9uIGFyZ3VtZW50IHRv IFVzZXJBZ2VudEVmbDo6c3RhbmRhcmRVc2VyQWdlbnQoKSAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTA2MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICphcHBsaWNhdGlvblZlcnNpb24qIHdhcyBtaXNz ZWQgdG8gc3VwcG9ydCBieSByMTkyMTQ4LiBUaGlzIHBhdGNoIGFkZHMgaXQgYXMgd2VsbCBhcwor ICAgICAgICBtaXNzZWQgRGFyaW4gY29tbWVudHMgYXJlIGZpeGVkLgorCisgICAgICAgICogcGxh dGZvcm0vZWZsL1VzZXJBZ2VudEVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpwbGF0Zm9ybVZl cnNpb25Gb3JVQVN0cmluZyk6CisgICAgICAgIChXZWJDb3JlOjp2ZXJzaW9uRm9yVUFTdHJpbmcp OgorICAgICAgICAoV2ViQ29yZTo6c3RhbmRhcmRVc2VyQWdlbnQpOgorCiAyMDE1LTExLTAyICBT ZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtjc3Mt Z3JpZF0gSW1wcm92ZSBncmlkIGNvbnRhaW5lciBzaXppbmcgd2l0aCBzaXplIGNvbnN0cmFpbnRz IGFuZCBpbnRyaW5zaWMgc2l6ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2VmbC9Vc2VyQWdlbnRFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1VzZXJB Z2VudEVmbC5jcHAKaW5kZXggMTFmZDM4Zi4uODAxNTk0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZWZsL1VzZXJBZ2VudEVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZWZsL1VzZXJBZ2VudEVmbC5jcHAKQEAgLTUxLDIzICs1MSwyNyBAQCBzdGF0aWMg U3RyaW5nIHBsYXRmb3JtVmVyc2lvbkZvclVBU3RyaW5nKCkKICAgICBpZiAodW5hbWUoJm5hbWUp ICE9IC0xKQogICAgICAgICB2ZXJzaW9uID0gbWFrZVN0cmluZyhuYW1lLnN5c25hbWUsICcgJywg bmFtZS5tYWNoaW5lKTsKICAgICBlbHNlCi0gICAgICAgIHZlcnNpb24gPSAiVW5rbm93biI7Cisg ICAgICAgIHZlcnNpb24gPSBBU0NJSUxpdGVyYWwoIlVua25vd24iKTsKICAgICByZXR1cm4gdmVy c2lvbjsKIH0KIAotc3RhdGljIGNvbnN0IFN0cmluZyB2ZXJzaW9uRm9yVUFTdHJpbmcoKQorc3Rh dGljIGNvbnN0IFN0cmluZyYgdmVyc2lvbkZvclVBU3RyaW5nKCkKIHsKICAgICBzdGF0aWMgTmV2 ZXJEZXN0cm95ZWQ8U3RyaW5nPiB2ZXJzaW9uKFN0cmluZzo6Zm9ybWF0KCIlaS4laSIsIFdFQktJ VF9NQUpPUl9WRVJTSU9OLCBXRUJLSVRfTUlOT1JfVkVSU0lPTikpOwogICAgIHJldHVybiB2ZXJz aW9uOwogfQogCi1TdHJpbmcgc3RhbmRhcmRVc2VyQWdlbnQoY29uc3QgU3RyaW5nJiBhcHBsaWNh dGlvbk5hbWUsIGNvbnN0IFN0cmluZyYpCitTdHJpbmcgc3RhbmRhcmRVc2VyQWdlbnQoY29uc3Qg U3RyaW5nJiBhcHBsaWNhdGlvbk5hbWUsIGNvbnN0IFN0cmluZyYgYXBwbGljYXRpb25WZXJzaW9u KQogewotICAgIFN0cmluZyB2ZXJzaW9uID0gdmVyc2lvbkZvclVBU3RyaW5nKCk7CisgICAgY29u c3QgU3RyaW5nJiB2ZXJzaW9uID0gdmVyc2lvbkZvclVBU3RyaW5nKCk7CiAgICAgc3RhdGljIE5l dmVyRGVzdHJveWVkPFN0cmluZz4gc3RhbmRhcmRVc2VyQWdlbnRTdHJpbmcgPSBtYWtlU3RyaW5n KCJNb3ppbGxhLzUuMCAoIiwgcGxhdGZvcm1Gb3JVQVN0cmluZygpLCAiOyAiLCBwbGF0Zm9ybVZl cnNpb25Gb3JVQVN0cmluZygpLAogICAgICAgICAiKSBBcHBsZVdlYktpdC8iLCB2ZXJzaW9uLCAi IChLSFRNTCwgbGlrZSBHZWNrbykgVmVyc2lvbi84LjAgU2FmYXJpLzYwMS4yLjciKTsKIAotICAg IHJldHVybiBhcHBsaWNhdGlvbk5hbWUuaXNFbXB0eSgpID8gc3RhbmRhcmRVc2VyQWdlbnRTdHJp bmcgOiBzdGFuZGFyZFVzZXJBZ2VudFN0cmluZyArICcgJyArIGFwcGxpY2F0aW9uTmFtZTsKKyAg ICBTdHJpbmcgZmluYWxBcHBsaWNhdGlvblZlcnNpb24gPSBhcHBsaWNhdGlvblZlcnNpb247Cisg ICAgaWYgKGZpbmFsQXBwbGljYXRpb25WZXJzaW9uLmlzRW1wdHkoKSkKKyAgICAgICAgZmluYWxB cHBsaWNhdGlvblZlcnNpb24gPSB2ZXJzaW9uRm9yVUFTdHJpbmcoKTsKKworICAgIHJldHVybiBh cHBsaWNhdGlvbk5hbWUuaXNFbXB0eSgpID8gc3RhbmRhcmRVc2VyQWdlbnRTdHJpbmcgOiBzdGFu ZGFyZFVzZXJBZ2VudFN0cmluZyArICcgJyArIGFwcGxpY2F0aW9uTmFtZSArICcvJyArIGZpbmFs QXBwbGljYXRpb25WZXJzaW9uOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg== 265258 2015-11-10 18:34:02 -0800 2015-11-10 19:41:13 -0800 Patch bug-151060-20151111113356.patch text/plain 2712 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjNiNWQ5YzEwZTVkNWM2 Y2M4ZGM0NDlhOWQwOGUyN2JmZWYwN2I3OS4uYmQwODAyNDI4MGJmZmNiMzM0MDI5NmRiMTQ2MTVl ODljMDIzN2I5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTExLTEwICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBbRUZMXSBTdXBw b3J0IGFuIGFwcGxpY2F0aW9uVmVyc2lvbiBhcmd1bWVudCB0byBVc2VyQWdlbnRFZmw6OnN0YW5k YXJkVXNlckFnZW50KCkgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTEwNjAKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAg ICAgICAqYXBwbGljYXRpb25WZXJzaW9uKiB3YXMgbWlzc2VkIHRvIHN1cHBvcnQgYnkgcjE5MjE0 OC4gVGhpcyBwYXRjaCBhZGRzIGl0IGFzIHdlbGwgYXMKKyAgICAgICAgbWlzc2VkIERhcmluIGNv bW1lbnRzIGFyZSBmaXhlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9Vc2VyQWdlbnRFZmwu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6cGxhdGZvcm1WZXJzaW9uRm9yVUFTdHJpbmcpOgorICAg ICAgICAoV2ViQ29yZTo6dmVyc2lvbkZvclVBU3RyaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OnN0 YW5kYXJkVXNlckFnZW50KToKKwogMjAxNS0xMS0xMCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJh c2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgZGlmZmVyZW50IHBpeGVsIGZvcm1hdHMgZm9y IGRpc3BsYXlzIHRoYXQgc3VwcG9ydCB0aGVtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Vm bC9Vc2VyQWdlbnRFZmwuY3BwCmluZGV4IDExZmQzOGZhYTYzOGM5ZTg5YjYwYTM5MGQxYWEzNTdh YWNmMDVjYzIuLjgyNTFiOTgwYzNhYThlNWVmMzMyMWQwMTBhZGQ5NTI2NWU3OTlkNDQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Vc2VyQWdlbnRFZmwuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Vc2VyQWdlbnRFZmwuY3BwCkBAIC01MSwyMyAr NTEsMzAgQEAgc3RhdGljIFN0cmluZyBwbGF0Zm9ybVZlcnNpb25Gb3JVQVN0cmluZygpCiAgICAg aWYgKHVuYW1lKCZuYW1lKSAhPSAtMSkKICAgICAgICAgdmVyc2lvbiA9IG1ha2VTdHJpbmcobmFt ZS5zeXNuYW1lLCAnICcsIG5hbWUubWFjaGluZSk7CiAgICAgZWxzZQotICAgICAgICB2ZXJzaW9u ID0gIlVua25vd24iOworICAgICAgICB2ZXJzaW9uID0gQVNDSUlMaXRlcmFsKCJVbmtub3duIik7 CiAgICAgcmV0dXJuIHZlcnNpb247CiB9CiAKLXN0YXRpYyBjb25zdCBTdHJpbmcgdmVyc2lvbkZv clVBU3RyaW5nKCkKK3N0YXRpYyBjb25zdCBTdHJpbmcmIHZlcnNpb25Gb3JVQVN0cmluZygpCiB7 CiAgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPFN0cmluZz4gdmVyc2lvbihTdHJpbmc6OmZvcm1h dCgiJWkuJWkiLCBXRUJLSVRfTUFKT1JfVkVSU0lPTiwgV0VCS0lUX01JTk9SX1ZFUlNJT04pKTsK ICAgICByZXR1cm4gdmVyc2lvbjsKIH0KIAotU3RyaW5nIHN0YW5kYXJkVXNlckFnZW50KGNvbnN0 IFN0cmluZyYgYXBwbGljYXRpb25OYW1lLCBjb25zdCBTdHJpbmcmKQorU3RyaW5nIHN0YW5kYXJk VXNlckFnZW50KGNvbnN0IFN0cmluZyYgYXBwbGljYXRpb25OYW1lLCBjb25zdCBTdHJpbmcmIGFw cGxpY2F0aW9uVmVyc2lvbikKIHsKLSAgICBTdHJpbmcgdmVyc2lvbiA9IHZlcnNpb25Gb3JVQVN0 cmluZygpOworICAgIGNvbnN0IFN0cmluZyYgdmVyc2lvbiA9IHZlcnNpb25Gb3JVQVN0cmluZygp OwogICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxTdHJpbmc+IHN0YW5kYXJkVXNlckFnZW50U3Ry aW5nID0gbWFrZVN0cmluZygiTW96aWxsYS81LjAgKCIsIHBsYXRmb3JtRm9yVUFTdHJpbmcoKSwg IjsgIiwgcGxhdGZvcm1WZXJzaW9uRm9yVUFTdHJpbmcoKSwKICAgICAgICAgIikgQXBwbGVXZWJL aXQvIiwgdmVyc2lvbiwgIiAoS0hUTUwsIGxpa2UgR2Vja28pIFZlcnNpb24vOC4wIFNhZmFyaS82 MDEuMi43Iik7CiAKLSAgICByZXR1cm4gYXBwbGljYXRpb25OYW1lLmlzRW1wdHkoKSA/IHN0YW5k YXJkVXNlckFnZW50U3RyaW5nIDogc3RhbmRhcmRVc2VyQWdlbnRTdHJpbmcgKyAnICcgKyBhcHBs aWNhdGlvbk5hbWU7CisgICAgaWYgKGFwcGxpY2F0aW9uTmFtZS5pc0VtcHR5KCkpCisgICAgICAg IHJldHVybiBzdGFuZGFyZFVzZXJBZ2VudFN0cmluZzsKKworICAgIFN0cmluZyBmaW5hbEFwcGxp Y2F0aW9uVmVyc2lvbiA9IGFwcGxpY2F0aW9uVmVyc2lvbjsKKyAgICBpZiAoZmluYWxBcHBsaWNh dGlvblZlcnNpb24uaXNFbXB0eSgpKQorICAgICAgICBmaW5hbEFwcGxpY2F0aW9uVmVyc2lvbiA9 IHZlcnNpb25Gb3JVQVN0cmluZygpOworCisgICAgcmV0dXJuIHN0YW5kYXJkVXNlckFnZW50U3Ry aW5nICsgJyAnICsgYXBwbGljYXRpb25OYW1lICsgJy8nICsgZmluYWxBcHBsaWNhdGlvblZlcnNp b247CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK