151050 2015-11-09 13:01:28 -0800 Web Inspector: REGRESSION: 2nd level inspector should not be able to dock to first 2015-11-12 14:32:19 -0800 1 1 1 Unclassified WebKit Web Inspector Other All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev thorton timothy webkit-bug-importer oldest_to_newest 1140479 0 joepeck 2015-11-09 13:01:28 -0800 * SUMMARY REGRESSION: 2nd level inspector should not be able to dock to first. * STEPS TO REPRODUCE 1. Inspect about:blank 2. Inspect Inspector => inspector² has dock toolbar icons to dock to inspector¹, it should NOT 1140481 1 webkit-bug-importer 2015-11-09 13:02:11 -0800 <rdar://problem/23468180> 1140482 2 265086 joepeck 2015-11-09 13:02:40 -0800 Created attachment 265086 [PATCH] Proposed Fix 1140486 3 265086 bburg 2015-11-09 13:05:32 -0800 Comment on attachment 265086 [PATCH] Proposed Fix Oooh, neat. r=me 1140525 4 265086 commit-queue 2015-11-09 14:07:17 -0800 Comment on attachment 265086 [PATCH] Proposed Fix Clearing flags on attachment: 265086 Committed r192178: <http://trac.webkit.org/changeset/192178> 1140526 5 commit-queue 2015-11-09 14:07:22 -0800 All reviewed patches have been landed. Closing bug. 1141641 6 nvasilyev 2015-11-12 14:32:19 -0800 I liked when inspector² was dockable :( 265086 2015-11-09 13:02:40 -0800 2015-11-09 14:07:17 -0800 [PATCH] Proposed Fix double-dock.patch text/plain 1398 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1M2E5MzhhLi4zZDEyYzY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTUtMTEtMDkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBSRUdSRVNTSU9OOiAybmQgbGV2ZWwgaW5zcGVjdG9yIHNo b3VsZCBub3QgYmUgYWJsZSB0byBkb2NrIHRvIGZpcnN0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTEwNTAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJv eHlNYWMubW06CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybUNh bkF0dGFjaCk6CisgICAgICAgIENoZWNrIG5vdyB0aGF0IHRoZSBpbnNwZWN0ZWQgdmlldyBjYW4g YmUgYSBXS1dlYlZpZXcuCisKIDIwMTUtMTEtMDMgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUu Y29tPgogCiAgICAgICAgIFtDb2NvYV0gQWRkIFNQSSB0byB3YXJtIGFuIGluaXRpYWwgd2ViIHBy b2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVj dG9yUHJveHlNYWMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkluc3BlY3Rv clByb3h5TWFjLm1tCmluZGV4IDhiOThlNjQuLmIxYmU1ZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbQpAQCAtNDY4LDcg KzQ2OCw3IEBAIGJvb2wgV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtQ2FuQXR0YWNoKGJvb2wg d2ViUHJvY2Vzc0NhbkF0dGFjaCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgTlNWaWV3 ICppbnNwZWN0ZWRWaWV3ID0gaW5zcGVjdGVkUGFnZSgpLT5pbnNwZWN0b3JBdHRhY2htZW50Vmll dygpOwotICAgIGlmIChbaW5zcGVjdGVkVmlldyBpc0tpbmRPZkNsYXNzOltXS1ZpZXcgY2xhc3Nd XSkKKyAgICBpZiAoW2luc3BlY3RlZFZpZXcgaXNLaW5kT2ZDbGFzczpbV0tWaWV3IGNsYXNzXV0g fHwgW2luc3BlY3RlZFZpZXcgaXNLaW5kT2ZDbGFzczpbV0tXZWJWaWV3IGNsYXNzXV0pCiAgICAg ICAgIHJldHVybiB3ZWJQcm9jZXNzQ2FuQXR0YWNoOwogCiAgICAgc3RhdGljIGNvbnN0IGZsb2F0 IG1pbmltdW1BdHRhY2hlZEhlaWdodCA9IDI1MDsK