151047 2015-11-09 12:32:08 -0800 run-jsc-benchmarks doesn't work with internal benchmarks 2015-12-03 03:13:46 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 151784 1 ggaren ggaren clopez fpizlo ossy oldest_to_newest 1140468 0 ggaren 2015-11-09 12:32:08 -0800 run-jsc-benchmarks doesn't work with internal benchmarks 1140469 1 265080 ggaren 2015-11-09 12:32:59 -0800 Created attachment 265080 Patch 1140947 2 265080 ggaren 2015-11-10 14:22:07 -0800 Comment on attachment 265080 Patch Clearing flags on attachment: 265080 Committed r192271: <http://trac.webkit.org/changeset/192271> 1140948 3 ggaren 2015-11-10 14:22:11 -0800 All reviewed patches have been landed. Closing bug. 1142448 4 clopez 2015-11-16 19:21:44 -0800 This broke the script for me: FAILED: #<TypeError: no implicit conversion of nil into String> Stack trace: Tools/Scripts/run-jsc-benchmarks:2823:in `initialize' Tools/Scripts/run-jsc-benchmarks:2823:in `new' Tools/Scripts/run-jsc-benchmarks:2823:in `<main>' Use the --help option to get basic usage information. 1145910 5 ossy 2015-12-03 03:13:24 -0800 (In reply to comment #4) > This broke the script for me: > > FAILED: #<TypeError: no implicit conversion of nil into String> > Stack trace: > Tools/Scripts/run-jsc-benchmarks:2823:in `initialize' > Tools/Scripts/run-jsc-benchmarks:2823:in `new' > Tools/Scripts/run-jsc-benchmarks:2823:in `<main>' > Use the --help option to get basic usage information. already fixed in bug151047 1145911 6 ossy 2015-12-03 03:13:46 -0800 I meant bug151784. 265080 2015-11-09 12:32:59 -0800 2015-11-10 14:22:07 -0800 Patch bug-151047-20151109123256.patch text/plain 2869 ggaren SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5MjE3MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTExLTA5ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+ CisKKyAgICAgICAgcnVuLWpzYy1iZW5jaG1hcmtzIGRvZXNuJ3Qgd29yayB3aXRoIGludGVybmFs IGJlbmNobWFya3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1MTA0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy9ydW4tanNjLWJlbmNobWFya3M6IFVzZSBQYXRobmFtZSBzbyB3ZSBnZXQg YSAiLyIgaW5zZXJ0ZWQgd2hlbgorICAgICAgICB3ZSBjb25jYXRlbmF0ZS4KKwogMjAxNS0xMS0w OSAgSXNhYWMgRGV2aW5lICA8aXNhYWNAZGV2aW5lc3lzdGVtcy5jby5uej4KIAogICAgICAgICBG cmVzaCBjaGVja291dCBmYWlscyB0byBidWlsZCBvbiB3aW5kb3dzLCBEdW1wUmVuZGVyVHJlZSBj YW4ndCBmaW5kIGNhaXJvX3dpbi5oCkluZGV4OiBUb29scy9TY3JpcHRzL3J1bi1qc2MtYmVuY2ht YXJrcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3J1bi1qc2MtYmVuY2htYXJrcwkocmV2 aXNpb24gMTkyMTQ3KQorKysgVG9vbHMvU2NyaXB0cy9ydW4tanNjLWJlbmNobWFya3MJKHdvcmtp bmcgY29weSkKQEAgLTI4MTksMjIgKzI4MTksMjIgQEAgYmVnaW4KICAgZWxzZQogICAgIGNvbmZp ZyA9IHt9CiAgIGVuZAotICBPQ1RBTkVfUEFUSCA9IGNvbmZpZ1siT2N0YW5lUGF0aCJdCi0gIEJS T1dTRVJNQVJLX1BBVEggPSBjb25maWdbIkJyb3dzZXJNYXJrUGF0aCJdCi0gIEJST1dTRVJNQVJL X0pTX1BBVEggPSBjb25maWdbIkJyb3dzZXJNYXJrSlNQYXRoIl0KLSAgQlJPV1NFUk1BUktfRE9N X1BBVEggPSBjb25maWdbIkJyb3dzZXJNYXJrRE9NUGF0aCJdCi0gIEFTTUJFTkNIX1BBVEggPSBj b25maWdbIkFzbUJlbmNoUGF0aCJdCi0gIENPTVBSRVNTSU9OQkVOQ0hfUEFUSCA9IGNvbmZpZ1si Q29tcHJlc3Npb25CZW5jaFBhdGgiXQotICBEU1BKU19GSUxUUlJfUEFUSCA9IGNvbmZpZ1siRFNQ SlNGaWx0cnJQYXRoIl0KLSAgRFNQSlNfUk9VVEU5X1BBVEggPSBjb25maWdbIkRTUEpTUm91dGU5 UGF0aCJdCi0gIERTUEpTX1NUQVJGSUVMRF9QQVRIID0gY29uZmlnWyJEU1BKU1N0YXJmaWVsZFBh dGgiXQotICBEU1BKU19RVUFLRTNfUEFUSCA9IGNvbmZpZ1siRFNQSlNRdWFrZTNQYXRoIl0KLSAg RFNQSlNfTUFOREVMQlJPVF9QQVRIID0gY29uZmlnWyJEU1BKU01hbmRlbGJyb3RQYXRoIl0KLSAg RFNQSlNfSlNMSU5VWF9QQVRIID0gY29uZmlnWyJEU1BKU0xpbnV4UGF0aCJdCi0gIERTUEpTX0FN TU9KU19BU01KU19QQVRIID0gY29uZmlnWyJEU1BKU0FtbW9KU0FzbUpTUGF0aCJdCi0gIERTUEpT X0FNTU9KU19SRUdVTEFSX1BBVEggPSBjb25maWdbIkRTUEpTQW1tb0pTUmVndWxhclBhdGgiXQot ICBKU0JFTkNIX1BBVEggPSBjb25maWdbIkpTQmVuY2hQYXRoIl0KLSAgS1JBS0VOX1BBVEggPSBj b25maWdbIktyYWtlblBhdGgiXQorICBPQ1RBTkVfUEFUSCA9IFBhdGhuYW1lLm5ldyhjb25maWdb Ik9jdGFuZVBhdGgiXSkKKyAgQlJPV1NFUk1BUktfUEFUSCA9IFBhdGhuYW1lLm5ldyhjb25maWdb IkJyb3dzZXJNYXJrUGF0aCJdKQorICBCUk9XU0VSTUFSS19KU19QQVRIID0gUGF0aG5hbWUubmV3 KGNvbmZpZ1siQnJvd3Nlck1hcmtKU1BhdGgiXSkKKyAgQlJPV1NFUk1BUktfRE9NX1BBVEggPSBQ YXRobmFtZS5uZXcoY29uZmlnWyJCcm93c2VyTWFya0RPTVBhdGgiXSkKKyAgQVNNQkVOQ0hfUEFU SCA9IFBhdGhuYW1lLm5ldyhjb25maWdbIkFzbUJlbmNoUGF0aCJdKQorICBDT01QUkVTU0lPTkJF TkNIX1BBVEggPSBQYXRobmFtZS5uZXcoY29uZmlnWyJDb21wcmVzc2lvbkJlbmNoUGF0aCJdKQor ICBEU1BKU19GSUxUUlJfUEFUSCA9IFBhdGhuYW1lLm5ldyhjb25maWdbIkRTUEpTRmlsdHJyUGF0 aCJdKQorICBEU1BKU19ST1VURTlfUEFUSCA9IFBhdGhuYW1lLm5ldyhjb25maWdbIkRTUEpTUm91 dGU5UGF0aCJdKQorICBEU1BKU19TVEFSRklFTERfUEFUSCA9IFBhdGhuYW1lLm5ldyhjb25maWdb IkRTUEpTU3RhcmZpZWxkUGF0aCJdKQorICBEU1BKU19RVUFLRTNfUEFUSCA9IFBhdGhuYW1lLm5l dyhjb25maWdbIkRTUEpTUXVha2UzUGF0aCJdKQorICBEU1BKU19NQU5ERUxCUk9UX1BBVEggPSBQ YXRobmFtZS5uZXcoY29uZmlnWyJEU1BKU01hbmRlbGJyb3RQYXRoIl0pCisgIERTUEpTX0pTTElO VVhfUEFUSCA9IFBhdGhuYW1lLm5ldyhjb25maWdbIkRTUEpTTGludXhQYXRoIl0pCisgIERTUEpT X0FNTU9KU19BU01KU19QQVRIID0gUGF0aG5hbWUubmV3KGNvbmZpZ1siRFNQSlNBbW1vSlNBc21K U1BhdGgiXSkKKyAgRFNQSlNfQU1NT0pTX1JFR1VMQVJfUEFUSCA9IFBhdGhuYW1lLm5ldyhjb25m aWdbIkRTUEpTQW1tb0pTUmVndWxhclBhdGgiXSkKKyAgSlNCRU5DSF9QQVRIID0gUGF0aG5hbWUu bmV3KGNvbmZpZ1siSlNCZW5jaFBhdGgiXSkKKyAgS1JBS0VOX1BBVEggPSBQYXRobmFtZS5uZXco Y29uZmlnWyJLcmFrZW5QYXRoIl0pCiAgIAogICAjIElmIHRoZSAtLWRvbnQtY29weS12bXMgb3B0 aW9uIHdhcyBwYXNzZWQsIGl0IG92ZXJyaWRlcyB0aGUgLS1mb3JjZS12bS1jb3B5IG9wdGlvbi4K ICAgaWYgJGRvbnRDb3B5Vk1zCg==