151046 2015-11-09 12:28:55 -0800 Web Inspector: Uncaught exception creating TimelineRecord alternate subtitles 2015-11-16 10:44:18 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1140464 0 joepeck 2015-11-09 12:28:55 -0800 * SUMMARY Uncaught expiation creating TimelineRecord alternate subtitles. * EXCEPTION TimelineRecordTreeElement.js:97:49: CONSOLE ERROR TypeError: null is not an object (evaluating 'subtitle.appendChild') 1140467 1 265079 joepeck 2015-11-09 12:30:40 -0800 Created attachment 265079 [PATCH] Proposed Fix 1140485 2 265079 bburg 2015-11-09 13:04:36 -0800 Comment on attachment 265079 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=265079&action=review r=me > Source/WebInspectorUI/ChangeLog:3 > + Web Inspector: Uncaught expiation creating TimelineRecord alternate subtitles Please amend the bug title in changelog. 1140563 3 265106 joepeck 2015-11-09 15:33:10 -0800 Created attachment 265106 [PATCH] For Landing 1140590 4 265106 commit-queue 2015-11-09 16:30:28 -0800 Comment on attachment 265106 [PATCH] For Landing Clearing flags on attachment: 265106 Committed r192188: <http://trac.webkit.org/changeset/192188> 265079 2015-11-09 12:30:40 -0800 2015-11-09 13:04:36 -0800 [PATCH] Proposed Fix fix-alternate-subtitle.patch text/plain 1925 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDM4NjYxYWYuLjg1OTdlMzMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTExLTA5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgZXhwaWF0aW9uIGNyZWF0aW5nIFRpbWVsaW5lUmVjb3JkIGFsdGVybmF0ZSBzdWJ0aXRsZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTA0Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZFRyZWVFbGVtZW50LmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkVHJlZUVsZW1lbnQpOgorICAgICAgICBXZSBqdXN0IG5l ZWQgdG8gY3JlYXRlIGFuIGVsZW1lbnQsIGl0IGRvZXMgbm90IG5lZWQgdG8gYmUKKyAgICAgICAg YSBjaGlsZCBvZiBzdWJ0aXRsZSwgYXMgaXQgZ2V0cyBhcHBlbmRlZCB0byB0aGUgcmlnaHQKKyAg ICAgICAgcGxhY2UgbGF0ZXIgb24uCisKIDIwMTUtMTEtMDkgIE1hdHQgQmFrZXIgIDxtYXR0YmFr ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbnZlcnQgRGF0YWJhc2VD b250ZW50VmlldyB0byB1c2UgVmlldyBiYXNlIGNsYXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZFRyZWVFbGVtZW50 LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVS ZWNvcmRUcmVlRWxlbWVudC5qcwppbmRleCAxNWI4NGI1Li5hMTg4MGFhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZFRy ZWVFbGVtZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1RpbWVsaW5lUmVjb3JkVHJlZUVsZW1lbnQuanMKQEAgLTk0LDcgKzk0LDcgQEAgV2ViSW5z cGVjdG9yLlRpbWVsaW5lUmVjb3JkVHJlZUVsZW1lbnQgPSBjbGFzcyBUaW1lbGluZVJlY29yZFRy ZWVFbGVtZW50IGV4dGVuZHMKICAgICAgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLlNjcmlwdFRp bWVsaW5lUmVjb3JkLkV2ZW50VHlwZS5UaW1lckluc3RhbGxlZDoKICAgICAgICAgICAgICAgICBp ZiAoaW5jbHVkZURldGFpbHNJbk1haW5UaXRsZSkgewogICAgICAgICAgICAgICAgICAgICBsZXQg dGltZW91dFN0cmluZyA9ICBOdW1iZXIuc2Vjb25kc1RvU3RyaW5nKHRpbWVsaW5lUmVjb3JkLmRl dGFpbHMudGltZW91dCAvIDEwMDApOwotICAgICAgICAgICAgICAgICAgICBhbHRlcm5hdGVTdWJ0 aXRsZSA9IHN1YnRpdGxlLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInNwYW4i KSk7CisgICAgICAgICAgICAgICAgICAgIGFsdGVybmF0ZVN1YnRpdGxlID0gZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgic3BhbiIpOwogICAgICAgICAgICAgICAgICAgICBhbHRlcm5hdGVTdWJ0aXRs ZS5jbGFzc0xpc3QuYWRkKCJhbHRlcm5hdGUtc3VidGl0bGUiKTsKICAgICAgICAgICAgICAgICAg ICAgaWYgKHRpbWVsaW5lUmVjb3JkLmRldGFpbHMucmVwZWF0aW5nKQogICAgICAgICAgICAgICAg ICAgICAgICAgYWx0ZXJuYXRlU3VidGl0bGUudGV4dENvbnRlbnQgPSBXZWJJbnNwZWN0b3IuVUlT dHJpbmcoIiVzIGludGVydmFsIikuZm9ybWF0KHRpbWVvdXRTdHJpbmcpOwo= 265106 2015-11-09 15:33:10 -0800 2015-11-09 16:30:28 -0800 [PATCH] For Landing fix-exception.patch text/plain 1921 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDM4NjYxYWYuLmRlY2E2M2QgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTExLTA5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgZXhjZXB0aW9uIGNyZWF0aW5nIFRpbWVsaW5lUmVjb3JkIGFsdGVybmF0ZSBzdWJ0aXRsZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTA0Ngor CisgICAgICAgIFJldmlld2VkIGJ5IEJyaWFuIEJ1cmcuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkVHJlZUVsZW1lbnQuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuVGltZWxpbmVSZWNvcmRUcmVlRWxlbWVudCk6CisgICAgICAgIFdlIGp1c3QgbmVlZCB0 byBjcmVhdGUgYW4gZWxlbWVudCwgaXQgZG9lcyBub3QgbmVlZCB0byBiZQorICAgICAgICBhIGNo aWxkIG9mIHN1YnRpdGxlLCBhcyBpdCBnZXRzIGFwcGVuZGVkIHRvIHRoZSByaWdodAorICAgICAg ICBwbGFjZSBsYXRlciBvbi4KKwogMjAxNS0xMS0wOSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ29udmVydCBEYXRhYmFzZUNvbnRl bnRWaWV3IHRvIHVzZSBWaWV3IGJhc2UgY2xhc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkVHJlZUVsZW1lbnQuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29y ZFRyZWVFbGVtZW50LmpzCmluZGV4IDE1Yjg0YjUuLmExODgwYWEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkVHJlZUVs ZW1lbnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGltZWxpbmVSZWNvcmRUcmVlRWxlbWVudC5qcwpAQCAtOTQsNyArOTQsNyBAQCBXZWJJbnNwZWN0 b3IuVGltZWxpbmVSZWNvcmRUcmVlRWxlbWVudCA9IGNsYXNzIFRpbWVsaW5lUmVjb3JkVHJlZUVs ZW1lbnQgZXh0ZW5kcwogICAgICAgICAgICAgY2FzZSBXZWJJbnNwZWN0b3IuU2NyaXB0VGltZWxp bmVSZWNvcmQuRXZlbnRUeXBlLlRpbWVySW5zdGFsbGVkOgogICAgICAgICAgICAgICAgIGlmIChp bmNsdWRlRGV0YWlsc0luTWFpblRpdGxlKSB7CiAgICAgICAgICAgICAgICAgICAgIGxldCB0aW1l b3V0U3RyaW5nID0gIE51bWJlci5zZWNvbmRzVG9TdHJpbmcodGltZWxpbmVSZWNvcmQuZGV0YWls cy50aW1lb3V0IC8gMTAwMCk7Ci0gICAgICAgICAgICAgICAgICAgIGFsdGVybmF0ZVN1YnRpdGxl ID0gc3VidGl0bGUuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic3BhbiIpKTsK KyAgICAgICAgICAgICAgICAgICAgYWx0ZXJuYXRlU3VidGl0bGUgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCJzcGFuIik7CiAgICAgICAgICAgICAgICAgICAgIGFsdGVybmF0ZVN1YnRpdGxlLmNs YXNzTGlzdC5hZGQoImFsdGVybmF0ZS1zdWJ0aXRsZSIpOwogICAgICAgICAgICAgICAgICAgICBp ZiAodGltZWxpbmVSZWNvcmQuZGV0YWlscy5yZXBlYXRpbmcpCiAgICAgICAgICAgICAgICAgICAg ICAgICBhbHRlcm5hdGVTdWJ0aXRsZS50ZXh0Q29udGVudCA9IFdlYkluc3BlY3Rvci5VSVN0cmlu ZygiJXMgaW50ZXJ2YWwiKS5mb3JtYXQodGltZW91dFN0cmluZyk7Cg==