151044 2015-11-09 12:00:42 -0800 Implement -[_WKRemoteObjectInterface debugDescription] and have it look like the NSXPCInterface equivalent 2015-11-10 08:44:29 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 1140453 0 andersca 2015-11-09 12:00:42 -0800 Implement -[_WKRemoteObjectInterface debugDescription] and have it look like the NSXPCInterface equivalent 1140455 1 265078 andersca 2015-11-09 12:07:53 -0800 Created attachment 265078 Patch 1140457 2 commit-queue 2015-11-09 12:10:50 -0800 Attachment 265078 did not pass style-queue: ERROR: Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectInterface.mm:186: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectInterface.mm:190: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1140460 3 265078 thorton 2015-11-09 12:11:48 -0800 Comment on attachment 265078 Patch Should we really use NSMutableString instead of StringBuilder or something like that? 1140461 4 andersca 2015-11-09 12:15:20 -0800 (In reply to comment #3) > Comment on attachment 265078 [details] > Patch > > Should we really use NSMutableString instead of StringBuilder or something > like that? Since this is debug-only code it doesn't really matter. 1140462 5 andersca 2015-11-09 12:16:30 -0800 Committed r192171: <http://trac.webkit.org/changeset/192171> 1140776 6 265078 darin 2015-11-10 08:43:50 -0800 Comment on attachment 265078 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265078&action=review > Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectInterface.mm:197 > + return CString(class_getName(a)) < CString(class_getName(b)); Why copy these strings with the CString constructor instead of just using strcmp directly? 1140777 7 265078 darin 2015-11-10 08:44:29 -0800 Comment on attachment 265078 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265078&action=review >> Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectInterface.mm:197 >> + return CString(class_getName(a)) < CString(class_getName(b)); > > Why copy these strings with the CString constructor instead of just using strcmp directly? I guess the answer is “debug-only code and doesn’t matter”, but still! 265078 2015-11-09 12:07:53 -0800 2015-11-09 12:11:48 -0800 Patch bug-151044-20151109120750.patch text/plain 4365 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTNkNDZmM2I4MzI3OWZk ZTdlZDYxMjJmYmRjM2I0MTQ0ZWI0MTJhNS4uODRlMmQ0NTVlZjJlNTJiOGFjMmE3ZTQ1OWY5Yzhj MWFhNTZmYTVkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTExLTA5ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgSW1wbGVtZW50IC1b X1dLUmVtb3RlT2JqZWN0SW50ZXJmYWNlIGRlYnVnRGVzY3JpcHRpb25dIGFuZCBoYXZlIGl0IGxv b2sgbGlrZSB0aGUgTlNYUENJbnRlcmZhY2UgZXF1aXZhbGVudAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMDQ0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvQVBJL0NvY29hL19XS1JlbW90 ZU9iamVjdEludGVyZmFjZS5tbToKKyAgICAgICAgKC1bX1dLUmVtb3RlT2JqZWN0SW50ZXJmYWNl IGluaXRXaXRoUHJvdG9jb2w6aWRlbnRpZmllcjpdKToKKyAgICAgICAgKC1bX1dLUmVtb3RlT2Jq ZWN0SW50ZXJmYWNlIGRlYnVnRGVzY3JpcHRpb25dKToKKyAgICAgICAgKC1bX1dLUmVtb3RlT2Jq ZWN0SW50ZXJmYWNlIGRlc2NyaXB0aW9uXSk6IERlbGV0ZWQuCisKIDIwMTUtMTEtMDYgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXdvcmsgdGhlIHdh eSBhbGxvd2VkIGFyZ3VtZW50IGNsYXNzZXMgYXJlIHN0b3JlZApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9fV0tSZW1vdGVPYmplY3RJbnRlcmZhY2UubW0gYi9T b3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL19XS1JlbW90ZU9iamVjdEludGVyZmFjZS5t bQppbmRleCBiNzJkZmRlZGNiMzUyY2E1MzE2NGYwODVmMTQ0MDRmZmI0ZDk0YzYzLi4zYTQ2MmMy YTkyNWMyOTVjZWUwMDc1N2MzNmI5ZDIwODMwZmIzMDViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvQVBJL0NvY29hL19XS1JlbW90ZU9iamVjdEludGVyZmFjZS5tbQorKysgYi9T b3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL19XS1JlbW90ZU9iamVjdEludGVyZmFjZS5t bQpAQCAtMzMsMTEgKzMzLDEyIEBACiAjaW1wb3J0IDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KICNp bXBvcnQgPHd0Zi9SZXRhaW5QdHIuaD4KICNpbXBvcnQgPHd0Zi9WZWN0b3IuaD4KKyNpbXBvcnQg PHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAogZXh0ZXJuICJDIgogY29uc3QgY2hhciAqX3Byb3RvY29s X2dldE1ldGhvZFR5cGVFbmNvZGluZyhQcm90b2NvbCAqcCwgU0VMIHNlbCwgQk9PTCBpc1JlcXVp cmVkTWV0aG9kLCBCT09MIGlzSW5zdGFuY2VNZXRob2QpOwogCi1AaW50ZXJmYWNlIE5TTWV0aG9k U2lnbmF0dXJlIChXS0RldGFpbHMpCitAaW50ZXJmYWNlIE5TTWV0aG9kU2lnbmF0dXJlICgpCiAt IChDbGFzcylfY2xhc3NGb3JPYmplY3RBdEFyZ3VtZW50SW5kZXg6KE5TSW50ZWdlcilpZHg7CiBA ZW5kCiAKQEAgLTE2Myw2ICsxNjQsOCBAQCBzdGF0aWMgdm9pZCBpbml0aWFsaXplTWV0aG9kcyhf V0tSZW1vdGVPYmplY3RJbnRlcmZhY2UgKmludGVyZmFjZSwgUHJvdG9jb2wgKnBybwogCiAgICAg aW5pdGlhbGl6ZU1ldGhvZHMoc2VsZiwgX3Byb3RvY29sKTsKIAorICAgIE5TTG9nKEAiJUAiLCBz ZWxmLmRlYnVnRGVzY3JpcHRpb24pOworCiAgICAgcmV0dXJuIHNlbGY7CiB9CiAKQEAgLTE3Niw5 ICsxNzksNTQgQEAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZU1ldGhvZHMoX1dLUmVtb3RlT2JqZWN0 SW50ZXJmYWNlICppbnRlcmZhY2UsIFByb3RvY29sICpwcm8KICAgICByZXR1cm4gX2lkZW50aWZp ZXIuZ2V0KCk7CiB9CiAKLS0gKE5TU3RyaW5nICopZGVzY3JpcHRpb24KKy0gKE5TU3RyaW5nICop ZGVidWdEZXNjcmlwdGlvbgogewotICAgIHJldHVybiBbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1h dDpAIjwlQDogJXA7IHByb3RvY29sID0gXCIlQFwiOyBpZGVudGlmaWVyID0gXCIlQFwiPiIsIE5T U3RyaW5nRnJvbUNsYXNzKHNlbGYuY2xhc3MpLCBzZWxmLCBfaWRlbnRpZmllci5nZXQoKSwgTlNT dHJpbmdGcm9tUHJvdG9jb2woX3Byb3RvY29sKV07CisgICAgYXV0byByZXN1bHQgPSBhZG9wdE5T KFtbTlNNdXRhYmxlU3RyaW5nIGFsbG9jXSBpbml0V2l0aEZvcm1hdDpAIjwlQDogJXA7IHByb3Rv Y29sID0gXCIlQFwiOyBpZGVudGlmaWVyID0gXCIlQFwiXG4iLCBOU1N0cmluZ0Zyb21DbGFzcyhz ZWxmLmNsYXNzKSwgc2VsZiwgX2lkZW50aWZpZXIuZ2V0KCksIE5TU3RyaW5nRnJvbVByb3RvY29s KF9wcm90b2NvbCldKTsKKworICAgIGF1dG8gZGVzY3JpcHRpb25Gb3JDbGFzc2VzID0gW10oY29u c3QgVmVjdG9yPEhhc2hTZXQ8Q2xhc3M+PiYgYWxsb3dlZENsYXNzZXMpIHsKKyAgICAgICAgYXV0 byByZXN1bHQgPSBhZG9wdE5TKFtbTlNNdXRhYmxlU3RyaW5nIGFsbG9jXSBpbml0V2l0aFN0cmlu ZzpAIlsiXSk7CisgICAgICAgIGJvb2wgbmVlZHNDb21tYSA9IGZhbHNlOworCisgICAgICAgIGF1 dG8gZGVzY3JpcHRpb25Gb3JBcmd1bWVudCA9IFtdKGNvbnN0IEhhc2hTZXQ8Q2xhc3M+JiBhbGxv d2VkQXJndW1lbnRDbGFzc2VzKSB7CisgICAgICAgICAgICBhdXRvIHJlc3VsdCA9IGFkb3B0TlMo W1tOU011dGFibGVTdHJpbmcgYWxsb2NdIGluaXRXaXRoU3RyaW5nOkAieyJdKTsKKworICAgICAg ICAgICAgVmVjdG9yPENsYXNzPiBvcmRlcmVkQXJndW1lbnRDbGFzc2VzOworICAgICAgICAgICAg Y29weVRvVmVjdG9yKGFsbG93ZWRBcmd1bWVudENsYXNzZXMsIG9yZGVyZWRBcmd1bWVudENsYXNz ZXMpOworCisgICAgICAgICAgICBzdGQ6OnNvcnQob3JkZXJlZEFyZ3VtZW50Q2xhc3Nlcy5iZWdp bigpLCBvcmRlcmVkQXJndW1lbnRDbGFzc2VzLmVuZCgpLCBbXShDbGFzcyBhLCBDbGFzcyBiKSB7 CisgICAgICAgICAgICAgICAgcmV0dXJuIENTdHJpbmcoY2xhc3NfZ2V0TmFtZShhKSkgPCBDU3Ry aW5nKGNsYXNzX2dldE5hbWUoYikpOworICAgICAgICAgICAgfSk7CisKKyAgICAgICAgICAgIGJv b2wgbmVlZHNDb21tYSA9IGZhbHNlOworICAgICAgICAgICAgZm9yIChhdXRvJiBhcmd1bWVudENs YXNzIDogb3JkZXJlZEFyZ3VtZW50Q2xhc3NlcykgeworICAgICAgICAgICAgICAgIGlmIChuZWVk c0NvbW1hKQorICAgICAgICAgICAgICAgICAgICBbcmVzdWx0IGFwcGVuZFN0cmluZzpAIiwgIl07 CisKKyAgICAgICAgICAgICAgICBbcmVzdWx0IGFwcGVuZEZvcm1hdDpAIiVzIiwgY2xhc3NfZ2V0 TmFtZShhcmd1bWVudENsYXNzKV07CisgICAgICAgICAgICAgICAgbmVlZHNDb21tYSA9IHRydWU7 CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIFtyZXN1bHQgYXBwZW5kU3RyaW5nOkAifSJd OworICAgICAgICAgICAgcmV0dXJuIHJlc3VsdC5hdXRvcmVsZWFzZSgpOworICAgICAgICB9Owor CisgICAgICAgIGZvciAoYXV0byYgYXJndW1lbnRDbGFzc2VzIDogYWxsb3dlZENsYXNzZXMpIHsK KyAgICAgICAgICAgIGlmIChuZWVkc0NvbW1hKQorICAgICAgICAgICAgICAgIFtyZXN1bHQgYXBw ZW5kU3RyaW5nOkAiLCAiXTsKKworICAgICAgICAgICAgW3Jlc3VsdCBhcHBlbmRTdHJpbmc6ZGVz Y3JpcHRpb25Gb3JBcmd1bWVudChhcmd1bWVudENsYXNzZXMpXTsKKyAgICAgICAgICAgIG5lZWRz Q29tbWEgPSB0cnVlOworICAgICAgICB9CisKKyAgICAgICAgW3Jlc3VsdCBhcHBlbmRTdHJpbmc6 QCJdIl07CisgICAgICAgIHJldHVybiByZXN1bHQuYXV0b3JlbGVhc2UoKTsKKyAgICB9OworCisg ICAgZm9yIChhdXRvJiBzZWxlY3RvckFuZE1ldGhvZCA6IF9tZXRob2RzKQorICAgICAgICBbcmVz dWx0IGFwcGVuZEZvcm1hdDpAIiBzZWxlY3RvciA9ICVzXG4gIGFyZ3VtZW50IGNsYXNzZXMgPSAl QFxuIiwgc2VsX2dldE5hbWUoc2VsZWN0b3JBbmRNZXRob2Qua2V5KSwgZGVzY3JpcHRpb25Gb3JD bGFzc2VzKHNlbGVjdG9yQW5kTWV0aG9kLnZhbHVlLmFsbG93ZWRBcmd1bWVudENsYXNzZXMpXTsK KworICAgIFtyZXN1bHQgYXBwZW5kU3RyaW5nOkAiPlxuIl07CisgICAgcmV0dXJuIHJlc3VsdC5h dXRvcmVsZWFzZSgpOwogfQogCiBzdGF0aWMgSGFzaFNldDxDbGFzcz4mIGNsYXNzZXNGb3JTZWxl Y3RvckFyZ3VtZW50KF9XS1JlbW90ZU9iamVjdEludGVyZmFjZSAqaW50ZXJmYWNlLCBTRUwgc2Vs ZWN0b3IsIE5TVUludGVnZXIgYXJndW1lbnRJbmRleCkK