151013 2015-11-08 20:43:03 -0800 Fresh checkout fails to build on windows, DumpRenderTree can't find cairo_win.h 2015-11-09 11:17:58 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Windows 10 RESOLVED FIXED P2 Normal --- 1 isaac+webkit webkit-unassigned achristensen bfulgham commit-queue lforschler ossy peavo oldest_to_newest 1140299 0 isaac+webkit 2015-11-08 20:43:03 -0800 On Windows 10 64-bit machine with Visual Studio 2015 Community Edition: Followed instructions on http://trac.webkit.org/wiki/WindowsWithoutCygwin (except without iTunes or DirectX); except for building. Then in a "normal" command prompt ("start->run cmd.exe") cd PATH_TO_WEBKIT perl Tools\Scripts\build-webkit --wincairo --release Causes build failures in DumpRenderTree: C:\work\WebKit\Tools\DumpRenderTree\cairo\PixelDumpSupportCairo.h(38): fatal error C1083: Cannot open include file: 'cairo-win32.h': No such file or directory (compiling source file C:\work\WebKit\Tools\DumpRenderTree\PixelDumpSupport.cpp) [C:\work\WebKit\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj] C:\work\WebKit\Tools\DumpRenderTree\cairo\PixelDumpSupportCairo.h(38): fatal error C1083: Cannot open include file: 'cairo-win32.h': No such file or directory (compiling source file C:\work\WebKit\Tools\DumpRenderTree\win\PixelDumpSupportWin.cpp) [C:\work\WebKit\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj] c:\work\webkit\tools\dumprendertree\cairo\PixelDumpSupportCairo.h(38): fatal error C1083: Cannot open include file: 'cairo-win32.h': No such file or directory (compiling source file C:\work\WebKit\Tools\DumpRenderTree\cairo\PixelDumpSupportCairo.cpp) [C:\work\WebKit\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj] C:\work\WebKit\Tools\DumpRenderTree\win\ImageDiffCairo.cpp(32): fatal error C1083: Cannot open include file: 'cairo.h': No such file or directory [C:\work\WebKit\WebKitBuild\Release\Tools\DumpRenderTree\ImageDiffLib.vcxproj] Looking into DumpRenderTreeLib.vcxproj it doesn't have the fully qualified path to the WebkitLibraries\win\include\cairo directory, it just has "\include\cairo". 1140303 1 265032 isaac+webkit 2015-11-08 22:14:20 -0800 Created attachment 265032 Patch 1140400 2 bfulgham 2015-11-09 09:50:21 -0800 I think this looks good, but let's let Alex Christensen double-check before we land. 1140415 3 265032 achristensen 2015-11-09 10:27:29 -0800 Comment on attachment 265032 Patch Yep. 1140436 4 265032 commit-queue 2015-11-09 11:17:54 -0800 Comment on attachment 265032 Patch Clearing flags on attachment: 265032 Committed r192167: <http://trac.webkit.org/changeset/192167> 1140437 5 commit-queue 2015-11-09 11:17:58 -0800 All reviewed patches have been landed. Closing bug. 265032 2015-11-08 22:14:20 -0800 2015-11-09 11:17:54 -0800 Patch bug-151013-20151109191429.patch text/plain 1566 isaac+webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMTQ3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTc1ZmY5ZDUzZTkwNmE2MDZkODJkOTQwNWFjYjYzYTlm NDQxMjJjMS4uMTIzYzVlYjQ4YmE2OWI0NTE0MzQ1Yjg3MDYwMGU3YTcxM2I0YTFhYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE1LTExLTA4ICBJc2FhYyBEZXZpbmUgIDxpc2FhY0BkZXZpbmVzeXN0ZW1zLmNvLm56 PgorCisgICAgICAgIEZyZXNoIGNoZWNrb3V0IGZhaWxzIHRvIGJ1aWxkIG9uIHdpbmRvd3MsIER1 bXBSZW5kZXJUcmVlIGNhbid0IGZpbmQgY2Fpcm9fd2luLmgKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTAxMworCisgICAgICAgIFVzZSB0aGUgdmFy aWFibGUgZGVmaW5lZCBpbiB0aGUgQ01ha2Ugc2NyaXB0cyB0byBkZXRlcm1pbmUgdGhlIGNhaXJv IGluY2x1ZGUgbG9jYXRpb24sIHJhdGhlcgorICAgICAgICB0aGFuIHJlbHlpbmcgb24gYSBlbnZp cm9ubWVudCB2YXJpYWJsZSB0byBiZSBzZXQgY29ycmVjdGx5LiBPdGhlcndpc2UgdGhlIER1bXBS ZW5kZXJUcmVlTGliLnZjeHByb2ogd2lsbAorICAgICAgICBjb250YWluICJcaW5jbHVkZVxjYWly byIgcmF0aGVyIHRoYW4gdGhlIGZ1bGx5IHF1YWxpZmllZCBwYXRoIHRvIHRoZSBjYWlybyBpbmNs dWRlIGxvY2F0aW9uLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogRHVtcFJlbmRlclRyZWUvUGxhdGZvcm1XaW4uY21ha2U6CisKIDIwMTUtMTEtMDcg IERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIEF0dGVtcHQgdG8g Zml4IHRoZSBXaW5kb3dzIEVXUyBib3QgYWZ0ZXIgcjE5MjA4NwpkaWZmIC0tZ2l0IGEvVG9vbHMv RHVtcFJlbmRlclRyZWUvUGxhdGZvcm1XaW4uY21ha2UgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9Q bGF0Zm9ybVdpbi5jbWFrZQppbmRleCA1YjE0MjNjMDNiMmE3ZjZjOTE5ZDU5ZWY0NDczMjU5NDBk ZDI0YTMxLi5iOWIxMjFhZjk5NWQxMzZlYzI3MWMzZGU0OTBlYmIzZDM5Y2JkZThhIDEwMDY0NAot LS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9QbGF0Zm9ybVdpbi5jbWFrZQorKysgYi9Ub29scy9E dW1wUmVuZGVyVHJlZS9QbGF0Zm9ybVdpbi5jbWFrZQpAQCAtODgsNyArODgsNyBAQCBzZXQoRHVt cFJlbmRlclRyZWVMaWJfTElCUkFSSUVTCiBpZiAoJHtXVEZfUExBVEZPUk1fV0lOX0NBSVJPfSkK ICAgICBsaXN0KEFQUEVORCBEdW1wUmVuZGVyVHJlZV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAg ICAgIGNhaXJvCi0gICAgICAgICIkRU5We1dFQktJVF9MSUJSQVJJRVN9L2luY2x1ZGUvY2Fpcm8i CisgICAgICAgICIke1dFQktJVF9MSUJSQVJJRVNfRElSfS9pbmNsdWRlL2NhaXJvIgogICAgICkK ICAgICBsaXN0KEFQUEVORCBEdW1wUmVuZGVyVHJlZUxpYl9TT1VSQ0VTCiAgICAgICAgIGNhaXJv L1BpeGVsRHVtcFN1cHBvcnRDYWlyby5jcHAK