150996 2015-11-07 07:13:14 -0800 Node.h:392:12: warning: 'this' pointer cannot be null in well-defined C++ code 2015-11-07 09:17:44 -0800 1 1 1 Unclassified WebKit WebCore Misc. Other PC All RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro commit-queue esprehn+autocc kangil.han mcatanzaro oldest_to_newest 1140181 0 mcatanzaro 2015-11-07 07:13:14 -0800 WebCore::Node::document begins with the line ASSERT(this), which is bogus. In Clang 3.7, this triggers a compiler warning for every file that includes Node.h: ../../Source/WebCore/dom/Node.h:392:12: warning: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion] (!(this) ? (WTFReportAssertionFailure("../../Source/WebCore/dom/Node.h", 392, __PRETTY_FUNCTION__, "this"), WTFCrash()) : (void)0); ~ ^~~~ 1 warning generated. Pretty sure GCC and Clang both optimize away this assertion, but I guess the warning is new. The fix is just to remove the assertion. 1140182 1 265002 mcatanzaro 2015-11-07 07:29:54 -0800 Created attachment 265002 Patch 1140189 2 mcatanzaro 2015-11-07 09:17:44 -0800 Committed r192130: <http://trac.webkit.org/changeset/192130> 265002 2015-11-07 07:29:54 -0800 2015-11-07 08:33:06 -0800 Patch bug-150996-20151107092952.patch text/plain 1229 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjU1YmQ5NDQzZGE5MTI1 ZGQ3OGQ5OTE1ZjEwN2VmZWE1MmNhZDI5MC4uYjQyNTY3YTdjMTUwNzNlMmIyN2JhZTQxMjVhODc1 OWE0YmM0OTJiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTExLTA3ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBOb2RlLmg6 MzkyOjEyOiB3YXJuaW5nOiAndGhpcycgcG9pbnRlciBjYW5ub3QgYmUgbnVsbCBpbiB3ZWxsLWRl ZmluZWQgQysrIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1MDk5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlbW92ZSBBU1NFUlQodGhpcykgc3RhdGVtZW50IHRoYXQgaXMgdHJpZ2dlcmluZyBo dW5kcmVkcyBvZiB3YXJuaW5ncyBmcm9tIENsYW5nLgorCisgICAgICAgICogZG9tL05vZGUuaDoK KyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmRvY3VtZW50KToKKworMjAxNS0xMS0wNyAgTWljaGFl bCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKICAgICAgICAgVW5yZXZpZXdl ZCwgZml4IEdUSyBidWlsZCBhZnRlciByMTkxOTgxCiAKICAgICAgICAgKiBodG1sL0hUTUxGb3Jt Q29udHJvbEVsZW1lbnQuY3BwOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUu aCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmgKaW5kZXggMTY5ZDQwZGQzODhhYWUyOTI3OGFi MzU1OGZmNzJjNjcwY2ZhNzVjNS4uZWZmMDg2YTViZWUyZTBiZjg1Yjc3YWM4N2ViYzIxYTUwNzUz YWJkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vTm9kZS5oCkBAIC0zODksNyArMzg5LDYgQEAgcHVibGljOgogICAgIC8vIEEg RG9jdW1lbnQgbm9kZSByZXR1cm5zIGl0c2VsZi4KICAgICBEb2N1bWVudCYgZG9jdW1lbnQoKSBj b25zdAogICAgIHsKLSAgICAgICAgQVNTRVJUKHRoaXMpOwogICAgICAgICByZXR1cm4gdHJlZVNj b3BlKCkuZG9jdW1lbnRTY29wZSgpOwogICAgIH0KIAo=