150989 2015-11-06 17:50:11 -0800 Do not build LayoutTestRelay when --root is specified to run-webkit-tests 2015-11-06 21:14:30 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Mac All RESOLVED FIXED P2 Normal --- 1 dbates dbates ap commit-queue ddkilzer glenn lforschler oldest_to_newest 1140127 0 dbates 2015-11-06 17:50:11 -0800 We should not build LayoutTestRelay when an explicit directory of built executables was specified to run-webkit-test via --root because we assume that when a person specifies --root that the directory they passed contains all the built executables needed to run the tests. 1140128 1 264985 dbates 2015-11-06 17:52:41 -0800 Created attachment 264985 Patch 1140163 2 dbates 2015-11-06 21:14:30 -0800 Committed r192127: <http://trac.webkit.org/changeset/192127> 264985 2015-11-06 17:52:41 -0800 2015-11-06 18:50:26 -0800 Patch bug-150989-20151106175230.patch text/plain 2396 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMTA1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmFjMzE5NjAzM2I0NDMxOTY0MDc4ZWE1ODIwYzJlYmU4 YTZmZWNhNy4uMDIwODFjNzc4ZGZjYmQ5NmM5OGEwMjU5OGQwYmNhNDNjMTQ3NGIyNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIz IEBACiAyMDE1LTExLTA2ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAorICAg ICAgICBEbyBub3QgYnVpbGQgTGF5b3V0VGVzdFJlbGF5IHdoZW4gLS1yb290IGlzIHNwZWNpZmll ZCB0byBydW4td2Via2l0LXRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTA5ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgc2NyaXB0IHJ1bi13ZWJraXQtdGVzdHMgc2hvdWxkIG9ubHkgY2hl Y2sgaWYgTGF5b3V0VGVzdFJlbGF5IGV4aXN0cyB3aGVuIGludm9rZWQgd2l0aAorICAgICAgICAt LXJvb3QgYW5kIGV4aXQgd2l0aCBhbiBlcnJvciBpZiBpdCBkb2VzIG5vdCBleGlzdC4gVGhhdCBp cywgd2Ugc2hvdWxkIG5vdCBidWlsZCBMYXlvdXRUZXN0UmVsYXkKKyAgICAgICAgd2hlbiBpdCBk b2VzIG5vdCBleGlzdCBhbmQgYW4gZXhwbGljaXQgZGlyZWN0b3J5IG9mIGJ1aWx0IGV4ZWN1dGFi bGVzIHdhcyBzcGVjaWZpZWQgdmlhIC0tcm9vdC4KKyAgICAgICAgVGhpcyB3aWxsIG1ha2UgdGhl IGNyaXRlcmlvbiBmb3IgYnVpbGRpbmcgTGF5b3V0VGVzdFJlbGF5IG1hdGNoIHRoZSBjcml0ZXJp b24gZm9yIGJ1aWxkaW5nCisgICAgICAgIER1bXBSZW5kZXJUcmVlL1dlYktpdFRlc3RSdW5uZXIu CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5OgorICAgICAgICAoSU9T U2ltdWxhdG9yUG9ydC5fY2hlY2tfcG9ydF9idWlsZCk6IE1vdmVkIGxvZ2ljIGZyb20gSU9TU2lt dWxhdG9yUG9ydC57X2NoZWNrX2J1aWxkX3JlbGF5LCBjaGVja19idWlsZH0gdG8gaGVyZS4KKyAg ICAgICAgKElPU1NpbXVsYXRvclBvcnQuX2NoZWNrX2J1aWxkX3JlbGF5KTogRGVsZXRlZC4KKyAg ICAgICAgKElPU1NpbXVsYXRvclBvcnQuY2hlY2tfYnVpbGQpOiBEZWxldGVkLgorCisyMDE1LTEx LTA2ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKwogICAgICAgICBUZWFjaCBN YWtlZmlsZSB0byBidWlsZCBMYXlvdXRUZXN0UmVsYXkgd2hlbiBidWlsZGluZyBmb3IgaU9TIFNp bXVsYXRvcgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTUwODQ5CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5CmluZGV4IDg3MGYyMzk2NWU3MGJh MTMxYzFkYTk4M2E0ZWJkNjg0YzMxZDY5NWUuLjIyZmNiNWI0Mzk2NWZlODYyODRmOTQzMDA4ZTJk ZjRjOTYwNDkzZjIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3Mu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvcy5weQpAQCAtMTQ0LDE3ICsx NDQsMTMgQEAgY2xhc3MgSU9TU2ltdWxhdG9yUG9ydChQb3J0KToKICAgICAgICAgICAgIHJldHVy biBGYWxzZQogICAgICAgICByZXR1cm4gVHJ1ZQogCi0gICAgZGVmIF9jaGVja19idWlsZF9yZWxh eShzZWxmKToKLSAgICAgICAgaWYgc2VsZi5nZXRfb3B0aW9uKCdidWlsZCcpIGFuZCBub3Qgc2Vs Zi5fYnVpbGRfcmVsYXkoKToKKyAgICBkZWYgX2NoZWNrX3BvcnRfYnVpbGQoc2VsZik6CisgICAg ICAgIGlmIG5vdCBzZWxmLl9yb290X3dhc19zZXQgYW5kIHNlbGYuZ2V0X29wdGlvbignYnVpbGQn KSBhbmQgbm90IHNlbGYuX2J1aWxkX3JlbGF5KCk6CiAgICAgICAgICAgICByZXR1cm4gRmFsc2UK ICAgICAgICAgaWYgbm90IHNlbGYuX2NoZWNrX3JlbGF5KCk6CiAgICAgICAgICAgICByZXR1cm4g RmFsc2UKICAgICAgICAgcmV0dXJuIFRydWUKIAotICAgIGRlZiBjaGVja19idWlsZChzZWxmLCBu ZWVkc19odHRwKToKLSAgICAgICAgbmVlZHNfZHJpdmVyID0gc3VwZXIoSU9TU2ltdWxhdG9yUG9y dCwgc2VsZikuY2hlY2tfYnVpbGQobmVlZHNfaHR0cCkKLSAgICAgICAgcmV0dXJuIG5lZWRzX2Ry aXZlciBhbmQgc2VsZi5fY2hlY2tfYnVpbGRfcmVsYXkoKQotCiAgICAgZGVmIF9idWlsZF9yZWxh eShzZWxmKToKICAgICAgICAgZW52aXJvbm1lbnQgPSBzZWxmLmhvc3QuY29weV9jdXJyZW50X2Vu dmlyb25tZW50KCkKICAgICAgICAgZW52aXJvbm1lbnQuZGlzYWJsZV9nY2Nfc21hcnRxdW90ZXMo KQo=