150975 2015-11-06 11:47:56 -0800 Remove unused HTMLFormControlsCollection::namedItem() 2015-11-06 15:59:10 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue darin kling koivisto rniwa oldest_to_newest 1140018 0 cdumez 2015-11-06 11:47:56 -0800 Remove unused HTMLFormControlsCollection::namedItem(). JSHTMLFormControlsCollection::namedItem() calls namedItems() on the implementation object, not namedItem() because it returns a RadioNodeList when there are several matches. 1140019 1 264945 cdumez 2015-11-06 11:49:44 -0800 Created attachment 264945 Patch 1140044 2 264945 kling 2015-11-06 13:04:16 -0800 Comment on attachment 264945 Patch r=me 1140082 3 264945 commit-queue 2015-11-06 15:58:25 -0800 Comment on attachment 264945 Patch Clearing flags on attachment: 264945 Committed r192122: <http://trac.webkit.org/changeset/192122> 1140083 4 commit-queue 2015-11-06 15:59:10 -0800 All reviewed patches have been landed. Closing bug. 264945 2015-11-06 11:49:44 -0800 2015-11-06 15:58:25 -0800 Patch bug-150975-20151106114844.patch text/plain 3700 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTZkNTllM2Y3MDgzOGI0 YzZmYWM5Y2Y1YmIwOTI0Njg0YTQwNDAzZS4uNmVjZTUwMGIyNjZkMjhmMjA0YTBhN2FjMDQ0MTkz MDI4NzE4YTY4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTExLTA2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBIVE1M Rm9ybUNvbnRyb2xzQ29sbGVjdGlvbjo6bmFtZWRJdGVtKCkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDk3NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQgSFRNTEZvcm1Db250cm9s c0NvbGxlY3Rpb246Om5hbWVkSXRlbSgpLgorICAgICAgICBKU0hUTUxGb3JtQ29udHJvbHNDb2xs ZWN0aW9uOjpuYW1lZEl0ZW0oKSBjYWxscyBuYW1lZEl0ZW1zKCkgb24gdGhlCisgICAgICAgIGlt cGxlbWVudGF0aW9uIG9iamVjdCwgbm90IG5hbWVkSXRlbSgpIGJlY2F1c2UgaXQgcmV0dXJucyBh CisgICAgICAgIFJhZGlvTm9kZUxpc3Qgd2hlbiB0aGVyZSBhcmUgc2V2ZXJhbCBtYXRjaGVzLgor CisgICAgICAgICogaHRtbC9IVE1MRm9ybUNvbnRyb2xzQ29sbGVjdGlvbi5jcHA6CisgICAgICAg IChXZWJDb3JlOjpmaXJzdE5hbWVkSXRlbSk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpI VE1MRm9ybUNvbnRyb2xzQ29sbGVjdGlvbjo6bmFtZWRJdGVtKTogRGVsZXRlZC4KKyAgICAgICAg KiBodG1sL0hUTUxGb3JtQ29udHJvbHNDb2xsZWN0aW9uLmg6CisKIDIwMTUtMTEtMDYgIE1hcmlv IFNhbmNoZXogUHJhZGEgIDxtYXJpb0BlbmRsZXNzbS5jb20+CiAKICAgICAgICAgTGF5b3V0IFRl c3QgYWNjZXNzaWJpbGl0eS93aW4vbGlua2VkLWVsZW1lbnRzLmh0bWwgaXMgY3Jhc2hpbmcgb24g d2luIGRlYnVnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJv bHNDb2xsZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sc0Nv bGxlY3Rpb24uY3BwCmluZGV4IDM2ZjczM2Q1NGQ2MjFiZGEyNjYyYzc0NmNhMGMzODVlODQ0M2Ey YWMuLjg0MDJhYTY3ZTU4ZjVlZjc5YzAyNjQ5YjhiNTNjYTNjNDA4ODc3OTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sc0NvbGxlY3Rpb24uY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sc0NvbGxlY3Rpb24uY3BwCkBAIC05 OCw0MSArOTgsNiBAQCBIVE1MRWxlbWVudCogSFRNTEZvcm1Db250cm9sc0NvbGxlY3Rpb246OmN1 c3RvbUVsZW1lbnRBZnRlcihFbGVtZW50KiBjdXJyZW50KSBjbwogICAgIHJldHVybiBudWxscHRy OwogfQogCi1zdGF0aWMgSFRNTEVsZW1lbnQqIGZpcnN0TmFtZWRJdGVtKGNvbnN0IFZlY3RvcjxG b3JtQXNzb2NpYXRlZEVsZW1lbnQqPiYgZWxlbWVudHNBcnJheSwKLSAgICBjb25zdCBWZWN0b3I8 SFRNTEltYWdlRWxlbWVudCo+KiBpbWFnZUVsZW1lbnRzQXJyYXksIGNvbnN0IFF1YWxpZmllZE5h bWUmIGF0dHJOYW1lLCBjb25zdCBTdHJpbmcmIG5hbWUpCi17Ci0gICAgQVNTRVJUKGF0dHJOYW1l ID09IGlkQXR0ciB8fCBhdHRyTmFtZSA9PSBuYW1lQXR0cik7Ci0KLSAgICBmb3IgKGF1dG8mIGVu dHJ5IDogZWxlbWVudHNBcnJheSkgewotICAgICAgICBIVE1MRWxlbWVudCYgZWxlbWVudCA9IGVu dHJ5LT5hc0hUTUxFbGVtZW50KCk7Ci0gICAgICAgIGlmIChlbnRyeS0+aXNFbnVtZXJhdGFibGUo KSAmJiBlbGVtZW50LmZhc3RHZXRBdHRyaWJ1dGUoYXR0ck5hbWUpID09IG5hbWUpCi0gICAgICAg ICAgICByZXR1cm4gJmVsZW1lbnQ7Ci0gICAgfQotCi0gICAgaWYgKCFpbWFnZUVsZW1lbnRzQXJy YXkpCi0gICAgICAgIHJldHVybiAwOwotCi0gICAgZm9yIChhdXRvJiBlbGVtZW50IDogKmltYWdl RWxlbWVudHNBcnJheSkgewotICAgICAgICBpZiAoZWxlbWVudC0+ZmFzdEdldEF0dHJpYnV0ZShh dHRyTmFtZSkgPT0gbmFtZSkKLSAgICAgICAgICAgIHJldHVybiBlbGVtZW50OwotICAgIH0KLQot ICAgIHJldHVybiBudWxscHRyOwotfQotCi1IVE1MRWxlbWVudCogSFRNTEZvcm1Db250cm9sc0Nv bGxlY3Rpb246Om5hbWVkSXRlbShjb25zdCBBdG9taWNTdHJpbmcmIG5hbWUpIGNvbnN0Ci17Ci0g ICAgLy8gaHR0cDovL21zZG4ubWljcm9zb2Z0LmNvbS93b3Jrc2hvcC9hdXRob3IvZGh0bWwvcmVm ZXJlbmNlL21ldGhvZHMvbmFtZWRpdGVtLmFzcAotICAgIC8vIFRoaXMgbWV0aG9kIGZpcnN0IHNl YXJjaGVzIGZvciBhbiBvYmplY3Qgd2l0aCBhIG1hdGNoaW5nIGlkCi0gICAgLy8gYXR0cmlidXRl LiBJZiBhIG1hdGNoIGlzIG5vdCBmb3VuZCwgdGhlIG1ldGhvZCB0aGVuIHNlYXJjaGVzIGZvciBh bgotICAgIC8vIG9iamVjdCB3aXRoIGEgbWF0Y2hpbmcgbmFtZSBhdHRyaWJ1dGUsIGJ1dCBvbmx5 IG9uIHRob3NlIGVsZW1lbnRzCi0gICAgLy8gdGhhdCBhcmUgYWxsb3dlZCBhIG5hbWUgYXR0cmli dXRlLgotICAgIGF1dG8qIGltYWdlRWxlbWVudHMgPSBpczxIVE1MRmllbGRTZXRFbGVtZW50Pihv d25lck5vZGUoKSkgPyBudWxscHRyIDogJmZvcm1JbWFnZUVsZW1lbnRzKCk7Ci0gICAgaWYgKEhU TUxFbGVtZW50KiBpdGVtID0gZmlyc3ROYW1lZEl0ZW0oZm9ybUNvbnRyb2xFbGVtZW50cygpLCBp bWFnZUVsZW1lbnRzLCBpZEF0dHIsIG5hbWUpKQotICAgICAgICByZXR1cm4gaXRlbTsKLSAgICBy ZXR1cm4gZmlyc3ROYW1lZEl0ZW0oZm9ybUNvbnRyb2xFbGVtZW50cygpLCBpbWFnZUVsZW1lbnRz LCBuYW1lQXR0ciwgbmFtZSk7Ci19Ci0KIHZvaWQgSFRNTEZvcm1Db250cm9sc0NvbGxlY3Rpb246 OnVwZGF0ZU5hbWVkRWxlbWVudENhY2hlKCkgY29uc3QKIHsKICAgICBpZiAoaGFzTmFtZWRFbGVt ZW50Q2FjaGUoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250 cm9sc0NvbGxlY3Rpb24uaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sc0Nv bGxlY3Rpb24uaAppbmRleCA4MDI3YmRlOWRhMjdmYWQzYWU2ZWE0NGQ1ZDE1Y2MxOTU3NjBmZGQx Li45M2Q0NzdmOTBlYjdmMTQyMTVlOTE2NmM5ZWNmODI0ZGE0ZWRhYjI0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbHNDb2xsZWN0aW9uLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xzQ29sbGVjdGlvbi5oCkBAIC00Nyw3ICs0 Nyw2IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgZXhwbGljaXQgSFRNTEZvcm1Db250cm9sc0Nv bGxlY3Rpb24oQ29udGFpbmVyTm9kZSYpOwogCi0gICAgdmlydHVhbCBIVE1MRWxlbWVudCogbmFt ZWRJdGVtKGNvbnN0IEF0b21pY1N0cmluZyYgbmFtZSkgY29uc3Qgb3ZlcnJpZGU7CiAgICAgdmly dHVhbCB2b2lkIGludmFsaWRhdGVDYWNoZShEb2N1bWVudCYpIG92ZXJyaWRlOwogICAgIHZpcnR1 YWwgdm9pZCB1cGRhdGVOYW1lZEVsZW1lbnRDYWNoZSgpIGNvbnN0IG92ZXJyaWRlOwogCg==