15096 2007-08-27 17:17:41 -0700 CG and non-CG GIF decoders have different frame duration minima 2007-08-29 10:40:12 -0700 1 1 1 Unclassified WebKit Images 523.x (Safari 3) PC All RESOLVED FIXED P2 Normal --- 0 pkasting webkit-unassigned oldest_to_newest 1363 0 pkasting 2007-08-27 17:17:41 -0700 ImageSourceCG.cpp uses a WinIE-like >50 ms minimum cutoff for GIF frame durations. But the code in image-decoders/gif/GIFImageReader.cpp (used by Cairo, QT) uses =10 ms. Patch to make the non-CG ImageSources work like ImageSourceCG coming shortly. 1364 1 16137 pkasting 2007-08-27 17:21:09 -0700 Created attachment 16137 patch v1 This makes the various ImageSource*.cpp files look closer to ImageSourceCG.cpp, including using the same threshold value. It also makes GIFImageReader.cpp closer to the original Mozilla source. 1298 2 16137 mjs 2007-08-28 21:19:39 -0700 Comment on attachment 16137 patch v1 r=me 1242 3 mrowe 2007-08-29 10:40:12 -0700 Landed in r25295. 16137 2007-08-27 17:21:09 -0700 2007-08-28 21:19:39 -0700 patch v1 patch text/plain 3744 pkasting SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTI2NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDctMDgtMjcgIFBldGVyIEthc3RpbmcgIDx6ZXJvZHB4QGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAt IGZpeCBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA5NgorICAgICAg ICBNb3ZlIHRoZSBHSUYgZnJhbWUgZHVyYXRpb24gbWluaW11bSBjaGVjayBpbnRvIHRoZSB2YXJp b3VzCisgICAgICAgIEltYWdlU291cmNlKi5jcHAgYmFja2VuZHMgYW5kIHVzZSB0aGUgc2FtZSB2 YWx1ZXMgYXMKKyAgICAgICAgSW1hZ2VTb3VyY2VDRy5jcHAuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9jYWlyby9JbWFnZVNvdXJjZUNhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkltYWdlU291cmNlOjpmcmFtZUR1cmF0aW9uQXRJbmRleCk6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvcXQvSW1hZ2VTb3VyY2VRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZVNv dXJjZTo6ZnJhbWVEdXJhdGlvbkF0SW5kZXgpOgorICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRl Y29kZXJzL2dpZi9HSUZJbWFnZVJlYWRlci5jcHA6CisgICAgICAgIChHSUZJbWFnZVJlYWRlcjo6 cmVhZCk6CisKIDIwMDctMDgtMjcgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llai4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2Fpcm8vSW1hZ2VTb3VyY2VDYWlyby5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZVNvdXJjZUNhaXJvLmNwcAkocmV2aXNpb24gMjUy NjcpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlU291cmNlQ2Fpcm8u Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODIsNyArMTgyLDEzIEBAIGZsb2F0IEltYWdlU291cmNl OjpmcmFtZUR1cmF0aW9uQXRJbmRleCgKICAgICBpZiAoIWJ1ZmZlciB8fCBidWZmZXItPnN0YXR1 cygpID09IFJHQkEzMkJ1ZmZlcjo6RnJhbWVFbXB0eSkKICAgICAgICAgcmV0dXJuIDA7CiAKLSAg ICByZXR1cm4gYnVmZmVyLT5kdXJhdGlvbigpIC8gMTAwMC4wZjsKKyAgICAvLyBNYW55IGFubm95 aW5nIGFkcyBzcGVjaWZ5IGEgMCBkdXJhdGlvbiB0byBtYWtlIGFuIGltYWdlIGZsYXNoIGFzIHF1 aWNrbHkKKyAgICAvLyBhcyBwb3NzaWJsZS4gIFdlIGZvbGxvdyBXaW5JRSdzIGJlaGF2aW9yIGFu ZCB1c2UgYSBkdXJhdGlvbiBvZiAxMDAgbXMKKyAgICAvLyBmb3IgYW55IGZyYW1lcyB0aGF0IHNw ZWNpZnkgYSBkdXJhdGlvbiBvZiA8PSA1MCBtcy4gIFNlZQorICAgIC8vIDxodHRwOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQxMz4gb3IgUmFkYXIgNDA1MTM4OSBmb3IKKyAg ICAvLyBtb3JlLgorICAgIGNvbnN0IGZsb2F0IGR1cmF0aW9uID0gYnVmZmVyLT5kdXJhdGlvbigp IC8gMTAwMC4wZjsKKyAgICByZXR1cm4gKGR1cmF0aW9uIDwgMC4wNTFmKSA/IDAuMTAwZiA6IGR1 cmF0aW9uOwogfQogCiBib29sIEltYWdlU291cmNlOjpmcmFtZUhhc0FscGhhQXRJbmRleChzaXpl X3QgaW5kZXgpCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlU291cmNl UXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VT b3VyY2VRdC5jcHAJKHJldmlzaW9uIDI1MjY3KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9xdC9JbWFnZVNvdXJjZVF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTcwLDcgKzE3MCwxMyBA QCBmbG9hdCBJbWFnZVNvdXJjZTo6ZnJhbWVEdXJhdGlvbkF0SW5kZXgoCiAgICAgaWYgKCFtX2Rl Y29kZXIpCiAgICAgICAgIHJldHVybiAwOwogICAgIAotICAgIHJldHVybiBtX2RlY29kZXItPmR1 cmF0aW9uKGluZGV4KSAvIDEwMDAuMGY7CisgICAgLy8gTWFueSBhbm5veWluZyBhZHMgc3BlY2lm eSBhIDAgZHVyYXRpb24gdG8gbWFrZSBhbiBpbWFnZSBmbGFzaCBhcyBxdWlja2x5CisgICAgLy8g YXMgcG9zc2libGUuICBXZSBmb2xsb3cgV2luSUUncyBiZWhhdmlvciBhbmQgdXNlIGEgZHVyYXRp b24gb2YgMTAwIG1zCisgICAgLy8gZm9yIGFueSBmcmFtZXMgdGhhdCBzcGVjaWZ5IGEgZHVyYXRp b24gb2YgPD0gNTAgbXMuICBTZWUKKyAgICAvLyA8aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ0MTM+IG9yIFJhZGFyIDQwNTEzODkgZm9yCisgICAgLy8gbW9yZS4KKyAg ICBjb25zdCBmbG9hdCBkdXJhdGlvbiA9IG1fZGVjb2Rlci0+ZHVyYXRpb24oaW5kZXgpIC8gMTAw MC4wZjsKKyAgICByZXR1cm4gKGR1cmF0aW9uIDwgMC4wNTFmKSA/IDAuMTAwZiA6IGR1cmF0aW9u OwogfQogCiBib29sIEltYWdlU291cmNlOjpmcmFtZUhhc0FscGhhQXRJbmRleChzaXplX3QgaW5k ZXgpCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJbWFnZVJl YWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9n aWYvR0lGSW1hZ2VSZWFkZXIuY3BwCShyZXZpc2lvbiAyNTI2NykKKysrIFdlYkNvcmUvcGxhdGZv cm0vaW1hZ2UtZGVjb2RlcnMvZ2lmL0dJRkltYWdlUmVhZGVyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNjUxLDExICs2NTEsNyBAQCBib29sIEdJRkltYWdlUmVhZGVyOjpyZWFkKGNvbnN0IHVuc2ln bmVkCiAgICAgICAgIC8vIExldCdzIGNob29zZSAzICh0aGUgbW9yZSBwb3B1bGFyKQogICAgICAg ICBpZiAoZnJhbWVfcmVhZGVyLT5kaXNwb3NhbF9tZXRob2QgPT0gNCkKICAgICAgICAgICBmcmFt ZV9yZWFkZXItPmRpc3Bvc2FsX21ldGhvZCA9IChnZGlzcG9zZSkzOwotICAgICAgICB1bnNpZ25l ZCBzaG9ydCBuID0gR0VUSU5UMTYocSArIDEpOwotICAgICAgICAvLyBNYW55IGFubm95aW5nIGFk cyBzcGVjaWZ5IGEgMCBkdXJhdGlvbiB0byBtYWtlIGFuIGltYWdlIGZsYXNoIGFzIHF1aWNrbHkg YXMgcG9zc2libGUuCi0gICAgICAgIC8vIFdlIGZvbGxvdyBGaXJlZm94J3MgYmVoYXZpb3IgYW5k IHVzZSBhIGR1cmF0aW9uIG9mIDEwMCBtcyBmb3IgYW55IGZyYW1lcyB0aGF0IHNwZWNpZnkKLSAg ICAgICAgLy8gYSBkdXJhdGlvbiBvZiA8PSAxMCBtcy4gU2VlIGdmeEltYWdlRnJhbWU6OkdldFRp bWVvdXQgaW4gR2Vja28gb3IgUmFkYXIgNDA1MTM4OSBmb3IgbW9yZS4KLSAgICAgICAgZnJhbWVf cmVhZGVyLT5kZWxheV90aW1lID0gbiA8PSAxID8gMTAwIDogbiAqIDEwOworICAgICAgICBmcmFt ZV9yZWFkZXItPmRlbGF5X3RpbWUgPSBHRVRJTlQxNihxICsgMSkgKiAxMDsKICAgICAgIH0KICAg ICAgIEdFVE4oMSwgZ2lmX2NvbnN1bWVfYmxvY2spOwogICAgIH0K