150938 2015-11-05 10:55:52 -0800 Web Inspector: Toolbar "Inspect Node" button not highlighting when active 2015-11-05 11:29:42 -0800 1 1 1 Unclassified WebKit Web Inspector Other All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev simon.fraser timothy webkit-bug-importer oldest_to_newest 1139655 0 joepeck 2015-11-05 10:55:52 -0800 * SUMMARY Toolbar "Inspect Node" button not highlighting when active. * STEPS TO REPRODUCE 1. Inspect this page 2. Click "Inspect Node" button in Toolbar => expected button to appear active, it did not 1139656 1 joepeck 2015-11-05 10:56:18 -0800 <rdar://problem/23414255> 1139657 2 264871 joepeck 2015-11-05 10:57:26 -0800 Created attachment 264871 [PATCH] Proposed Fix 1139667 3 simon.fraser 2015-11-05 11:17:44 -0800 Could this breakage have been detected by regression testing? 1139677 4 264871 commit-queue 2015-11-05 11:28:31 -0800 Comment on attachment 264871 [PATCH] Proposed Fix Clearing flags on attachment: 264871 Committed r192063: <http://trac.webkit.org/changeset/192063> 1139678 5 commit-queue 2015-11-05 11:28:35 -0800 All reviewed patches have been landed. Closing bug. 1139679 6 bburg 2015-11-05 11:29:42 -0800 (In reply to comment #3) > Could this breakage have been detected by regression testing? Currently, we do not have any test coverage for purely UI regressions like this one. It would be nice, but we'd need to have better user automation support to simulate clicking the element. And then we'd need to look at the computed style or something. Preventing these regressions is high on my list of ways to reduce Web Inspector patch churn. 264871 2015-11-05 10:57:26 -0800 2015-11-05 11:28:31 -0800 [PATCH] Proposed Fix inspect-button.patch text/plain 1615 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM3ZjA1ZjIuLjdhZTJlZjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTExLTA1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVG9vbGJh ciAiSW5zcGVjdCBOb2RlIiBidXR0b24gbm90IGhpZ2hsaWdodGluZyB3aGVuIGFjdGl2ZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwOTM4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL0J1dHRvblRvb2xiYXJJdGVtLmNzczoKKyAgICAgICAgKC50b29sYmFyIC5pdGVt LmJ1dHRvbjpub3QoLmRpc2FibGVkKTptYXRjaGVzKDpmb2N1cywgLmFjdGl2YXRlLmFjdGl2YXRl ZCkgPiAuZ2x5cGgpOgorICAgICAgICAoLnRvb2xiYXIgLml0ZW0uYnV0dG9uOm5vdCguZGlzYWJs ZWQpOmFjdGl2ZTptYXRjaGVzKDpmb2N1cywgLmFjdGl2YXRlLmFjdGl2YXRlZCkgPiAuZ2x5cGgp OgorICAgICAgICBDb3B5IHRoZSBuYXZpZ2F0aW9uLWJhciBidXR0b24gYWN0aXZhdGVkIHN0eWxl cyB0byB0b29sYmFyLgorCiAyMDE1LTExLTA0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0Bh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog4oyl4oyYQyBzb21ldGltZXMgZW5k cyB1cHMgdXAgb3BlbmluZyBpbnNwZWN0b3Igd2l0aG91dCBjb25zb2xlIHByb21wdCBmb2N1c2Vk CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9C dXR0b25Ub29sYmFySXRlbS5jc3MgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9CdXR0b25Ub29sYmFySXRlbS5jc3MKaW5kZXggYjViOTkyYTQuLmVmMTQ2OWQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0J1dHRv blRvb2xiYXJJdGVtLmNzcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9CdXR0b25Ub29sYmFySXRlbS5jc3MKQEAgLTUwLDYgKzUwLDE0IEBACiAgICAgY29s b3I6IGhzbCgwLCAwJSwgMzAlKTsKIH0KIAorLnRvb2xiYXIgLml0ZW0uYnV0dG9uOm5vdCguZGlz YWJsZWQpOm1hdGNoZXMoOmZvY3VzLCAuYWN0aXZhdGUuYWN0aXZhdGVkKSA+IC5nbHlwaCB7Cisg ICAgY29sb3I6IGhzbCgyMTIsIDkyJSwgNTQlKTsKK30KKworLnRvb2xiYXIgLml0ZW0uYnV0dG9u Om5vdCguZGlzYWJsZWQpOmFjdGl2ZTptYXRjaGVzKDpmb2N1cywgLmFjdGl2YXRlLmFjdGl2YXRl ZCkgPiAuZ2x5cGggeworICAgIGNvbG9yOiBoc2woMjE4LCA4NSUsIDUyJSk7Cit9CisKIC50b29s YmFyLnNtYWxsLXNpemUgLml0ZW0uYnV0dG9uID4gLmdseXBoIHsKICAgICB3aWR0aDogMTZweDsK ICAgICBoZWlnaHQ6IDE2cHg7Cg==