150937 2015-11-05 10:23:43 -0800 Regression(r192038): Safari cannot load any pages 2015-11-05 13:27:03 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P1 Normal --- 150898 1 cdumez cdumez achristensen commit-queue simon.fraser webkit-bug-importer wig_2006 oldest_to_newest 1139644 0 cdumez 2015-11-05 10:23:43 -0800 Safari cannot load any pages after r192038. 1139645 1 cdumez 2015-11-05 10:24:11 -0800 rdar://problem/23413859 1139646 2 264870 cdumez 2015-11-05 10:29:16 -0800 Created attachment 264870 Fix 1139647 3 264870 cdumez 2015-11-05 10:31:44 -0800 Comment on attachment 264870 Fix Clearing flags on attachment: 264870 Committed r192060: <http://trac.webkit.org/changeset/192060> 1139648 4 cdumez 2015-11-05 10:31:49 -0800 All reviewed patches have been landed. Closing bug. 1139651 5 264870 simon.fraser 2015-11-05 10:43:12 -0800 Comment on attachment 264870 Fix Why was this not caught by tests? 1139653 6 cdumez 2015-11-05 10:48:39 -0800 (In reply to comment #5) > Comment on attachment 264870 [details] > Patch > > Why was this not caught by tests? I think because this relies on load deferring. I am looking into adding an internals API that would enable load deferring so we can add test coverage for this. 1139654 7 cdumez 2015-11-05 10:53:25 -0800 (In reply to comment #6) > (In reply to comment #5) > > Comment on attachment 264870 [details] > > Patch > > > > Why was this not caught by tests? > > I think because this relies on load deferring. I am looking into adding an > internals API that would enable load deferring so we can add test coverage > for this. Actually, there is already testRunner.setDefersLoading(bool). I will see if I can add coverage for this bug using this API. 1139669 8 cdumez 2015-11-05 11:22:36 -0800 Reopening to attach new patch. 1139670 9 264872 cdumez 2015-11-05 11:22:38 -0800 Created attachment 264872 Regression test 1139673 10 264872 ggaren 2015-11-05 11:23:49 -0800 Comment on attachment 264872 Regression test r=me 1139714 11 264872 commit-queue 2015-11-05 12:38:19 -0800 Comment on attachment 264872 Regression test Clearing flags on attachment: 264872 Committed r192069: <http://trac.webkit.org/changeset/192069> 1139715 12 commit-queue 2015-11-05 12:38:23 -0800 All reviewed patches have been landed. Closing bug. 1139729 13 ap 2015-11-05 13:27:03 -0800 *** Bug 150926 has been marked as a duplicate of this bug. *** 264870 2015-11-05 10:29:16 -0800 2015-11-05 11:49:51 -0800 Fix bug-150937-20151105102818.patch text/plain 1597 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTQxNTYyNTBiZmI3M2Uw MGMyNmM1YjBmYzdhYTRkZjFiMDRlMzQ3NC4uZWI0M2IzYzc0NGQ0NzYzOTYxNzcxMGJjZTI2OWNj ZjQzYzU5YzMyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTExLTA1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihyMTkyMDM4 KTogU2FmYXJpIGNhbm5vdCBsb2FkIGFueSBwYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwOTM3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y MzQxMzg1OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBNYWtlIHN1cmUgd2UgdXNlIHRoZSBjdXJyZW50ICJkZWZlcnNMb2FkaW5nIiBzdGF0ZSBpbnN0 ZWFkIG9mIHRoZQorICAgICAgICBvcmlnaW5hbCBvbmUgd2hlbiBjb25zdHJ1Y3RpbmcgLyBpbml0 aWFsaXppbmcgdGhlIE5ldHdvcmtMb2FkLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0 d29ya1Jlc291cmNlTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Jlc291cmNl TG9hZGVyOjpzdGFydE5ldHdvcmtMb2FkKToKKwogMjAxNS0xMS0wNSAgUnl1YW4gQ2hvaSAgPHJ5 dWFuLmNob2lAbmF2ZXJjb3JwLmNvbT4KIAogICAgICAgICBbRUZMXSBBZGQgdHJ5X2Nsb3NlIEFQ SSB0byBoYW5kbGUgYmVmb3JldW5sb2FkIGV2ZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwIGIvU291cmNlL1dlYktp dDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAppbmRleCA5NWVhYTFj MjZjZGQ5ZGM3MzFhODU4YWZhMDhlM2QxNDYwMWY5YWY1Li5jMzU4MjFjODI1YTU5ZjU1ZTM2ZDE1 ZjBkOWU2OWE3ODIwOTc3YjAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJv Y2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdv cmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAKQEAgLTE3Myw2ICsxNzMsNyBAQCB2 b2lkIE5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6c3RhcnROZXR3b3JrTG9hZChjb25zdCBPcHRpb25h bDxSZXNvdXJjZVJlcXVlc3Q+JiB1cAogI2VuZGlmCiAKICAgICBOZXR3b3JrTG9hZFBhcmFtZXRl cnMgcGFyYW1ldGVycyA9IG1fcGFyYW1ldGVyczsKKyAgICBwYXJhbWV0ZXJzLmRlZmVyc0xvYWRp bmcgPSBtX2RlZmVyc0xvYWRpbmc7CiAgICAgaWYgKHVwZGF0ZWRSZXF1ZXN0KQogICAgICAgICBw YXJhbWV0ZXJzLnJlcXVlc3QgPSB1cGRhdGVkUmVxdWVzdC52YWx1ZSgpOwogICAgIG1fbmV0d29y a0xvYWQgPSBzdGQ6Om1ha2VfdW5pcXVlPE5ldHdvcmtMb2FkPigqdGhpcywgcGFyYW1ldGVycyk7 Cg== 264872 2015-11-05 11:22:38 -0800 2015-11-05 12:38:19 -0800 Regression test bug-150937-20151105112139.patch text/plain 2560 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMDYwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2NkY2M1NjM1MTVmMjg2MDgzM2Q3 N2E4MTk5NDljNTQ3OTRhYTk3MS4uZWM3YzQ2MzdlNWRmMDdiYWI1NTZjNWZhZmFlZTM0NjBlZDVj ZjQ0YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTExLTA1ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHJlZ3Jlc3Npb24gdGVzdCBmb3IgQnVnIDE1 MDkzNworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUw OTM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRk IHJlZ3Jlc3Npb24gdGVzdCBmb3IgQnVnIDE1MDkzNzoKKyAgICAgICAgUmVncmVzc2lvbihyMTky MDM4KTogU2FmYXJpIGNhbm5vdCBsb2FkIGFueSBwYWdlcworCisgICAgICAgIFRoZSBuZXcgdGVz dCBtYWtlcyBzdXJlIHRoYXQgbG9hZCBkZWZlcnJpbmcgd29ya3MgYXMgaW50ZW5kZWQuIFRoZSBm aXgKKyAgICAgICAgZm9yIHRoaXMgYWxyZWFkeSBsYW5kZWQgaW4gcjE5MjA2MC4KKworICAgICAg ICAqIGxvYWRlci9sb2FkLWRlZmVyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogbG9h ZGVyL2xvYWQtZGVmZXIuaHRtbDogQWRkZWQuCisKIDIwMTUtMTEtMDUgIFJ5YW4gSGFkZGFkICA8 cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAgTWFya2luZyBodHRwL3Rlc3RzL2NvbnRl bnRleHRlbnNpb25zL2FzeW5jLXhoci1vbmVycm9yLmh0bWwgYXMgZmxha3kgb24gbWFjLXdrMgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbG9hZGVyL2xvYWQtZGVmZXItZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvbG9hZGVyL2xvYWQtZGVmZXItZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjNm YzlhZTg1NjEwZjhjY2ZlMjA1YTM1ZmVhZWJhNWQ2NmJjMzk5OTgKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9sb2FkZXIvbG9hZC1kZWZlci1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwz IEBACitBTEVSVDogVGVzdCB0aGF0IGxvYWQgZGVmZXJyaW5nIHdvcmtzIGFzIGludGVuZGVkLgor QUxFUlQ6IFBBU1M6IFRoZSBmcmFtZSBsb2FkZWQgYWZ0ZXIgbG9hZHMgd2VyZSByZXN1bWVkLgor CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9sb2FkZXIvbG9hZC1kZWZlci5odG1sIGIvTGF5b3V0 VGVzdHMvbG9hZGVyL2xvYWQtZGVmZXIuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45Y2M4ZGQ1NzcwOTI3YjY0 ZjI5YjllNjc0ZWM2MDk1NTJlNTA0N2YwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv bG9hZGVyL2xvYWQtZGVmZXIuaHRtbApAQCAtMCwwICsxLDQ2IEBACis8IURPQ1RZUEUgaHRtbD4K KzxodG1sPgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgIHRlc3RSdW5u ZXIuZHVtcEFzVGV4dCgpOworICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworfQorCit2 YXIgdGVzdEZyYW1lOworCitmdW5jdGlvbiBsb2FkZWRUb29FYXJseSgpCit7CisgICAgYWxlcnQo IkZBSUw6IFRoZSBmcmFtZSBsb2FkZWQgd2hpbGUgbG9hZHMgd2VyZSBkZWZlcnJlZC4iKTsKKyAg ICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKK30KKworZnVuY3Rpb24gcGFzc0FuZEZpbmlzaCgp Cit7CisgICAgYWxlcnQoIlBBU1M6IFRoZSBmcmFtZSBsb2FkZWQgYWZ0ZXIgbG9hZHMgd2VyZSBy ZXN1bWVkLiIpOworICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworfQorCitmdW5jdGlvbiBy ZXN1bWVMb2FkcygpCit7CisgICAgdGVzdEZyYW1lLm9ubG9hZCA9IHBhc3NBbmRGaW5pc2g7Cisg ICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVyLnNldERlZmVyc0xv YWRpbmcoZmFsc2UpOworfQorCitmdW5jdGlvbiBydW5UZXN0KCkKK3sKKyAgICBhbGVydCgiVGVz dCB0aGF0IGxvYWQgZGVmZXJyaW5nIHdvcmtzIGFzIGludGVuZGVkLiIpOworICAgIGlmICh3aW5k b3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5zZXREZWZlcnNMb2FkaW5nKHRydWUp OworCisgICAgdGVzdEZyYW1lID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaWZyYW1lIik7Cisg ICAgdGVzdEZyYW1lLm9ubG9hZCA9IGxvYWRlZFRvb0Vhcmx5OworICAgIHRlc3RGcmFtZS5zcmMg PSAicmVzb3VyY2VzL2ltYWdlcy5odG1sIjsKKyAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxk KHRlc3RGcmFtZSk7CisgICAgc2V0VGltZW91dChyZXN1bWVMb2FkcywgMTAwKTsKK30KKworPC9z Y3JpcHQ+Cis8Ym9keSBvbmxvYWQ9J3J1blRlc3QoKSc+Cis8L2JvZHk+Cis8L2h0bWw+Cg==