150918 2015-11-04 19:02:32 -0800 Web Inspector: Load markers persist in timeline ruler after resetting recording 2015-11-04 20:10:23 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1139516 0 mattbaker 2015-11-04 19:02:32 -0800 * SUMMARY Load markers persist in timeline ruler after resetting recording. This doesn't apply to the current time marker, which is correctly reset to time zero. * STEPS TO REPRODUCE 1. Inspector -> Timelines 2. Record a page reload 3. Stop the recording once the blue and red load markers appear (or let it stop on its own) 4. Reset the recording (Click the trashcan icon) => Current time marker resets to zero, but load markers remain 1139517 1 webkit-bug-importer 2015-11-04 19:03:01 -0800 <rdar://problem/23406324> 1139518 2 264834 mattbaker 2015-11-04 19:06:06 -0800 Created attachment 264834 [Patch] Proposed Fix 1139525 3 264834 joepeck 2015-11-04 19:19:05 -0800 Comment on attachment 264834 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=264834&action=review r=me > Source/WebInspectorUI/ChangeLog:11 > + (WebInspector.OverviewTimelineView.prototype._recordingReset): > + Clears ruler markers on recording reset. Adds current time marker back. Good find! When is the recording reset? Only the clear button and initial load? Is there any other way? 1139535 4 264834 commit-queue 2015-11-04 20:10:19 -0800 Comment on attachment 264834 [Patch] Proposed Fix Clearing flags on attachment: 264834 Committed r192050: <http://trac.webkit.org/changeset/192050> 1139536 5 commit-queue 2015-11-04 20:10:23 -0800 All reviewed patches have been landed. Closing bug. 264834 2015-11-04 19:06:06 -0800 2015-11-04 20:10:19 -0800 [Patch] Proposed Fix bug-150918-20151104190507.patch text/plain 4982 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5 M2YzMTM1MWNkMWUyYmUyNDE2NDc0MTljOTZjYzYzNTU5NTBkZGU3Li5mMDJhMDM3ZjcxOTlkYTgx MmM4ODRhMTVhNDRmNjk1NTkyOWJjNDk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxNS0xMS0wNCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTG9hZCBtYXJrZXJzIHBlcnNpc3QgaW4gdGltZWxp bmUgcnVsZXIgYWZ0ZXIgcmVzZXR0aW5nIHJlY29yZGluZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwOTE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL092ZXJ2aWV3 VGltZWxpbmVWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk92ZXJ2aWV3VGltZWxpbmVW aWV3KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5PdmVydmlld1RpbWVsaW5lVmlldy5wcm90b3R5 cGUuX3JlY29yZGluZ1Jlc2V0KToKKyAgICAgICAgQ2xlYXJzIHJ1bGVyIG1hcmtlcnMgb24gcmVj b3JkaW5nIHJlc2V0LiBBZGRzIGN1cnJlbnQgdGltZSBtYXJrZXIgYmFjay4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVPdmVydmlldy5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGlu ZU92ZXJ2aWV3LnByb3RvdHlwZS5fcmVjb3JkaW5nUmVzZXQpOgorICAgICAgICBDbGVhcnMgcnVs ZXIgbWFya2VycyBvbiByZWNvcmRpbmcgcmVzZXQuIEFkZHMgY3VycmVudCB0aW1lIG1hcmtlciBi YWNrLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJ1bGVyLmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUnVsZXIucHJvdG90eXBlLmNsZWFyTWFya2Vy cyk6CisgICAgICAgIEFkZGVkIG1ldGhvZCB0byBjbGVhciBtYXJrZXJzIGFuZCBtYXJrZXIgZWxl bWVudHMuCisKIDIwMTUtMTEtMDQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBXZWJJbnNwZWN0b3IuQ29sb3Igc2hvdWxkIHN1 cHBvcnQgI3JnYmEgYW5kICNycmdnYmJhYSBzeW50YXgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL092ZXJ2aWV3VGltZWxpbmVWaWV3LmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT3ZlcnZpZXdUaW1lbGlu ZVZpZXcuanMKaW5kZXggOGM4YTNkNWI0Y2NmNGUzZjJjMzFkMGNjNWE0MjRhM2UxZmFmZmZiNS4u ZWRmZDQ0YjM1MTExZGJjYmY4MjE1MmViOTMzODExODBjZTdjYzE0NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT3ZlcnZpZXdUaW1lbGluZVZp ZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT3Zl cnZpZXdUaW1lbGluZVZpZXcuanMKQEAgLTU1LDYgKzU1LDcgQEAgV2ViSW5zcGVjdG9yLk92ZXJ2 aWV3VGltZWxpbmVWaWV3ID0gY2xhc3MgT3ZlcnZpZXdUaW1lbGluZVZpZXcgZXh0ZW5kcyBXZWJJ bnNwZWMKIAogICAgICAgICByZWNvcmRpbmcuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3Iu VGltZWxpbmVSZWNvcmRpbmcuRXZlbnQuU291cmNlQ29kZVRpbWVsaW5lQWRkZWQsIHRoaXMuX3Nv dXJjZUNvZGVUaW1lbGluZUFkZGVkLCB0aGlzKTsKICAgICAgICAgcmVjb3JkaW5nLmFkZEV2ZW50 TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5nLkV2ZW50Lk1hcmtlckFkZGVk LCB0aGlzLl9tYXJrZXJBZGRlZCwgdGhpcyk7CisgICAgICAgIHJlY29yZGluZy5hZGRFdmVudExp c3RlbmVyKFdlYkluc3BlY3Rvci5UaW1lbGluZVJlY29yZGluZy5FdmVudC5SZXNldCwgdGhpcy5f cmVjb3JkaW5nUmVzZXQsIHRoaXMpOwogCiAgICAgICAgIHRoaXMuX3BlbmRpbmdSZXByZXNlbnRl ZE9iamVjdHMgPSBbXTsKICAgICB9CkBAIC0zNjMsNCArMzY0LDEwIEBAIFdlYkluc3BlY3Rvci5P dmVydmlld1RpbWVsaW5lVmlldyA9IGNsYXNzIE92ZXJ2aWV3VGltZWxpbmVWaWV3IGV4dGVuZHMg V2ViSW5zcGVjCiAgICAgewogICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhX ZWJJbnNwZWN0b3IuQ29udGVudFZpZXcuRXZlbnQuU2VsZWN0aW9uUGF0aENvbXBvbmVudHNEaWRD aGFuZ2UpOwogICAgIH0KKworICAgIF9yZWNvcmRpbmdSZXNldChldmVudCkKKyAgICB7CisgICAg ICAgIHRoaXMuX3RpbWVsaW5lUnVsZXIuY2xlYXJNYXJrZXJzKCk7CisgICAgICAgIHRoaXMuX3Rp bWVsaW5lUnVsZXIuYWRkTWFya2VyKHRoaXMuX2N1cnJlbnRUaW1lTWFya2VyKTsKKyAgICB9CiB9 OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGltZWxpbmVPdmVydmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1RpbWVsaW5lT3ZlcnZpZXcuanMKaW5kZXggYmRjOTBkYjUxNzllNjA5N2U0YjJmOTQ2 NjVjYjkyODkzYTBmNzRkNS4uZDVlZTFiYzQ0ZDBiMGMxZjRmMjc0N2U0NDExM2RjODU1NzMzMzk4 NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGltZWxpbmVPdmVydmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9UaW1lbGluZU92ZXJ2aWV3LmpzCkBAIC0zMyw2ICszMyw3IEBAIFdlYkluc3Bl Y3Rvci5UaW1lbGluZU92ZXJ2aWV3ID0gY2xhc3MgVGltZWxpbmVPdmVydmlldyBleHRlbmRzIFdl Ykluc3BlY3Rvci5PYmplCiAgICAgICAgIHRoaXMuX3JlY29yZGluZy5hZGRFdmVudExpc3RlbmVy KFdlYkluc3BlY3Rvci5UaW1lbGluZVJlY29yZGluZy5FdmVudC5UaW1lbGluZUFkZGVkLCB0aGlz Ll90aW1lbGluZUFkZGVkLCB0aGlzKTsKICAgICAgICAgdGhpcy5fcmVjb3JkaW5nLmFkZEV2ZW50 TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5nLkV2ZW50LlRpbWVsaW5lUmVt b3ZlZCwgdGhpcy5fdGltZWxpbmVSZW1vdmVkLCB0aGlzKTsKICAgICAgICAgdGhpcy5fcmVjb3Jk aW5nLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5nLkV2ZW50 Lk1hcmtlckFkZGVkLCB0aGlzLl9tYXJrZXJBZGRlZCwgdGhpcyk7CisgICAgICAgIHRoaXMuX3Jl Y29yZGluZy5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5UaW1lbGluZVJlY29yZGluZy5F dmVudC5SZXNldCwgdGhpcy5fcmVjb3JkaW5nUmVzZXQsIHRoaXMpOwogCiAgICAgICAgIHRoaXMu X2VsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAgICAgICAgdGhpcy5f ZWxlbWVudC5jbGFzc0xpc3QuYWRkKCJ0aW1lbGluZS1vdmVydmlldyIsIGlkZW50aWZpZXIpOwpA QCAtNTQzLDYgKzU0NCwxMiBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVPdmVydmlldyA9IGNsYXNz IFRpbWVsaW5lT3ZlcnZpZXcgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZQogICAgICAgICB0aGlz LnNlbGVjdGlvblN0YXJ0VGltZSA9IHRoaXMuX2RlZmF1bHRTZXR0aW5nc1ZhbHVlcy5zZWxlY3Rp b25TdGFydFZhbHVlOwogICAgICAgICB0aGlzLnNlbGVjdGlvbkR1cmF0aW9uID0gdGhpcy5fZGVm YXVsdFNldHRpbmdzVmFsdWVzLnNlbGVjdGlvbkR1cmF0aW9uOwogICAgIH0KKworICAgIF9yZWNv cmRpbmdSZXNldChldmVudCkKKyAgICB7CisgICAgICAgIHRoaXMuX3RpbWVsaW5lUnVsZXIuY2xl YXJNYXJrZXJzKCk7CisgICAgICAgIHRoaXMuX3RpbWVsaW5lUnVsZXIuYWRkTWFya2VyKHRoaXMu X2N1cnJlbnRUaW1lTWFya2VyKTsKKyAgICB9CiB9OwogCiBXZWJJbnNwZWN0b3IuVGltZWxpbmVP dmVydmlldy5TY3JvbGxEZWx0YURlbm9taW5hdG9yID0gNTAwOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSdWxlci5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUnVsZXIuanMK aW5kZXggMjNkZDIwZTc5YmUxMTZmZTViMTNhMDU0ZjE0OWI3ODM3NDMzMDBkMi4uOGE0MWM2MDE4 ZmZjY2E4YzBkYjU0Nzk2ODY3ZDQ2NjI1NmI0OTRiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSdWxlci5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJ1bGVyLmpzCkBA IC0zMjksNiArMzI5LDE0IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVJ1bGVyID0gY2xhc3MgVGlt ZWxpbmVSdWxlciBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAgICAgICAgdGhpcy5fbmVl ZHNNYXJrZXJMYXlvdXQoKTsKICAgICB9CiAKKyAgICBjbGVhck1hcmtlcnMoKQorICAgIHsKKyAg ICAgICAgZm9yIChsZXQgbWFya2VyRWxlbWVudCBvZiB0aGlzLl9tYXJrZXJFbGVtZW50TWFwLnZh bHVlcygpKQorICAgICAgICAgICAgbWFya2VyRWxlbWVudC5yZW1vdmUoKTsKKworICAgICAgICB0 aGlzLl9tYXJrZXJFbGVtZW50TWFwLmNsZWFyKCk7CisgICAgfQorCiAgICAgZWxlbWVudEZvck1h cmtlcihtYXJrZXIpCiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5fbWFya2VyRWxlbWVudE1h cC5nZXQobWFya2VyKSB8fCBudWxsOwo=