150916 2015-11-04 17:17:01 -0800 Web Inspector: ⌥⌘C sometimes ends ups up opening inspector without console prompt focused 2015-11-05 11:36:20 -0800 1 1 1 Unclassified WebKit Web Inspector Other All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1139500 0 joepeck 2015-11-04 17:17:01 -0800 * SUMMARY ⌥⌘C sometimes ends ups up opening inspector without console prompt focused. * STEPS TO REPRODUCE 1. Open this page 2. Develop > Show Error Console (⌥⌘C) => Console prompt not focused * NOTES - It appears as if even though we explicitly focused the console prompt it was getting blurred later - It looks like when the document becomesFirstResponder it sets the initial focus element, after blurring whatever was focused (lldb) bt * thread #1: tid = 0x3a6f0f, 0x000000010a46ac04 WebCore`WebCore::Document::setFocusedElement(WTF::PassRefPtr<WebCore::Element>, WebCore::FocusDirection) [inlined] WebCore::Element* std::exchange<WebCore::Element*, std::nullptr_t>(t=0x00007fff5b8a45f0) at StdLibExtras.h:358, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1 * frame #0: 0x000000010a46ac04 WebCore`WebCore::Document::setFocusedElement(WTF::PassRefPtr<WebCore::Element>, WebCore::FocusDirection) [inlined] WebCore::Element* std::exchange<WebCore::Element*, std::nullptr_t>(t=0x00007fff5b8a45f0) at StdLibExtras.h:358 frame #1: 0x000000010a46ac04 WebCore`WebCore::Document::setFocusedElement(WTF::PassRefPtr<WebCore::Element>, WebCore::FocusDirection) [inlined] WTF::PassRefPtr<WebCore::Element>::leakRef(this=0x00007fff5b8a45f0) const at PassRefPtr.h:96 frame #2: 0x000000010a46ac04 WebCore`WebCore::Document::setFocusedElement(WTF::PassRefPtr<WebCore::Element>, WebCore::FocusDirection) [inlined] WTF::RefPtr<WebCore::Element>::RefPtr<WebCore::Element>(o=0x00007fff5b8a45f0) at RefPtr.h:103 frame #3: 0x000000010a46ac04 WebCore`WebCore::Document::setFocusedElement(WTF::PassRefPtr<WebCore::Element>, WebCore::FocusDirection) [inlined] WTF::RefPtr<WebCore::Element>::RefPtr<WebCore::Element>(o=0x00007fff5b8a45f0) at RefPtr.h:104 frame #4: 0x000000010a46ac04 WebCore`WebCore::Document::setFocusedElement(this=0x000000010f53ef40, prpNewFocusedElement=PassRefPtr<WebCore::Element> at 0x00007fff5b8a45f0, direction=FocusDirectionNone) + 20 at Document.cpp:3696 frame #5: 0x00000001089859dd WebKit`WebKit::WebPage::setInitialFocus(this=0x00007fdbcd067210, forward=true, isKeyboardEventValid=false, event=0x00007fff5b8a4640, callbackID=5) + 91 at WebPage.cpp:2327 frame #6: 0x00000001089a0edf WebKit`void IPC::handleMessage<Messages::WebPage::SetInitialFocus, WebKit::WebPage, void (WebKit::WebPage::*)(bool, bool, WebKit::WebKeyboardEvent const&, unsigned long long)>(IPC::MessageDecoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(bool, bool, WebKit::WebKeyboardEvent const&, unsigned long long)) [inlined] void IPC::callMemberFunction<WebKit::WebPage, void (WebKit::WebPage::*)(bool, bool, WebKit::WebKeyboardEvent const&, unsigned long long), std::__1::tuple<bool, bool, WebKit::WebKeyboardEvent, unsigned long long>, std::make_index_sequence<4ul> >(object=<unavailable>, function=<unavailable>)(bool, bool, WebKit::WebKeyboardEvent const&, unsigned long long)) + 103 at HandleMessage.h:22 frame #7: 0x00000001089a0ed1 WebKit`void IPC::handleMessage<Messages::WebPage::SetInitialFocus, WebKit::WebPage, void (WebKit::WebPage::*)(bool, bool, WebKit::WebKeyboardEvent const&, unsigned long long)>(decoder=<unavailable>, object=<unavailable>, function=<unavailable>)(bool, bool, WebKit::WebKeyboardEvent const&, unsigned long long)) + 89 at HandleMessage.h:92 frame #8: 0x000000010883bf03 WebKit`IPC::MessageReceiverMap::dispatchMessage(this=<unavailable>, connection=0x000000010cefd000, decoder=0x000000011d355440) + 113 at MessageReceiverMap.cpp:102 1139501 1 webkit-bug-importer 2015-11-04 17:17:36 -0800 <rdar://problem/23404951> 1139502 2 264830 joepeck 2015-11-04 17:19:41 -0800 Created attachment 264830 [PATCH] Proposed Fix 1139508 3 264832 joepeck 2015-11-04 17:37:28 -0800 Created attachment 264832 [PATCH] Proposed Fix 1139686 4 264832 commit-queue 2015-11-05 11:36:16 -0800 Comment on attachment 264832 [PATCH] Proposed Fix Clearing flags on attachment: 264832 Committed r192065: <http://trac.webkit.org/changeset/192065> 1139687 5 commit-queue 2015-11-05 11:36:20 -0800 All reviewed patches have been landed. Closing bug. 264830 2015-11-04 17:19:41 -0800 2015-11-04 17:37:28 -0800 [PATCH] Proposed Fix console-prompt.patch text/plain 2505 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGFiODNlYzkuLmM3ZjA1ZjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE1LTExLTA0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog4oyl4oyY QyBzb21ldGltZXMgZW5kcyB1cHMgdXAgb3BlbmluZyBpbnNwZWN0b3Igd2l0aG91dCBjb25zb2xl IHByb21wdCBmb2N1c2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTA5MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXaGVuIGZpcnN0IG9wZW5pbmcgdGhlIGluc3BlY3RvciB3ZSBoaWRlIHRoZSB3aW5k b3cgdW50aWwgdGhlIGRvY3VtZW50CisgICAgICAgIGlzIG1vc3RseSByZWFkeSAvIGxvYWRlZC4g SG93ZXZlciBvbmNlIGRpc3BsYXlpbmcgdGhlIHdpbmRvdyBXSzIgd291bGQKKyAgICAgICAgc2V0 IHRoZSBpbml0aWFsIGZvY3VzLCBjbGVhcmluZyB3aGF0IHdlIGFscmVhZHkgaGFkIGFuZCBmb2N1 c2luZyB0aGUKKyAgICAgICAgZmlyc3QgbmF0dXJhbCBlbGVtZW50ICh0YWJpbmRleCBkaWN0YXRl cyB0aGUgdG9vbGJhcikuIFdvcmthcm91bmQgdGhpcworICAgICAgICBieSBkZXRlY3Rpbmcgd2hl biB0aGUgZG9jdW1lbnQgYmVjb21lcyB2aXNpYmxlIGFuZCB0aGVuIGZvY3VzaW5nIHRoZQorICAg ICAgICBjb25zb2xlIHByb21wdC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvUHJvdG9jb2wv SW5zcGVjdG9yRnJvbnRlbmRBUEkuanM6CisgICAgICAgIChJbnNwZWN0b3JGcm9udGVuZEFQSS5z aG93Q29uc29sZSk6CisgICAgICAgIChJbnNwZWN0b3JGcm9udGVuZEFQSS5oYW5kbGVFdmVudCk6 CisKKzIwMTUtMTEtMDQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBXZWJJbnNwZWN0b3IuQ29sb3Igc2hvdWxkIHN1cHBvcnQg I3JnYmEgYW5kICNycmdnYmJhYSBzeW50YXgKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1MDg5NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9JbnNwZWN0b3JGcm9udGVuZEFQSS5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvckZyb250 ZW5kQVBJLmpzCmluZGV4IDQzNWFlZDAuLmJmY2U5ZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvckZyb250ZW5kQVBJLmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3Bl Y3RvckZyb250ZW5kQVBJLmpzCkBAIC03NCwxNSArNzQsMTggQEAgSW5zcGVjdG9yRnJvbnRlbmRB UEkgPSB7CiAgICAgICAgIC8vIElmIHRoZSBwYWdlIGlzIHN0aWxsIGxvYWRpbmcsIGZvY3VzIHRo ZSBxdWljayBjb25zb2xlIGFnYWluIGFmdGVyIHRhYmluZGV4IGF1dG9mb2N1cy4KICAgICAgICAg aWYgKGRvY3VtZW50LnJlYWR5U3RhdGUgIT09ICJjb21wbGV0ZSIpCiAgICAgICAgICAgICBkb2N1 bWVudC5hZGRFdmVudExpc3RlbmVyKCJyZWFkeXN0YXRlY2hhbmdlIiwgdGhpcyk7CisgICAgICAg IGlmIChkb2N1bWVudC52aXNpYmlsaXR5U3RhdGUgIT09ICJ2aXNpYmxlIikKKyAgICAgICAgICAg IGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoInZpc2liaWxpdHljaGFuZ2UiLCB0aGlzKTsgIAog ICAgIH0sCiAKICAgICBoYW5kbGVFdmVudDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewotICAgICAg ICBjb25zb2xlLmFzc2VydChldmVudC50eXBlID09PSAicmVhZHlzdGF0ZWNoYW5nZSIpOworICAg ICAgICBjb25zb2xlLmFzc2VydChldmVudC50eXBlID09PSAicmVhZHlzdGF0ZWNoYW5nZSIgfHwg ZXZlbnQudHlwZSA9PT0gInJlYWR5c3RhdGVjaGFuZ2UiKTsKIAotICAgICAgICBpZiAoZG9jdW1l bnQucmVhZHlTdGF0ZSA9PT0gImNvbXBsZXRlIikgeworICAgICAgICBpZiAoZG9jdW1lbnQucmVh ZHlTdGF0ZSA9PT0gImNvbXBsZXRlIiAmJiBkb2N1bWVudC52aXNpYmlsaXR5U3RhdGUgPT09ICJ2 aXNpYmxlIikgewogICAgICAgICAgICAgV2ViSW5zcGVjdG9yLnF1aWNrQ29uc29sZS5wcm9tcHQu Zm9jdXMoKTsKICAgICAgICAgICAgIGRvY3VtZW50LnJlbW92ZUV2ZW50TGlzdGVuZXIoInJlYWR5 c3RhdGVjaGFuZ2UiLCB0aGlzKTsKKyAgICAgICAgICAgIGRvY3VtZW50LnJlbW92ZUV2ZW50TGlz dGVuZXIoInZpc2liaWxpdHljaGFuZ2UiLCB0aGlzKTsKICAgICAgICAgfQogICAgIH0sCiAK 264832 2015-11-04 17:37:28 -0800 2015-11-05 11:36:16 -0800 [PATCH] Proposed Fix better2.patch text/plain 2505 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGFiODNlYzkuLmM3ZjA1ZjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE1LTExLTA0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog4oyl4oyY QyBzb21ldGltZXMgZW5kcyB1cHMgdXAgb3BlbmluZyBpbnNwZWN0b3Igd2l0aG91dCBjb25zb2xl IHByb21wdCBmb2N1c2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTA5MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXaGVuIGZpcnN0IG9wZW5pbmcgdGhlIGluc3BlY3RvciB3ZSBoaWRlIHRoZSB3aW5k b3cgdW50aWwgdGhlIGRvY3VtZW50CisgICAgICAgIGlzIG1vc3RseSByZWFkeSAvIGxvYWRlZC4g SG93ZXZlciBvbmNlIGRpc3BsYXlpbmcgdGhlIHdpbmRvdyBXSzIgd291bGQKKyAgICAgICAgc2V0 IHRoZSBpbml0aWFsIGZvY3VzLCBjbGVhcmluZyB3aGF0IHdlIGFscmVhZHkgaGFkIGFuZCBmb2N1 c2luZyB0aGUKKyAgICAgICAgZmlyc3QgbmF0dXJhbCBlbGVtZW50ICh0YWJpbmRleCBkaWN0YXRl cyB0aGUgdG9vbGJhcikuIFdvcmthcm91bmQgdGhpcworICAgICAgICBieSBkZXRlY3Rpbmcgd2hl biB0aGUgZG9jdW1lbnQgYmVjb21lcyB2aXNpYmxlIGFuZCB0aGVuIGZvY3VzaW5nIHRoZQorICAg ICAgICBjb25zb2xlIHByb21wdC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvUHJvdG9jb2wv SW5zcGVjdG9yRnJvbnRlbmRBUEkuanM6CisgICAgICAgIChJbnNwZWN0b3JGcm9udGVuZEFQSS5z aG93Q29uc29sZSk6CisgICAgICAgIChJbnNwZWN0b3JGcm9udGVuZEFQSS5oYW5kbGVFdmVudCk6 CisKKzIwMTUtMTEtMDQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBXZWJJbnNwZWN0b3IuQ29sb3Igc2hvdWxkIHN1cHBvcnQg I3JnYmEgYW5kICNycmdnYmJhYSBzeW50YXgKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1MDg5NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9JbnNwZWN0b3JGcm9udGVuZEFQSS5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvckZyb250 ZW5kQVBJLmpzCmluZGV4IDQzNWFlZDAuLjBjNmVhNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvckZyb250ZW5kQVBJLmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3Bl Y3RvckZyb250ZW5kQVBJLmpzCkBAIC03NCwxNSArNzQsMTggQEAgSW5zcGVjdG9yRnJvbnRlbmRB UEkgPSB7CiAgICAgICAgIC8vIElmIHRoZSBwYWdlIGlzIHN0aWxsIGxvYWRpbmcsIGZvY3VzIHRo ZSBxdWljayBjb25zb2xlIGFnYWluIGFmdGVyIHRhYmluZGV4IGF1dG9mb2N1cy4KICAgICAgICAg aWYgKGRvY3VtZW50LnJlYWR5U3RhdGUgIT09ICJjb21wbGV0ZSIpCiAgICAgICAgICAgICBkb2N1 bWVudC5hZGRFdmVudExpc3RlbmVyKCJyZWFkeXN0YXRlY2hhbmdlIiwgdGhpcyk7CisgICAgICAg IGlmIChkb2N1bWVudC52aXNpYmlsaXR5U3RhdGUgIT09ICJ2aXNpYmxlIikKKyAgICAgICAgICAg IGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoInZpc2liaWxpdHljaGFuZ2UiLCB0aGlzKTsgIAog ICAgIH0sCiAKICAgICBoYW5kbGVFdmVudDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewotICAgICAg ICBjb25zb2xlLmFzc2VydChldmVudC50eXBlID09PSAicmVhZHlzdGF0ZWNoYW5nZSIpOworICAg ICAgICBjb25zb2xlLmFzc2VydChldmVudC50eXBlID09PSAicmVhZHlzdGF0ZWNoYW5nZSIgfHwg ZXZlbnQudHlwZSA9PT0gInZpc2liaWxpdHljaGFuZ2UiKTsKIAotICAgICAgICBpZiAoZG9jdW1l bnQucmVhZHlTdGF0ZSA9PT0gImNvbXBsZXRlIikgeworICAgICAgICBpZiAoZG9jdW1lbnQucmVh ZHlTdGF0ZSA9PT0gImNvbXBsZXRlIiAmJiBkb2N1bWVudC52aXNpYmlsaXR5U3RhdGUgPT09ICJ2 aXNpYmxlIikgewogICAgICAgICAgICAgV2ViSW5zcGVjdG9yLnF1aWNrQ29uc29sZS5wcm9tcHQu Zm9jdXMoKTsKICAgICAgICAgICAgIGRvY3VtZW50LnJlbW92ZUV2ZW50TGlzdGVuZXIoInJlYWR5 c3RhdGVjaGFuZ2UiLCB0aGlzKTsKKyAgICAgICAgICAgIGRvY3VtZW50LnJlbW92ZUV2ZW50TGlz dGVuZXIoInZpc2liaWxpdHljaGFuZ2UiLCB0aGlzKTsKICAgICAgICAgfQogICAgIH0sCiAK