150913 2015-11-04 17:04:36 -0800 Web Inspector: Uncaught Exception opening inspector - TypeError: Attempted to assign to readonly property. 2015-11-04 20:08:50 -0800 1 1 1 Unclassified WebKit Web Inspector Other All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1139495 0 joepeck 2015-11-04 17:04:36 -0800 * SUMMARY Uncaught Exception opening inspector - TypeError: Attempted to assign to readonly property. * EXCEPTION TypeError: Attempted to assign to readonly property. replaceContentView — ContentViewContainer.js:229 _resourceTypeDidChange — ResourceClusterContentView.js:248 dispatch — Object.js:155 dispatchEventToListeners — Object.js:162 associateWithScript — Resource.js:653 Script — Script.js:42 scriptDidParse — DebuggerManager.js:531 scriptParsed — DebuggerObserver.js:37 dispatchEvent — InspectorBackend.js:382 _dispatchEvent — InspectorBackend.js:281 dispatch — InspectorBackend.js:89 dispatchNextQueuedMessageFromBackend — MessageDispatcher.js:42 * NOTES BackForwardEntry.js has a "get contentView()" but no "set contentView(x)" so this looks legit. // Replace all occurrences of oldContentView with newContentView in the back/forward list. for (var i = 0; i < this._backForwardList.length; ++i) { if (this._backForwardList[i].contentView === oldContentView) this._backForwardList[i].contentView = newContentView; // <-- attempting to set content view. } 1139496 1 webkit-bug-importer 2015-11-04 17:05:27 -0800 <rdar://problem/23404728> 1139511 2 mattbaker 2015-11-04 18:12:08 -0800 A BackForwardEntry associates a ContentView with a cookie, so having a contentView setter seems like the wrong thing to do. What we probably want is: // Replace all occurrences of oldContentView with newContentView in the back/forward list. for (var i = 0; i < this._backForwardList.length; ++i) { if (this._backForwardList[i].contentView === oldContentView) this._backForwardList[i] = new WebInspector.BackForwardEntry(newContentView, newCookie); } 1139519 3 timothy 2015-11-04 19:09:11 -0800 Looks right to me. Good catch. 1139524 4 264836 mattbaker 2015-11-04 19:18:22 -0800 Created attachment 264836 [Patch] Proposed Fix 1139532 5 264836 commit-queue 2015-11-04 20:08:46 -0800 Comment on attachment 264836 [Patch] Proposed Fix Clearing flags on attachment: 264836 Committed r192049: <http://trac.webkit.org/changeset/192049> 1139533 6 commit-queue 2015-11-04 20:08:50 -0800 All reviewed patches have been landed. Closing bug. 264836 2015-11-04 19:18:22 -0800 2015-11-04 20:08:46 -0800 [Patch] Proposed Fix bug-150913-20151104191724.patch text/plain 2165 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5 M2YzMTM1MWNkMWUyYmUyNDE2NDc0MTljOTZjYzYzNTU5NTBkZGU3Li4xMDQ0NGMxMzhjYmZiYTU4 MmY3NTQzMThkMjFjZmE5YTY5M2EzZDNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNS0xMS0wNCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVnaHQgRXhjZXB0aW9uIG9wZW5pbmcgaW5z cGVjdG9yIC0gVHlwZUVycm9yOiBBdHRlbXB0ZWQgdG8gYXNzaWduIHRvIHJlYWRvbmx5IHByb3Bl cnR5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUw OTEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 IGludmFsaWQgY2FsbCB0byBCYWNrRm9yd2FyZEVudHJ5LnByb3RvdHlwZS5jb250ZW50VmlldyBz ZXQuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRWaWV3Q29udGFpbmVy LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnRlbnRWaWV3Q29udGFpbmVyLnByb3RvdHlw ZS5yZXBsYWNlQ29udGVudFZpZXcpOgorICAgICAgICBSZXBsYWNlIGVhY2ggQmFja0ZvcndhcmRF bnRyeSBtYXRjaGluZyB0aGUgb2xkIGNvbnRlbnQgdmlldyB3aXRoIGEgbmV3IGVudHJ5LgorCiAy MDE1LTExLTA0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogV2ViSW5zcGVjdG9yLkNvbG9yIHNob3VsZCBzdXBwb3J0ICNyZ2Jh IGFuZCAjcnJnZ2JiYWEgc3ludGF4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50Vmlld0NvbnRhaW5lci5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRWaWV3Q29udGFpbmVyLmpzCmlu ZGV4IGE2ZGExZGE0MjIwZDVlYzU2MzdiNGYxYWY1YTc0MDA2ODk0ZjNhZDcuLmQwMDVkMzBlN2M0 MDI1NzNkZTJmNGU0MDExNjQ0OTBmNmE0M2Q5MzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRWaWV3Q29udGFpbmVyLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRWaWV3Q29u dGFpbmVyLmpzCkBAIC0yMjUsOCArMjI1LDEwIEBAIFdlYkluc3BlY3Rvci5Db250ZW50Vmlld0Nv bnRhaW5lciA9IGNsYXNzIENvbnRlbnRWaWV3Q29udGFpbmVyIGV4dGVuZHMgV2ViSW5zcGVjCiAK ICAgICAgICAgLy8gUmVwbGFjZSBhbGwgb2NjdXJyZW5jZXMgb2Ygb2xkQ29udGVudFZpZXcgd2l0 aCBuZXdDb250ZW50VmlldyBpbiB0aGUgYmFjay9mb3J3YXJkIGxpc3QuCiAgICAgICAgIGZvciAo dmFyIGkgPSAwOyBpIDwgdGhpcy5fYmFja0ZvcndhcmRMaXN0Lmxlbmd0aDsgKytpKSB7Ci0gICAg ICAgICAgICBpZiAodGhpcy5fYmFja0ZvcndhcmRMaXN0W2ldLmNvbnRlbnRWaWV3ID09PSBvbGRD b250ZW50VmlldykKLSAgICAgICAgICAgICAgICB0aGlzLl9iYWNrRm9yd2FyZExpc3RbaV0uY29u dGVudFZpZXcgPSBuZXdDb250ZW50VmlldzsKKyAgICAgICAgICAgIGlmICh0aGlzLl9iYWNrRm9y d2FyZExpc3RbaV0uY29udGVudFZpZXcgPT09IG9sZENvbnRlbnRWaWV3KSB7CisgICAgICAgICAg ICAgICAgbGV0IGN1cnJlbnRDb29raWUgPSB0aGlzLl9iYWNrRm9yd2FyZExpc3RbaV0uY29va2ll OworICAgICAgICAgICAgICAgIHRoaXMuX2JhY2tGb3J3YXJkTGlzdFtpXSA9IG5ldyBXZWJJbnNw ZWN0b3IuQmFja0ZvcndhcmRFbnRyeShuZXdDb250ZW50VmlldywgY3VycmVudENvb2tpZSk7Cisg ICAgICAgICAgICB9CiAgICAgICAgIH0KIAogICAgICAgICAvLyBSZS1zaG93IHRoZSBjdXJyZW50 IGVudHJ5LCBiZWNhdXNlIGl0cyBjb250ZW50IHZpZXcgaW5zdGFuY2Ugd2FzIHJlcGxhY2VkLgo=