150900 2015-11-04 12:17:22 -0800 Regression(r188820): Downloads of data URLs is broken 2015-11-14 21:23:16 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Local Build Mac OS X 10.11 RESOLVED FIXED https://jsfiddle.net/58vnsa6c/embedded/result/ InRadar P2 Normal --- 148128 1 gordon_sheridan koivisto ap cdumez commit-queue gordon_sheridan japhet webkit-bug-importer oldest_to_newest 1139400 0 gordon_sheridan 2015-11-04 12:17:22 -0800 As of http://trac.webkit.org/changeset/188820 clicking on a link like this: <a href="data:application/zip;base64,UEsDBAoAAAAAANuBTUefqBf4BAAAAAQAAAAHABwAb25lLnR4dFVUCQADbpAdVjmRHVZ1eAsAAQT2AQAABBQAAABvbmUKUEsBAh4DCgAAAAAA24FNR5+oF/gEAAAABAAAAAcAGAAAAAAAAQAAAKSBAAAAAG9uZS50eHRVVAUAA26QHVZ1eAsAAQT2AQAABBQAAABQSwUGAAAAAAEAAQBNAAAARQAAAAAA">href=data URL</a> ...no longer downloads the data as a file. The r188820 commit was for https://bugs.webkit.org/show_bug.cgi?id=148128 1139416 1 webkit-bug-importer 2015-11-04 13:05:17 -0800 <rdar://problem/23399223> 1139816 2 cdumez 2015-11-05 16:01:19 -0800 Likely a MIME type detection problem? 1139821 3 cdumez 2015-11-05 16:10:06 -0800 (In reply to comment #2) > Likely a MIME type detection problem? Nope, MIME type is correctly detected as application/zip. 1141990 4 265517 koivisto 2015-11-13 16:56:21 -0800 Created attachment 265517 patch 1141991 5 265518 koivisto 2015-11-13 16:57:39 -0800 Created attachment 265518 patch 1142092 6 265518 commit-queue 2015-11-14 21:23:11 -0800 Comment on attachment 265518 patch Clearing flags on attachment: 265518 Committed r192458: <http://trac.webkit.org/changeset/192458> 1142093 7 commit-queue 2015-11-14 21:23:16 -0800 All reviewed patches have been landed. Closing bug. 265517 2015-11-13 16:56:21 -0800 2015-11-13 16:57:39 -0800 patch data-download.patch text/plain 2091 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MjQ1MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTExLTEzICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxODg4MjAp OiBEb3dubG9hZHMgb2YgZGF0YSBVUkxzIGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwOTAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gdGVzdCwgdGhlIGN1cnJlbnQgdGVzdCBpbmZy YXN0cnVjdHVyZSBvbmx5IGFsbG93cyB0ZXN0aW5nIHBvbGljeSBkZWNpc2lvbnMsIG5vdCB0aGUg YWN0dWFsIGRvd25sb2FkLgorCisgICAgICAgICogbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpjb250aW51ZUFmdGVyQ29udGVudFBv bGljeSk6CisKKyAgICAgICAgVXNlIG5vcm1hbCBkb3dubG9hZCBwYXRoIGZvciBkYXRhIFVSTHMg aW5zdGVhZCBvZiB0cnlpbmcgdG8gY29udmVydCB0aGUgbWFpbiByZXNvdXJjZSBsb2FkLgorICAg ICAgICBTaW5jZSB3ZSBkZWNvZGUgZGF0YSBVUkxzIGxvY2FsbHkgdGhlcmUgaXMgbm8gYXNzb2Np YXRlZCByZXNvdXJjZSBsb2FkIG9uIFdlYktpdCBzaWRlLgorCiAyMDE1LTExLTEzICBBbmRlcnMg Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGlkZW50aWZpZXIg c3RyaW5ncyBmb3IgYSBidW5jaCBvZiBjb250ZXh0IG1lbnUgaXRlbXMKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAkocmV2aXNpb24gMTkyNDM3KQorKysgU291 cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NzI3LDcgKzcyNywxMiBAQCB2b2lkIERvY3VtZW50TG9hZGVyOjpjb250aW51ZUFmdGVyQ29udGVu CiAgICAgICAgIC8vIFdoZW4gc3RhcnRpbmcgdGhlIHJlcXVlc3QsIHdlIGRpZG4ndCBrbm93IHRo YXQgaXQgd291bGQgcmVzdWx0IGluIGRvd25sb2FkIGFuZCBub3QgbmF2aWdhdGlvbi4gTm93IHdl IGtub3cgdGhhdCBtYWluIGRvY3VtZW50IFVSTCBkaWRuJ3QgY2hhbmdlLgogICAgICAgICAvLyBE b3dubG9hZCBtYXkgdXNlIHRoaXMga25vd2xlZGdlIGZvciBwdXJwb3NlcyB1bnJlbGF0ZWQgdG8g Y29va2llcywgbm90YWJseSBmb3Igc2V0dGluZyBmaWxlIHF1YXJhbnRpbmUgZGF0YS4KICAgICAg ICAgZnJhbWVMb2FkZXIoKS0+c2V0T3JpZ2luYWxVUkxGb3JEb3dubG9hZFJlcXVlc3QobV9yZXF1 ZXN0KTsKLSAgICAgICAgZnJhbWVMb2FkZXIoKS0+Y2xpZW50KCkuY29udmVydE1haW5SZXNvdXJj ZUxvYWRUb0Rvd25sb2FkKHRoaXMsIG1fcmVxdWVzdCwgbV9yZXNwb25zZSk7CisKKyAgICAgICAg aWYgKG1fcmVxdWVzdC51cmwoKS5wcm90b2NvbElzRGF0YSgpKSB7CisgICAgICAgICAgICAvLyBX ZSBkZWNvZGUgZGF0YSBVUkwgaW50ZXJuYWxseSwgdGhlcmUgaXMgbm8gcmVzb3VyY2UgbG9hZCB0 byBjb252ZXJ0LgorICAgICAgICAgICAgZnJhbWVMb2FkZXIoKS0+Y2xpZW50KCkuc3RhcnREb3du bG9hZChtX3JlcXVlc3QpOworICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIGZyYW1lTG9hZGVy KCktPmNsaWVudCgpLmNvbnZlcnRNYWluUmVzb3VyY2VMb2FkVG9Eb3dubG9hZCh0aGlzLCBtX3Jl cXVlc3QsIG1fcmVzcG9uc2UpOwogCiAgICAgICAgIC8vIEl0IG1pZ2h0IGhhdmUgZ29uZSBtaXNz aW5nCiAgICAgICAgIGlmIChtYWluUmVzb3VyY2VMb2FkZXIoKSkK 265518 2015-11-13 16:57:39 -0800 2015-11-14 21:23:11 -0800 patch data-download-2.patch text/plain 2124 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MjQ1MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTExLTEzICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxODg4MjAp OiBEb3dubG9hZHMgb2YgZGF0YSBVUkxzIGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwOTAwCisgICAgICAgIHJkYXI6Ly9wcm9ibGVt LzIzMzk5MjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTm8gdGVzdCwgdGhlIGN1cnJlbnQgdGVzdCBpbmZyYXN0cnVjdHVyZSBvbmx5IGFsbG93cyB0 ZXN0aW5nIHBvbGljeSBkZWNpc2lvbnMsIG5vdCB0aGUgYWN0dWFsIGRvd25sb2FkLgorCisgICAg ICAgICogbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3Vt ZW50TG9hZGVyOjpjb250aW51ZUFmdGVyQ29udGVudFBvbGljeSk6CisKKyAgICAgICAgVXNlIG5v cm1hbCBkb3dubG9hZCBwYXRoIGZvciBkYXRhIFVSTHMgaW5zdGVhZCBvZiB0cnlpbmcgdG8gY29u dmVydCB0aGUgbWFpbiByZXNvdXJjZSBsb2FkLgorICAgICAgICBTaW5jZSB3ZSBkZWNvZGUgZGF0 YSBVUkxzIGxvY2FsbHkgdGhlcmUgaXMgbm8gYXNzb2NpYXRlZCByZXNvdXJjZSBsb2FkIG9uIFdl YktpdCBzaWRlLgorCiAyMDE1LTExLTEzICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIGlkZW50aWZpZXIgc3RyaW5ncyBmb3IgYSBidW5jaCBvZiBj b250ZXh0IG1lbnUgaXRlbXMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExv YWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9h ZGVyLmNwcAkocmV2aXNpb24gMTkyNDM3KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3Vt ZW50TG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzI3LDcgKzcyNywxMiBAQCB2b2lkIERv Y3VtZW50TG9hZGVyOjpjb250aW51ZUFmdGVyQ29udGVuCiAgICAgICAgIC8vIFdoZW4gc3RhcnRp bmcgdGhlIHJlcXVlc3QsIHdlIGRpZG4ndCBrbm93IHRoYXQgaXQgd291bGQgcmVzdWx0IGluIGRv d25sb2FkIGFuZCBub3QgbmF2aWdhdGlvbi4gTm93IHdlIGtub3cgdGhhdCBtYWluIGRvY3VtZW50 IFVSTCBkaWRuJ3QgY2hhbmdlLgogICAgICAgICAvLyBEb3dubG9hZCBtYXkgdXNlIHRoaXMga25v d2xlZGdlIGZvciBwdXJwb3NlcyB1bnJlbGF0ZWQgdG8gY29va2llcywgbm90YWJseSBmb3Igc2V0 dGluZyBmaWxlIHF1YXJhbnRpbmUgZGF0YS4KICAgICAgICAgZnJhbWVMb2FkZXIoKS0+c2V0T3Jp Z2luYWxVUkxGb3JEb3dubG9hZFJlcXVlc3QobV9yZXF1ZXN0KTsKLSAgICAgICAgZnJhbWVMb2Fk ZXIoKS0+Y2xpZW50KCkuY29udmVydE1haW5SZXNvdXJjZUxvYWRUb0Rvd25sb2FkKHRoaXMsIG1f cmVxdWVzdCwgbV9yZXNwb25zZSk7CisKKyAgICAgICAgaWYgKG1fcmVxdWVzdC51cmwoKS5wcm90 b2NvbElzRGF0YSgpKSB7CisgICAgICAgICAgICAvLyBXZSBkZWNvZGUgZGF0YSBVUkwgaW50ZXJu YWxseSwgdGhlcmUgaXMgbm8gcmVzb3VyY2UgbG9hZCB0byBjb252ZXJ0LgorICAgICAgICAgICAg ZnJhbWVMb2FkZXIoKS0+Y2xpZW50KCkuc3RhcnREb3dubG9hZChtX3JlcXVlc3QpOworICAgICAg ICB9IGVsc2UKKyAgICAgICAgICAgIGZyYW1lTG9hZGVyKCktPmNsaWVudCgpLmNvbnZlcnRNYWlu UmVzb3VyY2VMb2FkVG9Eb3dubG9hZCh0aGlzLCBtX3JlcXVlc3QsIG1fcmVzcG9uc2UpOwogCiAg ICAgICAgIC8vIEl0IG1pZ2h0IGhhdmUgZ29uZSBtaXNzaW5nCiAgICAgICAgIGlmIChtYWluUmVz b3VyY2VMb2FkZXIoKSkK