150896 2015-11-04 10:25:50 -0800 Fix crashing fast-clicking WK2 tests on iOS 2015-11-04 14:22:24 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh commit-queue lforschler simon.fraser webkit-bug-importer oldest_to_newest 1139376 0 wenson_hsieh 2015-11-04 10:25:50 -0800 The two affected tests are fast/events/ios/viewport-device-width-at-initial-scale-fast-clicks.html and css3/touch-action/touch-action-manipulation-fast-clicks.html. Instead of sending rapid-fire single taps and finishing the test when a number of clicks have been detected, we instead fire an amount of taps equal to the number of clicks we expect. 1139377 1 wenson_hsieh 2015-11-04 10:26:39 -0800 <rdar://problem/23344491> 1139411 2 264805 wenson_hsieh 2015-11-04 12:53:30 -0800 Created attachment 264805 Patch 1139438 3 264805 commit-queue 2015-11-04 14:22:20 -0800 Comment on attachment 264805 Patch Clearing flags on attachment: 264805 Committed r192036: <http://trac.webkit.org/changeset/192036> 1139439 4 commit-queue 2015-11-04 14:22:24 -0800 All reviewed patches have been landed. Closing bug. 264805 2015-11-04 12:53:30 -0800 2015-11-04 14:22:20 -0800 Patch bug-150896-20151104125232.patch text/plain 6816 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTNhOTM4YTFjNDZkODA4 ZWI2Y2UwMGE4ZjQwNGMyMDBjNWIyOGVlMy4uNWMxYThjYWY3Mzg1NmNjZDlmMGQzNTZjNDU2OWY3 ZDgyNWJhNGMzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTExLTA0ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBjcmFzaGlu ZyBmYXN0LWNsaWNraW5nIFdLMiB0ZXN0cyBvbiBpT1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDg5NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MjMzNDQ0OTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSW4gb3JkZXIgZm9yIHRoZSBtb2RpZmllZCBmYXN0LWNsaWNraW5nIHRlc3RzIHRvIHBhc3Ms IHdlIGNhbid0IGFsbG93IGhpdC10ZXN0aW5nIHRvCisgICAgICAgIGZpbmQgdGhlIHRhcCBoaWdo bGlnaHQgdmlldy4gU2VlIHRoZSBSYWRhciBmb3IgbW9yZSBVSUtpdC1zcGVjaWZpYyBkZXNjcmlw dGlvbnMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv bi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfc2hvd1RhcEhpZ2hsaWdodF0pOgorCiAy MDE1LTExLTAzICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29j b2FdIEFkZCBTUEkgdG8gd2FybSBhbiBpbml0aWFsIHdlYiBwcm9jZXNzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t CmluZGV4IGQ4MWE3MjYxOWI2ZGVmYjllOGY2YTY0ZGU3NzE1YzFkMWI0NmZmNjUuLmMyYTQyNjBi OGE1ZjkwNTAyMDJiZGMxNGU0ZTJjZjE1M2QyOTYyNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC04 NDUsNiArODQ1LDcgQEAgLSAodm9pZClfc2hvd1RhcEhpZ2hsaWdodAogCiAgICAgaWYgKCFfaGln aGxpZ2h0VmlldykgewogICAgICAgICBfaGlnaGxpZ2h0VmlldyA9IGFkb3B0TlMoW1tfVUlIaWdo bGlnaHRWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOkNHUmVjdFplcm9dKTsKKyAgICAgICAgW19o aWdobGlnaHRWaWV3IHNldFVzZXJJbnRlcmFjdGlvbkVuYWJsZWQ6Tk9dOwogICAgICAgICBbX2hp Z2hsaWdodFZpZXcgc2V0T3BhcXVlOk5PXTsKICAgICAgICAgW19oaWdobGlnaHRWaWV3IHNldENv cm5lclJhZGl1czptaW5pbXVtVGFwSGlnaGxpZ2h0UmFkaXVzXTsKICAgICB9CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDk4 YzU5NTRiMmU5MDA5OGQyMjhhZDhiMjI0MDBlZmUxNWY0ZTI2Mi4uMzFhMDJjM2UxYzdhZTk3MDQ0 YmE1MTg1MzEzMzVhY2UzNWE1MTI4MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTExLTA0 ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBj cmFzaGluZyBmYXN0LWNsaWNraW5nIFdLMiB0ZXN0cyBvbiBpT1MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDg5NgorICAgICAgICA8cmRhcjovL3By b2JsZW0vMjMzNDQ0OTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRml4IHRoZSBmYXN0LWNsaWNraW5nIHRlc3RzIGJ5IG1ha2luZyB0aGVtIGZpcmUg YW4gZXhhY3QgbnVtYmVyIG9mIHRpbWVzIHJhdGhlciB0aGFuCisgICAgICAgIHNlbmRpbmcgY29u dGludW91c2x5IHVudGlsIGEgbWluaW11bSBudW1iZXIgb2YgY2xpY2tzIGFyZSBmaXJlZC4gVGhp cyBjYXVzZXMgdXMgdG8KKyAgICAgICAgYXZvaWQgY3Jhc2hpbmcgZHVyaW5nIHRoZSBmb2xsb3dp bmcgdGVzdCB3aGVuIHRoZSBtYXJrZXIgZXZlbnRzIGNvcnJlc3BvbmRpbmcgdG8gc2luZ2xlCisg ICAgICAgIHRhcHMgZmlyZWQgYWZ0ZXIgdGhlIHRlc3QgaGFzIGNvbXBsZXRlZCBoYXZlIGJlZW4g aGFuZGxlZC4KKworICAgICAgICAqIGNzczMvdG91Y2gtYWN0aW9uL3RvdWNoLWFjdGlvbi1tYW5p cHVsYXRpb24tZmFzdC1jbGlja3MuaHRtbDoKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9pb3Mvdmll d3BvcnQtZGV2aWNlLXdpZHRoLWF0LWluaXRpYWwtc2NhbGUtZmFzdC1jbGlja3MuaHRtbDoKKwog MjAxNS0xMS0wMyAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgQWNj ZXB0IDggYW5kIDQgdmFsdWUgaGV4IGNvbG9ycyAoI1JSR0dCQkFBKQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvY3NzMy90b3VjaC1hY3Rpb24vdG91Y2gtYWN0aW9uLW1hbmlwdWxhdGlvbi1mYXN0 LWNsaWNrcy5odG1sIGIvTGF5b3V0VGVzdHMvY3NzMy90b3VjaC1hY3Rpb24vdG91Y2gtYWN0aW9u LW1hbmlwdWxhdGlvbi1mYXN0LWNsaWNrcy5odG1sCmluZGV4IGI2NTE5ZTc5MjM1MTRiMDcxZjI5 NzJmMjk5ZjE2ZDNjOWRlM2NhYWEuLjViY2M5YTkwNzIyMDZlODgwZTVhMzRmYTk1MDY0ZDI1MmI3 NWZjYmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2NzczMvdG91Y2gtYWN0aW9uL3RvdWNoLWFj dGlvbi1tYW5pcHVsYXRpb24tZmFzdC1jbGlja3MuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9jc3Mz L3RvdWNoLWFjdGlvbi90b3VjaC1hY3Rpb24tbWFuaXB1bGF0aW9uLWZhc3QtY2xpY2tzLmh0bWwK QEAgLTcsMTQgKzcsMjEgQEAKICAgICA8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRl c3QtcHJlLmpzIj48L3NjcmlwdD4KICAgICA8c2NyaXB0IGlkPSJ1aS1zY3JpcHQiIHR5cGU9InRl eHQvcGxhaW4iPgogICAgICAgICAoZnVuY3Rpb24oKSB7Ci0gICAgICAgICAgICBmdW5jdGlvbiBw ZXJmb3JtVGFwKCkgewotICAgICAgICAgICAgICAgIHVpQ29udHJvbGxlci5zaW5nbGVUYXBBdFBv aW50KDIwMCwgMjAwLCBwZXJmb3JtVGFwKTsKKyAgICAgICAgICAgIHZhciBjb3VudCA9IDA7Cisg ICAgICAgICAgICBmdW5jdGlvbiBmaXJlU3VjY2Vzc2l2ZVRhcHMoKSB7CisgICAgICAgICAgICAg ICAgaWYgKGNvdW50IDwgMykKKyAgICAgICAgICAgICAgICAgICAgdWlDb250cm9sbGVyLnNpbmds ZVRhcEF0UG9pbnQoMjAwLCAyMDAsIGZpcmVTdWNjZXNzaXZlVGFwcyk7CisgICAgICAgICAgICAg ICAgZWxzZQorICAgICAgICAgICAgICAgICAgICB1aUNvbnRyb2xsZXIudWlTY3JpcHRDb21wbGV0 ZSgiIik7CisKKyAgICAgICAgICAgICAgICBjb3VudCsrOwogICAgICAgICAgICAgfQotICAgICAg ICAgICAgcGVyZm9ybVRhcCgpOworICAgICAgICAgICAgZmlyZVN1Y2Nlc3NpdmVUYXBzKCk7CiAg ICAgICAgIH0pKCk7CiAgICAgPC9zY3JpcHQ+CiAKICAgICA8c2NyaXB0PgorICAgIHZhciBzY3Jp cHRDb21wbGV0ZWQgPSBmYWxzZTsKICAgICB2YXIgY2xpY2tDb3VudCA9IDA7CiAgICAgaWYgKHdp bmRvdy50ZXN0UnVubmVyKQogICAgICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKQEAg LTI1LDEzICszMiwxNyBAQAogCiAgICAgZnVuY3Rpb24gcnVuVGVzdCgpIHsKICAgICAgICAgaWYg KHRlc3RSdW5uZXIucnVuVUlTY3JpcHQpCi0gICAgICAgICAgICB0ZXN0UnVubmVyLnJ1blVJU2Ny aXB0KGdldFVJU2NyaXB0KCksIGZ1bmN0aW9uKHJlc3VsdCkgeyB9KTsKKyAgICAgICAgICAgIHRl c3RSdW5uZXIucnVuVUlTY3JpcHQoZ2V0VUlTY3JpcHQoKSwgZnVuY3Rpb24ocmVzdWx0KSB7Cisg ICAgICAgICAgICAgICAgc2NyaXB0Q29tcGxldGVkID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICBp ZiAoY2xpY2tDb3VudCA9PSAzKQorICAgICAgICAgICAgICAgICAgICB0ZXN0UnVubmVyLm5vdGlm eURvbmUoKTsKKyAgICAgICAgICAgIH0pOwogICAgIH0KICAgICBmdW5jdGlvbiBoYW5kbGVDbGlj a2VkKCkgewogICAgICAgICBjbGlja0NvdW50Kys7CiAgICAgICAgIGRvY3VtZW50LmJvZHkuYXBw ZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoIkNsaWNrISIpKTsKICAgICAgICAgZG9j dW1lbnQuYm9keS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJiciIpKTsKLSAg ICAgICAgaWYgKGNsaWNrQ291bnQgPT0gMykKKyAgICAgICAgaWYgKGNsaWNrQ291bnQgPT0gMyAm JiBzY3JpcHRDb21wbGV0ZWQpCiAgICAgICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsK ICAgICB9CiAgICAgPC9zY3JpcHQ+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50 cy9pb3Mvdmlld3BvcnQtZGV2aWNlLXdpZHRoLWF0LWluaXRpYWwtc2NhbGUtZmFzdC1jbGlja3Mu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy92aWV3cG9ydC1kZXZpY2Utd2lkdGgt YXQtaW5pdGlhbC1zY2FsZS1mYXN0LWNsaWNrcy5odG1sCmluZGV4IGZmMzczOTFmYTBiNTY1NmMz ZDJmNTg5MDE0YTRlYmJhNjJmZTNlYTcuLmQyMGZlOTYzMGQxNDg0YjZkOGRkNzI0YThiOTI2YzRi MmIzZTE3NWEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy92aWV3cG9y dC1kZXZpY2Utd2lkdGgtYXQtaW5pdGlhbC1zY2FsZS1mYXN0LWNsaWNrcy5odG1sCisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy92aWV3cG9ydC1kZXZpY2Utd2lkdGgtYXQtaW5pdGlh bC1zY2FsZS1mYXN0LWNsaWNrcy5odG1sCkBAIC03LDE4ICs3LDIxIEBACiAgICAgPHNjcmlwdCBz cmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CiAgICAgPHNj cmlwdCBpZD0idWktc2NyaXB0IiB0eXBlPSJ0ZXh0L3BsYWluIj4KICAgICAgICAgKGZ1bmN0aW9u KCkgewotICAgICAgICAgICAgdWlDb250cm9sbGVyLmRpZEVuZFpvb21pbmdDYWxsYmFjayA9IGZ1 bmN0aW9uKCkgewotICAgICAgICAgICAgICAgIHVpQ29udHJvbGxlci51aVNjcmlwdENvbXBsZXRl KCJGQUlMOiBab29tZWQgdG8gc2NhbGUgIiArIHVpQ29udHJvbGxlci56b29tU2NhbGUgKyAiIHdo ZW4gd2Ugc2hvdWxkIG9ubHkgYmUgZmlyaW5nIGZhc3QgY2xpY2tzLiIpOwotICAgICAgICAgICAg fTsKKyAgICAgICAgICAgIHZhciBjb3VudCA9IDA7CisgICAgICAgICAgICBmdW5jdGlvbiBmaXJl U3VjY2Vzc2l2ZVRhcHMoKSB7CisgICAgICAgICAgICAgICAgaWYgKGNvdW50IDwgMykKKyAgICAg ICAgICAgICAgICAgICAgdWlDb250cm9sbGVyLnNpbmdsZVRhcEF0UG9pbnQoMjAwLCAyMDAsIGZp cmVTdWNjZXNzaXZlVGFwcyk7CisgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAg ICAgICB1aUNvbnRyb2xsZXIudWlTY3JpcHRDb21wbGV0ZSgiIik7CiAKLSAgICAgICAgICAgIGZ1 bmN0aW9uIGZpcmVTdWNjZXNzaXZlU2luZ2xlVGFwcygpIHsKLSAgICAgICAgICAgICAgICB1aUNv bnRyb2xsZXIuc2luZ2xlVGFwQXRQb2ludCgyMDAsIDIwMCwgZmlyZVN1Y2Nlc3NpdmVTaW5nbGVU YXBzKTsKKyAgICAgICAgICAgICAgICBjb3VudCsrOwogICAgICAgICAgICAgfQotICAgICAgICAg ICAgZmlyZVN1Y2Nlc3NpdmVTaW5nbGVUYXBzKCk7CisgICAgICAgICAgICBmaXJlU3VjY2Vzc2l2 ZVRhcHMoKTsKICAgICAgICAgfSkoKTsKICAgICA8L3NjcmlwdD4KIAogICAgIDxzY3JpcHQ+Cisg ICAgdmFyIHNjcmlwdENvbXBsZXRlZCA9IGZhbHNlOwogICAgIHZhciBjbGlja0NvdW50ID0gMDsK ICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCiAgICAgICAgIHRlc3RSdW5uZXIud2FpdFVudGls RG9uZSgpOwpAQCAtMjksMTMgKzMyLDE3IEBACiAKICAgICBmdW5jdGlvbiBydW5UZXN0KCkgewog ICAgICAgICBpZiAodGVzdFJ1bm5lci5ydW5VSVNjcmlwdCkKLSAgICAgICAgICAgIHRlc3RSdW5u ZXIucnVuVUlTY3JpcHQoZ2V0VUlTY3JpcHQoKSwgZnVuY3Rpb24ocmVzdWx0KSB7IH0pOworICAg ICAgICAgICAgdGVzdFJ1bm5lci5ydW5VSVNjcmlwdChnZXRVSVNjcmlwdCgpLCBmdW5jdGlvbihy ZXN1bHQpIHsKKyAgICAgICAgICAgICAgICBzY3JpcHRDb21wbGV0ZWQgPSB0cnVlOworICAgICAg ICAgICAgICAgIGlmIChjbGlja0NvdW50ID09IDMpCisgICAgICAgICAgICAgICAgICAgIHRlc3RS dW5uZXIubm90aWZ5RG9uZSgpOworICAgICAgICAgICAgfSk7CiAgICAgfQogICAgIGZ1bmN0aW9u IGhhbmRsZUNsaWNrZWQoKSB7CiAgICAgICAgIGNsaWNrQ291bnQrKzsKICAgICAgICAgZG9jdW1l bnQuYm9keS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgiQ2xpY2shIikpOwog ICAgICAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo ImJyIikpOwotICAgICAgICBpZiAoY2xpY2tDb3VudCA9PSAzKQorICAgICAgICBpZiAoY2xpY2tD b3VudCA9PSAzICYmIHNjcmlwdENvbXBsZXRlZCkKICAgICAgICAgICAgIHRlc3RSdW5uZXIubm90 aWZ5RG9uZSgpOwogICAgIH0KICAgICA8L3NjcmlwdD4K