150866 2015-11-03 16:06:02 -0800 Rename DFG's compileAdd to compileArithAdd. 2015-11-03 17:01:35 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue oldest_to_newest 1139157 0 mark.lam 2015-11-03 16:06:02 -0800 The function is supposed to only generate code to do arithmetic on numeric types. Naming it compileArithAdd() is more accurate, and is consistent with the name of the node it emits code for (i.e. ArithAdd) as well as other compiler functions for analogous operations e.g. compileArithSub. 1139161 1 264748 mark.lam 2015-11-03 16:09:30 -0800 Created attachment 264748 the patch. 1139197 2 264748 commit-queue 2015-11-03 17:01:32 -0800 Comment on attachment 264748 the patch. Clearing flags on attachment: 264748 Committed r192000: <http://trac.webkit.org/changeset/192000> 1139198 3 commit-queue 2015-11-03 17:01:35 -0800 All reviewed patches have been landed. Closing bug. 264748 2015-11-03 16:09:30 -0800 2015-11-03 17:01:32 -0800 the patch. bug-150866.patch text/plain 3317 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkxOTkwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE1LTExLTAzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW5hbWUgREZHJ3MgY29tcGlsZUFkZCB0byBjb21waWxlQXJpdGhBZGQuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA4NjYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZnVuY3Rpb24gaXMgb25seSBz dXBwb3NlZCB0byBnZW5lcmF0ZSBjb2RlIHRvIGRvIGFyaXRobWV0aWMgYWRkaXRpb24gb24KKyAg ICAgICAgbnVtZXJpYyB0eXBlcy4gIE5hbWluZyBpdCBjb21waWxlQXJpdGhBZGQoKSBpcyBtb3Jl IGFjY3VyYXRlLCBhbmQgaXMgY29uc2lzdGVudAorICAgICAgICB3aXRoIHRoZSBuYW1lIG9mIHRo ZSBub2RlIGl0IGVtaXRzIGNvZGUgZm9yIChpLmUuIEFyaXRoQWRkKSBhcyB3ZWxsIGFzIG90aGVy CisgICAgICAgIGNvbXBpbGVyIGZ1bmN0aW9ucyBmb3IgYW5hbG9nb3VzIG9wZXJhdGlvbnMgZS5n LiBjb21waWxlQXJpdGhTdWIuCisKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuY3Bw OgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlSW5zdGFuY2VPZik6 CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVBcml0aEFkZCk6Cisg ICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVBZGQpOiBEZWxldGVkLgor ICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oOgorICAgICAgICAqIGRmZy9ERkdTcGVj dWxhdGl2ZUpJVDMyXzY0LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6 Y29tcGlsZSk6CisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwOgorICAgICAg ICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlKToKKwogMjAxNS0xMS0wMyAgQmVu amFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBBZGQg QWlyIGxvd2VyaW5nIGZvciBCaXRPciBhbmQgaW1wb3ZlIEJpdEFuZApJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCShy ZXZpc2lvbiAxOTE5ODIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0 aXZlSklUMzJfNjQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTkxLDcgKzIxOTEsNyBAQCB2b2lk IFNwZWN1bGF0aXZlSklUOjpjb21waWxlKE5vZGUqIG5vZGUpCiAgICAgfQogCiAgICAgY2FzZSBB cml0aEFkZDoKLSAgICAgICAgY29tcGlsZUFkZChub2RlKTsKKyAgICAgICAgY29tcGlsZUFyaXRo QWRkKG5vZGUpOwogICAgICAgICBicmVhazsKIAogICAgIGNhc2UgQXJpdGhDbHozMjoKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNw cAkocmV2aXNpb24gMTkxOTgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVj dWxhdGl2ZUpJVDY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjMxOCw3ICsyMzE4LDcgQEAgdm9p ZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZShOb2RlKiBub2RlKQogICAgIH0KIAogICAgIGNhc2Ug QXJpdGhBZGQ6Ci0gICAgICAgIGNvbXBpbGVBZGQobm9kZSk7CisgICAgICAgIGNvbXBpbGVBcml0 aEFkZChub2RlKTsKICAgICAgICAgYnJlYWs7CiAKICAgICBjYXNlIEFyaXRoQ2x6MzI6CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAko cmV2aXNpb24gMTkxOTgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxh dGl2ZUpJVC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3ODIsNyArMjc4Miw3IEBAIHZvaWQgU3Bl Y3VsYXRpdmVKSVQ6OmNvbXBpbGVJbnN0YW5jZU9mKE4KICAgICBibGVzc2VkQm9vbGVhblJlc3Vs dChzY3JhdGNoUmVnLCBub2RlKTsKIH0KIAotdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZUFk ZChOb2RlKiBub2RlKQordm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZUFyaXRoQWRkKE5vZGUq IG5vZGUpCiB7CiAgICAgc3dpdGNoIChub2RlLT5iaW5hcnlVc2VLaW5kKCkpIHsKICAgICBjYXNl IEludDMyVXNlOiB7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0 aXZlSklULmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVj dWxhdGl2ZUpJVC5oCShyZXZpc2lvbiAxOTE5ODIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR1NwZWN1bGF0aXZlSklULmgJKHdvcmtpbmcgY29weSkKQEAgLTIyMDcsNyArMjIwNyw3 IEBAIHB1YmxpYzoKICAgICB2b2lkIGNvbXBpbGVWYWx1ZVRvSW50MzIoTm9kZSopOwogICAgIHZv aWQgY29tcGlsZVVJbnQzMlRvTnVtYmVyKE5vZGUqKTsKICAgICB2b2lkIGNvbXBpbGVEb3VibGVB c0ludDMyKE5vZGUqKTsKLSAgICB2b2lkIGNvbXBpbGVBZGQoTm9kZSopOworICAgIHZvaWQgY29t cGlsZUFyaXRoQWRkKE5vZGUqKTsKICAgICB2b2lkIGNvbXBpbGVNYWtlUm9wZShOb2RlKik7CiAg ICAgdm9pZCBjb21waWxlQXJpdGhDbHozMihOb2RlKik7CiAgICAgdm9pZCBjb21waWxlQXJpdGhT dWIoTm9kZSopOwo=