150862 2015-11-03 15:42:11 -0800 Web Inspector: REGRESSION (r191612): Storage sidebar panel tree outline is broken 2015-11-03 17:49:44 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1139137 0 mattbaker 2015-11-03 15:42:11 -0800 * SUMMARY Storage sidebar panel tree outline is broken. Calling append() instead of appendChild() on database and application cache tree elements. Regressed in: http://trac.webkit.org/changeset/191612. 1139138 1 webkit-bug-importer 2015-11-03 15:42:49 -0800 <rdar://problem/23383951> 1139153 2 mattbaker 2015-11-03 15:58:28 -0800 The app cache UI is still broken after fixing the regression because ApplicationCacheFrameContentView inherits from the wrong base class (regressed in http://trac.webkit.org/changeset/187967). Simply changing the base class to ContentView fixes the issue, so I'll roll that into this patch. 1139156 3 264746 mattbaker 2015-11-03 16:02:49 -0800 Created attachment 264746 [Patch] Proposed Fix 1139200 4 264746 joepeck 2015-11-03 17:01:41 -0800 Comment on attachment 264746 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=264746&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js:26 > -WebInspector.ApplicationCacheFrameContentView = class ApplicationCacheFrameContentView extends WebInspector.ApplicationCacheFrame > +WebInspector.ApplicationCacheFrameContentView = class ApplicationCacheFrameContentView extends WebInspector.ContentView Great find. 1139212 5 264746 commit-queue 2015-11-03 17:49:40 -0800 Comment on attachment 264746 [Patch] Proposed Fix Clearing flags on attachment: 264746 Committed r192005: <http://trac.webkit.org/changeset/192005> 1139213 6 commit-queue 2015-11-03 17:49:44 -0800 All reviewed patches have been landed. Closing bug. 264746 2015-11-03 16:02:49 -0800 2015-11-03 17:49:40 -0800 [Patch] Proposed Fix bug-150862-20151103160152.patch text/plain 4057 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxOTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2 YThjZjk0MWQzNWM3YzVmOTgzYjA0OWFlY2JkMTU0OGEzZGU1ZWEzLi5mZDM1MDRkNDhiNzhkMzY4 MGQ2MjMyMGExMGZjYTdkMjNkZjE4NzZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMiBAQAogMjAxNS0xMS0wMyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTiAocjE5MTYxMik6IFN0b3JhZ2Ug c2lkZWJhciBwYW5lbCB0cmVlIG91dGxpbmUgaXMgYnJva2VuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA4NjIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQXBwbGlj YXRpb25DYWNoZUZyYW1lQ29udGVudFZpZXcuanM6CisgICAgICAgIEluaGVyaXQgZnJvbSBDb250 ZW50Vmlldy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU3RvcmFnZVNpZGViYXJQ YW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdG9yYWdlU2lkZWJhclBhbmVsLnByb3Rv dHlwZS5fYWRkRGF0YWJhc2UpOgorICAgICAgICBGaXhlZCBzeW50YXggZXJyb3IuCisgICAgICAg IChXZWJJbnNwZWN0b3IuU3RvcmFnZVNpZGViYXJQYW5lbC5wcm90b3R5cGUuX2FkZEluZGV4ZWRE YXRhYmFzZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3RvcmFnZVNpZGViYXJQYW5lbC5wcm90 b3R5cGUuX2FkZEZyYW1lTWFuaWZlc3QpOgorICAgICAgICBXZWJJbnNwZWN0b3IuVHJlZU91dGxp bmUuYXBwZW5kIGRvZXNuJ3QgZXhpc3Q7IGNoYW5nZWQgdG8gYXBwZW5kQ2hpbGQuCisKKzIwMTUt MTEtMDMgIE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IENyZWF0ZSBWaWV3IGJhc2UgY2xhc3MsIHJlZmFjdG9yIHNvbWUgY29yZSB2aWV3 IGNsYXNzZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0OTE4NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9BcHBsaWNhdGlvbkNhY2hlRnJhbWVDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0FwcGxpY2F0aW9uQ2FjaGVGcmFtZUNvbnRl bnRWaWV3LmpzCmluZGV4IDYzZWFhYzdkZDUyNzVjY2Y4NWNhYWJiNzVmZWU5MjRkZTRiOTcxNTgu LjAxODZkYzM1ZGQ3MGI4NTllMDRjNTNkZDU4MWM3ZGJkM2E4YTM1YTMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0FwcGxpY2F0aW9uQ2FjaGVG cmFtZUNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0FwcGxpY2F0aW9uQ2FjaGVGcmFtZUNvbnRlbnRWaWV3LmpzCkBAIC0yMyw3ICsy Myw3IEBACiAgKiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAgKi8KIAotV2ViSW5z cGVjdG9yLkFwcGxpY2F0aW9uQ2FjaGVGcmFtZUNvbnRlbnRWaWV3ID0gY2xhc3MgQXBwbGljYXRp b25DYWNoZUZyYW1lQ29udGVudFZpZXcgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuQXBwbGljYXRpb25D YWNoZUZyYW1lCitXZWJJbnNwZWN0b3IuQXBwbGljYXRpb25DYWNoZUZyYW1lQ29udGVudFZpZXcg PSBjbGFzcyBBcHBsaWNhdGlvbkNhY2hlRnJhbWVDb250ZW50VmlldyBleHRlbmRzIFdlYkluc3Bl Y3Rvci5Db250ZW50VmlldwogewogICAgIGNvbnN0cnVjdG9yKHJlcHJlc2VudGVkT2JqZWN0KQog ICAgIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1N0b3JhZ2VTaWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9TdG9yYWdlU2lkZWJhclBhbmVsLmpzCmluZGV4IGU5NDIzZGZjZDljNDU3 ZDVlNzZkNTQ3ZWExMDY3ZDQ3NjM2YWZjMWEuLjNhZGM2NGRmYzM4OGIyODA5MWNhYzgyMTUyYzM2 ZDVhODBiOGQ0NDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1N0b3JhZ2VTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3RvcmFnZVNpZGViYXJQYW5lbC5qcwpAQCAtMjE1LDEx ICsyMTUsMTEgQEAgV2ViSW5zcGVjdG9yLlN0b3JhZ2VTaWRlYmFyUGFuZWwgPSBjbGFzcyBTdG9y YWdlU2lkZWJhclBhbmVsIGV4dGVuZHMgV2ViSW5zcGVjdG8KICAgICAgICAgaWYgKCFkYXRhYmFz ZUhvc3RFbGVtZW50KSB7CiAgICAgICAgICAgICBkYXRhYmFzZUhvc3RFbGVtZW50ID0gbmV3IFdl Ykluc3BlY3Rvci5EYXRhYmFzZUhvc3RUcmVlRWxlbWVudChkYXRhYmFzZS5ob3N0KTsKICAgICAg ICAgICAgIHRoaXMuX2RhdGFiYXNlSG9zdFRyZWVFbGVtZW50TWFwLnNldChkYXRhYmFzZS5ob3N0 LCBkYXRhYmFzZUhvc3RFbGVtZW50KTsKLSAgICAgICAgICAgIHRoaXMuX2RhdGFiYXNlUm9vdFRy ZWVFbGVtZW50ID0gdGhpcy5fYWRkU3RvcmFnZUNoaWxkKHRyZWVFbGVtZW50LCB0aGlzLl9kYXRh YmFzZVJvb3RUcmVlRWxlbWVudCwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJEYXRhYmFzZXMiKSk7 CisgICAgICAgICAgICB0aGlzLl9kYXRhYmFzZVJvb3RUcmVlRWxlbWVudCA9IHRoaXMuX2FkZFN0 b3JhZ2VDaGlsZChkYXRhYmFzZUhvc3RFbGVtZW50LCB0aGlzLl9kYXRhYmFzZVJvb3RUcmVlRWxl bWVudCwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJEYXRhYmFzZXMiKSk7CiAgICAgICAgIH0KIAog ICAgICAgICBsZXQgZGF0YWJhc2VFbGVtZW50ID0gbmV3IFdlYkluc3BlY3Rvci5EYXRhYmFzZVRy ZWVFbGVtZW50KGRhdGFiYXNlKTsKLSAgICAgICAgZGF0YWJhc2VIb3N0RWxlbWVudC5hcHBlbmQo ZGF0YWJhc2VFbGVtZW50KTsKKyAgICAgICAgZGF0YWJhc2VIb3N0RWxlbWVudC5hcHBlbmRDaGls ZChkYXRhYmFzZUVsZW1lbnQpOwogICAgIH0KIAogICAgIF9kYXRhYmFzZVdhc0luc3BlY3RlZChl dmVudCkKQEAgLTI0Niw3ICsyNDYsNyBAQCBXZWJJbnNwZWN0b3IuU3RvcmFnZVNpZGViYXJQYW5l bCA9IGNsYXNzIFN0b3JhZ2VTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbnNwZWN0bwogICAgICAg ICB9CiAKICAgICAgICAgbGV0IGluZGV4ZWREYXRhYmFzZUVsZW1lbnQgPSBuZXcgV2ViSW5zcGVj dG9yLkluZGV4ZWREYXRhYmFzZVRyZWVFbGVtZW50KGluZGV4ZWREYXRhYmFzZSk7Ci0gICAgICAg IGluZGV4ZWREYXRhYmFzZUhvc3RFbGVtZW50LmFwcGVuZChpbmRleGVkRGF0YWJhc2VFbGVtZW50 KTsKKyAgICAgICAgaW5kZXhlZERhdGFiYXNlSG9zdEVsZW1lbnQuYXBwZW5kQ2hpbGQoaW5kZXhl ZERhdGFiYXNlRWxlbWVudCk7CiAgICAgfQogCiAgICAgX2Nvb2tpZVN0b3JhZ2VPYmplY3RXYXNB ZGRlZChldmVudCkKQEAgLTI4MSw3ICsyODEsNyBAQCBXZWJJbnNwZWN0b3IuU3RvcmFnZVNpZGVi YXJQYW5lbCA9IGNsYXNzIFN0b3JhZ2VTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbnNwZWN0bwog ICAgICAgICB9CiAKICAgICAgICAgbGV0IGZyYW1lQ2FjaGVFbGVtZW50ID0gbmV3IFdlYkluc3Bl Y3Rvci5BcHBsaWNhdGlvbkNhY2hlRnJhbWVUcmVlRWxlbWVudChmcmFtZU1hbmlmZXN0KTsKLSAg ICAgICAgYXBwbGljYXRpb25DYWNoZU1hbmlmZXN0RWxlbWVudC5hcHBlbmQoZnJhbWVDYWNoZUVs ZW1lbnQpOworICAgICAgICBhcHBsaWNhdGlvbkNhY2hlTWFuaWZlc3RFbGVtZW50LmFwcGVuZENo aWxkKGZyYW1lQ2FjaGVFbGVtZW50KTsKICAgICB9CiAKICAgICBfZnJhbWVNYW5pZmVzdFJlbW92 ZWQoZXZlbnQpCg==