150852 2015-11-03 13:16:03 -0800 Rewrite "const" as "var" for iTunes/iBooks on the Mac 2015-11-03 15:25:30 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam bshafiei commit-queue ggaren oldest_to_newest 1139044 0 saam 2015-11-03 13:16:03 -0800 ... 1139096 1 264730 saam 2015-11-03 14:41:42 -0800 Created attachment 264730 patch 1139097 2 commit-queue 2015-11-03 14:43:34 -0800 Attachment 264730 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1139107 3 264730 ggaren 2015-11-03 14:59:48 -0800 Comment on attachment 264730 patch View in context: https://bugs.webkit.org/attachment.cgi?id=264730&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Remove this line please. 1139119 4 saam 2015-11-03 15:25:30 -0800 landed in: http://trac.webkit.org/changeset/191982 264730 2015-11-03 14:41:42 -0800 2015-11-03 14:59:48 -0800 patch patch.diff text/plain 4181 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkxOTcxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE1LTExLTAzICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFJld3JpdGUgImNvbnN0IiBhcyAidmFyIiBmb3IgaVR1bmVzL2lCb29rcyBvbiB0aGUgTWFjCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA4NTIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBWTSBub3cgaGFz IGEgc2V0dGluZyBpbmRpY2F0aW5nIGlmIHdlIHNob3VsZCB0cmVhdAorICAgICAgICAiY29uc3Qi IHZhcmlhYmxlcyBhcyAidmFyIiB0byBtb3JlIGNsb3NlbHkgbWF0Y2gKKyAgICAgICAgSlNDJ3Mg cHJldmlvdXMgaW1wbGVtZW50YXRpb24gb2YgImNvbnN0IiBiZWZvcmUgRVM2LgorCisgICAgICAg ICogcGFyc2VyL1BhcnNlci5oOgorICAgICAgICAoSlNDOjpQYXJzZXI6Om5leHQpOgorICAgICAg ICAoSlNDOjpQYXJzZXI6Om5leHRFeHBlY3RJZGVudGlmaWVyKToKKyAgICAgICAgKiBydW50aW1l L1ZNLmg6CisgICAgICAgIChKU0M6OlZNOjpzZXRTaG91bGRSZXdyaXRlQ29uc3RBc1Zhcik6Cisg ICAgICAgIChKU0M6OlZNOjpzaG91bGRSZXdyaXRlQ29uc3RBc1Zhcik6CisKIDIwMTUtMTEtMDMg IEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5z cGVjdG9yOiBIYW5kbGUgb3IgUmVtb3ZlIFBhcnNlSFRNTCBUaW1lbGluZSBFdmVudCBSZWNvcmRz CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmgJKHJldmlzaW9uIDE5MTk2 MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmgJKHdvcmtpbmcgY29w eSkKQEAgLTkwOCw2ICs5MDgsOCBAQCBwcml2YXRlOgogICAgICAgICBtX2xhc3RUb2tlbkVuZFBv c2l0aW9uID0gSlNUZXh0UG9zaXRpb24obGFzdExpbmUsIGxhc3RUb2tlbkVuZCwgbGFzdFRva2Vu TGluZVN0YXJ0KTsKICAgICAgICAgbV9sZXhlci0+c2V0TGFzdExpbmVOdW1iZXIobGFzdExpbmUp OwogICAgICAgICBtX3Rva2VuLm1fdHlwZSA9IG1fbGV4ZXItPmxleCgmbV90b2tlbiwgbGV4ZXJG bGFncywgc3RyaWN0TW9kZSgpKTsKKyAgICAgICAgaWYgKFVOTElLRUxZKG1fdG9rZW4ubV90eXBl ID09IENPTlNUVE9LRU4gJiYgbV92bS0+c2hvdWxkUmV3cml0ZUNvbnN0QXNWYXIoKSkpCisgICAg ICAgICAgICBtX3Rva2VuLm1fdHlwZSA9IFZBUjsKICAgICB9CiAKICAgICBBTFdBWVNfSU5MSU5F IHZvaWQgbmV4dEV4cGVjdElkZW50aWZpZXIodW5zaWduZWQgbGV4ZXJGbGFncyA9IDApCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmgJKHJldmlzaW9uIDE5MTk2MykKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmgJKHdvcmtpbmcgY29weSkKQEAgLTU4MSw2ICs1 ODEsOCBAQCBwdWJsaWM6CiAKICAgICBKU19FWFBPUlRfUFJJVkFURSB2b2lkIHF1ZXVlTWljcm90 YXNrKEpTR2xvYmFsT2JqZWN0KiwgUGFzc1JlZlB0cjxNaWNyb3Rhc2s+KTsKICAgICBKU19FWFBP UlRfUFJJVkFURSB2b2lkIGRyYWluTWljcm90YXNrcygpOworICAgIEpTX0VYUE9SVF9QUklWQVRF IHZvaWQgc2V0U2hvdWxkUmV3cml0ZUNvbnN0QXNWYXIoYm9vbCBzaG91bGRSZXdyaXRlKSB7IG1f c2hvdWxkUmV3cml0ZUNvbnN0QXNWYXIgPSBzaG91bGRSZXdyaXRlOyB9CisgICAgQUxXQVlTX0lO TElORSBib29sIHNob3VsZFJld3JpdGVDb25zdEFzVmFyKCkgeyByZXR1cm4gbV9zaG91bGRSZXdy aXRlQ29uc3RBc1ZhcjsgfQogCiAgICAgaW5saW5lIGJvb2wgc2hvdWxkVHJpZ2dlclRlcm1pbmF0 aW9uKEV4ZWNTdGF0ZSopOwogCkBAIC02MzQsNiArNjM2LDcgQEAgcHJpdmF0ZToKICAgICBFeGNl cHRpb24qIG1fbGFzdEV4Y2VwdGlvbiB7IG51bGxwdHIgfTsKICAgICBib29sIG1fZmFpbE5leHRO ZXdDb2RlQmxvY2sgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9pbkRlZmluZU93blByb3BlcnR5Owor ICAgIGJvb2wgbV9zaG91bGRSZXdyaXRlQ29uc3RBc1ZhciB7IGZhbHNlIH07CiAgICAgc3RkOjp1 bmlxdWVfcHRyPENvZGVDYWNoZT4gbV9jb2RlQ2FjaGU7CiAgICAgTGVnYWN5UHJvZmlsZXIqIG1f ZW5hYmxlZFByb2ZpbGVyOwogICAgIHN0ZDo6dW5pcXVlX3B0cjxCdWlsdGluRXhlY3V0YWJsZXM+ IG1fYnVpbHRpbkV4ZWN1dGFibGVzOwpJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkxOTYzKQor KysgU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTUtMTEtMDMgIFNhYW0gYmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CisKKyAgICAg ICAgUmV3cml0ZSAiY29uc3QiIGFzICJ2YXIiIGZvciBpVHVuZXMvaUJvb2tzIG9uIHRoZSBNYWMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDg1Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyAoT09QUyEpLgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNET01XaW5kb3dCYXNlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkpTRE9NV2luZG93QmFzZTo6Y29tbW9uVk0pOgorCiAyMDE1 LTExLTAzICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXNv dXJjZVVzYWdlT3ZlcmxheSBzaG91bGQgZHJhdyBpdHNlbGYgdXNpbmcgV2ViQ29yZTo6R3JhcGhp Y3NDb250ZXh0LgpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dC YXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdp bmRvd0Jhc2UuY3BwCShyZXZpc2lvbiAxOTE5NjMpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU0RPTVdpbmRvd0Jhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw2ICszNCw3IEBA CiAjaW5jbHVkZSAiSlNOb2RlLmgiCiAjaW5jbHVkZSAiTG9nZ2luZy5oIgogI2luY2x1ZGUgIlBh Z2UuaCIKKyNpbmNsdWRlICJSdW50aW1lQXBwbGljYXRpb25DaGVja3MuaCIKICNpbmNsdWRlICJT Y3JpcHRDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiU2VjdXJpdHlPcmlnaW4uaCIKICNpbmNsdWRl ICJTZXR0aW5ncy5oIgpAQCAtMjYxLDYgKzI2MiwxMiBAQCBWTSYgSlNET01XaW5kb3dCYXNlOjpj b21tb25WTSgpCiAgICAgICAgIHZtLT5oZWFwLnNldEluY3JlbWVudGFsU3dlZXBlcihzdGQ6Om1h a2VfdW5pcXVlPFdlYlNhZmVJbmNyZW1lbnRhbFN3ZWVwZXI+KCZ2bS0+aGVhcCkpOwogICAgICAg ICB2bS0+aGVhcC5tYWNoaW5lVGhyZWFkcygpLmFkZEN1cnJlbnRUaHJlYWQoKTsKICNlbmRpZgor CisjaWYgUExBVEZPUk0oTUFDKQorICAgICAgICBpZiAoYXBwbGljYXRpb25Jc0lUdW5lcygpIHx8 IGFwcGxpY2F0aW9uSXNJQm9va3MoKSkKKyAgICAgICAgICAgIHZtLT5zZXRTaG91bGRSZXdyaXRl Q29uc3RBc1Zhcih0cnVlKTsKKyNlbmRpZgorCiAgICAgICAgIGluaXROb3JtYWxXb3JsZENsaWVu dERhdGEodm0pOwogICAgIH0KIAo=