150849 2015-11-03 12:43:24 -0800 Teach Makefile to build LayoutTestRelay when building for iOS Simulator 2015-11-10 21:19:58 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build iPhone / iPad Unspecified RESOLVED FIXED P2 Normal --- 150962 1 dbates dbates ap commit-queue ddkilzer jmarcell lforschler oldest_to_newest 1139031 0 dbates 2015-11-03 12:43:24 -0800 For convenience, we should support building LayoutTestRelay by default when building WebKit using `make SDKROOT=iphonesimulator`. 1139032 1 264714 dbates 2015-11-03 12:47:08 -0800 Created attachment 264714 Patch 1139057 2 264714 ap 2015-11-03 13:32:55 -0800 Comment on attachment 264714 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264714&action=review > Tools/LayoutTestRelay/Makefile:14 > +ifneq (,$(SAVED_SDK_ROOT)) > + override SDKROOT = $(SAVED_SDK_ROOT) > +endif Should we also unset SAVED_SDK_ROOT here? 1139742 3 dbates 2015-11-05 13:57:38 -0800 (In reply to comment #2) > Comment on attachment 264714 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=264714&action=review > > > Tools/LayoutTestRelay/Makefile:14 > > +ifneq (,$(SAVED_SDK_ROOT)) > > + override SDKROOT = $(SAVED_SDK_ROOT) > > +endif > > Should we also unset SAVED_SDK_ROOT here? Yes, will modify patch to undefine SAVED_SDK_ROOT inside the if block above before landing. 1139744 4 dbates 2015-11-05 14:01:11 -0800 Committed r192073: <http://trac.webkit.org/changeset/192073> 1139801 5 commit-queue 2015-11-05 15:14:47 -0800 Re-opened since this is blocked by bug 150962 1139845 6 264909 dbates 2015-11-05 17:38:43 -0800 Created attachment 264909 Patch 1139977 7 dbates 2015-11-06 08:59:27 -0800 Committed r192106: <http://trac.webkit.org/changeset/192106> 1140056 8 264909 jmarcell 2015-11-06 14:43:45 -0800 Comment on attachment 264909 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264909&action=review > Tools/ChangeLog:11 > + * LayoutTestRelay/Makefile: Define OVERWRITE_SDKROOT and OVERWRITE_ARCHS. Nit: OVERWRITE_{ARCHS, SDKROOT} -> OVERRIDE_{ARCHS, SDKROOT} > Makefile.shared:7 > + ifneq (,$(OVERRIDE_SDKROOT)) Why is this nested inside the first if block? Don't you want to use the OVERRIDE_SDKROOT regardless of whether SDKROOT was set? > Makefile.shared:9 > + XCODE_OPTIONS := $(XCODE_OPTIONS) SDKROOT=$(OVERRIDE_SDKROOT) Why did you use this syntax instead of the += syntax that was previously used? 1140057 9 264909 jmarcell 2015-11-06 14:43:54 -0800 Comment on attachment 264909 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264909&action=review > Tools/ChangeLog:11 > + * LayoutTestRelay/Makefile: Define OVERWRITE_SDKROOT and OVERWRITE_ARCHS. Nit: OVERWRITE_{ARCHS, SDKROOT} -> OVERRIDE_{ARCHS, SDKROOT} > Makefile.shared:7 > + ifneq (,$(OVERRIDE_SDKROOT)) Why is this nested inside the first if block? Don't you want to use the OVERRIDE_SDKROOT regardless of whether SDKROOT was set? > Makefile.shared:9 > + XCODE_OPTIONS := $(XCODE_OPTIONS) SDKROOT=$(OVERRIDE_SDKROOT) Why did you use this syntax instead of the += syntax that was previously used? 1141051 10 dbates 2015-11-10 20:40:45 -0800 (In reply to comment #8) > Comment on attachment 264909 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=264909&action=review > > > Tools/ChangeLog:11 > > + * LayoutTestRelay/Makefile: Define OVERWRITE_SDKROOT and OVERWRITE_ARCHS. > > Nit: OVERWRITE_{ARCHS, SDKROOT} -> OVERRIDE_{ARCHS, SDKROOT} > Fixed in <http://trac.webkit.org/changeset/192289>. > > Makefile.shared:7 > > + ifneq (,$(OVERRIDE_SDKROOT)) > > Why is this nested inside the first if block? Don't you want to use the > OVERRIDE_SDKROOT regardless of whether SDKROOT was set? > Yes, we should respect OVERRIDE_SDKROOT regardless of whether SDKROOT is set. Filed bug #151127 to address this issue. > > Makefile.shared:9 > > + XCODE_OPTIONS := $(XCODE_OPTIONS) SDKROOT=$(OVERRIDE_SDKROOT) > > Why did you use this syntax instead of the += syntax that was previously > used? Notice that XCODE_OPTIONS is a recursively expanded variable by <https://ftp.gnu.org/old-gnu/Manuals/make-3.79.1/html_chapter/make_6.html#SEC59>. The += operator preserves the flavor of the variable by <https://ftp.gnu.org/old-gnu/Manuals/make-3.79.1/html_chapter/make_6.html#SEC65>. Due to the way Makefiles are executed, we want to expand $OVERRIDE_SDKROOT in the definition of XCODE_OPTIONS immediately (i.e. make XCODE_OPTIONS a simply expanded variable) so that we can clear it and allow subsequent Makefiles to define it again. Therefore, I used the := operator to define XCODE_OPTIONS as a simply-expanded variable. For some reason, I was concerned about unconditionally defining XCODE_OPTIONS as a simply expanded variable and chose to only convert XCODE_OPTIONS to a simply-expanded variable when $(OVERRIDE_SDKROOT) is defined. We should look to unconditionally define XCODE_OPTIONS as a simply expanded variable and then we can use the += operator when appending the expression "SDKROOT=$(OVERRIDE_SDKROOT)". 1141052 11 dbates 2015-11-10 20:45:01 -0800 Re-opening this bug since I inadvertently did not append LayoutTestRelay to the end of the list of modules to build in file Tools/Makefile. So, `make SDKROOT=iphonesimulator` only works when executed inside directory Tools/LayoutTestRelay. We should make `make SDKROOT=iphonesimulator` work when executed from directory Tools and the top-level WebKit checkout. 1141054 12 265266 dbates 2015-11-10 20:55:24 -0800 Created attachment 265266 [Patch] Addendum - Build LayoutTestRelay when make invoked from Tools or top-level checkout 1141058 13 dbates 2015-11-10 21:19:58 -0800 Committed r192293: <http://trac.webkit.org/changeset/192293> 264714 2015-11-03 12:47:08 -0800 2015-11-05 17:38:40 -0800 Patch bug-150849-20151103124614.patch text/plain 1929 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwNzc1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2I5YTRiNmE2YTRjYzI4YjU4NTc5ZjliNDU0N2VkYzgy MTg5Nzc3ZC4uMTQ3OTAyMTZhZDk0ZGIyNTFkNjA1ODJhYTg0ZWEwYWIzZWY2YjQyZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTExLTAzICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBUZWFjaCBNYWtlZmlsZSB0byBidWlsZCBMYXlvdXRUZXN0UmVsYXkgd2hlbiBidWlsZGlu ZyBmb3IgaU9TIFNpbXVsYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUwODQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBMYXlvdXRUZXN0UmVsYXkvTWFrZWZpbGU6IFRlbXBvcmFyaWx5IG92ZXJy aWRlIFNES1JPT1Qgd2hlbiBpdCBpcyBpcGhvbmVzaW11bGF0b3Igc28KKyAgICAgICAgdGhhdCB3 ZSBidWlsZCB3aXRoIHRoZSBkZWZhdWx0IFNESy4gV2UgYXNzdW1lIHRoYXQgdGhlIGRlZmF1bHQg U0RLIGlzIHRoZSBPUyBYIFNESy4KKyAgICAgICAgKiBNYWtlZmlsZTogQXBwZW5kIExheW91dFRl c3RSZWxheSB0byB0aGUgbGlzdCBvZiBtb2R1bGVzIHRvIGJ1aWxkIHdoZW4gYnVpbGRpbmcgd2l0 aAorICAgICAgICBTREsgaXBob25lc2ltdWxhdG9yLgorCiAyMDE1LTEwLTA4ICBEYW5pZWwgQmF0 ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgaU9TIDkgZGV2aWNlIGJ1aWxk ZXIgdG8gV2ViS2l0IEJvdCBXYXRjaGVyJ3MgRGFzaGJvYXJkCmRpZmYgLS1naXQgYS9Ub29scy9M YXlvdXRUZXN0UmVsYXkvTWFrZWZpbGUgYi9Ub29scy9MYXlvdXRUZXN0UmVsYXkvTWFrZWZpbGUK aW5kZXggZTQ4OWZjNGJmODkxMGMwYmNhYzlhMDUyYTAyNTg1MDM1MDM4NmUxYi4uYjQ3ZjE1ZWRi M2Y5MjJjYmY4M2U4M2Q5Y2I0NGQ2ZTM5ZWMyMzlkMiAxMDA2NDQKLS0tIGEvVG9vbHMvTGF5b3V0 VGVzdFJlbGF5L01ha2VmaWxlCisrKyBiL1Rvb2xzL0xheW91dFRlc3RSZWxheS9NYWtlZmlsZQpA QCAtMSwzICsxLDE0IEBACiBTQ1JJUFRTX1BBVEggPSAuLi9TY3JpcHRzCiAKK2lmbmVxICgsJChT REtST09UKSkKKwlpZmVxICgkKGZpbmRzdHJpbmcgaXBob25lc2ltdWxhdG9yLCQoU0RLUk9PVCkp LGlwaG9uZXNpbXVsYXRvcikKKwkJU0FWRURfU0RLX1JPT1QgPSAkKFNES1JPT1QpCisJCW92ZXJy aWRlIFNES1JPT1QgPQorCWVuZGlmCitlbmRpZgorCiBpbmNsdWRlIC4uLy4uL01ha2VmaWxlLnNo YXJlZAorCitpZm5lcSAoLCQoU0FWRURfU0RLX1JPT1QpKQorCW92ZXJyaWRlIFNES1JPT1QgPSAk KFNBVkVEX1NES19ST09UKQorZW5kaWYKZGlmZiAtLWdpdCBhL1Rvb2xzL01ha2VmaWxlIGIvVG9v bHMvTWFrZWZpbGUKaW5kZXggZGNkYjRkOGE0YjAzY2E3NmJkODQ2ZTFjNjY4ZWIyYjQ4ZGEyZjgx MC4uMTU0MGQxNjJiNmQ0YjVkOWE4M2E1MDc2YjI5NTkxZTQ2NWIxYWM0OCAxMDA2NDQKLS0tIGEv VG9vbHMvTWFrZWZpbGUKKysrIGIvVG9vbHMvTWFrZWZpbGUKQEAgLTQsNiArNCw5IEBAIGlmbmVx ICgsJChTREtST09UKSkKIAlpZmVxICgsJChmaW5kc3RyaW5nIG1hY29zeCwkKFNES1JPT1QpKSkK IAkJTU9EVUxFUyA9IER1bXBSZW5kZXJUcmVlIFdlYktpdFRlc3RSdW5uZXIgLi4vU291cmNlL1Ro aXJkUGFydHkvZ3Rlc3QveGNvZGUgVGVzdFdlYktpdEFQSQogCWVuZGlmCisJaWZlcSAoJChmaW5k c3RyaW5nIGlwaG9uZXNpbXVsYXRvciwkKFNES1JPT1QpKSxpcGhvbmVzaW11bGF0b3IpCisJCU1P RFVMRVMgKz0gTGF5b3V0VGVzdFJlbGF5CisJZW5kaWYKIGVuZGlmCiAKIGFsbDoK 264909 2015-11-05 17:38:43 -0800 2015-11-05 21:12:35 -0800 Patch bug-150849-20151105173744.patch text/plain 3142 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMDg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDhhZTE3YjgyZTM4NjdiMzBiMWQ0ZDFmNDA1OWRkYjUw MjNiYjhiNy4uNThhYTJjMzY3M2NmNzk4ODVmMzRiYTIzYzhiMGJjMzEyOWZjMGNjZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTExLTA1ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBUZWFjaCBNYWtlZmlsZSB0byBidWlsZCBMYXlvdXRUZXN0UmVsYXkgd2hlbiBidWlsZGlu ZyBmb3IgaU9TIFNpbXVsYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUwODQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgT3ZlcnJpZGUgdGhlIHVzZXItc3BlY2lmaWVkIGFyZ3VtZW50cyBTREtST09U IGFuZCBBUkNIUyB0byB1c2UgdGhlIGRlZmF1bHQgU0RLCisgICAgICAgIGFuZCBkZWZhdWx0IEFS Q0hTIHNpbmNlIExheW91dFRlc3RSZWxheSBpcyBhIE1hYyBjb21tYW5kIGxpbmUgdG9vbC4KKwor ICAgICAgICAqIExheW91dFRlc3RSZWxheS9NYWtlZmlsZTogRGVmaW5lIE9WRVJXUklURV9TREtS T09UIGFuZCBPVkVSV1JJVEVfQVJDSFMuCisKIDIwMTUtMTEtMDUgIEphc29uIE1hcmNlbGwgIDxq bWFyY2VsbEBhcHBsZS5jb20+CiAKICAgICAgICAgcnVuLXdlYmtpdC10ZXN0IHNob3VsZCBsb29r IGluIC0tcm9vdCBkaXJlY3RvcnkgZm9yIExheW91dFRlc3RSZWxheQpkaWZmIC0tZ2l0IGEvVG9v bHMvTGF5b3V0VGVzdFJlbGF5L01ha2VmaWxlIGIvVG9vbHMvTGF5b3V0VGVzdFJlbGF5L01ha2Vm aWxlCmluZGV4IGU0ODlmYzRiZjg5MTBjMGJjYWM5YTA1MmEwMjU4NTAzNTAzODZlMWIuLmZkOWQw YjY4NmY4ZjE1MmRlYTIyNTkyNGEwNmM4MTU1NWU4NjQ4ZWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0xh eW91dFRlc3RSZWxheS9NYWtlZmlsZQorKysgYi9Ub29scy9MYXlvdXRUZXN0UmVsYXkvTWFrZWZp bGUKQEAgLTEsMyArMSw2IEBACiBTQ1JJUFRTX1BBVEggPSAuLi9TY3JpcHRzCiAKK09WRVJSSURF X0FSQ0hTID0gZGVmYXVsdAorT1ZFUlJJREVfU0RLUk9PVCA9IGRlZmF1bHQKKwogaW5jbHVkZSAu Li8uLi9NYWtlZmlsZS5zaGFyZWQKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwpp bmRleCBkMDIzYTgwZGUyMDBmODQyMDMxMDIxYmNlZGFmYzNlZjM4YTk3NDM3Li5hYTNhNWY3YjBk MTBkMjU5OThhNDBkZTY4YzEzZmI0ZmVhNzUwZDk0IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysr IGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMTEtMDUgIERhbmllbCBCYXRlcyAg PGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFRlYWNoIE1ha2VmaWxlIHRvIGJ1aWxkIExh eW91dFRlc3RSZWxheSB3aGVuIGJ1aWxkaW5nIGZvciBpT1MgU2ltdWxhdG9yCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA4NDkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc3VwcG9ydCBmb3Igb3Zl cnJpZGluZyB0aGUgdXNlci1wcm92aWRlZCBhcmd1bWVudHMgU0RLUk9PVCBhbmQgQVJDSFMKKyAg ICAgICAgb24gYSBwZXIgTWFrZWZpbGUgYmFzaXMuCisKKyAgICAgICAgKiBNYWtlZmlsZS5zaGFy ZWQ6CisKIDIwMTUtMTEtMDMgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAK ICAgICAgICAgW1dpbl0gQ01ha2UgYnVpbGQgdXBkYXRlLgpkaWZmIC0tZ2l0IGEvTWFrZWZpbGUu c2hhcmVkIGIvTWFrZWZpbGUuc2hhcmVkCmluZGV4IGE1Y2IyMTA4MzM3NDRkYzk4NGEwZWEzOGIy YTE0NzU4MTMyNmVmMzguLjVkYWU4MTgyODM3YWIwZDZmNTA1NTdhMzlhMTAwNzZiZjk2OWMxZDgg MTAwNjQ0Ci0tLSBhL01ha2VmaWxlLnNoYXJlZAorKysgYi9NYWtlZmlsZS5zaGFyZWQKQEAgLTQs MTIgKzQsMjcgQEAgU0VUX0NPTE9SX0RJQUdOT1NUSUNTX0FSRyA9IGlmIFtbIC10IDEgXV07IHRo ZW4gQ09MT1JfRElBR05PU1RJQ1NfQVJHPSJDT0xPUl9ESUEKIFhDT0RFX09QVElPTlMgPSBgcGVy bCAtSSQoU0NSSVBUU19QQVRIKSAtTXdlYmtpdGRpcnMgLWUgJ3ByaW50IFhjb2RlT3B0aW9uU3Ry aW5nKCknIC0tICQoQlVJTERfV0VCS0lUX09QVElPTlMpYCAkJHtDT0xPUl9ESUFHTk9TVElDU19B Ukd9ICQoQVJHUykKIAogaWZuZXEgKCwkKFNES1JPT1QpKQotCVhDT0RFX09QVElPTlMgKz0gU0RL Uk9PVD0kKFNES1JPT1QpCisJaWZuZXEgKCwkKE9WRVJSSURFX1NES1JPT1QpKQorCQlpZm5lcSAo ZGVmYXVsdCwkKE9WRVJSSURFX1NES1JPT1QpKQorCQkJWENPREVfT1BUSU9OUyA6PSAkKFhDT0RF X09QVElPTlMpIFNES1JPT1Q9JChPVkVSUklERV9TREtST09UKQorCQllbmRpZgorCQlPVkVSUklE RV9TREtST09UID0KKwllbHNlCisJCVhDT0RFX09QVElPTlMgOj0gJChYQ09ERV9PUFRJT05TKSBT REtST09UPSQoU0RLUk9PVCkKKwllbmRpZgogZW5kaWYKIAogaWZuZXEgKCwkKEFSQ0hTKSkKLQlY Q09ERV9PUFRJT05TICs9IEFSQ0hTPSIkKEFSQ0hTKSIKLQlYQ09ERV9PUFRJT05TICs9IE9OTFlf QUNUSVZFX0FSQ0g9Tk8KKwlpZm5lcSAoLCQoT1ZFUlJJREVfQVJDSFMpKQorCQlpZm5lcSAoZGVm YXVsdCwkKE9WRVJSSURFX0FSQ0hTKSkKKwkJCVhDT0RFX09QVElPTlMgOj0gJChYQ09ERV9PUFRJ T05TKSBBUkNIUz0iJChPVkVSUklERV9BUkNIUykiCisJCQlYQ09ERV9PUFRJT05TICs9IE9OTFlf QUNUSVZFX0FSQ0g9Tk8KKwkJZW5kaWYKKwkJT1ZFUlJJREVfQVJDSFMgPQorCWVsc2UKKwkJWENP REVfT1BUSU9OUyA6PSAkKFhDT0RFX09QVElPTlMpIEFSQ0hTPSIkKEFSQ0hTKSIKKwkJWENPREVf T1BUSU9OUyArPSBPTkxZX0FDVElWRV9BUkNIPU5PCisJZW5kaWYKIGVuZGlmCiAKIERFRkFVTFRf VkVSQk9TSVRZIDo9ICQoc2hlbGwgZGVmYXVsdHMgcmVhZCBvcmcud2Via2l0LkJ1aWxkQ29uZmln dXJhdGlvbiBCdWlsZFRyYW5zY3JpcHRWZXJib3NpdHkgMj4vZGV2L251bGwgfHwgZWNobyAiZGVm YXVsdCIpCg== 265266 2015-11-10 20:55:24 -0800 2015-11-10 21:14:56 -0800 [Patch] Addendum - Build LayoutTestRelay when make invoked from Tools or top-level checkout Bug150849Addendum.patch text/plain 1624 dbates RnJvbSA3ZjgxZDFjZTBmNzgyMzE1MTczYTVmOWE5MWJjMmNlNWI3ZDk3YzQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW5pZWwgQmF0ZXMgPGRiYXRlc0B3ZWJraXQub3JnPgpEYXRl OiBUdWUsIDEwIE5vdiAyMDE1IDIwOjQ4OjI2IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gVGVhY2gg TWFrZWZpbGUgdG8gYnVpbGQgTGF5b3V0VGVzdFJlbGF5IHdoZW4gYnVpbGRpbmcgZm9yIGlPUwog U2ltdWxhdG9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA4NDkK ClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKVW5sZXNzIHZhcmlhYmxlIERPX05PVF9CVUlM RF9MQVlPVVRfVEVTVF9SRUxBWSBpcyBub24tZW1wdHksIGJ1aWxkIExheW91dFRlc3RSZWxheSB3 aGVuCmJ1aWxkaW5nIFdlYktpdCB0b29scy4KCiogTWFrZWZpbGU6Ci0tLQogVG9vbHMvQ2hhbmdl TG9nIHwgMTIgKysrKysrKysrKysrCiBUb29scy9NYWtlZmlsZSAgfCAgMyArKysKIDIgZmlsZXMg Y2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiMWI3M2FkLi5mODI1ODI1IDEwMDY0NAotLS0gYS9Ub29s cy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUt MTEtMTAgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFRlYWNo IE1ha2VmaWxlIHRvIGJ1aWxkIExheW91dFRlc3RSZWxheSB3aGVuIGJ1aWxkaW5nIGZvciBpT1Mg U2ltdWxhdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTA4NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVbmxlc3MgdmFyaWFibGUgRE9fTk9UX0JVSUxEX0xBWU9VVF9URVNUX1JFTEFZIGlzIG5vbi1l bXB0eSwgYnVpbGQgTGF5b3V0VGVzdFJlbGF5IHdoZW4KKyAgICAgICAgYnVpbGRpbmcgV2ViS2l0 IHRvb2xzLgorCisgICAgICAgICogTWFrZWZpbGU6CisKIDIwMTUtMTEtMTAgIERhdmlkIEtpbHpl ciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBbY2hlY2std2Via2l0LXN0eWxlXSBG YWxzZSBwb3NpdGl2ZSAocmVhZGFiaWxpdHkvZW51bV9jYXNpbmcpIG9uIENGLXN0eWxlZCBlbnVt IG1lbWJlcnMKZGlmZiAtLWdpdCBhL1Rvb2xzL01ha2VmaWxlIGIvVG9vbHMvTWFrZWZpbGUKaW5k ZXggZGNkYjRkOC4uNTVlODllYSAxMDA2NDQKLS0tIGEvVG9vbHMvTWFrZWZpbGUKKysrIGIvVG9v bHMvTWFrZWZpbGUKQEAgLTQsNiArNCw5IEBAIGlmbmVxICgsJChTREtST09UKSkKIAlpZmVxICgs JChmaW5kc3RyaW5nIG1hY29zeCwkKFNES1JPT1QpKSkKIAkJTU9EVUxFUyA9IER1bXBSZW5kZXJU cmVlIFdlYktpdFRlc3RSdW5uZXIgLi4vU291cmNlL1RoaXJkUGFydHkvZ3Rlc3QveGNvZGUgVGVz dFdlYktpdEFQSQogCWVuZGlmCisJaWZlcSAoLCQoRE9fTk9UX0JVSUxEX0xBWU9VVF9URVNUX1JF TEFZKSkKKwkJTU9EVUxFUyArPSBMYXlvdXRUZXN0UmVsYXkKKwllbmRpZgogZW5kaWYKIAogYWxs OgotLSAKMi4zLjggKEFwcGxlIEdpdC01OCkKCg==