15083 2007-08-26 12:29:47 -0700 Some symbols in WebKit do not need to be exported 2007-09-01 00:50:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P3 Normal --- 1 rwlbuis webkit-unassigned oldest_to_newest 1432 0 rwlbuis 2007-08-26 12:29:47 -0700 There are some occasions of helper functions in cpp files that do not need to be exposed/exported. 1429 1 16126 rwlbuis 2007-08-26 12:33:56 -0700 Created attachment 16126 Symbol export fixes Do not export these symbols to get some smaller object file sizes. Cheers, Rob. 1074 2 16126 darin 2007-08-31 18:25:16 -0700 Comment on attachment 16126 Symbol export fixes All good changes. r=me 1065 3 rwlbuis 2007-09-01 00:50:14 -0700 Landed in r25340. 16126 2007-08-26 12:33:56 -0700 2007-08-31 18:25:16 -0700 Symbol export fixes 15083.diff text/plain 6632 rwlbuis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTI1NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzMgQEAKKzIwMDctMDgtMjYgIFJvYiBCdWlzICA8YnVpc0BrZGUub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdBUk5JTkc6IE5P IFRFU1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRAorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDgzCisgICAgICAgIFNvbWUgc3ltYm9scyBpbiBXZWJL aXQgZG8gbm90IG5lZWQgdG8gYmUgZXhwb3J0ZWQKKworICAgICAgICBEbyBub3QgZXhwb3J0IHRo ZXNlIHN5bWJvbHMuCisKKyAgICAgICAgKiBkb20vUXVhbGlmaWVkTmFtZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpoYXNoQ29tcG9uZW50cyk6CisgICAgICAgICogZG9tL1hNTFRva2VuaXplci5j cHA6CisgICAgICAgIChXZWJDb3JlOjp0b1N0cmluZyk6CisgICAgICAgIChXZWJDb3JlOjpnZXRU b2tlbml6ZXIpOgorICAgICAgICAqIGhpc3RvcnkvSGlzdG9yeUl0ZW0uY3BwOgorICAgICAgICAo V2ViQ29yZTo6ZGVmYXVsdE5vdGlmeUhpc3RvcnlJdGVtQ2hhbmdlZCk6CisgICAgICAgICogcGxh dGZvcm0vQXJlbmEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2VpbGluZ0xvZzIpOgorICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL0NvbG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNhbGNI dWUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1BhdGguY3BwOgorICAgICAgICAoV2Vi Q29yZTo6cGF0aExlbmd0aEFwcGxpZXJGdW5jdGlvbik6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvY2cvUGF0aENHLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNHUGF0aFRvQ0ZTdHJpbmdB cHBsaWVyRnVuY3Rpb24pOgorICAgICAgICAoV2ViQ29yZTo6Q0ZTdHJpbmdGcm9tQ0dQYXRoKToK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpp c1NwYWNlQWNjb3JkaW5nVG9TdHlsZSk6CisKIDIwMDctMDgtMjQgIFNhbSBXZWluaWcgIDxzYW1A d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGVsZS4KSW5kZXg6IFdlYkNvcmUv ZG9tL1F1YWxpZmllZE5hbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL1F1YWxpZmll ZE5hbWUuY3BwCShyZXZpc2lvbiAyNTI0NSkKKysrIFdlYkNvcmUvZG9tL1F1YWxpZmllZE5hbWUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Myw3ICs0Myw3IEBAIHN0cnVjdCBRdWFsaWZpZWROYW1l Q29tcG9uZW50cyB7CiAvLyBHb2xkZW4gcmF0aW8gLSBhcmJpdHJhcnkgc3RhcnQgdmFsdWUgdG8g YXZvaWQgbWFwcGluZyBhbGwgMCdzIHRvIGFsbCAwJ3MKIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBQ SEkgPSAweDllMzc3OWI5VTsKICAgICAKLWlubGluZSB1bnNpZ25lZCBoYXNoQ29tcG9uZW50cyhj b25zdCBRdWFsaWZpZWROYW1lQ29tcG9uZW50cyYgYnVmKQorc3RhdGljIGlubGluZSB1bnNpZ25l ZCBoYXNoQ29tcG9uZW50cyhjb25zdCBRdWFsaWZpZWROYW1lQ29tcG9uZW50cyYgYnVmKQogewog ICAgIEFTU0VSVChzaXplb2YoUXVhbGlmaWVkTmFtZUNvbXBvbmVudHMpICUgKHNpemVvZih1aW50 MTZfdCkgKiAyKSA9PSAwKTsKIApJbmRleDogV2ViQ29yZS9kb20vWE1MVG9rZW5pemVyLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9YTUxUb2tlbml6ZXIuY3BwCShyZXZpc2lvbiAyNTI0 NSkKKysrIFdlYkNvcmUvZG9tL1hNTFRva2VuaXplci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYx MiwxMiArNjEyLDEyIEBAIGJvb2wgWE1MVG9rZW5pemVyOjp3cml0ZShjb25zdCBTZWdtZW50ZWQK ICAgICByZXR1cm4gZmFsc2U7CiB9CiAjaWZuZGVmIFVTRV9RWE1MU1RSRUFNCi1pbmxpbmUgU3Ry aW5nIHRvU3RyaW5nKGNvbnN0IHhtbENoYXIqIHN0ciwgdW5zaWduZWQgbGVuKQorc3RhdGljIGlu bGluZSBTdHJpbmcgdG9TdHJpbmcoY29uc3QgeG1sQ2hhciogc3RyLCB1bnNpZ25lZCBsZW4pCiB7 CiAgICAgcmV0dXJuIFVURjhFbmNvZGluZygpLmRlY29kZShyZWludGVycHJldF9jYXN0PGNvbnN0 IGNoYXIqPihzdHIpLCBsZW4pOwogfQogCi1pbmxpbmUgU3RyaW5nIHRvU3RyaW5nKGNvbnN0IHht bENoYXIqIHN0cikKK3N0YXRpYyBpbmxpbmUgU3RyaW5nIHRvU3RyaW5nKGNvbnN0IHhtbENoYXIq IHN0cikKIHsKICAgICBpZiAoIXN0cikKICAgICAgICAgcmV0dXJuIFN0cmluZygpOwpAQCAtOTUy LDcgKzk1Miw3IEBAIHZvaWQgWE1MVG9rZW5pemVyOjppbnRlcm5hbFN1YnNldChjb25zdCAKICAg ICBkb2MtPnNldERvY1R5cGUobmV3IERvY3VtZW50VHlwZShkb2MsIHRvU3RyaW5nKG5hbWUpLCB0 b1N0cmluZyhleHRlcm5hbElEKSwgdG9TdHJpbmcoc3lzdGVtSUQpKSk7CiB9CiAKLWlubGluZSBY TUxUb2tlbml6ZXIqIGdldFRva2VuaXplcih2b2lkKiBjbG9zdXJlKQorc3RhdGljIGlubGluZSBY TUxUb2tlbml6ZXIqIGdldFRva2VuaXplcih2b2lkKiBjbG9zdXJlKQogewogICAgIHhtbFBhcnNl ckN0eHRQdHIgY3R4dCA9IHN0YXRpY19jYXN0PHhtbFBhcnNlckN0eHRQdHI+KGNsb3N1cmUpOwog ICAgIHJldHVybiBzdGF0aWNfY2FzdDxYTUxUb2tlbml6ZXIqPihjdHh0LT5fcHJpdmF0ZSk7Cklu ZGV4OiBXZWJDb3JlL2hpc3RvcnkvSGlzdG9yeUl0ZW0uY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvaGlzdG9yeS9IaXN0b3J5SXRlbS5jcHAJKHJldmlzaW9uIDI1MjQ1KQorKysgV2ViQ29yZS9o aXN0b3J5L0hpc3RvcnlJdGVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzcsNyArMzcsNyBAQAog CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLXZvaWQgZGVmYXVsdE5vdGlmeUhpc3RvcnlJdGVtQ2hh bmdlZCgpIHt9CitzdGF0aWMgdm9pZCBkZWZhdWx0Tm90aWZ5SGlzdG9yeUl0ZW1DaGFuZ2VkKCkg e30KIHZvaWQgKCpub3RpZnlIaXN0b3J5SXRlbUNoYW5nZWQpKCkgPSBkZWZhdWx0Tm90aWZ5SGlz dG9yeUl0ZW1DaGFuZ2VkOwogCiBIaXN0b3J5SXRlbTo6SGlzdG9yeUl0ZW0oKQpJbmRleDogV2Vi Q29yZS9wbGF0Zm9ybS9BcmVuYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9B cmVuYS5jcHAJKHJldmlzaW9uIDI1MjQ1KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9BcmVuYS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTg0LDcgKzg0LDcgQEAgc3RhdGljIGludCBmcmVlbGlzdF9jb3Vu dCA9IDA7CiAgICAgICBpZiAoKGpfKSA+PiAxKSAgICAgICAgICAgICAgICAgIFwKICAgICAgIChf bG9nMikgKz0gMTsKIAotaW50IENlaWxpbmdMb2cyKHVuc2lnbmVkIGludCBpKSB7CitzdGF0aWMg aW50IENlaWxpbmdMb2cyKHVuc2lnbmVkIGludCBpKSB7CiAgICAgaW50IGxvZzI7CiAgICAgQ0VJ TElOR19MT0cyKGxvZzIsaSk7CiAgICAgcmV0dXJuIGxvZzI7CkBAIC0yODMsMTUgKzI4Myw0IEBA IHZvaWQgRmluaXNoQXJlbmFQb29sKEFyZW5hUG9vbCAqcG9vbCkKICAgICBGcmVlQXJlbmFMaXN0 KHBvb2wsICZwb29sLT5maXJzdCwgdHJ1ZSk7CiB9CiAKLXZvaWQgQXJlbmFGaW5pc2godm9pZCkK LXsKLSAgICBBcmVuYSAqYSwgKm5leHQ7Ci0KLSAgICBmb3IgKGEgPSBhcmVuYV9mcmVlbGlzdDsg YTsgYSA9IG5leHQpIHsKLSAgICAgICAgbmV4dCA9IGEtPm5leHQ7Ci0gICAgICAgIGZhc3RGcmVl KGEpOyBhID0gMDsKLSAgICB9Ci0gICAgYXJlbmFfZnJlZWxpc3QgPSBOVUxMOwotfQotCiB9Cklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9yLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9yLmNwcAkocmV2aXNpb24gMjUyNDUpCisrKyBX ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTEs NyArNTEsNyBAQCBSR0JBMzIgbWFrZVJHQkEoaW50IHIsIGludCBnLCBpbnQgYiwgaW50CiAgICAg cmV0dXJuIG1heCgwLCBtaW4oYSwgMjU1KSkgPDwgMjQgfCBtYXgoMCwgbWluKHIsIDI1NSkpIDw8 IDE2IHwgbWF4KDAsIG1pbihnLCAyNTUpKSA8PCA4IHwgbWF4KDAsIG1pbihiLCAyNTUpKTsKIH0K IAotZG91YmxlIGNhbGNIdWUoZG91YmxlIHRlbXAxLCBkb3VibGUgdGVtcDIsIGRvdWJsZSBodWVW YWwpCitzdGF0aWMgZG91YmxlIGNhbGNIdWUoZG91YmxlIHRlbXAxLCBkb3VibGUgdGVtcDIsIGRv dWJsZSBodWVWYWwpCiB7CiAgICAgaWYgKGh1ZVZhbCA8IDAuMCkKICAgICAgICAgaHVlVmFsKys7 CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BhdGguY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGF0aC5jcHAJKHJldmlzaW9uIDI1MjQ1KQorKysg V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QYXRoLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzks NyArMzksNyBAQCBjb25zdCBmbG9hdCBRVUFSVEVSID0gMC41NTJmOyAvLyBhcHByb3hpCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAvLyB0byBzaW11bGF0ZSBhIHF1YXJ0ZXIgb2YgYSBj aXJjbGUuCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLXZvaWQgcGF0aExlbmd0aEFwcGxpZXJGdW5j dGlvbih2b2lkKiBpbmZvLCBjb25zdCBQYXRoRWxlbWVudCogZWxlbWVudCkKK3N0YXRpYyB2b2lk IHBhdGhMZW5ndGhBcHBsaWVyRnVuY3Rpb24odm9pZCogaW5mbywgY29uc3QgUGF0aEVsZW1lbnQq IGVsZW1lbnQpCiB7CiAgICAgUGF0aFRyYXZlcnNhbFN0YXRlJiB0cmF2ZXJzYWxTdGF0ZSA9ICpz dGF0aWNfY2FzdDxQYXRoVHJhdmVyc2FsU3RhdGUqPihpbmZvKTsKICAgICBpZiAodHJhdmVyc2Fs U3RhdGUubV9zdWNjZXNzKQpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9QYXRo Q0cuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvUGF0aENH LmNwcAkocmV2aXNpb24gMjUyNDUpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL1Bh dGhDRy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0Nyw3ICsxNDcsNyBAQCBib29sIFBhdGg6Omlz RW1wdHkoKSBjb25zdAogICAgIHJldHVybiBDR1BhdGhJc0VtcHR5KG1fcGF0aCk7CiAgfQogCi12 b2lkIENHUGF0aFRvQ0ZTdHJpbmdBcHBsaWVyRnVuY3Rpb24odm9pZCogaW5mbywgY29uc3QgQ0dQ YXRoRWxlbWVudCAqZWxlbWVudCkKK3N0YXRpYyB2b2lkIENHUGF0aFRvQ0ZTdHJpbmdBcHBsaWVy RnVuY3Rpb24odm9pZCogaW5mbywgY29uc3QgQ0dQYXRoRWxlbWVudCAqZWxlbWVudCkKIHsKICAg ICBDRk11dGFibGVTdHJpbmdSZWYgc3RyaW5nID0gKENGTXV0YWJsZVN0cmluZ1JlZilpbmZvOwog ICAgIENGU3RyaW5nUmVmIHR5cGVTdHJpbmcgPSBDRlNUUigiIik7CkBAIC0xNzMsNyArMTczLDcg QEAgdm9pZCBDR1BhdGhUb0NGU3RyaW5nQXBwbGllckZ1bmN0aW9uKHZvaQogICAgIH0KIH0KIAot Q0ZTdHJpbmdSZWYgQ0ZTdHJpbmdGcm9tQ0dQYXRoKENHUGF0aFJlZiBwYXRoKQorc3RhdGljIENG U3RyaW5nUmVmIENGU3RyaW5nRnJvbUNHUGF0aChDR1BhdGhSZWYgcGF0aCkKIHsKICAgICBpZiAo IXBhdGgpCiAgICAgICAgIHJldHVybiAwOwpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAJ KHJldmlzaW9uIDI1MjQ1KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTQ5Miw3ICs0OTIsNyBAQCB2b2lkIFJlbmRlclRleHQ6OnRyaW1tZWRQ cmVmV2lkdGhzKGludCBsCiAgICAgfQogfQogCi1pbmxpbmUgYm9vbCBpc1NwYWNlQWNjb3JkaW5n VG9TdHlsZShVQ2hhciBjLCBSZW5kZXJTdHlsZSogc3R5bGUpCitzdGF0aWMgaW5saW5lIGJvb2wg aXNTcGFjZUFjY29yZGluZ1RvU3R5bGUoVUNoYXIgYywgUmVuZGVyU3R5bGUqIHN0eWxlKQogewog ICAgIHJldHVybiBjID09ICcgJyB8fCAoYyA9PSBub0JyZWFrU3BhY2UgJiYgc3R5bGUtPm5ic3BN b2RlKCkgPT0gU1BBQ0UpOwogfQo=