150829 2015-11-02 17:50:48 -0800 Clean up NETWORK_SESSION code after r191848 2015-11-03 12:39:46 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 150834 1 achristensen achristensen commit-queue oldest_to_newest 1138789 0 achristensen 2015-11-02 17:50:48 -0800 Clean up NETWORK_SESSION code after r191848 1138790 1 264652 achristensen 2015-11-02 17:51:03 -0800 Created attachment 264652 Patch 1138792 2 achristensen 2015-11-02 17:51:45 -0800 Fixed Darin's comment in https://bugs.webkit.org/show_bug.cgi?id=150742 1138850 3 264652 darin 2015-11-02 22:08:09 -0800 Comment on attachment 264652 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264652&action=review > Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:474 > - sharedDidReceiveBuffer(WTF::move(buffer), buffer->size()); > + auto size = buffer->size(); > + sharedDidReceiveBuffer(WTF::move(buffer), size); This is not clean up; it’s fixing a potentially serious bug. 1138868 4 264652 commit-queue 2015-11-03 01:17:45 -0800 Comment on attachment 264652 Patch Clearing flags on attachment: 264652 Committed r191942: <http://trac.webkit.org/changeset/191942> 1138869 5 commit-queue 2015-11-03 01:17:48 -0800 All reviewed patches have been landed. Closing bug. 1139029 6 achristensen 2015-11-03 12:39:46 -0800 (In reply to comment #3) > Comment on attachment 264652 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=264652&action=review > > > Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:474 > > - sharedDidReceiveBuffer(WTF::move(buffer), buffer->size()); > > + auto size = buffer->size(); > > + sharedDidReceiveBuffer(WTF::move(buffer), size); > > This is not clean up; it’s fixing a potentially serious bug. I agree. I think this should've caused crashes, but it didn't. I also think we should remove the size parameter because it's not really used. 264652 2015-11-02 17:51:03 -0800 2015-11-03 01:17:45 -0800 Patch bug-150829-20151102175007.patch text/plain 3583 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MTkzMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTExLTAyICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ2xlYW4gdXAg TkVUV09SS19TRVNTSU9OIGNvZGUgYWZ0ZXIgcjE5MTg0OAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwODI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3Vy Y2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OmRp ZFJlY2VpdmVEYXRhKToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Jlc291cmNlTG9hZGVyOjpk aWRDb21wbGV0ZVdpdGhFcnJvcik6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Nl c3Npb24uaDoKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNv Y29hLm1tOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrU2Vzc2lvbjo6TmV0d29ya1Nlc3Npb24p OgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrU2Vzc2lvbjo6Y3JlYXRlRGF0YVRhc2tXaXRoUmVx dWVzdCk6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtTZXNzaW9uOjpkYXRhVGFza0ZvcklkZW50 aWZpZXIpOgorCiAyMDE1LTExLTAyICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUu Y29tPgogCiAgICAgICAgIFRyeSB0byBmaXggdGhlIGlPUyBidWlsZApJbmRleDogU291cmNlL1dl YktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIu Y3BwCShyZXZpc2lvbiAxOTE5MDEpCisrKyBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9O ZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NzAsNyArNDcwLDgg QEAgdm9pZCBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVSZQogdm9pZCBOZXR3b3Jr UmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVEYXRhKFJlZlB0cjxXZWJDb3JlOjpTaGFyZWRCdWZm ZXI+JiYgYnVmZmVyKQogewogICAgIEFTU0VSVChidWZmZXIpOwotICAgIHNoYXJlZERpZFJlY2Vp dmVCdWZmZXIoV1RGOjptb3ZlKGJ1ZmZlciksIGJ1ZmZlci0+c2l6ZSgpKTsKKyAgICBhdXRvIHNp emUgPSBidWZmZXItPnNpemUoKTsKKyAgICBzaGFyZWREaWRSZWNlaXZlQnVmZmVyKFdURjo6bW92 ZShidWZmZXIpLCBzaXplKTsKIH0KIAogdm9pZCBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OmRpZENv bXBsZXRlV2l0aEVycm9yKGNvbnN0IFdlYkNvcmU6OlJlc291cmNlRXJyb3ImIGVycm9yKQpJbmRl eDogU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Nlc3Npb24uaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrU2Vzc2lvbi5oCShy ZXZpc2lvbiAxOTE5MDEpCisrKyBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3Jr U2Vzc2lvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDMsNyArMTAzLDcgQEAgcHVibGljOgogICAg ICAgICBFcGhlbWVyYWwKICAgICB9OwogCi0gICAgUmVmUHRyPE5ldHdvcmtpbmdEYXRhVGFzaz4g Y3JlYXRlRGF0YVRhc2tXaXRoUmVxdWVzdChjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3Qm LCBOZXR3b3JrU2Vzc2lvblRhc2tDbGllbnQmKTsKKyAgICBSZWY8TmV0d29ya2luZ0RhdGFUYXNr PiBjcmVhdGVEYXRhVGFza1dpdGhSZXF1ZXN0KGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVz dCYsIE5ldHdvcmtTZXNzaW9uVGFza0NsaWVudCYpOwogCiAgICAgc3RhdGljIFJlZjxOZXR3b3Jr U2Vzc2lvbj4gc2luZ2xldG9uKCk7IC8vIEZJWE1FOiBUaGlzIHNob3VsZG4ndCBhY3R1YWxseSBi ZSBhIHNpbmdsZXRvbi4KICAgICBOZXR3b3JraW5nRGF0YVRhc2sqIGRhdGFUYXNrRm9ySWRlbnRp Zmllcih1aW50NjRfdCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jb2Nv YS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL05l dHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0JKHJldmlzaW9uIDE5MTkw MSkKKysrIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9u Q29jb2EubW0JKHdvcmtpbmcgY29weSkKQEAgLTE4NiwxMCArMTg2LDkgQEAgTmV0d29ya1Nlc3Np b246Ok5ldHdvcmtTZXNzaW9uKFR5cGUgdHlwZQogICAgIG1fc2Vzc2lvbiA9IFtOU1VSTFNlc3Np b24gc2Vzc2lvbldpdGhDb25maWd1cmF0aW9uOmNvbmZpZ3VyYXRpb24gZGVsZWdhdGU6c3RhdGlj X2Nhc3Q8aWQ+KG1fc2Vzc2lvbkRlbGVnYXRlLmdldCgpKSBkZWxlZ2F0ZVF1ZXVlOltOU09wZXJh dGlvblF1ZXVlIG1haW5RdWV1ZV1dOwogfQogCi1SZWZQdHI8TmV0d29ya2luZ0RhdGFUYXNrPiBO ZXR3b3JrU2Vzc2lvbjo6Y3JlYXRlRGF0YVRhc2tXaXRoUmVxdWVzdChjb25zdCBXZWJDb3JlOjpS ZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QsIE5ldHdvcmtTZXNzaW9uVGFza0NsaWVudCYgY2xpZW50 KQorUmVmPE5ldHdvcmtpbmdEYXRhVGFzaz4gTmV0d29ya1Nlc3Npb246OmNyZWF0ZURhdGFUYXNr V2l0aFJlcXVlc3QoY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBOZXR3 b3JrU2Vzc2lvblRhc2tDbGllbnQmIGNsaWVudCkKIHsKLSAgICBSZWZQdHI8TmV0d29ya2luZ0Rh dGFUYXNrPiB0YXNrID0gYWRvcHRSZWYobmV3IE5ldHdvcmtpbmdEYXRhVGFzaygqdGhpcywgY2xp ZW50LCBbbV9zZXNzaW9uIGRhdGFUYXNrV2l0aFJlcXVlc3Q6cmVxdWVzdC5uc1VSTFJlcXVlc3Qo V2ViQ29yZTo6VXBkYXRlSFRUUEJvZHkpXSkpOwotICAgIHJldHVybiB0YXNrOworICAgIHJldHVy biBhZG9wdFJlZigqbmV3IE5ldHdvcmtpbmdEYXRhVGFzaygqdGhpcywgY2xpZW50LCBbbV9zZXNz aW9uIGRhdGFUYXNrV2l0aFJlcXVlc3Q6cmVxdWVzdC5uc1VSTFJlcXVlc3QoV2ViQ29yZTo6VXBk YXRlSFRUUEJvZHkpXSkpOwogfQogCiBOZXR3b3JraW5nRGF0YVRhc2sqIE5ldHdvcmtTZXNzaW9u OjpkYXRhVGFza0ZvcklkZW50aWZpZXIodWludDY0X3QgdGFza0lkZW50aWZpZXIpCg==