150817 2015-11-02 14:30:33 -0800 Web Inspector: Search Results tab causes jump to Resources tab on reload 2015-11-06 11:19:30 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1138701 0 timothy 2015-11-02 14:30:33 -0800 Steps: 1) Load any page 2) Do a search in the global search field to make a Search Results tab (a result needs found) 3) Go to the Console tab 4) Reload the page The Resources tab will be switched to. It should not switch tabs and cookie restoring for the Search Results tab should not be done until it is active. Views/ContentBrowserTabContentView.js:193:22: CONSOLE TRACE showRepresentedObject {"lineNumber":1248,"columnNumber":16} 0: showRepresentedObject(Views/ContentBrowserTabContentView.js:193:22) 1: showRepresentedObject(Base/Main.js:993:41) 2: showSourceCode(Base/Main.js:1033:31) 3: showOriginalOrFormattedSourceCodeTextRange(Base/Main.js:1054:24) 4: _treeElementSelected(Views/SearchSidebarPanel.js:384:68) 5: _treeElementSelected([native code]) 6: select(Views/TreeOutline.js:1014:33) 7: revealAndSelect(Views/TreeOutline.js:1022:20) 8: (unknown)(Views/SearchSidebarPanel.js:154:61) 9: (unknown)([native code]) 10: forEachMatch(Views/SearchSidebarPanel.js:120:25) 11: resourceCallback(Views/SearchSidebarPanel.js:149:33) 12: resourceCallback([native code]) 13: _dispatchResponseToCallback(Protocol/InspectorBackend.js:233:27) 14: _dispatchResponse(Protocol/InspectorBackend.js:203:45) 15: dispatch(Protocol/InspectorBackend.js:87:35) 16: dispatchNextQueuedMessageFromBackend(Protocol/MessageDispatcher.js:42:34) 1138702 1 webkit-bug-importer 2015-11-02 14:30:53 -0800 <rdar://problem/23362429> 1138703 2 timothy 2015-11-02 14:31:32 -0800 It should also not jump to the Resources tab, it should use the ContentBrowser of the Search Results tab. 1139822 3 264898 timothy 2015-11-05 16:22:19 -0800 Created attachment 264898 Patch 1140000 4 264898 bburg 2015-11-06 10:31:26 -0800 Comment on attachment 264898 Patch r=me 1140008 5 264898 commit-queue 2015-11-06 11:19:27 -0800 Comment on attachment 264898 Patch Clearing flags on attachment: 264898 Committed r192110: <http://trac.webkit.org/changeset/192110> 1140009 6 commit-queue 2015-11-06 11:19:30 -0800 All reviewed patches have been landed. Closing bug. 264898 2015-11-05 16:22:19 -0800 2015-11-06 11:19:27 -0800 Patch bug-150817-20151105162120.patch text/plain 4002 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxOTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2 YThjZjk0MWQzNWM3YzVmOTgzYjA0OWFlY2JkMTU0OGEzZGU1ZWEzLi43OGQzYjFmMDhlODY2NmEx ZjUzOTE5OTQzMzZjZDcxOWExODAxM2VjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxNS0xMS0wNSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU2VhcmNoIFJlc3VsdHMgdGFiIGNhdXNlcyBq dW1wIHRvIFJlc291cmNlcyB0YWIgb24gcmVsb2FkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA4MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdGhlICJzZWFyY2ggb24gcmVsb2FkIiBiZWhh dmlvciBmcm9tIHRoZSBTZWFyY2ggUmVzdWx0cyB0YWIuIEl0IG9mdGVuIGRpZG4ndCBmaW5kIGV2 ZXJ5dGhpbmcKKyAgICAgICAgb24gbGFyZ2UgcGFnZXMsIHNpbmNlIGl0IG9ubHkgc2VhcmNoZWQg YWZ0ZXIgNTAwbXMgb2YgdGhlIG1haW4gcmVzb3VyY2UgY2hhbmdpbmcuIFRoZSBidWcgaGVyZQor ICAgICAgICB3YXMgY2F1c2VkIGJ5IHBlcmZvcm1TZWFyY2ggc2VsZWN0aW5nIHRoZSBmaXJzdCBy ZXN1bHQsIGV2ZW4gaWYgaXQgd2FzIGEgYmFja2dyb3VuZCB0YWIuIFdlIG5vdworICAgICAgICBh dm9pZCBkb2luZyB1bm5lY2Vzc2FyeSBzZWFyY2ggd29yayBpbiB0aGUgYmFja2dyb3VuZCB3aGVu IHRoZSBTZWFyY2ggUmVzdWx0cyB0YWIgaXNuJ3QgdmlzaWJsZS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvVmlld3MvU2VhcmNoU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLlNlYXJjaFNpZGViYXJQYW5lbCk6IERlbGV0ZWQuCisgICAgICAgIChXZWJJbnNwZWN0b3Iu U2VhcmNoU2lkZWJhclBhbmVsLnByb3RvdHlwZS5fbWFpblJlc291cmNlRGlkQ2hhbmdlKTogUmVt b3ZlIGNoaWxkcmVuIGZyb20gdGhlCisgICAgICAgIHNpZGViYXIgc2luY2UgcGVyZm9ybVNlYXJj aCBpc24ndCBkb2luZyBpdCBub3cgYW5kIFNjcmlwdFRyZWVFbGVtZW50cyB3ZXJlIG5vdCBiZWlu ZyByZW1vdmVkLgorICAgICAgICBSZXNvdXJjZVRyZWVFbGVtZW50cyB3ZXJlIGFscmVhZHkgYmVp bmcgcmVtb3ZlZCBieSBOYXZpZ2F0aW9uU2lkZWJhclBhbmVsJ3MgcHJ1bmUgYmVoYXZpb3IuCisg ICAgICAgIFJlbW92ZWQgdGhlIGNhbGwgdG8gcGVyZm9ybVNlYXJjaCBhbmQgcmVsYXRlZCBjb2Rl LgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNlYXJjaFNpZGViYXJQYW5lbC5wcm90b3R5cGUuX21h aW5SZXNvdXJjZURpZENoYW5nZS5kZWxheWVkV29yayk6IERlbGV0ZWQuCisKIDIwMTUtMTEtMDMg IE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IENyZWF0ZSBWaWV3IGJhc2UgY2xhc3MsIHJlZmFjdG9yIHNvbWUgY29yZSB2aWV3IGNsYXNz ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1NlYXJjaFNpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1NlYXJjaFNpZGViYXJQYW5lbC5qcwppbmRleCAxYTFiMTY4NzNlYzVmZmMwNDY1 ZmQ0MjhiM2Q5ZGM1YjRlY2U3YzA4Li40MGZhZWJjMDU5MmQwMzI4M2I4YWVhNzAwNDQ0ODhlMDE4 Njc2NTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9TZWFyY2hTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoU2lkZWJhclBhbmVsLmpzCkBAIC00Nyw4ICs0Nyw2IEBA IFdlYkluc3BlY3Rvci5TZWFyY2hTaWRlYmFyUGFuZWwgPSBjbGFzcyBTZWFyY2hTaWRlYmFyUGFu ZWwgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuCiAKICAgICAgICAgdGhpcy5maWx0ZXJCYXIucGxhY2Vo b2xkZXIgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkZpbHRlciBTZWFyY2ggUmVzdWx0cyIpOwog Ci0gICAgICAgIHRoaXMuX2xhc3RTZWFyY2hlZFBhZ2VTZXR0aW5nID0gbmV3IFdlYkluc3BlY3Rv ci5TZXR0aW5nKCJsYXN0LXNlYXJjaGVkLXBhZ2UiLCBudWxsKTsKLQogICAgICAgICB0aGlzLl9z ZWFyY2hRdWVyeVNldHRpbmcgPSBuZXcgV2ViSW5zcGVjdG9yLlNldHRpbmcoInNlYXJjaC1zaWRl YmFyLXF1ZXJ5IiwgIiIpOwogICAgICAgICB0aGlzLl9pbnB1dEVsZW1lbnQudmFsdWUgPSB0aGlz Ll9zZWFyY2hRdWVyeVNldHRpbmcudmFsdWU7CiAKQEAgLTgxLDcgKzc5LDYgQEAgV2ViSW5zcGVj dG9yLlNlYXJjaFNpZGViYXJQYW5lbCA9IGNsYXNzIFNlYXJjaFNpZGViYXJQYW5lbCBleHRlbmRz IFdlYkluc3BlY3Rvci4KIAogICAgICAgICB0aGlzLl9pbnB1dEVsZW1lbnQudmFsdWUgPSBzZWFy Y2hRdWVyeTsKICAgICAgICAgdGhpcy5fc2VhcmNoUXVlcnlTZXR0aW5nLnZhbHVlID0gc2VhcmNo UXVlcnk7Ci0gICAgICAgIHRoaXMuX2xhc3RTZWFyY2hlZFBhZ2VTZXR0aW5nLnZhbHVlID0gc2Vh cmNoUXVlcnkgJiYgV2ViSW5zcGVjdG9yLmZyYW1lUmVzb3VyY2VNYW5hZ2VyLm1haW5GcmFtZSA/ IFdlYkluc3BlY3Rvci5mcmFtZVJlc291cmNlTWFuYWdlci5tYWluRnJhbWUudXJsLmhhc2ggOiBu dWxsOwogCiAgICAgICAgIHRoaXMuaGlkZUVtcHR5Q29udGVudFBsYWNlaG9sZGVyKCk7CiAKQEAg LTM0MiwyNiArMzM5LDExIEBAIFdlYkluc3BlY3Rvci5TZWFyY2hTaWRlYmFyUGFuZWwgPSBjbGFz cyBTZWFyY2hTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuCiAgICAgICAgICAgICB0 aGlzLl9kZWxheWVkU2VhcmNoVGltZW91dCA9IHVuZGVmaW5lZDsKICAgICAgICAgfQogCisgICAg ICAgIHRoaXMuY29udGVudFRyZWVPdXRsaW5lLnJlbW92ZUNoaWxkcmVuKCk7CiAgICAgICAgIHRo aXMuY29udGVudEJyb3dzZXIuY29udGVudFZpZXdDb250YWluZXIuY2xvc2VBbGxDb250ZW50Vmll d3MoKTsKIAogICAgICAgICBpZiAodGhpcy52aXNpYmxlKQogICAgICAgICAgICAgdGhpcy5mb2N1 c1NlYXJjaEZpZWxkKCk7Ci0KLSAgICAgICAgLy8gT25seSBpZiB0aGUgbGFzdCBwYWdlIHNlYXJj aGVkIGlzIHRoZSBzYW1lIGFzIHRoZSBjdXJyZW50IHBhZ2UuCi0gICAgICAgIHZhciBtYWluRnJh bWUgPSBldmVudC50YXJnZXQ7Ci0gICAgICAgIGlmICh0aGlzLl9sYXN0U2VhcmNoZWRQYWdlU2V0 dGluZy52YWx1ZSAhPT0gbWFpbkZyYW1lLnVybC5oYXNoKQotICAgICAgICAgICAgcmV0dXJuOwot Ci0gICAgICAgIGZ1bmN0aW9uIGRlbGF5ZWRXb3JrKCkKLSAgICAgICAgewotICAgICAgICAgICAg dGhpcy5fZGVsYXllZFNlYXJjaFRpbWVvdXQgPSB1bmRlZmluZWQ7Ci0KLSAgICAgICAgICAgIC8v IFNlYXJjaCBmb3Igd2hhdGV2ZXIgaXMgaW4gdGhlIGlucHV0IGZpZWxkLiBUaGlzIHdhcyBwb3B1 bGF0ZWQgd2l0aCB0aGUgbGFzdCB1c2VkIHNlYXJjaCB0ZXJtLgotICAgICAgICAgICAgdGhpcy5w ZXJmb3JtU2VhcmNoKHRoaXMuX2lucHV0RWxlbWVudC52YWx1ZSk7Ci0gICAgICAgIH0KLQotICAg ICAgICAvLyBQZXJmb3JtIHRoZSBzZWFyY2ggb24gYSBkZWxheSBzbyB3ZSBoYXZlIGEgYmV0dGVy IGNoYW5jZSBvZiBmaW5kaW5nIHN1YnJlc291cmNlIHJlc3VsdHMuCi0gICAgICAgIHRoaXMuX2Rl bGF5ZWRTZWFyY2hUaW1lb3V0ID0gc2V0VGltZW91dChkZWxheWVkV29yay5iaW5kKHRoaXMpLCA1 MDApOwogICAgIH0KIAogICAgIF90cmVlRWxlbWVudFNlbGVjdGVkKHRyZWVFbGVtZW50LCBzZWxl Y3RlZEJ5VXNlcikK