150813 2015-11-02 13:11:16 -0800 Remove unused API client callback code 2015-11-02 13:14:11 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1138665 0 andersca 2015-11-02 13:11:16 -0800 Remove unused API client callback code 1138666 1 264618 andersca 2015-11-02 13:11:35 -0800 Created attachment 264618 Patch 1138667 2 264618 thorton 2015-11-02 13:12:25 -0800 Comment on attachment 264618 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264618&action=review > Source/WebKit2/UIProcess/API/APILoaderClient.h:87 > // FIXME: These four functions should not be part of this client. THREE NOW 1138669 3 andersca 2015-11-02 13:14:11 -0800 Committed r191906: <http://trac.webkit.org/changeset/191906> 264618 2015-11-02 13:11:35 -0800 2015-11-02 13:12:25 -0800 Patch bug-150813-20151102131043.patch text/plain 7033 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxOTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYWEzMzNhMWYyYzBiZmEy Njg2N2M3NDk5N2UyNDJhZjc2ZWYzZjE5MS4uYWQ3YTc4N2ExNDZmMjdhOGFkZmJlYTQ0MGY2NmQw ZjJmNjE0Y2U0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE1LTExLTAyICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVudXNl ZCBBUEkgY2xpZW50IGNhbGxiYWNrIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1MDgxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9BUElMb2FkZXJDbGllbnQuaDoKKyAg ICAgICAgKEFQSTo6TG9hZGVyQ2xpZW50OjppbnRlcmFjdGlvbk9jY3VycmVkV2hpbGVQcm9jZXNz VW5yZXNwb25zaXZlKTogRGVsZXRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tQYWdl LmNwcDoKKyAgICAgICAgKFdLUGFnZVNldFBhZ2VMb2FkZXJDbGllbnQpOiBEZWxldGVkLgorICAg ICAgICAqIFVJUHJvY2Vzcy9SZXNwb25zaXZlbmVzc1RpbWVyLmNwcDoKKyAgICAgICAgKFdlYktp dDo6UmVzcG9uc2l2ZW5lc3NUaW1lcjo6dGltZXJGaXJlZCk6CisgICAgICAgICogVUlQcm9jZXNz L1Jlc3BvbnNpdmVuZXNzVGltZXIuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5 LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjppbnRlcmFjdGlvbk9jY3VycmVk V2hpbGVQcm9jZXNzVW5yZXNwb25zaXZlKTogRGVsZXRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3Mv V2ViUGFnZVByb3h5Lmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHA6 CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQcm94eTo6aW50ZXJhY3Rpb25PY2N1cnJlZFdo aWxlVW5yZXNwb25zaXZlKTogRGVsZXRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vz c1Byb3h5Lmg6CisKIDIwMTUtMTAtMzEgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgog CiAgICAgICAgIFJlcGxhY2UgaU9TLW9ubHkgV2ViS2l0U3lzdGVtSW50ZXJmYWNlIGNhbGxzIHdp dGggU1BJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0FQSUxvYWRl ckNsaWVudC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9BUElMb2FkZXJDbGllbnQu aAppbmRleCA4MTdjZDU2YTllNjAxZjcxMmE4YWFmY2UwYmY0Y2FkZTk2MTJjOTZmLi4zZmIyNjU0 OTZjYjA2ZmI2YTZjNzU5MjRlODBkZTQ4NDI3YmMzY2ViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL0FQSUxvYWRlckNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQVBJTG9hZGVyQ2xpZW50LmgKQEAgLTg2LDcgKzg2LDYgQEAgcHVibGlj OgogCiAgICAgLy8gRklYTUU6IFRoZXNlIGZvdXIgZnVuY3Rpb25zIHNob3VsZCBub3QgYmUgcGFy dCBvZiB0aGlzIGNsaWVudC4KICAgICB2aXJ0dWFsIHZvaWQgcHJvY2Vzc0RpZEJlY29tZVVucmVz cG9uc2l2ZShXZWJLaXQ6OldlYlBhZ2VQcm94eSYpIHsgfQotICAgIHZpcnR1YWwgdm9pZCBpbnRl cmFjdGlvbk9jY3VycmVkV2hpbGVQcm9jZXNzVW5yZXNwb25zaXZlKFdlYktpdDo6V2ViUGFnZVBy b3h5JikgeyB9CiAgICAgdmlydHVhbCB2b2lkIHByb2Nlc3NEaWRCZWNvbWVSZXNwb25zaXZlKFdl YktpdDo6V2ViUGFnZVByb3h5JikgeyB9CiAgICAgdmlydHVhbCB2b2lkIHByb2Nlc3NEaWRDcmFz aChXZWJLaXQ6OldlYlBhZ2VQcm94eSYpIHsgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvQy9XS1BhZ2UuY3BwCmluZGV4IDQ4YTMyOWM5MjkxOGM3NDI5NTdmOWQ2M2I5ZTFkYmJmNjQ4 YWY3OGIuLmFjNTdkM2RiNWNlZTQ5ZWZiOGJiYjA1YTM2ZWIwYTA1ZjlmODc1MDAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwCkBAIC0xMTQ2LDE0ICsxMTQ2LDYg QEAgdm9pZCBXS1BhZ2VTZXRQYWdlTG9hZGVyQ2xpZW50KFdLUGFnZVJlZiBwYWdlUmVmLCBjb25z dCBXS1BhZ2VMb2FkZXJDbGllbnRCYXNlKgogICAgICAgICAgICAgbV9jbGllbnQucHJvY2Vzc0Rp ZEJlY29tZVVucmVzcG9uc2l2ZSh0b0FQSSgmcGFnZSksIG1fY2xpZW50LmJhc2UuY2xpZW50SW5m byk7CiAgICAgICAgIH0KIAotICAgICAgICB2aXJ0dWFsIHZvaWQgaW50ZXJhY3Rpb25PY2N1cnJl ZFdoaWxlUHJvY2Vzc1VucmVzcG9uc2l2ZShXZWJQYWdlUHJveHkmIHBhZ2UpIG92ZXJyaWRlCi0g ICAgICAgIHsKLSAgICAgICAgICAgIGlmICghbV9jbGllbnQuaW50ZXJhY3Rpb25PY2N1cnJlZFdo aWxlUHJvY2Vzc1VucmVzcG9uc2l2ZSkKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0KLSAgICAg ICAgICAgIG1fY2xpZW50LmludGVyYWN0aW9uT2NjdXJyZWRXaGlsZVByb2Nlc3NVbnJlc3BvbnNp dmUodG9BUEkoJnBhZ2UpLCBtX2NsaWVudC5iYXNlLmNsaWVudEluZm8pOwotICAgICAgICB9Ci0K ICAgICAgICAgdmlydHVhbCB2b2lkIHByb2Nlc3NEaWRCZWNvbWVSZXNwb25zaXZlKFdlYlBhZ2VQ cm94eSYgcGFnZSkgb3ZlcnJpZGUKICAgICAgICAgewogICAgICAgICAgICAgaWYgKCFtX2NsaWVu dC5wcm9jZXNzRGlkQmVjb21lUmVzcG9uc2l2ZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9SZXNwb25zaXZlbmVzc1RpbWVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9SZXNwb25zaXZlbmVzc1RpbWVyLmNwcAppbmRleCA5NzM5ZmEzYTExZjU0MDhhNjEwMGIw NjM4ZWJiMTAzYTU5ODQ2ZmJjLi42OWFlZDlhMWI2ZTI5NzljMTQzOGNmMTdhZTA2OGFjMDJiMDcx ODExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUmVzcG9uc2l2ZW5lc3NU aW1lci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1Jlc3BvbnNpdmVuZXNzVGlt ZXIuY3BwCkBAIC00OSwxMyArNDksMTEgQEAgdm9pZCBSZXNwb25zaXZlbmVzc1RpbWVyOjppbnZh bGlkYXRlKCkKIAogdm9pZCBSZXNwb25zaXZlbmVzc1RpbWVyOjp0aW1lckZpcmVkKCkKIHsKLSAg ICBpZiAobV9pc1Jlc3BvbnNpdmUpIHsKLSAgICAgICAgbV9pc1Jlc3BvbnNpdmUgPSBmYWxzZTsK LSAgICAgICAgbV9jbGllbnQtPmRpZEJlY29tZVVucmVzcG9uc2l2ZSh0aGlzKTsKLSAgICB9IGVs c2UgewotICAgICAgICAvLyBUaGUgdGltZXIgZmlyZWQgd2hpbGUgdW5yZXNwb25zaXZlLgotICAg ICAgICBtX2NsaWVudC0+aW50ZXJhY3Rpb25PY2N1cnJlZFdoaWxlVW5yZXNwb25zaXZlKHRoaXMp OwotICAgIH0KKyAgICBpZiAoIW1faXNSZXNwb25zaXZlKQorICAgICAgICByZXR1cm47CisKKyAg ICBtX2lzUmVzcG9uc2l2ZSA9IGZhbHNlOworICAgIG1fY2xpZW50LT5kaWRCZWNvbWVVbnJlc3Bv bnNpdmUodGhpcyk7CiB9CiAgICAgCiB2b2lkIFJlc3BvbnNpdmVuZXNzVGltZXI6OnN0YXJ0KCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9SZXNwb25zaXZlbmVzc1RpbWVy LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUmVzcG9uc2l2ZW5lc3NUaW1lci5oCmluZGV4 IGY3NWMwYTk5OGZmNDY3ZGFjOTNiYTczYWJjMGUyYTU2YjZjODE1OTIuLjU3NDEzMWJkZmZmZTk0 MTg2OGU4ZTY5NWRiZjE5NTYyZWQ5OWRmNGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9SZXNwb25zaXZlbmVzc1RpbWVyLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1Jlc3BvbnNpdmVuZXNzVGltZXIuaApAQCAtMzYsNyArMzYsNiBAQCBwdWJsaWM6CiAgICAg cHVibGljOgogICAgICAgICB2aXJ0dWFsIH5DbGllbnQoKSB7IH0KICAgICAgICAgdmlydHVhbCB2 b2lkIGRpZEJlY29tZVVucmVzcG9uc2l2ZShSZXNwb25zaXZlbmVzc1RpbWVyKikgPSAwOwotICAg ICAgICB2aXJ0dWFsIHZvaWQgaW50ZXJhY3Rpb25PY2N1cnJlZFdoaWxlVW5yZXNwb25zaXZlKFJl c3BvbnNpdmVuZXNzVGltZXIqKSA9IDA7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBkaWRCZWNvbWVS ZXNwb25zaXZlKFJlc3BvbnNpdmVuZXNzVGltZXIqKSA9IDA7CiAgICAgfTsKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCAyYTdiZjU1YTA2ZDliYTUxZDIw YTEyM2QyM2VlOWUzYTY3MzFiOGM5Li41ODgyYWE1YmMwZjFiZTg4NWUwMTA5NzEzNzkwMGJiNWFh NWIwMjkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAt NDg2MywxNCArNDg2Myw2IEBAIHZvaWQgV2ViUGFnZVByb3h5Ojpwcm9jZXNzRGlkQmVjb21lVW5y ZXNwb25zaXZlKCkKICAgICAgICAgbV9sb2FkZXJDbGllbnQtPnByb2Nlc3NEaWRCZWNvbWVVbnJl c3BvbnNpdmUoKnRoaXMpOwogfQogCi12b2lkIFdlYlBhZ2VQcm94eTo6aW50ZXJhY3Rpb25PY2N1 cnJlZFdoaWxlUHJvY2Vzc1VucmVzcG9uc2l2ZSgpCi17Ci0gICAgaWYgKCFpc1ZhbGlkKCkpCi0g ICAgICAgIHJldHVybjsKLQotICAgIG1fbG9hZGVyQ2xpZW50LT5pbnRlcmFjdGlvbk9jY3VycmVk V2hpbGVQcm9jZXNzVW5yZXNwb25zaXZlKCp0aGlzKTsKLX0KLQogdm9pZCBXZWJQYWdlUHJveHk6 OnByb2Nlc3NEaWRCZWNvbWVSZXNwb25zaXZlKCkKIHsKICAgICBpZiAoIWlzVmFsaWQoKSkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAppbmRleCA1YTk0Njg2ODAyMGY5ZDYz MGZmYzY0ODMyZjgxYTNkODFlNTM5ZDIxLi43YWU2MjZiMzBjNjZiMTcyN2NmMzFjYTM4YmVkMDFj MjhiMGVkOGEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCkBAIC04 MDksNyArODA5LDYgQEAgcHVibGljOgogI2VuZGlmCiAKICAgICB2b2lkIHByb2Nlc3NEaWRCZWNv bWVVbnJlc3BvbnNpdmUoKTsKLSAgICB2b2lkIGludGVyYWN0aW9uT2NjdXJyZWRXaGlsZVByb2Nl c3NVbnJlc3BvbnNpdmUoKTsKICAgICB2b2lkIHByb2Nlc3NEaWRCZWNvbWVSZXNwb25zaXZlKCk7 CiAgICAgdm9pZCBwcm9jZXNzRGlkQ3Jhc2goKTsKICNpZiBQTEFURk9STShJT1MpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCmluZGV4IGIyODU3MzI1NzNi ZDA2ZmUzMTI3YTJhMzQ0NTkxNzQ5NjBlNWMxN2MuLmU1M2RhZDVhNGE0OTY1YzQyNTY1NDhlNTUw MTA2M2FjOTQ1OGI2MzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ cm9jZXNzUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNz UHJveHkuY3BwCkBAIC01NjAsMTQgKzU2MCw2IEBAIHZvaWQgV2ViUHJvY2Vzc1Byb3h5OjpkaWRC ZWNvbWVVbnJlc3BvbnNpdmUoUmVzcG9uc2l2ZW5lc3NUaW1lciopCiAgICAgICAgIHBhZ2VzW2ld LT5wcm9jZXNzRGlkQmVjb21lVW5yZXNwb25zaXZlKCk7CiB9CiAKLXZvaWQgV2ViUHJvY2Vzc1By b3h5OjppbnRlcmFjdGlvbk9jY3VycmVkV2hpbGVVbnJlc3BvbnNpdmUoUmVzcG9uc2l2ZW5lc3NU aW1lciopCi17Ci0gICAgVmVjdG9yPFJlZlB0cjxXZWJQYWdlUHJveHk+PiBwYWdlczsKLSAgICBj b3B5VmFsdWVzVG9WZWN0b3IobV9wYWdlTWFwLCBwYWdlcyk7Ci0gICAgZm9yIChzaXplX3QgaSA9 IDAsIHNpemUgPSBwYWdlcy5zaXplKCk7IGkgPCBzaXplOyArK2kpCi0gICAgICAgIHBhZ2VzW2ld LT5pbnRlcmFjdGlvbk9jY3VycmVkV2hpbGVQcm9jZXNzVW5yZXNwb25zaXZlKCk7Ci19Ci0KIHZv aWQgV2ViUHJvY2Vzc1Byb3h5OjpkaWRCZWNvbWVSZXNwb25zaXZlKFJlc3BvbnNpdmVuZXNzVGlt ZXIqKQogewogICAgIFZlY3RvcjxSZWZQdHI8V2ViUGFnZVByb3h5Pj4gcGFnZXM7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmggYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmgKaW5kZXggMzZiMWQ2NjVhZWMwODVm MTZlODYxN2Q3ZDNhY2Y5NjRiYmQ0MTgyMS4uNGYxMGFiMjJiMjY4MWFiMjRiMWNlZjhkY2JiYTU0 ZTIzMTg2YmIxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nl c3NQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHku aApAQCAtMjA3LDcgKzIwNyw2IEBAIHByaXZhdGU6CiAKICAgICAvLyBSZXNwb25zaXZlbmVzc1Rp bWVyOjpDbGllbnQKICAgICB2b2lkIGRpZEJlY29tZVVucmVzcG9uc2l2ZShSZXNwb25zaXZlbmVz c1RpbWVyKikgb3ZlcnJpZGU7Ci0gICAgdm9pZCBpbnRlcmFjdGlvbk9jY3VycmVkV2hpbGVVbnJl c3BvbnNpdmUoUmVzcG9uc2l2ZW5lc3NUaW1lciopIG92ZXJyaWRlOwogICAgIHZvaWQgZGlkQmVj b21lUmVzcG9uc2l2ZShSZXNwb25zaXZlbmVzc1RpbWVyKikgb3ZlcnJpZGU7CiAKICAgICAvLyBQ cm9jZXNzVGhyb3R0bGVyQ2xpZW50Cg==