150810 2015-11-02 11:26:52 -0800 [Win] Minibrowser unable to use WebInspector (CRASH) 2015-11-02 15:52:41 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham achristensen bburg bfulgham graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1138625 0 bfulgham 2015-11-02 11:26:52 -0800 I'm encountering the following crash when attempting to use the WebInspector in MiniBrowser: 'MiniBrowser.exe' (Win32): Loaded 'C:\Windows\System32\rasadhlp.dll'. Symbols loaded. Failed to parse/execute InjectedScriptSource.js! "//# sourceURL=__WebInspectorInjectedScript__" ?(function(InjectedScriptHost,inspectedGlobalObject,injectedScriptId){var Object={}.constructor;function toString(obj)?{return String(obj);}?function toStringDescription(obj)?{if(obj===0&&1/obj<0)?return"-0";return toString(obj);}?function isUInt32(obj)?{if(typeof obj==="number")?return obj>>>0===obj&&(obj>0||1/obj>0);return""+(obj>>>0)===obj;}?function isSymbol(obj)?{return typeof obj==="symbol";}?var InjectedScript=function()?{this._lastBoundObjectId=1;this._idToWrappedObject={};this._idToObjectGroupName={};this._objectGroups={};this._modules={};this._nextSavedResultIndex=1;this._savedResults=[];}?InjectedScript.primitiveTypes={undefined:true,boolean:true,number:true,string:true,}?InjectedScript.CollectionMode={OwnProperties:1<<0,NativeGetterProperties:1<<1,AllProperties:1<<2,}?InjectedScript.prototype={isPrimitiveValue:function(object)?{return InjectedScript.primitiveTypes[typeof object]&&!this._isHTMLAllCollection(object);},wrapObject:function(object,groupN1 00007FFC2880B2EF 1138626 1 webkit-bug-importer 2015-11-02 11:27:43 -0800 <rdar://problem/23358514> 1138664 2 joepeck 2015-11-02 13:10:44 -0800 This is emitted by InjectedScriptManager::injectedScriptFor normally when InjectedScriptSource.js has a parse error. Here is one possible issue: JavaScriptCore's DerivedSource.make / CMakeLists.txt attempts to minify the InjectedScriptSource and in the process injects the sourceURL comment that would have been stripped: COMMAND echo "//# sourceURL=__WebInspectorInjectedScript__" > ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InjectedScriptSource.min.js Perhaps that is not doing what we expect on Windows? Did Windows just move to CMake? 1138672 3 bfulgham 2015-11-02 13:32:34 -0800 (In reply to comment #2) > This is emitted by InjectedScriptManager::injectedScriptFor normally when > InjectedScriptSource.js has a parse error. > > Here is one possible issue: > > JavaScriptCore's DerivedSource.make / CMakeLists.txt attempts to minify the > InjectedScriptSource and in the process injects the sourceURL comment that > would have been stripped: > > COMMAND echo "//# sourceURL=__WebInspectorInjectedScript__" > > ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InjectedScriptSource.min.js > > Perhaps that is not doing what we expect on Windows? Did Windows just move > to CMake? Yes it did! That may very well be the problem. 1138683 4 bfulgham 2015-11-02 13:54:33 -0800 It looks like this problem was introduced right around the time we switched Windows over to CMake. 1138725 5 bfulgham 2015-11-02 15:20:52 -0800 It looks like this command: COMMAND echo "//# sourceURL=__WebInspectorInjectedScript__" ... is inserting quotes into the JS file, which is causing a parse error. 1138729 6 264637 bfulgham 2015-11-02 15:25:21 -0800 Created attachment 264637 Patch 1138737 7 264637 joepeck 2015-11-02 15:38:36 -0800 Comment on attachment 264637 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264637&action=review > Source/JavaScriptCore/CMakeLists.txt:1277 > - COMMAND echo "//# sourceURL=__WebInspectorInjectedScript__" > ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InjectedScriptSource.min.js > + COMMAND ${CMAKE_COMMAND} -E echo "//# sourceURL=__WebInspectorInjectedScript__" > ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InjectedScriptSource.min.js We should therefore do the same to WebCore: COMMAND echo "//# sourceURL=__WebInspectorCommandLineAPIModuleSource__" > ${DERIVED_SOURCES_WEBCORE_DIR}/CommandLineAPIModuleSource.min.js 1138742 8 bfulgham 2015-11-02 15:52:41 -0800 Committed r191917: <http://trac.webkit.org/changeset/191917> 264637 2015-11-02 15:25:21 -0800 2015-11-02 15:26:12 -0800 Patch bug-150810-20151102154229.patch text/plain 2426 bfulgham SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkxOTE1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE1LTExLTAyICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAg ICAgIFtXaW5dIE1pbmlCcm93c2VyIHVuYWJsZSB0byB1c2UgV2ViSW5zcGVjdG9yCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA4MTAKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzIzMzU4NTE0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZSBDTWFrZUxpc3QgcnVsZSBmb3IgY3JlYXRpbmcgdGhlIElu amVjdGVkU2NyaXB0U291cmNlLm1pbi5qcyB3YXMgaW1wcm9wZXJseSBpbmNsdWRpbmcKKyAgICAg ICAgdGhlIHF1b3RlIGNoYXJhY3RlcnMgaW4gdGhlIHRleHQgcHJlcGVuZGVkIHRvIEluamVjdGVk U2NyaXB0U291cmNlLm1pbi5qcy4gVGhpcyBjYXVzZWQgYQorICAgICAgICBwYXJzaW5nIGVycm9y IGluIHRoZSBKUyBmaWxlLgorICAgICAgICAKKyAgICAgICAgVGhlIHNvbHV0aW9uIHdhcyB0byBz d2l0Y2ggZnJvbSB1c2luZyAiQ09NTUFORCBlY2hvIiB0byB1c2UgdGhlIG1vcmUgY3Jvc3MtcGxh dGZvcm0KKyAgICAgICAgY29tcGF0aWJsZSBjb21tYW5kICJDT01NQU5EICR7Q01BS0VfQ09NTUFO RH0gLUUgZWNobyAuLi4iLCB3aGljaCBoYW5kbGVzIHRoZSBzdHJpbmcKKyAgICAgICAgZXNjYXBp bmcgcHJvcGVybHkgb24gYWxsIHBsYXRmb3Jtcy4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0 OiBTd2l0Y2ggdGhlICdlY2hvJyBjb21tYW5kIHN5bnRheCB0byBiZSBtb3JlIGNyb3NzLXBsYXRm b3JtLgorCiAyMDE1LTExLTAyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAg ICAgICAgQjMgc2hvdWxkIGJlIGFibGUgdG8gY29tcGlsZSBhIFBhdGNocG9pbnQKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQJKHJldmlzaW9uIDE5MTkwOSkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMTI3NCw3 ICsxMjc0LDcgQEAgYWRkX2N1c3RvbV9jb21tYW5kKAogICAgIE9VVFBVVCAke0RFUklWRURfU09V UkNFU19KQVZBU0NSSVBUQ09SRV9ESVJ9L0luamVjdGVkU2NyaXB0U291cmNlLmggJHtERVJJVkVE X1NPVVJDRVNfSkFWQVNDUklQVENPUkVfRElSfS9JbmplY3RlZFNjcmlwdFNvdXJjZS5taW4uanMK ICAgICBNQUlOX0RFUEVOREVOQ1kgJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L2luc3BlY3Rvci9Jbmpl Y3RlZFNjcmlwdFNvdXJjZS5qcwogICAgIERFUEVORFMgJHtKYXZhU2NyaXB0Q29yZV9TQ1JJUFRT X0RJUn0veHhkLnBsICR7SmF2YVNjcmlwdENvcmVfU0NSSVBUU19ESVJ9L2pzbWluLnB5Ci0gICAg Q09NTUFORCBlY2hvICIvLyMgc291cmNlVVJMPV9fV2ViSW5zcGVjdG9ySW5qZWN0ZWRTY3JpcHRf XyIgPiAke0RFUklWRURfU09VUkNFU19KQVZBU0NSSVBUQ09SRV9ESVJ9L0luamVjdGVkU2NyaXB0 U291cmNlLm1pbi5qcworICAgIENPTU1BTkQgJHtDTUFLRV9DT01NQU5EfSAtRSBlY2hvICIvLyMg c291cmNlVVJMPV9fV2ViSW5zcGVjdG9ySW5qZWN0ZWRTY3JpcHRfXyIgPiAke0RFUklWRURfU09V UkNFU19KQVZBU0NSSVBUQ09SRV9ESVJ9L0luamVjdGVkU2NyaXB0U291cmNlLm1pbi5qcwogICAg IENPTU1BTkQgJHtQWVRIT05fRVhFQ1VUQUJMRX0gJHtKYXZhU2NyaXB0Q29yZV9TQ1JJUFRTX0RJ Un0vanNtaW4ucHkgPCAke0pBVkFTQ1JJUFRDT1JFX0RJUn0vaW5zcGVjdG9yL0luamVjdGVkU2Ny aXB0U291cmNlLmpzID4+ICR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vSW5q ZWN0ZWRTY3JpcHRTb3VyY2UubWluLmpzCiAgICAgQ09NTUFORCAke1BFUkxfRVhFQ1VUQUJMRX0g JHtKYXZhU2NyaXB0Q29yZV9TQ1JJUFRTX0RJUn0veHhkLnBsIEluamVjdGVkU2NyaXB0U291cmNl X2pzICR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vSW5qZWN0ZWRTY3JpcHRT b3VyY2UubWluLmpzICR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vSW5qZWN0 ZWRTY3JpcHRTb3VyY2UuaAogICAgIFZFUkJBVElNKQo=