150804 2015-11-02 09:39:52 -0800 storage/indexeddb/modern/idbobjectstore-get-failures.html is flaky on mac-wk1 2015-11-02 10:40:27 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Mac Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=150673 P2 Normal --- 149117 1 ryanhaddad beidson alecflett commit-queue jsbell oldest_to_newest 1138584 0 ryanhaddad 2015-11-02 09:39:52 -0800 storage/indexeddb/modern/idbobjectstore-get-failures.html is flaky on mac-wk1 <https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20%28Tests%29/builds/9598> --- /Volumes/Data/slave/yosemite-release-tests-wk1/build/layout-test-results/storage/indexeddb/modern/idbobjectstore-get-failures-expected.txt +++ /Volumes/Data/slave/yosemite-release-tests-wk1/build/layout-test-results/storage/indexeddb/modern/idbobjectstore-get-failures-actual.txt @@ -2,7 +2,6 @@ ALERT: Failed to get record from object store with an invalid key ALERT: Failed to get record from object store that has been deleted ALERT: Initial upgrade versionchange transaction complete -ALERT: Failed to get record from object store while the transaction is inactive ALERT: readonly transaction complete ALERT: Done This tests some obvious failures that can happen while calling IDBObjectStore.get(). 1138585 1 ryanhaddad 2015-11-02 09:42:49 -0800 Updated expectations in r191890. 1138590 2 beidson 2015-11-02 10:01:30 -0800 While I can't reproduce locally, I'm fairly certain I know what's wrong with the test and have a fix to make it more reliable. 1138604 3 beidson 2015-11-02 10:31:22 -0800 *** Bug 150805 has been marked as a duplicate of this bug. *** 1138605 4 beidson 2015-11-02 10:31:52 -0800 All of the "queue up 10 gets/puts to keep the transaction alive" tests were fundamentally flawed. Fixing them all in one shot. 1138610 5 264599 beidson 2015-11-02 10:36:52 -0800 Created attachment 264599 Patch 1138612 6 beidson 2015-11-02 10:40:21 -0800 https://trac.webkit.org/changeset/191898 264599 2015-11-02 10:36:52 -0800 2015-11-02 10:38:31 -0800 Patch patch text/plain 5543 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1Njg0MjUyLi42YzM4M2Y2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTUtMTEt MDIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIHN0b3JhZ2Uv aW5kZXhlZGRiL21vZGVybi9pZGJvYmplY3RzdG9yZS1nZXQtZmFpbHVyZXMuaHRtbCBpcyBmbGFr eSBvbiBtYWMtd2sxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTA4MDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHBsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiBzdG9y YWdlL2luZGV4ZWRkYi9tb2Rlcm4vaWRiZGF0YWJhc2UtZGVsZXRlb2JqZWN0c3RvcmUtZmFpbHVy ZXMuaHRtbDoKKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vaWRib2JqZWN0c3Rv cmUtY291bnQtZmFpbHVyZXMuaHRtbDoKKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9tb2Rl cm4vaWRib2JqZWN0c3RvcmUtZ2V0LWZhaWx1cmVzLmh0bWw6CisgICAgICAgICogc3RvcmFnZS9p bmRleGVkZGIvbW9kZXJuL2lkYm9iamVjdHN0b3JlLXB1dC1hbmQtY2xlYXItZmFpbHVyZXMuaHRt bDoKKwogMjAxNS0xMS0wMiAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAog ICAgICAgICBNYXJraW5nIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvWE1MSHR0cFJl cXVlc3Qvc2VuZC10aW1lb3V0LWV2ZW50cy5odG0gYXMgZmxha3kgb24gTWFjCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggOTRhMGIwZi4uMzhl ZWI4NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0 YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9u cwpAQCAtMTM5LDkgKzEzOSw2IEBAIHdlYmtpdC5vcmcvYi8xNTAzNjcgWyBNYXZlcmlja3MgXSBm YXN0L2NhbnZhcy93ZWJnbC9vZXMtdGV4dHVyZS1oYWxmLWZsb2F0Lmh0bWwKIAogWyBFbENhcGl0 YW4rIF0gY3NzMy9tYXNraW5nL21hc2stcmVwZWF0LXNwYWNlLXBhZGRpbmcuaHRtbCBbIEltYWdl T25seUZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTUwODA0IHN0b3JhZ2UvaW5kZXhlZGRiL21v ZGVybi9pZGJvYmplY3RzdG9yZS1nZXQtZmFpbHVyZXMuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCi13 ZWJraXQub3JnL2IvMTUwODA1IHN0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9pZGJvYmplY3RzdG9y ZS1jb3VudC1mYWlsdXJlcy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLQogIyMjIEVORCBPRiAoMikg RmFpbHVyZXMgd2l0aG91dCBidWcgcmVwb3J0cwogIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRk Yi9tb2Rlcm4vaWRiZGF0YWJhc2UtZGVsZXRlb2JqZWN0c3RvcmUtZmFpbHVyZXMuaHRtbCBiL0xh eW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9pZGJkYXRhYmFzZS1kZWxldGVvYmpl Y3RzdG9yZS1mYWlsdXJlcy5odG1sCmluZGV4IDdkMzBkNDEuLjhjNWFhODAgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9pZGJkYXRhYmFzZS1kZWxldGVv YmplY3RzdG9yZS1mYWlsdXJlcy5odG1sCisrKyBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhl ZGRiL21vZGVybi9pZGJkYXRhYmFzZS1kZWxldGVvYmplY3RzdG9yZS1mYWlsdXJlcy5odG1sCkBA IC0xMDAsMTEgKzEwMCwxMiBAQCBmdW5jdGlvbiBjb250aW51ZVRlc3QyKCkKICAgICAgICAgfSBj YXRjaChlKSB7CiAgICAgICAgICAgICBhbGVydCgiRmFpbGVkIHRvIGRlbGV0ZU9iamVjdFN0b3Jl IHdpdGggYSBub24tZXhpc3RlbnQgb2JqZWN0c3RvcmUgLSAiICsgZSk7CiAgICAgICAgIH0KLSAg ICAgICAgCi0gICAgICAgIC8vIFF1ZXVlIHVwIGEgd2hvbGUgYnVuY2ggb2YgcHV0cyB0byBrZWVw IHRoZSB0cmFuc2FjdGlvbiBhbGl2ZSBmb3IgYXdoaWxlCisKKyAgICAgICAgLy8gUXVldWUgdXAg c29tZSBwdXRzIHRvIGtlZXAgdGhlIHRyYW5zYWN0aW9uIGFsaXZlIGxvbmcgZW5vdWdoIGZvciB0 aGUgc2V0VGltZW91dCB0byBmaXJlLgogICAgICAgICB2YXIgb2JqZWN0U3RvcmUgPSB2ZXJzaW9u VHJhbnNhY3Rpb24ub2JqZWN0U3RvcmUoIlRlc3RPYmplY3RTdG9yZSIpOwotICAgICAgICBmb3Ig KHZhciBpID0gMDsgaSA8IDEwOyArK2kpCi0gICAgICAgICAgICBvYmplY3RTdG9yZS5wdXQoIkFI IEFIIEFIIEFIIEFIIiwgaSArICIgcHV0cyIpOworICAgICAgICBvYmplY3RTdG9yZS5wdXQoIndl IHdpbGwgd2Ugd2lsbCIsIDEpLm9uc3VjY2VzcyA9IGZ1bmN0aW9uKCkgeworICAgICAgICAgICAg b2JqZWN0U3RvcmUucHV0KCJyb2NrIHlvdSIsIDIpOworICAgICAgICB9CiAgICAgICAgIAogICAg ICAgICAvLyBBZnRlciB0aGUgdmVyc2lvbkNoYW5nZSB0cmFuc2FjdGlvbiBiZWNvbWVzIGluYWN0 aXZlLCBidXQgd2hpbGUgaXQncyBzdGlsbCBpbi1wcm9ncmVzcywgdHJ5IHRvIGRlbGV0ZSB0aGUg b2JqZWN0c3RvcmUKICAgICAgICAgdmFyIHRyeUluYWN0aXZlRGVsZXRlID0gZnVuY3Rpb24oKSAK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9pZGJvYmpl Y3RzdG9yZS1jb3VudC1mYWlsdXJlcy5odG1sIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVk ZGIvbW9kZXJuL2lkYm9iamVjdHN0b3JlLWNvdW50LWZhaWx1cmVzLmh0bWwKaW5kZXggMTM5ZjU3 OC4uNTFkM2YwZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW9k ZXJuL2lkYm9iamVjdHN0b3JlLWNvdW50LWZhaWx1cmVzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv c3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2lkYm9iamVjdHN0b3JlLWNvdW50LWZhaWx1cmVzLmh0 bWwKQEAgLTY1LDkgKzY1LDEwIEBAIGZ1bmN0aW9uIGNvbnRpbnVlVGVzdDEoKQogICAgIHZhciB0 cmFuc2FjdGlvbiA9IGRhdGFiYXNlLnRyYW5zYWN0aW9uKCJUZXN0T2JqZWN0U3RvcmUiLCAicmVh ZG9ubHkiKTsKICAgICB2YXIgb2JqZWN0U3RvcmUgPSB0cmFuc2FjdGlvbi5vYmplY3RTdG9yZSgi VGVzdE9iamVjdFN0b3JlIik7CiAKLSAgICAvLyBRdWV1ZSB1cCBhIHdob2xlIGJ1bmNoIG9mIGdl dHMgdG8ga2VlcCB0aGUgdHJhbnNhY3Rpb24gYWxpdmUgZm9yIGF3aGlsZQotICAgIGZvciAodmFy IGkgPSAwOyBpIDwgMTA7ICsraSkKKyAgICAvLyBRdWV1ZSB1cCBzb21lIGdldHMgdG8ga2VlcCB0 aGUgdHJhbnNhY3Rpb24gYWxpdmUgbG9uZyBlbm91Z2ggZm9yIHRoZSBzZXRUaW1lb3V0IHRvIGZp cmUuCisgICAgb2JqZWN0U3RvcmUuZ2V0KCJmb28iKS5vbnN1Y2Nlc3MgPSBmdW5jdGlvbigpIHsK ICAgICAgICAgb2JqZWN0U3RvcmUuZ2V0KCJmb28iKTsKKyAgICB9CiAKICAgICB2YXIgZ2V0V2hp bGVJbmFjdGl2ZSA9IGZ1bmN0aW9uKCkgewogICAgICAgICB0cnkgewpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2lkYm9iamVjdHN0b3JlLWdldC1mYWls dXJlcy5odG1sIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2lkYm9iamVj dHN0b3JlLWdldC1mYWlsdXJlcy5odG1sCmluZGV4IDA4MGI3OGUuLjg4ZjgxZWEgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9pZGJvYmplY3RzdG9yZS1n ZXQtZmFpbHVyZXMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9tb2Rl cm4vaWRib2JqZWN0c3RvcmUtZ2V0LWZhaWx1cmVzLmh0bWwKQEAgLTY1LDcgKzY1LDExIEBAIGZ1 bmN0aW9uIGNvbnRpbnVlVGVzdDEoKQogICAgIHZhciB0cmFuc2FjdGlvbiA9IGRhdGFiYXNlLnRy YW5zYWN0aW9uKCJUZXN0T2JqZWN0U3RvcmUiLCAicmVhZG9ubHkiKTsKICAgICB2YXIgb2JqZWN0 U3RvcmUgPSB0cmFuc2FjdGlvbi5vYmplY3RTdG9yZSgiVGVzdE9iamVjdFN0b3JlIik7CiAKLSAg ICAvLyBRdWV1ZSB1cCBhIHdob2xlIGJ1bmNoIG9mIGdldHMgdG8ga2VlcCB0aGUgdHJhbnNhY3Rp b24gYWxpdmUgZm9yIGF3aGlsZQorICAgIC8vIFF1ZXVlIHVwIHNvbWUgZ2V0cyB0byBrZWVwIHRo ZSB0cmFuc2FjdGlvbiBhbGl2ZSBsb25nIGVub3VnaCBmb3IgdGhlIHNldFRpbWVvdXQgdG8gZmly ZS4KKyAgICBvYmplY3RTdG9yZS5nZXQoImZvbyIpLm9uc3VjY2VzcyA9IGZ1bmN0aW9uKCkgewor ICAgICAgICBvYmplY3RTdG9yZS5nZXQoImZvbyIpOworICAgIH0KKwogICAgIGZvciAodmFyIGkg PSAwOyBpIDwgMTA7ICsraSkKICAgICAgICAgb2JqZWN0U3RvcmUuZ2V0KCJmb28iKTsKIApkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2lkYm9iamVjdHN0 b3JlLXB1dC1hbmQtY2xlYXItZmFpbHVyZXMuaHRtbCBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5k ZXhlZGRiL21vZGVybi9pZGJvYmplY3RzdG9yZS1wdXQtYW5kLWNsZWFyLWZhaWx1cmVzLmh0bWwK aW5kZXggY2RmNTgxMi4uZjMxMmRiZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9p bmRleGVkZGIvbW9kZXJuL2lkYm9iamVjdHN0b3JlLXB1dC1hbmQtY2xlYXItZmFpbHVyZXMuaHRt bAorKysgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vaWRib2JqZWN0c3Rv cmUtcHV0LWFuZC1jbGVhci1mYWlsdXJlcy5odG1sCkBAIC04MCw5ICs4MCwxMCBAQCBmdW5jdGlv biBjb250aW51ZVRlc3QxKCkKICAgICB2YXIgdHJhbnNhY3Rpb24gPSBkYXRhYmFzZS50cmFuc2Fj dGlvbigiVGVzdE9iamVjdFN0b3JlIiwgInJlYWR3cml0ZSIpOwogICAgIHZhciBvYmplY3RTdG9y ZSA9IHRyYW5zYWN0aW9uLm9iamVjdFN0b3JlKCJUZXN0T2JqZWN0U3RvcmUiKTsKIAotICAgIC8v IFF1ZXVlIHVwIGEgd2hvbGUgYnVuY2ggb2YgZ2V0cyB0byBrZWVwIHRoZSB0cmFuc2FjdGlvbiBh bGl2ZSBmb3IgYXdoaWxlCi0gICAgZm9yICh2YXIgaSA9IDA7IGkgPCAxMDsgKytpKQorICAgIC8v IFF1ZXVlIHVwIHNvbWUgZ2V0cyB0byBrZWVwIHRoZSB0cmFuc2FjdGlvbiBhbGl2ZSBsb25nIGVu b3VnaCBmb3IgdGhlIHNldFRpbWVvdXQgdG8gZmlyZS4KKyAgICBvYmplY3RTdG9yZS5nZXQoImZv byIpLm9uc3VjY2VzcyA9IGZ1bmN0aW9uKCkgewogICAgICAgICBvYmplY3RTdG9yZS5nZXQoImZv byIpOworICAgIH0KIAogICAgIHZhciB0ZXN0V2hpbGVJbmFjdGl2ZSA9IGZ1bmN0aW9uKCkgewog ICAgICAgICB0cnkgewo=