150797 2015-11-02 05:49:18 -0800 Fix build warning in bignum.cc 2015-11-27 05:24:32 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 150619 1 ossy ossy benjamin cdumez cmarcelo commit-queue jh718.park ossy oldest_to_newest 1138533 0 ossy 2015-11-02 05:49:18 -0800 With GCC 5.2 I got the following warning: /home/ossy/WebKit/Source/WTF/wtf/dtoa/bignum.cc: In member function ‘void WTF::double_conversion::Bignum::AssignDecimalString(WTF::double_conversion::BufferReference<const char>)’: /home/ossy/WebKit/Source/WTF/wtf/dtoa/bignum.cc:105:10: error: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Werror=strict-overflow] void Bignum::AssignDecimalString(BufferReference<const char> value) { ^ cc1plus: all warnings being treated as errors 1138534 1 ossy 2015-11-02 05:49:35 -0800 It is already fixed in V8: https://github.com/v8/v8/commit/e28183b5977a2d2732f7f8b9a2f26637c9566585 1138535 2 264578 ossy 2015-11-02 05:52:41 -0800 Created attachment 264578 Patch It's not the best fix, because it suppresses this warning. But from and digits_to_read are small numbers, it is unlikely to reach overflow in a real life use case. 1138537 3 264579 ossy 2015-11-02 05:54:21 -0800 Created attachment 264579 Patch typo fixed 1138596 4 264579 ggaren 2015-11-02 10:15:26 -0800 Comment on attachment 264579 Patch r=me 1138855 5 264579 darin 2015-11-02 22:32:56 -0800 Comment on attachment 264579 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264579&action=review > Source/WTF/wtf/dtoa/bignum.cc:98 > - for (int i = from; i < from + digits_to_read; ++i) { > + int to = from + digits_to_read; > + for (int i = from; i < to; ++i) { > int digit = buffer[i] - '0'; Instead of just quieting the warning I would have suggested: for (int i = 0; i <digits_to_read; ++i) { int digit = buffer[from + i] - '0'; Seems slightly more in the spirit of the warning. 1144101 6 hs85.jeong 2015-11-22 16:23:21 -0800 *** Bug 151553 has been marked as a duplicate of this bug. *** 1144580 7 266198 ossy 2015-11-27 05:10:39 -0800 Created attachment 266198 Patch for landing 1144583 8 266198 commit-queue 2015-11-27 05:24:27 -0800 Comment on attachment 266198 Patch for landing Clearing flags on attachment: 266198 Committed r192779: <http://trac.webkit.org/changeset/192779> 1144584 9 commit-queue 2015-11-27 05:24:32 -0800 All reviewed patches have been landed. Closing bug. 264578 2015-11-02 05:52:41 -0800 2015-11-02 05:54:15 -0800 Patch bug-150797-20151102145145.patch text/plain 1306 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxODg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGNhOWQzMzUxNWQyY2ZkMzg3M2UzNjMx YWEwNTk3YmYzOTA4OWQwZTAuLmNlOWZjMWJmZDIxNGJkMGQxOTc0ODAwMmY2ZDdlODkwNTczZDQ3 MDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTUtMTEtMDIgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBGaXggYnVpbGQgd2FybmluZyBpbiBiaWdudW0u Y2MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDc5 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3Rm L2R0b2EvYmlnbnVtLmNjOgorCiAyMDE1LTExLTAyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR0xJQl0gUmVtb3ZlIHN1cHBvcnQgZm9yIEdT b2NrZXQgbWFpbiBsb29wIHNvdXJjZXMgZnJvbSBHTWFpbkxvb3BTb3VyY2UKZGlmZiAtLWdpdCBh L1NvdXJjZS9XVEYvd3RmL2R0b2EvYmlnbnVtLmNjIGIvU291cmNlL1dURi93dGYvZHRvYS9iaWdu dW0uY2MKaW5kZXggOWJiOTA0OWEyZDQ5OWFjNWIzODZlMDY5MWFiOGIyNDdkYmI4NTJmNC4uZjYw YWNiMGFiMzhkYTFhMDdkMjI0ZGFkNmZkNjgyMzQ3M2U5YjE4YSAxMDA2NDQKLS0tIGEvU291cmNl L1dURi93dGYvZHRvYS9iaWdudW0uY2MKKysrIGIvU291cmNlL1dURi93dGYvZHRvYS9iaWdudW0u Y2MKQEAgLTkzLDcgKzkzLDggQEAgbmFtZXNwYWNlIGRvdWJsZV9jb252ZXJzaW9uIHsKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgZnJvbSwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBpbnQgZGlnaXRzX3RvX3JlYWQpIHsKICAgICAgICAgdWludDY0X3QgcmVzdWx0 ID0gMDsKLSAgICAgICAgZm9yIChpbnQgaSA9IGZyb207IGkgPCBmcm9tICsgZGlnaXRzX3RvX3Jl YWQ7ICsraSkgeworICAgICAgICB0byA9IGZyb20gKyBkaWdpdHNfdG9fcmVhZDsKKyAgICAgICAg Zm9yIChpbnQgaSA9IGZyb207IGkgPCB0bzsgKytpKSB7CiAgICAgICAgICAgICBpbnQgZGlnaXQg PSBidWZmZXJbaV0gLSAnMCc7CiAgICAgICAgICAgICBBU1NFUlQoMCA8PSBkaWdpdCAmJiBkaWdp dCA8PSA5KTsKICAgICAgICAgICAgIHJlc3VsdCA9IHJlc3VsdCAqIDEwICsgZGlnaXQ7Cg== 264579 2015-11-02 05:54:21 -0800 2015-11-27 05:10:34 -0800 Patch bug-150797-20151102145325.patch text/plain 1310 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxODg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGNhOWQzMzUxNWQyY2ZkMzg3M2UzNjMx YWEwNTk3YmYzOTA4OWQwZTAuLmNlOWZjMWJmZDIxNGJkMGQxOTc0ODAwMmY2ZDdlODkwNTczZDQ3 MDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTUtMTEtMDIgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBGaXggYnVpbGQgd2FybmluZyBpbiBiaWdudW0u Y2MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDc5 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3Rm L2R0b2EvYmlnbnVtLmNjOgorCiAyMDE1LTExLTAyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR0xJQl0gUmVtb3ZlIHN1cHBvcnQgZm9yIEdT b2NrZXQgbWFpbiBsb29wIHNvdXJjZXMgZnJvbSBHTWFpbkxvb3BTb3VyY2UKZGlmZiAtLWdpdCBh L1NvdXJjZS9XVEYvd3RmL2R0b2EvYmlnbnVtLmNjIGIvU291cmNlL1dURi93dGYvZHRvYS9iaWdu dW0uY2MKaW5kZXggOWJiOTA0OWEyZDQ5OWFjNWIzODZlMDY5MWFiOGIyNDdkYmI4NTJmNC4uYWE1 ZWQ4Y2NmODYxNjBkZmFkYTlkODEzNjg1NTIxZTFmZjYyOTk4NSAxMDA2NDQKLS0tIGEvU291cmNl L1dURi93dGYvZHRvYS9iaWdudW0uY2MKKysrIGIvU291cmNlL1dURi93dGYvZHRvYS9iaWdudW0u Y2MKQEAgLTkzLDcgKzkzLDggQEAgbmFtZXNwYWNlIGRvdWJsZV9jb252ZXJzaW9uIHsKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgZnJvbSwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBpbnQgZGlnaXRzX3RvX3JlYWQpIHsKICAgICAgICAgdWludDY0X3QgcmVzdWx0 ID0gMDsKLSAgICAgICAgZm9yIChpbnQgaSA9IGZyb207IGkgPCBmcm9tICsgZGlnaXRzX3RvX3Jl YWQ7ICsraSkgeworICAgICAgICBpbnQgdG8gPSBmcm9tICsgZGlnaXRzX3RvX3JlYWQ7CisgICAg ICAgIGZvciAoaW50IGkgPSBmcm9tOyBpIDwgdG87ICsraSkgewogICAgICAgICAgICAgaW50IGRp Z2l0ID0gYnVmZmVyW2ldIC0gJzAnOwogICAgICAgICAgICAgQVNTRVJUKDAgPD0gZGlnaXQgJiYg ZGlnaXQgPD0gOSk7CiAgICAgICAgICAgICByZXN1bHQgPSByZXN1bHQgKiAxMCArIGRpZ2l0Owo= 266198 2015-11-27 05:10:39 -0800 2015-11-27 05:24:27 -0800 Patch for landing bug-150797-20151127051020.patch text/plain 1344 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDgwYTU3OTRjMDZmNGZhYjA5ZmYwM2E2 NDE3ODBlM2YyNmFjM2FkOGQuLmYwNjhjYjQ0ZDYwYzhkZjU0NjJjZDJkZDYxYjVkZjY1NWQzOTFj MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTUtMTEtMjcgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBGaXggYnVpbGQgd2FybmluZyBpbiBiaWdudW0u Y2MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDc5 NworCisgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmcmV5IEdhcmVuLgorCisgICAgICAgICogd3Rm L2R0b2EvYmlnbnVtLmNjOgorCiAyMDE1LTExLTE4ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFw cGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBBU1NFUlRJT04gRkFJTEVEOiB0ZW1wb3JhcnlGaWxl UGF0aC5sYXN0KCkgPT0gJy8nIGluIFdlYkNvcmU6Om9wZW5UZW1wb3JhcnlGaWxlKCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XVEYvd3RmL2R0b2EvYmlnbnVtLmNjIGIvU291cmNlL1dURi93dGYvZHRv YS9iaWdudW0uY2MKaW5kZXggOWJiOTA0OWEyZDQ5OWFjNWIzODZlMDY5MWFiOGIyNDdkYmI4NTJm NC4uYWU2NmJjMTNjOGUxM2E3M2YwMzVjY2NiMWQ2OGE1ZmIwOTYzOTQ3MyAxMDA2NDQKLS0tIGEv U291cmNlL1dURi93dGYvZHRvYS9iaWdudW0uY2MKKysrIGIvU291cmNlL1dURi93dGYvZHRvYS9i aWdudW0uY2MKQEAgLTkzLDggKzkzLDggQEAgbmFtZXNwYWNlIGRvdWJsZV9jb252ZXJzaW9uIHsK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgZnJvbSwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBpbnQgZGlnaXRzX3RvX3JlYWQpIHsKICAgICAgICAgdWludDY0X3Qg cmVzdWx0ID0gMDsKLSAgICAgICAgZm9yIChpbnQgaSA9IGZyb207IGkgPCBmcm9tICsgZGlnaXRz X3RvX3JlYWQ7ICsraSkgewotICAgICAgICAgICAgaW50IGRpZ2l0ID0gYnVmZmVyW2ldIC0gJzAn OworICAgICAgICBmb3IgKGludCBpID0gMDsgaSA8IGRpZ2l0c190b19yZWFkOyArK2kpIHsKKyAg ICAgICAgICAgIGludCBkaWdpdCA9IGJ1ZmZlcltmcm9tICsgaV0gLSAnMCc7CiAgICAgICAgICAg ICBBU1NFUlQoMCA8PSBkaWdpdCAmJiBkaWdpdCA8PSA5KTsKICAgICAgICAgICAgIHJlc3VsdCA9 IHJlc3VsdCAqIDEwICsgZGlnaXQ7CiAgICAgICAgIH0K