150793 2015-11-02 03:13:01 -0800 Clean up ENABLE(ES6_ARROWFUNCTION_SYNTAX) ifdefs and keep minimal set of them 2015-11-03 02:37:16 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P1 Blocker --- 150769 1 ossy ysuzuki commit-queue ggaren ysuzuki oldest_to_newest 1138516 0 ossy 2015-11-02 03:13:01 -0800 https://trac.webkit.org/changeset/191875 broke the !ENABLE(ES6_ARROWFUNCTION_SYNTAX) build: ../../Source/JavaScriptCore/parser/Parser.cpp: In member function 'bool JSC::Parser<T>::parseFunctionInfo(TreeBuilder&, JSC::FunctionRequirements, JSC::SourceParseMode, bool, JSC::ConstructorKind, JSC::SuperBinding, int, JSC::ParserFunctionInfo<TreeBuilder>&, JSC::Parser<T>::FunctionDefinitionType)': ../../Source/JavaScriptCore/parser/Parser.cpp:1695:25: error: 'ARROWFUNCTION' was not declared in this scope ( I don't have any time to investigate this regression, feel free to pick it up. ) 1138551 1 ysuzuki 2015-11-02 07:08:18 -0800 I'll check this. 1138553 2 ysuzuki 2015-11-02 07:19:59 -0800 Thanks! This is my fault. I accidentally used ARROWFUNCTION token without ifdef. I'll create the patch once I returned home (in one hour). 1138559 3 ysuzuki 2015-11-02 07:54:05 -0800 I'll keep the minimal ENABLE(ES6_ARROWFUNCTION_SYNTAX) and clean up many ifdefs! 1138560 4 264588 ysuzuki 2015-11-02 08:00:21 -0800 Created attachment 264588 Patch 1138561 5 ysuzuki 2015-11-02 08:08:23 -0800 One difference from the original one is, this patch enables lexing `=>` token. But the parser does not use it for any reductions. This token is just rejected. 1138880 6 264588 ysuzuki 2015-11-03 01:49:17 -0800 Comment on attachment 264588 Patch Thanks! 1138888 7 264588 commit-queue 2015-11-03 02:37:13 -0800 Comment on attachment 264588 Patch Clearing flags on attachment: 264588 Committed r191946: <http://trac.webkit.org/changeset/191946> 1138889 8 commit-queue 2015-11-03 02:37:16 -0800 All reviewed patches have been landed. Closing bug. 264588 2015-11-02 08:00:21 -0800 2015-11-03 02:37:13 -0800 Patch bug-150793-20151103005925.patch text/plain 3960 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxODg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw MjdiNzE5MmRkNTU0NjY1MDZlMWI0YTkzNTU2ZDhlMTc1MGYxOWU1Li5iM2JmYzBlY2FjZWMzN2M3 ZTMxOWExNDBjMDczOTEwNDM0YTc1OTc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxNS0xMS0wMiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBDbGVhbiB1cCBFTkFCTEUoRVM2X0FSUk9XRlVOQ1RJT05fU1lOVEFY KSBpZmRlZnMgYW5kIGtlZXAgbWluaW1hbCBzZXQgb2YgdGhlbQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwNzkzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHRoZSAhRU5BQkxFKEVTNl9BUlJPV0ZV TkNUSU9OX1NZTlRBWCkgYnVpbGQgYWZ0ZXIgcjE5MTg3NS4KKyAgICAgICAgVGhpcyBwYXRjaCBk cm9wcyBtYW55IEVOQUJMRShFUzZfQVJST1dGVU5DVElPTl9TWU5UQVgpIGlmZGVmcyBhbmQga2Vl cCBvbmx5IG9uZSBvZiB0aGVtOworICAgICAgICB0aGUgaWZkZWYgaW4gcGFyc2VBc3NpZ25tZW50 RXhwcmVzc2lvbi4KKyAgICAgICAgVGhpcyBwcmV2ZW50cyBmdW5jdGlvbmFsaXR5IG9mIHBhcnNp bmcgYXJyb3cgZnVuY3Rpb24gc3ludGF4LgorCisgICAgICAgICogcGFyc2VyL0xleGVyLmNwcDoK KyAgICAgICAgKEpTQzo6TGV4ZXI8VD46OmxleCk6CisgICAgICAgICogcGFyc2VyL1BhcnNlci5j cHA6CisgICAgICAgIChKU0M6OlBhcnNlcjxMZXhlclR5cGU+OjpwYXJzZUlubmVyKTogRGVsZXRl ZC4KKyAgICAgICAgKiBwYXJzZXIvUGFyc2VyLmg6CisgICAgICAgIChKU0M6OlBhcnNlcjo6aXNB cnJvd0Z1bmN0aW9uUGFyYW10ZXJzKTogRGVsZXRlZC4KKyAgICAgICAgKiBwYXJzZXIvUGFyc2Vy VG9rZW5zLmg6CisKIDIwMTUtMTEtMDEgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFp bC5jb20+CiAKICAgICAgICAgW0VTNl0gU3VwcG9ydCBHZW5lcmF0b3IgU3ludGF4CmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0xleGVyLmNwcCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9wYXJzZXIvTGV4ZXIuY3BwCmluZGV4IDQ2ZDBjYTFmODI5NTdhNjQ2ZGQ4MDM1 OWQyOTZhMTBkZTE4YWViOTIuLmNiMDg2ZTI2NGVjZDViZDVjMzJlNTc0YzFmMTgwMzJjM2ZiNjJl ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvTGV4ZXIuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvTGV4ZXIuY3BwCkBAIC0xODUwLDcgKzE4 NTAsNiBAQCBjbGFzcyBMaW5lTnVtYmVyQWRkZXIgewogICAgICAgICB0b2tlbiA9IEdUOwogICAg ICAgICBicmVhazsKICAgICBjYXNlIENoYXJhY3RlckVxdWFsOiB7Ci0jaWYgRU5BQkxFKEVTNl9B UlJPV0ZVTkNUSU9OX1NZTlRBWCkKICAgICAgICAgaWYgKHBlZWsoMSkgPT0gJz4nKSB7CiAgICAg ICAgICAgICB0b2tlbiA9IEFSUk9XRlVOQ1RJT047CiAgICAgICAgICAgICB0b2tlbkRhdGEtPmxp bmUgPSBsaW5lTnVtYmVyKCk7CkBAIC0xODYxLDcgKzE4NjAsNyBAQCBjbGFzcyBMaW5lTnVtYmVy QWRkZXIgewogICAgICAgICAgICAgc2hpZnQoKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAg ICB9Ci0jZW5kaWYKKwogICAgICAgICBzaGlmdCgpOwogICAgICAgICBpZiAobV9jdXJyZW50ID09 ICc9JykgewogICAgICAgICAgICAgc2hpZnQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIv UGFyc2VyLmNwcAppbmRleCA4MDY2NjZjYjY5Y2E1NWRjNjk0ZTgyOTIwZTQ2OWMzM2FhMmQ4MzFm Li4yZWRlNjFmZmQyMWQ2MTYxMjgyNDgyZDU5NzhhNzgzNzY2ZDU3Y2VjIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCkBAIC0yNTAsMTQgKzI1MCwxMiBAQAogICAgICAg ICBwYXJzZUZ1bmN0aW9uUGFyYW1ldGVycyhjb250ZXh0LCBwYXJzZU1vZGUsIGZ1bmN0aW9uSW5m byk7CiAgICAgICAgIG1fcGFyYW1ldGVycyA9IGZ1bmN0aW9uSW5mby5wYXJhbWV0ZXJzOwogCi0j aWYgRU5BQkxFKEVTNl9BUlJPV0ZVTkNUSU9OX1NZTlRBWCkKICAgICAgICAgaWYgKHBhcnNlTW9k ZSA9PSBTb3VyY2VQYXJzZU1vZGU6OkFycm93RnVuY3Rpb25Nb2RlICYmICFoYXNFcnJvcigpKSB7 CiAgICAgICAgICAgICAvLyBUaGUgb25seSB3YXkgd2UgY291bGQgaGF2ZSBhbiBlcnJvciB3aWxl IHJlcGFyc2luZyBpcyBpZiB3ZSBydW4gb3V0IG9mIHN0YWNrIHNwYWNlLgogICAgICAgICAgICAg UkVMRUFTRV9BU1NFUlQobWF0Y2goQVJST1dGVU5DVElPTikpOwogICAgICAgICAgICAgbmV4dCgp OwogICAgICAgICAgICAgaXNBcnJvd0Z1bmN0aW9uQm9keUV4cHJlc3Npb24gPSAhbWF0Y2goT1BF TkJSQUNFKTsKICAgICAgICAgfQotI2VuZGlmCiAgICAgfQogCiAgICAgaWYgKCFjYWxsZWVOYW1l LmlzTnVsbCgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJz ZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmgKaW5kZXggMDdhZDMz NGU3YTZiN2VjYTU2YTFhNWExNjgwZDBkMWU2ZWQ5MTU2Zi4uZDRlNmU5OTE4YmI1NWRhMjlkMWJi Zjk0NmFkZmQ5MmIzNTNlY2E5OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3Bh cnNlci9QYXJzZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5o CkBAIC05NjEsNyArOTYxLDYgQEAgY2xhc3MgUGFyc2VyIHsKICAgICAKICAgICBBTFdBWVNfSU5M SU5FIGJvb2wgaXNBcnJvd0Z1bmN0aW9uUGFyYW10ZXJzKCkKICAgICB7Ci0jaWYgRU5BQkxFKEVT Nl9BUlJPV0ZVTkNUSU9OX1NZTlRBWCkKICAgICAgICAgYm9vbCBpc0Fycm93RnVuY3Rpb24gPSBm YWxzZTsKICAgICAgICAgCiAgICAgICAgIGlmIChtYXRjaChFT0ZUT0spKQpAQCAtOTkyLDkgKzk5 MSw2IEBAIGNsYXNzIFBhcnNlciB7CiAgICAgICAgIHJlc3RvcmVTYXZlUG9pbnQoc2F2ZUFycm93 RnVuY3Rpb25Qb2ludCk7CiAgICAgICAgIAogICAgICAgICByZXR1cm4gaXNBcnJvd0Z1bmN0aW9u OwotI2Vsc2UKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotI2VuZGlmCiAgICAgfQogICAgIAogICAg IEFMV0FZU19JTkxJTkUgdW5zaWduZWQgdG9rZW5TdGFydCgpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlclRva2Vucy5oIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3BhcnNlci9QYXJzZXJUb2tlbnMuaAppbmRleCA0MzY2NmYyZDkyOThkMGJlMjc2NzMwMDkx YzgxMzIzMDJlZTFmMGUyLi45ZmVmMzM0MGY3ZDI2YWVlNWNiMGJlM2E2ZDg4MjIyNDk0M2Q0Yzk1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlclRva2Vucy5o CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyVG9rZW5zLmgKQEAgLTEx OCw5ICsxMTgsNyBAQCBlbnVtIEpTVG9rZW5UeXBlIHsKICAgICBYT1JFUVVBTCwKICAgICBPUkVR VUFMLAogICAgIERPVERPVERPVCwKLSNpZiBFTkFCTEUoRVM2X0FSUk9XRlVOQ1RJT05fU1lOVEFY KQogICAgIEFSUk9XRlVOQ1RJT04sCi0jZW5kaWYKICAgICBMYXN0VW50YWdnZWRUb2tlbiwKIAog ICAgIC8vIEJlZ2luIHRhZ2dlZCB0b2tlbnMK