15077 2007-08-25 11:47:21 -0700 REGRESSION: Cannot drag selected text out of a background window 2007-08-25 12:08:33 -0700 1 1 1 Unclassified WebKit WebCore Misc. 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 mitz webkit-unassigned oldest_to_newest 1480 0 mitz 2007-08-25 11:47:21 -0700 EventHandler::eventMayStartDrag() is missing a conversion from window to contents coordinates, causing it to give false results. The only effect of that is that if you have a piece of selected text in a Safari window that's in the background, sometimes you cannot click-hold-and-drag the text out of the window. Instead, the window comes to the front right when you click it. Patch forthcoming. 1477 1 16119 mitz 2007-08-25 11:57:50 -0700 Created attachment 16119 Add missing coordinate conversion Includes change log and manual test 1476 2 mrowe 2007-08-25 12:06:37 -0700 <rdar://problem/5437963> 1472 3 mrowe 2007-08-25 12:08:33 -0700 Landed in r25248. 16119 2007-08-25 11:57:50 -0700 2007-08-25 12:04:02 -0700 Add missing coordinate conversion 15077_r1.diff text/plain 2923 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTI0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDctMDgtMjUgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDc3CisgICAgICAgICAg UkVHUkVTU0lPTjogQ2Fubm90IGRyYWcgc2VsZWN0ZWQgdGV4dCBvdXQgb2YgYSBiYWNrZ3JvdW5k IHdpbmRvdworCisgICAgICAgICogbWFudWFsLXRlc3RzL2RyYWctb3V0LW9mLWJhY2tncm91bmQt d2luZG93Lmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6ZXZlbnRNYXlTdGFydERyYWcpOiBBZGRlZCBt aXNzaW5nIGNvb3JkaW5hdGUKKyAgICAgICAgY29udmVyc2lvbi4KKwogMjAwNy0wOC0yNSAgUm9i IEJ1aXMgIDxidWlzQGtkZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4uCkluZGV4 OiBXZWJDb3JlL21hbnVhbC10ZXN0cy9kcmFnLW91dC1vZi1iYWNrZ3JvdW5kLXdpbmRvdy5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbWFudWFsLXRlc3RzL2RyYWctb3V0LW9mLWJhY2tncm91 bmQtd2luZG93Lmh0bWwJKHJldmlzaW9uIDApCisrKyBXZWJDb3JlL21hbnVhbC10ZXN0cy9kcmFn LW91dC1vZi1iYWNrZ3JvdW5kLXdpbmRvdy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI2 IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL1czQy8vRFREIEhUTUwgNC4wMS8vRU4iCisg ICAgICAgICJodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNC9zdHJpY3QuZHRkIj4KKzxodG1sIGxh bmc9ImVuIj4KKzxoZWFkPgorPC9oZWFkPgorPGJvZHk+Cis8cD48Yj5CVUcgSUQ6PC9iPiA8YSBo cmVmPSJodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA3NyI+QnVnemls bGEgYnVnIDE1MDc3PC9hPiBSRUdSRVNTSU9OOiBDYW5ub3QgZHJhZyBzZWxlY3RlZCB0ZXh0IG91 dCBvZiBhIGJhY2tncm91bmQgd2luZG93PC9wPgorCis8cCBpZD0idGVzdCIgc3R5bGU9ImJhY2tn cm91bmQtY29sb3I6c2t5Ymx1ZTsgcGFkZGluZzozcHg7Ij48Yj5TVEVQUyBUTyBURVNUOjwvYj4g PGJyPgorMS4gU2VsZWN0IHRoZSBmaXJzdCBsaW5lIG9mIHRleHQgaW4gdGhpcyB3aW5kb3cuPGJy PgorMi4gU3dpdGNoIHRvIGFub3RoZXIgYXBwbGljYXRpb24uPGJyPgorMy4gV2l0aCB0aGlzIHdp bmRvdyBpbiB0aGUgYmFja2dyb3VuZCwgY2xpY2sgYW5kIGhvbGQgaW5zaWRlIHRoZSBzZWxlY3Rl ZCB0ZXh0LAordGhlbiBkcmFnIHRoZSB0ZXh0IG91dCBvZiB0aGUgd2luZG93LgorPC9wPgorCis8 cCBpZD0ic3VjY2VzcyIgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6cGFsZWdyZWVuOyBwYWRkaW5n OjNweDsiPjxiPlRFU1QgUEFTUzo8L2I+IAorVGhpcyB3aW5kb3cgd2lsbCBub3QgY29tZSB0byB0 aGUgZm9yZWdyb3VuZCB3aGVuIHlvdSBjbGljaywgYW5kIHlvdSB3aWxsIGJlIGFibGUgdG8KK2Ry YWcgdGhlIHNlbGVjdGVkIHRleHQgb3V0LgorPC9wPgorCis8cCBpZD0iZmFpbHVyZSIgc3R5bGU9 ImJhY2tncm91bmQtY29sb3I6I0ZGMzMwMDsgcGFkZGluZzozcHg7Ij48Yj5URVNUIEZBSUw6PC9i PiAgCitBcyBzb29uIGFzIHlvdSBjbGljayBpbiB0aGUgc2VsZWN0ZWQgdGV4dCwgdGhpcyB3aW5k b3cgd2lsbCBjb21lIHRvIHRoZSBmb3JlZ3JvdW5kCithbmQgeW91IG1heSBub3QgYmUgYWJsZSB0 byBkcmFnIHRoZSBzZWxlY3RlZCB0ZXh0LgorPC9wPgorPC9ib2R5PgorPC9odG1sPgpJbmRleDog V2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdl L0V2ZW50SGFuZGxlci5jcHAJKHJldmlzaW9uIDI1MjQ1KQorKysgV2ViQ29yZS9wYWdlL0V2ZW50 SGFuZGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3MiwxMCArMzcyLDEwIEBAIGJvb2wgRXZl bnRIYW5kbGVyOjpldmVudE1heVN0YXJ0RHJhZyhjb24KICAgICAgICAgcmV0dXJuIGZhbHNlOwog ICAgIAogICAgIEhpdFRlc3RSZXF1ZXN0IHJlcXVlc3QodHJ1ZSwgZmFsc2UpOwotICAgIEhpdFRl c3RSZXN1bHQgcmVzdWx0KGV2ZW50LnBvcygpKTsKKyAgICBIaXRUZXN0UmVzdWx0IHJlc3VsdCht X2ZyYW1lLT52aWV3KCktPndpbmRvd1RvQ29udGVudHMoZXZlbnQucG9zKCkpKTsKICAgICBtX2Zy YW1lLT5yZW5kZXJlcigpLT5sYXllcigpLT5oaXRUZXN0KHJlcXVlc3QsIHJlc3VsdCk7CiAgICAg Ym9vbCBzcmNJc0RIVE1MOwotICAgIHJldHVybiByZXN1bHQuaW5uZXJOb2RlKCkgJiYgcmVzdWx0 LmlubmVyTm9kZSgpLT5yZW5kZXJlcigpLT5kcmFnZ2FibGVOb2RlKERIVE1MRmxhZywgVUFGbGFn LCBldmVudC54KCksIGV2ZW50LnkoKSwgc3JjSXNESFRNTCk7CisgICAgcmV0dXJuIHJlc3VsdC5p bm5lck5vZGUoKSAmJiByZXN1bHQuaW5uZXJOb2RlKCktPnJlbmRlcmVyKCktPmRyYWdnYWJsZU5v ZGUoREhUTUxGbGFnLCBVQUZsYWcsIHJlc3VsdC5wb2ludCgpLngoKSwgcmVzdWx0LnBvaW50KCku eSgpLCBzcmNJc0RIVE1MKTsKIH0KIAogdm9pZCBFdmVudEhhbmRsZXI6OnVwZGF0ZVNlbGVjdGlv bkZvck1vdXNlRHJhZygpCg==