150757 2015-10-31 01:36:41 -0700 [GTK] Use RunLoop::Timer in PluginInfoCache 2015-11-01 01:34:36 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 150754 1 cgarcia webkit-unassigned bugs-noreply zan oldest_to_newest 1138139 0 cgarcia 2015-10-31 01:36:41 -0700 We use a GMainLoopSource to save the cache in an idle. 1138140 1 264474 cgarcia 2015-10-31 01:41:58 -0700 Created attachment 264474 Patch 1138141 2 cgarcia 2015-10-31 01:42:34 -0700 This one also depends on patch attached to bug #150754 to build 1138202 3 264474 darin 2015-10-31 14:43:42 -0700 Comment on attachment 264474 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264474&action=review > Source/WebKit2/UIProcess/Plugins/gtk/PluginInfoCache.cpp:50 > + m_saveToFileIdle.setPriority(G_PRIORITY_DEFAULT_IDLE); Bot says: error: 'class WTF::RunLoop::Timer<WebKit::PluginInfoCache>' has no member named 'setPriority' 1138203 4 264474 darin 2015-10-31 14:43:58 -0700 Comment on attachment 264474 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264474&action=review >> Source/WebKit2/UIProcess/Plugins/gtk/PluginInfoCache.cpp:50 >> + m_saveToFileIdle.setPriority(G_PRIORITY_DEFAULT_IDLE); > > Bot says: error: 'class WTF::RunLoop::Timer<WebKit::PluginInfoCache>' has no member named 'setPriority' Oh, I see now. 1138288 5 cgarcia 2015-11-01 01:34:36 -0800 Committed r191855: <http://trac.webkit.org/changeset/191855> 264474 2015-10-31 01:41:58 -0700 2015-10-31 14:43:58 -0700 Patch wk2-plugin-cache-timer.diff text/plain 4268 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwMDZkNDhjLi4yYmQ0MDAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjgg QEAKIDIwMTUtMTAtMzEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIFVzZSBSdW5Mb29wOjpUaW1lciBpbiBQbHVnaW5JbmZvQ2FjaGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDc1Nwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBSdW5M b29wOjpUaW1lciBpbnN0ZWFkIG9mIEdNYWluTG9vcFNvdXJjZSB0byBzYXZlIHRoZSBjYWNoZQor ICAgICAgICBjb250ZW50cyBpbiBhbiBpZGxlLiBBbHNvIHJlbW92ZSB0aGUgbXV0ZXgsIHNpbmNl IFJ1bkxvb3A6OlRpbWVyCisgICAgICAgIGlzIHRocmVhZCBzYWZlIGFuZCBzYXZlVG9GaWxlKCkg aXMgcHJpdmF0ZSBhbmQgb25seSBjYWxsZWQgYnkgdGhlCisgICAgICAgIG1haW4gdGhyZWFkIGxv b3AuIEFsc28gcmVtb3ZlZCB0aGUgY29kZSB0byBzYXZlIHRoZSBmaWxlIGluIHRoZQorICAgICAg ICBkZXN0cnVjdG9yIHNpbmNlIFBsdWdpbkluZm9DYWNoZSBpcyBhIHNpbmdsZXRvbiBhbmQgbmV2 ZXIKKyAgICAgICAgZGVzdHJveWVkLiBJdCdzIHZlcnkgdW5saWtlbHkgdGhhdCB0aGUgcHJvZ3Jh bSBmaW5pc2hlZCBiZWZvcmUgdGhlCisgICAgICAgIGNhY2hlIGlzIHNhdmVkLCBidXQgZXZlbiBp ZiB0aGF0IGhhcHBlbnMgaXQgd291bGQgYmUgaGFybWxlc3MsIHRoZQorICAgICAgICBjYWNoZSB3 aWxsIGJlIHNhdmVkIGF0IHNvbWUgcG9pbnQgdGhlIG5leHQgdGltZS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9QbHVnaW5zL2d0ay9QbHVnaW5JbmZvQ2FjaGUuY3BwOgorICAgICAgICAoV2ViS2l0 OjpQbHVnaW5JbmZvQ2FjaGU6OlBsdWdpbkluZm9DYWNoZSk6CisgICAgICAgIChXZWJLaXQ6OlBs dWdpbkluZm9DYWNoZTo6dXBkYXRlUGx1Z2luSW5mbyk6CisgICAgICAgIChXZWJLaXQ6OlBsdWdp bkluZm9DYWNoZTo6flBsdWdpbkluZm9DYWNoZSk6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpbklu Zm9DYWNoZTo6c2F2ZVRvRmlsZSk6CisgICAgICAgICogVUlQcm9jZXNzL1BsdWdpbnMvZ3RrL1Bs dWdpbkluZm9DYWNoZS5oOgorCisyMDE1LTEwLTMxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBbR1RLXSBVc2UgYSBSdW5Mb29wOjpUaW1lciB0 byBzY2hlZHVsZSByZW5kZXJpbmcgZnJhbWVzIGluIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIG1v ZGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDc1 NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9ndGsvUGx1 Z2luSW5mb0NhY2hlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL2d0ay9Q bHVnaW5JbmZvQ2FjaGUuY3BwCmluZGV4IDZjMmM3N2YuLjkzNDUwMzMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL2d0ay9QbHVnaW5JbmZvQ2FjaGUuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL2d0ay9QbHVnaW5JbmZvQ2FjaGUu Y3BwCkBAIC00NCw4ICs0NCwxMSBAQCBQbHVnaW5JbmZvQ2FjaGUmIFBsdWdpbkluZm9DYWNoZTo6 c2luZ2xldG9uKCkKIAogUGx1Z2luSW5mb0NhY2hlOjpQbHVnaW5JbmZvQ2FjaGUoKQogICAgIDog bV9jYWNoZUZpbGUoZ19rZXlfZmlsZV9uZXcoKSkKKyAgICAsIG1fc2F2ZVRvRmlsZUlkbGUoUnVu TG9vcDo6bWFpbigpLCB0aGlzLCAmUGx1Z2luSW5mb0NhY2hlOjpzYXZlVG9GaWxlKQogICAgICwg bV9yZWFkT25seU1vZGUoZmFsc2UpCiB7CisgICAgbV9zYXZlVG9GaWxlSWRsZS5zZXRQcmlvcml0 eShHX1BSSU9SSVRZX0RFRkFVTFRfSURMRSk7CisKICAgICBHVW5pcXVlUHRyPGNoYXI+IGNhY2hl RGlyZWN0b3J5KGdfYnVpbGRfZmlsZW5hbWUoZ19nZXRfdXNlcl9jYWNoZV9kaXIoKSwgIndlYmtp dGd0ayIsIG51bGxwdHIpKTsKICAgICBpZiAoV2ViQ29yZTo6bWFrZUFsbERpcmVjdG9yaWVzKGNh Y2hlRGlyZWN0b3J5LmdldCgpKSkgewogICAgICAgICBtX2NhY2hlUGF0aC5yZXNldChnX2J1aWxk X2ZpbGVuYW1lKGNhY2hlRGlyZWN0b3J5LmdldCgpLCAicGx1Z2lucyIsIG51bGxwdHIpKTsKQEAg LTcxLDE2ICs3NCwxMCBAQCBQbHVnaW5JbmZvQ2FjaGU6OlBsdWdpbkluZm9DYWNoZSgpCiAKIFBs dWdpbkluZm9DYWNoZTo6flBsdWdpbkluZm9DYWNoZSgpCiB7Ci0gICAgaWYgKG1fc2F2ZVRvRmls ZUlkbGUuaXNTY2hlZHVsZWQoKSkgewotICAgICAgICBtX3NhdmVUb0ZpbGVJZGxlLmNhbmNlbCgp OwotICAgICAgICBzYXZlVG9GaWxlKCk7Ci0gICAgfQogfQogCiB2b2lkIFBsdWdpbkluZm9DYWNo ZTo6c2F2ZVRvRmlsZSgpCiB7Ci0gICAgc3RkOjpsb2NrX2d1YXJkPExvY2s+IGxvY2sobV9tdXRl eCk7Ci0KICAgICBnc2l6ZSBkYXRhTGVuZ3RoOwogICAgIEdVbmlxdWVQdHI8Y2hhcj4gZGF0YShn X2tleV9maWxlX3RvX2RhdGEobV9jYWNoZUZpbGUuZ2V0KCksICZkYXRhTGVuZ3RoLCBudWxscHRy KSk7CiAgICAgaWYgKCFkYXRhKQpAQCAtMTQyLDExICsxMzksMTAgQEAgdm9pZCBQbHVnaW5JbmZv Q2FjaGU6OnVwZGF0ZVBsdWdpbkluZm8oY29uc3QgU3RyaW5nJiBwbHVnaW5QYXRoLCBjb25zdCBQ bHVnaW5Nb2QKICAgICBpZiAobV9jYWNoZVBhdGggJiYgIW1fcmVhZE9ubHlNb2RlKSB7CiAgICAg ICAgIC8vIFNhdmUgdGhlIGNhY2hlIGZpbGUgaW4gYW4gaWRsZSB0byBtYWtlIHN1cmUgaXQgaGFw cGVucyBpbiB0aGUgbWFpbiB0aHJlYWQgYW5kCiAgICAgICAgIC8vIGl0J3MgZG9uZSBvbmx5IG9u Y2Ugd2hlbiB0aGlzIGlzIGNhbGxlZCBtdWx0aXBsZSB0aW1lcyBpbiBhIHZlcnkgc2hvcnQgdGlt ZS4KLSAgICAgICAgc3RkOjpsb2NrX2d1YXJkPExvY2s+IGxvY2sobV9tdXRleCk7Ci0gICAgICAg IGlmIChtX3NhdmVUb0ZpbGVJZGxlLmlzU2NoZWR1bGVkKCkpCisgICAgICAgIGlmIChtX3NhdmVU b0ZpbGVJZGxlLmlzQWN0aXZlKCkpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgbV9z YXZlVG9GaWxlSWRsZS5zY2hlZHVsZSgiW1dlYktpdF0gUGx1Z2luSW5mb0NhY2hlOjpzYXZlVG9G aWxlIiwgc3RkOjpiaW5kKCZQbHVnaW5JbmZvQ2FjaGU6OnNhdmVUb0ZpbGUsIHRoaXMpLCBHX1BS SU9SSVRZX0RFRkFVTFRfSURMRSk7CisgICAgICAgIG1fc2F2ZVRvRmlsZUlkbGUuc3RhcnRPbmVT aG90KDApOwogICAgIH0KIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1BsdWdpbnMvZ3RrL1BsdWdpbkluZm9DYWNoZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1BsdWdpbnMvZ3RrL1BsdWdpbkluZm9DYWNoZS5oCmluZGV4IGMyYmE5MjAuLjFhZjcwODUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL2d0ay9QbHVnaW5JbmZv Q2FjaGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9ndGsvUGx1Z2lu SW5mb0NhY2hlLmgKQEAgLTI5LDEwICsyOSw4IEBACiAjaWYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJ Tl9BUEkpCiAKICNpbmNsdWRlICJQbHVnaW5Nb2R1bGVJbmZvLmgiCi0jaW5jbHVkZSA8bXV0ZXg+ Ci0jaW5jbHVkZSA8d3RmL0xvY2suaD4KICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4K LSNpbmNsdWRlIDx3dGYvZ2xpYi9HTWFpbkxvb3BTb3VyY2UuaD4KKyNpbmNsdWRlIDx3dGYvUnVu TG9vcC5oPgogI2luY2x1ZGUgPHd0Zi9nbGliL0dVbmlxdWVQdHIuaD4KIAogbmFtZXNwYWNlIFdl YktpdCB7CkBAIC01NCw5ICs1Miw4IEBAIHByaXZhdGU6CiAKICAgICBHVW5pcXVlUHRyPEdLZXlG aWxlPiBtX2NhY2hlRmlsZTsKICAgICBHVW5pcXVlUHRyPGNoYXI+IG1fY2FjaGVQYXRoOwotICAg IEdNYWluTG9vcFNvdXJjZSBtX3NhdmVUb0ZpbGVJZGxlOworICAgIFJ1bkxvb3A6OlRpbWVyPFBs dWdpbkluZm9DYWNoZT4gbV9zYXZlVG9GaWxlSWRsZTsKICAgICBib29sIG1fcmVhZE9ubHlNb2Rl OwotICAgIExvY2sgbV9tdXRleDsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=