150744 2015-10-30 18:05:00 -0700 JSC should have a forceGCSlowPaths option 2015-10-31 09:57:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver sukolsak ysuzuki oldest_to_newest 1138075 0 saam 2015-10-30 18:05:00 -0700 This will be really helpful for testing exception handling from lazySlowPath inside the FTL. This will also be pretty good all around for testing our slow path code because it's so rare. It might even be worth it to run a subset of tests under such an option. 1138088 1 264458 saam 2015-10-30 18:59:43 -0700 Created attachment 264458 patch 1138143 2 264458 commit-queue 2015-10-31 02:16:25 -0700 Comment on attachment 264458 patch Clearing flags on attachment: 264458 Committed r191840: <http://trac.webkit.org/changeset/191840> 1138144 3 commit-queue 2015-10-31 02:16:30 -0700 All reviewed patches have been landed. Closing bug. 1138160 4 ggaren 2015-10-31 09:57:18 -0700 Can we call this forceAllocationSlowPaths instead? Or, even better given our new naming convention, useAllocationFastPath=false. 264458 2015-10-30 18:59:43 -0700 2015-10-31 02:16:25 -0700 patch b-backup.diff text/plain 7285 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkxODM0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM2IEBA CisyMDE1LTEwLTMwICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEpTQyBzaG91bGQgaGF2ZSBhIGZvcmNlR0NTbG93UGF0aHMgb3B0aW9uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA3NDQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGltcGxlbWVudHMg dGhlIGZvcmNlR0NTbG93UGF0aHMgb3B0aW9uLgorICAgICAgICBJdCBkZWZhdWx0cyB0byBmYWxz ZSwgYnV0IHdoZW4gaXQgaXMgc2V0IHRvIHRydWUsCisgICAgICAgIHRoZSBKSVRzIHdpbGwgYWx3 YXlzIGFsbG9jYXRlIG9iamVjdHMgYWxvbmcgdGhlIHNsb3cKKyAgICAgICAgcGF0aC4gVGhpcyB3 aWxsIGJlIGhlbHBmdWwgZm9yIHdyaXRpbmcgYSBjZXJ0YWluIGNsYXNzCisgICAgICAgIG9mIHRl c3RzLiBUaGlzIG1heSBhbHNvIGNvbWUgaW4gaGFuZHkgZm9yIGRlYnVnZ2luZworICAgICAgICBs YXRlci4KKworICAgICAgICBUaGlzIHBhdGNoIGFsc28gYWRkcyB0aGUgImZvcmNlR0NTbG93UGF0 aHMiIGZ1bmN0aW9uCisgICAgICAgIGluIGpzYy5jcHAgd2hpY2ggc2V0cyB0aGUgb3B0aW9uIHRv IHRydWUuIElmIHlvdQorICAgICAgICB1c2UgdGhpcyBmdW5jdGlvbiBpbiBhIGpzYyBzdHJlc3Mg dGVzdCwgaXQncyBiZXN0CisgICAgICAgIHRvIGNhbGwgaXQgYXMgdGhlIGZpcnN0IHRoaW5nIGlu IHRoZSBwcm9ncmFtIGJlZm9yZQorICAgICAgICB3ZSBKSVQgYW55dGhpbmcuCisKKyAgICAgICAg KiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuaDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2 ZUpJVDo6ZW1pdEFsbG9jYXRlSlNDZWxsKToKKyAgICAgICAgKiBmdGwvRlRMTG93ZXJERkdUb0xM Vk0uY3BwOgorICAgICAgICAoSlNDOjpGVEw6OkRGRzo6TG93ZXJERkdUb0xMVk06OmFsbG9jYXRl Q2VsbCk6CisgICAgICAgICogaml0L0pJVElubGluZXMuaDoKKyAgICAgICAgKEpTQzo6SklUOjpl bWl0QWxsb2NhdGVKU09iamVjdCk6CisgICAgICAgICoganNjLmNwcDoKKyAgICAgICAgKEdsb2Jh bE9iamVjdDo6ZmluaXNoQ3JlYXRpb24pOgorICAgICAgICAoZnVuY3Rpb25FZGVuR0MpOgorICAg ICAgICAoZnVuY3Rpb25Gb3JjZUdDU2xvd1BhdGhzKToKKyAgICAgICAgKGZ1bmN0aW9uSGVhcFNp emUpOgorICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5oOgorCiAyMDE1LTEwLTMwICBLZWl0aCBN aWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZv cmdvdCB0byBtYXJrIHRlc3RzIGFzIHBhc3NpbmcgZm9yIG5ldyBmZWF0dXJlLgpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2pzYy5jcHAJKHJldmlzaW9uIDE5MTgzMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qc2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MDgsNiArNTA4LDcgQEAgc3RhdGljIEVuY29k ZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuYwogc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19I T1NUX0NBTEwgZnVuY3Rpb25HQ0FuZFN3ZWVwKEV4ZWNTdGF0ZSopOwogc3RhdGljIEVuY29kZWRK U1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25GdWxsR0MoRXhlY1N0YXRlKik7CiBzdGF0aWMg RW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkVkZW5HQyhFeGVjU3RhdGUqKTsK K3N0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uRm9yY2VHQ1Nsb3dQ YXRocyhFeGVjU3RhdGUqKTsKIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1 bmN0aW9uSGVhcFNpemUoRXhlY1N0YXRlKik7CiBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hP U1RfQ0FMTCBmdW5jdGlvbkFkZHJlc3NPZihFeGVjU3RhdGUqKTsKICNpZm5kZWYgTkRFQlVHCkBA IC02NjgsNiArNjY5LDcgQEAgcHJvdGVjdGVkOgogICAgICAgICBhZGRGdW5jdGlvbih2bSwgImdj IiwgZnVuY3Rpb25HQ0FuZFN3ZWVwLCAwKTsKICAgICAgICAgYWRkRnVuY3Rpb24odm0sICJmdWxs R0MiLCBmdW5jdGlvbkZ1bGxHQywgMCk7CiAgICAgICAgIGFkZEZ1bmN0aW9uKHZtLCAiZWRlbkdD IiwgZnVuY3Rpb25FZGVuR0MsIDApOworICAgICAgICBhZGRGdW5jdGlvbih2bSwgImZvcmNlR0NT bG93UGF0aHMiLCBmdW5jdGlvbkZvcmNlR0NTbG93UGF0aHMsIDApOwogICAgICAgICBhZGRGdW5j dGlvbih2bSwgImdjSGVhcFNpemUiLCBmdW5jdGlvbkhlYXBTaXplLCAwKTsKICAgICAgICAgYWRk RnVuY3Rpb24odm0sICJhZGRyZXNzT2YiLCBmdW5jdGlvbkFkZHJlc3NPZiwgMSk7CiAjaWZuZGVm IE5ERUJVRwpAQCAtMTE4Niw2ICsxMTg4LDE0IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NB TEwgZnVuY3Rpb25FZGUKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzTnVtYmVyKGV4ZWMt PmhlYXAoKS0+c2l6ZUFmdGVyTGFzdEVkZW5Db2xsZWN0aW9uKCkpKTsKIH0KIAorRW5jb2RlZEpT VmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkZvcmNlR0NTbG93UGF0aHMoRXhlY1N0YXRlKikK K3sKKyAgICAvLyBJdCdzIGJlc3QgZm9yIHRoaXMgdG8gYmUgdGhlIGZpcnN0IHRoaW5nIGNhbGxl ZCBpbiB0aGUgCisgICAgLy8gSlMgcHJvZ3JhbSBzbyB0aGUgb3B0aW9uIGlzIHNldCB0byB0cnVl IGJlZm9yZSB3ZSBKSVQuCisgICAgT3B0aW9uczo6Zm9yY2VHQ1Nsb3dQYXRocygpID0gdHJ1ZTsK KyAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzVW5kZWZpbmVkKCkpOworfQorCiBFbmNvZGVk SlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uSGVhcFNpemUoRXhlY1N0YXRlKiBleGVjKQog ewogICAgIEpTTG9ja0hvbGRlciBsb2NrKGV4ZWMpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuaAkocmV2aXNpb24gMTkxODMzKQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oCSh3b3JraW5nIGNvcHkp CkBAIC0yMjgyLDggKzIyODIsMTIgQEAgcHVibGljOgogICAgIHZvaWQgZW1pdEFsbG9jYXRlSlND ZWxsKEdQUlJlZyByZXN1bHRHUFIsIEdQUlJlZyBhbGxvY2F0b3JHUFIsIFN0cnVjdHVyZVR5cGUg c3RydWN0dXJlLAogICAgICAgICBHUFJSZWcgc2NyYXRjaEdQUiwgTWFjcm9Bc3NlbWJsZXI6Okp1 bXBMaXN0JiBzbG93UGF0aCkKICAgICB7Ci0gICAgICAgIG1faml0LmxvYWRQdHIoTWFjcm9Bc3Nl bWJsZXI6OkFkZHJlc3MoYWxsb2NhdG9yR1BSLCBNYXJrZWRBbGxvY2F0b3I6Om9mZnNldE9mRnJl ZUxpc3RIZWFkKCkpLCByZXN1bHRHUFIpOwotICAgICAgICBzbG93UGF0aC5hcHBlbmQobV9qaXQu YnJhbmNoVGVzdFB0cihNYWNyb0Fzc2VtYmxlcjo6WmVybywgcmVzdWx0R1BSKSk7CisgICAgICAg IGlmIChPcHRpb25zOjpmb3JjZUdDU2xvd1BhdGhzKCkpCisgICAgICAgICAgICBzbG93UGF0aC5h cHBlbmQobV9qaXQuanVtcCgpKTsKKyAgICAgICAgZWxzZSB7CisgICAgICAgICAgICBtX2ppdC5s b2FkUHRyKE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNzKGFsbG9jYXRvckdQUiwgTWFya2VkQWxsb2Nh dG9yOjpvZmZzZXRPZkZyZWVMaXN0SGVhZCgpKSwgcmVzdWx0R1BSKTsKKyAgICAgICAgICAgIHNs b3dQYXRoLmFwcGVuZChtX2ppdC5icmFuY2hUZXN0UHRyKE1hY3JvQXNzZW1ibGVyOjpaZXJvLCBy ZXN1bHRHUFIpKTsKKyAgICAgICAgfQogICAgICAgICAKICAgICAgICAgLy8gVGhlIG9iamVjdCBp cyBoYWxmLWFsbG9jYXRlZDogd2UgaGF2ZSB3aGF0IHdlIGtub3cgaXMgYSBmcmVzaCBvYmplY3Qs IGJ1dAogICAgICAgICAvLyBpdCdzIHN0aWxsIG9uIHRoZSBHQydzIGZyZWUgbGlzdC4KSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCShy ZXZpc2lvbiAxOTE4MzMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZH VG9MTFZNLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjQxMSwxOCArNjQxMSwyNSBAQCBwcml2YXRl OgogICAgIExWYWx1ZSBhbGxvY2F0ZUNlbGwoTFZhbHVlIGFsbG9jYXRvciwgTEJhc2ljQmxvY2sg c2xvd1BhdGgpCiAgICAgewogICAgICAgICBMQmFzaWNCbG9jayBzdWNjZXNzID0gRlRMX05FV19C TE9DSyhtX291dCwgKCJvYmplY3QgYWxsb2NhdGlvbiBzdWNjZXNzIikpOwotICAgICAgICAKLSAg ICAgICAgTFZhbHVlIHJlc3VsdCA9IG1fb3V0LmxvYWRQdHIoCi0gICAgICAgICAgICBhbGxvY2F0 b3IsIG1faGVhcHMuTWFya2VkQWxsb2NhdG9yX2ZyZWVMaXN0SGVhZCk7Ci0gICAgICAgIAotICAg ICAgICBtX291dC5icmFuY2gobV9vdXQubm90TnVsbChyZXN1bHQpLCB1c3VhbGx5KHN1Y2Nlc3Mp LCByYXJlbHkoc2xvd1BhdGgpKTsKKyAgICAKKyAgICAgICAgTFZhbHVlIHJlc3VsdDsKKyAgICAg ICAgTFZhbHVlIGNvbmRpdGlvbjsKKyAgICAgICAgaWYgKE9wdGlvbnM6OmZvcmNlR0NTbG93UGF0 aHMoKSkgeworICAgICAgICAgICAgcmVzdWx0ID0gZ2V0VW5kZWYobV9vdXQuaW50NjQpOworICAg ICAgICAgICAgY29uZGl0aW9uID0gbV9vdXQuYm9vbGVhbkZhbHNlOworICAgICAgICB9IGVsc2Ug eworICAgICAgICAgICAgcmVzdWx0ID0gbV9vdXQubG9hZFB0cigKKyAgICAgICAgICAgICAgICBh bGxvY2F0b3IsIG1faGVhcHMuTWFya2VkQWxsb2NhdG9yX2ZyZWVMaXN0SGVhZCk7CisgICAgICAg ICAgICBjb25kaXRpb24gPSBtX291dC5ub3ROdWxsKHJlc3VsdCk7CisgICAgICAgIH0KKyAgICAg ICAgbV9vdXQuYnJhbmNoKGNvbmRpdGlvbiwgdXN1YWxseShzdWNjZXNzKSwgcmFyZWx5KHNsb3dQ YXRoKSk7CiAgICAgICAgIAogICAgICAgICBtX291dC5hcHBlbmRUbyhzdWNjZXNzKTsKICAgICAg ICAgCiAgICAgICAgIG1fb3V0LnN0b3JlUHRyKAogICAgICAgICAgICAgbV9vdXQubG9hZFB0cihy ZXN1bHQsIG1faGVhcHMuSlNDZWxsX2ZyZWVMaXN0TmV4dCksCiAgICAgICAgICAgICBhbGxvY2F0 b3IsIG1faGVhcHMuTWFya2VkQWxsb2NhdG9yX2ZyZWVMaXN0SGVhZCk7Ci0gICAgICAgIAorCiAg ICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfQogICAgIApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2ppdC9KSVRJbmxpbmVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9KSVRJbmxpbmVzLmgJKHJldmlzaW9uIDE5MTgzMykKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qaXQvSklUSW5saW5lcy5oCSh3b3JraW5nIGNvcHkpCkBAIC04ODAsOCArODgwLDEy IEBAIEFMV0FZU19JTkxJTkUgYm9vbCBKSVQ6OmlzT3BlcmFuZENvbnN0YW4KIHRlbXBsYXRlPHR5 cGVuYW1lIFN0cnVjdHVyZVR5cGU+CiBpbmxpbmUgdm9pZCBKSVQ6OmVtaXRBbGxvY2F0ZUpTT2Jq ZWN0KFJlZ2lzdGVySUQgYWxsb2NhdG9yLCBTdHJ1Y3R1cmVUeXBlIHN0cnVjdHVyZSwgUmVnaXN0 ZXJJRCByZXN1bHQsIFJlZ2lzdGVySUQgc2NyYXRjaCkKIHsKLSAgICBsb2FkUHRyKEFkZHJlc3Mo YWxsb2NhdG9yLCBNYXJrZWRBbGxvY2F0b3I6Om9mZnNldE9mRnJlZUxpc3RIZWFkKCkpLCByZXN1 bHQpOwotICAgIGFkZFNsb3dDYXNlKGJyYW5jaFRlc3RQdHIoWmVybywgcmVzdWx0KSk7CisgICAg aWYgKE9wdGlvbnM6OmZvcmNlR0NTbG93UGF0aHMoKSkKKyAgICAgICAgYWRkU2xvd0Nhc2UoanVt cCgpKTsKKyAgICBlbHNlIHsKKyAgICAgICAgbG9hZFB0cihBZGRyZXNzKGFsbG9jYXRvciwgTWFy a2VkQWxsb2NhdG9yOjpvZmZzZXRPZkZyZWVMaXN0SGVhZCgpKSwgcmVzdWx0KTsKKyAgICAgICAg YWRkU2xvd0Nhc2UoYnJhbmNoVGVzdFB0cihaZXJvLCByZXN1bHQpKTsKKyAgICB9CiAKICAgICAv LyByZW1vdmUgdGhlIG9iamVjdCBmcm9tIHRoZSBmcmVlIGxpc3QKICAgICBsb2FkUHRyKEFkZHJl c3MocmVzdWx0KSwgc2NyYXRjaCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9PcHRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv T3B0aW9ucy5oCShyZXZpc2lvbiAxOTE4MzMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9PcHRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTMxMyw2ICszMTMsNyBAQCB0eXBlZGVm IGNvbnN0IGNoYXIqIG9wdGlvblN0cmluZzsKICAgICBcCiAgICAgdihnY0xvZ0xldmVsLCBsb2dH QywgR0NMb2dnaW5nOjpOb25lLCAiZGVidWdnaW5nIG9wdGlvbiB0byBsb2cgR0MgYWN0aXZpdHkg KDAgPSBOb25lLCAxID0gQmFzaWMsIDIgPSBWZXJib3NlKSIpIFwKICAgICB2KGJvb2wsIHVzZUdD LCB0cnVlLCBudWxscHRyKSBcCisgICAgdihib29sLCBmb3JjZUdDU2xvd1BhdGhzLCBmYWxzZSwg IklmIHRydWUsIHdlIHdpbGwgZm9yY2UgYWxsIEpJVCBmYXN0IGFsbG9jYXRpb25zIGRvd24gdGhl aXIgc2xvdyBwYXRocy4iKVwKICAgICB2KHVuc2lnbmVkLCBnY01heEhlYXBTaXplLCAwLCBudWxs cHRyKSBcCiAgICAgdih1bnNpZ25lZCwgZm9yY2VSQU1TaXplLCAwLCBudWxscHRyKSBcCiAgICAg dihib29sLCByZWNvcmRHQ1BhdXNlVGltZXMsIGZhbHNlLCBudWxscHRyKSBcCg==