150741 2015-10-30 16:46:53 -0700 Web Inspector: Unify management of visibility state for views 2026-01-12 09:04:19 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All NEW InRadar P2 Normal --- 149186 1 mattbaker webkit-unassigned graouts inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1138040 0 mattbaker 2015-10-30 16:46:53 -0700 * SUMMARY Unify management of visibility state for views. We use methods shown() and hidden(), often coupled with a `visible` flag, throughout the UI to control layouts and perform other tasks. ContentView, DashboardView, and SidebarPanel define shown/hidden as base class methods, and elsewhere the pattern is implemented in an ad-hoc fashion. We should promote this concept to the View base class. * EXAMPLE Although implementations differ, the typical pattern is as follows: shown() { this._visible = true; this._childView.shown(); this.updateLayout(); } hidden() { this._visible = false; this._childView.hidden(); } needsLayout() { if (!this._visible) return; ... } This could be moved into View as: get visible() { return this._visible; } set visible(flag) { if (flag === this._visible) return; this._visible = flag; if (this._visible) this.shown(); // Implemented by subclasses. else this.hidden(); // Implemented by subclasses. this._subviews.forEach((view) => { console.assert(view.visible !== flag, "Unexpected subview visible state."); view.visible = flag; }); } * NOTES A few things to consider: 1. Currently when a view is shown, shown() isn't necessarily called for all child views that support it. ConsoleTabContentView.shown() doesn't call ContentBrowser.shown(), but ContentBrowserTabContentView does. 2. Visibility can be derived from other state, rather than being a simple flag (see SidebarPanel.visible). 3. Can all shown()/hidden() call sites simply be replaced with visible = true/false? 4. Layout isn't always updated when a view is shown (maybe limited to ApplicationCacheFrameContentView). 5. Should child views always become visible when the parent does? For example, what if a child view is collapsed? 1138041 1 webkit-bug-importer 2015-10-30 16:47:35 -0700 <rdar://problem/23341812>